<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213543] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213543">213543</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-03-07 14:44:53 -0800 (Tue, 07 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Drop non-standard MessageEvent.webkitInitMessageEvent()
https://bugs.webkit.org/show_bug.cgi?id=169295
Reviewed by Joseph Pecoraro.
Source/WebCore:
Drop non-standard MessageEvent.webkitInitMessageEvent().
Chrome dropped it almost 3 years ago. They had UseCounter data showing
consistent 0% usage:
- https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/H6lsGFqdy3Y
- https://www.chromestatus.com/metrics/feature/timeline/popularity/223
- https://src.chromium.org/viewvc/blink?revision=174967&view=revision
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::handleInitMessageEvent): Deleted.
(WebCore::JSMessageEvent::webkitInitMessageEvent): Deleted.
* dom/MessageEvent.idl:
Source/WebInspectorUI:
Drop MessageEvent.webkitInitMessageEvent and update parameters for various
init*Event() operations to match the current implementation.
* UserInterface/Models/NativeFunctionParameters.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSMessageEventCustomcpp">trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp</a></li>
<li><a href="#trunkSourceWebCoredomMessageEventidl">trunk/Source/WebCore/dom/MessageEvent.idl</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsNativeFunctionParametersjs">trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (213542 => 213543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-07 22:24:19 UTC (rev 213542)
+++ trunk/Source/WebCore/ChangeLog 2017-03-07 22:44:53 UTC (rev 213543)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2017-03-07 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Drop non-standard MessageEvent.webkitInitMessageEvent()
+ https://bugs.webkit.org/show_bug.cgi?id=169295
+
+ Reviewed by Joseph Pecoraro.
+
+ Drop non-standard MessageEvent.webkitInitMessageEvent().
+
+ Chrome dropped it almost 3 years ago. They had UseCounter data showing
+ consistent 0% usage:
+ - https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/H6lsGFqdy3Y
+ - https://www.chromestatus.com/metrics/feature/timeline/popularity/223
+ - https://src.chromium.org/viewvc/blink?revision=174967&view=revision
+
+ * bindings/js/JSMessageEventCustom.cpp:
+ (WebCore::handleInitMessageEvent): Deleted.
+ (WebCore::JSMessageEvent::webkitInitMessageEvent): Deleted.
+ * dom/MessageEvent.idl:
+
+2017-03-07 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Label of an <option> element should not be displayed in quirks mode
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=169296
</span><span class="cx"> <rdar://problem/30900751>
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSMessageEventCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp (213542 => 213543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp 2017-03-07 22:24:19 UTC (rev 213542)
+++ trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp 2017-03-07 22:44:53 UTC (rev 213543)
</span><span class="lines">@@ -103,46 +103,4 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static JSC::JSValue handleInitMessageEvent(JSMessageEvent* jsEvent, JSC::ExecState& state)
-{
- VM& vm = state.vm();
- auto scope = DECLARE_THROW_SCOPE(vm);
-
- const String& typeArg = state.argument(0).toWTFString(&state);
- RETURN_IF_EXCEPTION(scope, JSValue());
-
- bool canBubbleArg = state.argument(1).toBoolean(&state);
- RETURN_IF_EXCEPTION(scope, JSValue());
-
- bool cancelableArg = state.argument(2).toBoolean(&state);
- RETURN_IF_EXCEPTION(scope, JSValue());
-
- JSValue dataArg = state.argument(3);
-
- const String originArg = convert<IDLUSVString>(state, state.argument(4));
- RETURN_IF_EXCEPTION(scope, JSValue());
-
- const String lastEventIdArg = state.argument(5).toWTFString(&state);
- RETURN_IF_EXCEPTION(scope, JSValue());
-
- auto sourceArg = convert<IDLNullable<IDLUnion<IDLInterface<DOMWindow>, IDLInterface<MessagePort>>>>(state, state.argument(6));
- RETURN_IF_EXCEPTION(scope, JSValue());
-
- Vector<RefPtr<MessagePort>> messagePorts;
- if (!state.argument(7).isUndefinedOrNull()) {
- messagePorts = convert<IDLSequence<IDLInterface<MessagePort>>>(state, state.argument(7));
- RETURN_IF_EXCEPTION(scope, JSValue());
- }
-
- MessageEvent& event = jsEvent->wrapped();
- event.initMessageEvent(state, typeArg, canBubbleArg, cancelableArg, dataArg, originArg, lastEventIdArg, WTFMove(sourceArg), WTFMove(messagePorts));
- jsEvent->m_data.set(vm, jsEvent, dataArg);
- return jsUndefined();
-}
-
-JSC::JSValue JSMessageEvent::webkitInitMessageEvent(JSC::ExecState& state)
-{
- return handleInitMessageEvent(this, state);
-}
-
</del><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoredomMessageEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MessageEvent.idl (213542 => 213543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MessageEvent.idl 2017-03-07 22:24:19 UTC (rev 213542)
+++ trunk/Source/WebCore/dom/MessageEvent.idl 2017-03-07 22:44:53 UTC (rev 213543)
</span><span class="lines">@@ -40,9 +40,6 @@
</span><span class="cx"> [CallWith=ScriptState] void initMessageEvent(DOMString type, optional boolean bubbles = false, optional boolean cancelable = false,
</span><span class="cx"> optional any data = null, optional USVString originArg = "", optional DOMString lastEventId = "", optional (DOMWindow or MessagePort)? source = null,
</span><span class="cx"> optional sequence<MessagePort> messagePorts = []);
</span><del>- [Custom] void webkitInitMessageEvent(optional DOMString typeArg, optional boolean canBubbleArg, optional boolean cancelableArg,
- optional any dataArg, optional USVString originArg, optional DOMString lastEventIdArg, optional (DOMWindow or MessagePort)? sourceArg,
- optional sequence<MessagePort> messagePorts);
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> dictionary MessageEventInit : EventInit {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (213542 => 213543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2017-03-07 22:24:19 UTC (rev 213542)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-03-07 22:44:53 UTC (rev 213543)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-03-07 Chris Dumez <cdumez@apple.com>
+
+ Drop non-standard MessageEvent.webkitInitMessageEvent()
+ https://bugs.webkit.org/show_bug.cgi?id=169295
+
+ Reviewed by Joseph Pecoraro.
+
+ Drop MessageEvent.webkitInitMessageEvent and update parameters for various
+ init*Event() operations to match the current implementation.
+
+ * UserInterface/Models/NativeFunctionParameters.js:
+
</ins><span class="cx"> 2017-03-04 Nikita Vasilyev <nvasilyev@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Show Web Socket connections in Network tab
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsNativeFunctionParametersjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js (213542 => 213543)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2017-03-07 22:24:19 UTC (rev 213542)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2017-03-07 22:44:53 UTC (rev 213543)
</span><span class="lines">@@ -728,7 +728,7 @@
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> CustomEvent: {
</span><del>- initCustomEvent: "[typeArg], [canBubbleArg], [cancelableArg], [detailArg]",
</del><ins>+ initCustomEvent: "type, [bubbles], [cancelable], [detail]",
</ins><span class="cx"> __proto__: null,
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -820,7 +820,7 @@
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> Event: {
</span><del>- initEvent: "type, canBubble, cancelable",
</del><ins>+ initEvent: "type, [bubbles], [cancelable]",
</ins><span class="cx"> __proto__: null,
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -1119,8 +1119,7 @@
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> MessageEvent: {
</span><del>- initMessageEvent: "[typeArg], [canBubbleArg], [cancelableArg], [dataArg], [originArg], [lastEventIdArg], [sourceArg], [messagePorts]",
- webkitInitMessageEvent: "[typeArg], [canBubbleArg], [cancelableArg], [dataArg], [originArg], [lastEventIdArg], [sourceArg], [transferables]",
</del><ins>+ initMessageEvent: "type, [bubbles], [cancelable], [data], [origin], [lastEventId], [source], [messagePorts]",
</ins><span class="cx"> __proto__: null,
</span><span class="cx"> },
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>