<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213567] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213567">213567</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2017-03-07 22:06:41 -0800 (Tue, 07 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove never-implemented CSS3 text decoration-related properties
https://bugs.webkit.org/show_bug.cgi?id=169009
Reviewed by Zalan Bujtas.
The following CSS properties were added many years ago based on an old CSS3 Text
draft (https://www.w3.org/TR/2003/CR-css3-text-20030514/), but never had any implementations.
Remove them.
text-line-through
text-line-through-color
text-line-through-mode
text-line-through-style
text-line-through-width
text-overline
text-overline-color
text-overline-mode
text-overline-style
text-overline-width
text-underline
text-underline-color
text-underline-mode
text-underline-style
text-underline-width
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSProperties.json:
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isKeywordPropertyID):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCorecssCSSComputedStyleDeclarationcpp">trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSPropertiesjson">trunk/Source/WebCore/css/CSSProperties.json</a></li>
<li><a href="#trunkSourceWebCorecssparserCSSParserFastPathscpp">trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (213566 => 213567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-03-08 05:46:52 UTC (rev 213566)
+++ trunk/Source/WebCore/ChangeLog 2017-03-08 06:06:41 UTC (rev 213567)
</span><span class="lines">@@ -1,5 +1,39 @@
</span><span class="cx"> 2017-03-07 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ Remove never-implemented CSS3 text decoration-related properties
+ https://bugs.webkit.org/show_bug.cgi?id=169009
+
+ Reviewed by Zalan Bujtas.
+
+ The following CSS properties were added many years ago based on an old CSS3 Text
+ draft (https://www.w3.org/TR/2003/CR-css3-text-20030514/), but never had any implementations.
+ Remove them.
+
+ text-line-through
+ text-line-through-color
+ text-line-through-mode
+ text-line-through-style
+ text-line-through-width
+ text-overline
+ text-overline-color
+ text-overline-mode
+ text-overline-style
+ text-overline-width
+ text-underline
+ text-underline-color
+ text-underline-mode
+ text-underline-style
+ text-underline-width
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::propertyValue):
+ * css/CSSProperties.json:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+
+2017-03-07 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> Have fixedPositionCreatesStackingContext be on by default everywhere
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=169334
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (213566 => 213567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-03-08 05:46:52 UTC (rev 213566)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-03-08 06:06:41 UTC (rev 213567)
</span><span class="lines">@@ -7663,6 +7663,7 @@
</span><span class="cx"> 0F8B45731DC41DBA00443C3F /* JSIntersectionObserverCallback.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSIntersectionObserverCallback.cpp; sourceTree = "<group>"; };
</span><span class="cx"> 0F8B45741DC41DBA00443C3F /* JSIntersectionObserverCallback.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSIntersectionObserverCallback.h; sourceTree = "<group>"; };
</span><span class="cx"> 0F97A657155DA81E00FADD4C /* DisplayRefreshMonitorIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DisplayRefreshMonitorIOS.mm; sourceTree = "<group>"; };
</span><ins>+ 0FA0852B1E6FB55A00975FDD /* CSSProperties.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = CSSProperties.json; sourceTree = "<group>"; };
</ins><span class="cx"> 0FA24D77162DF91900A3F4C0 /* GraphicsLayerUpdater.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = GraphicsLayerUpdater.cpp; sourceTree = "<group>"; };
</span><span class="cx"> 0FA24D78162DF91900A3F4C0 /* GraphicsLayerUpdater.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GraphicsLayerUpdater.h; sourceTree = "<group>"; };
</span><span class="cx"> 0FA88EBC16A8D1BD00F99984 /* ScrollingStateFrameScrollingNodeMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ScrollingStateFrameScrollingNodeMac.mm; sourceTree = "<group>"; };
</span><span class="lines">@@ -24075,6 +24076,7 @@
</span><span class="cx"> A80E6CDB0A1989CA007FB8C5 /* CSSPrimitiveValue.cpp */,
</span><span class="cx"> A80E6CBC0A1989CA007FB8C5 /* CSSPrimitiveValue.h */,
</span><span class="cx"> E1ED8AC20CC49BE000BFC557 /* CSSPrimitiveValueMappings.h */,
</span><ins>+ 0FA0852B1E6FB55A00975FDD /* CSSProperties.json */,
</ins><span class="cx"> A80E6CCD0A1989CA007FB8C5 /* CSSProperty.cpp */,
</span><span class="cx"> A80E6CD50A1989CA007FB8C5 /* CSSProperty.h */,
</span><span class="cx"> 82E3D8DC122EA0D1003AE5BC /* CSSPropertySourceData.cpp */,
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSComputedStyleDeclarationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (213566 => 213567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2017-03-08 05:46:52 UTC (rev 213566)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2017-03-08 06:06:41 UTC (rev 213567)
</span><span class="lines">@@ -3870,21 +3870,6 @@
</span><span class="cx"> case CSSPropertyAll:
</span><span class="cx"> case CSSPropertyAnimation:
</span><span class="cx"> case CSSPropertyWebkitTextEmphasis:
</span><del>- case CSSPropertyTextLineThrough:
- case CSSPropertyTextLineThroughColor:
- case CSSPropertyTextLineThroughMode:
- case CSSPropertyTextLineThroughStyle:
- case CSSPropertyTextLineThroughWidth:
- case CSSPropertyTextOverline:
- case CSSPropertyTextOverlineColor:
- case CSSPropertyTextOverlineMode:
- case CSSPropertyTextOverlineStyle:
- case CSSPropertyTextOverlineWidth:
- case CSSPropertyTextUnderline:
- case CSSPropertyTextUnderlineColor:
- case CSSPropertyTextUnderlineMode:
- case CSSPropertyTextUnderlineStyle:
- case CSSPropertyTextUnderlineWidth:
</del><span class="cx"> break;
</span><span class="cx">
</span><span class="cx"> /* Directional properties are resolved by resolveDirectionAwareProperty() before the switch. */
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPropertiesjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSProperties.json (213566 => 213567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSProperties.json 2017-03-08 05:46:52 UTC (rev 213566)
+++ trunk/Source/WebCore/css/CSSProperties.json 2017-03-08 06:06:41 UTC (rev 213567)
</span><span class="lines">@@ -3148,8 +3148,9 @@
</span><span class="cx"> },
</span><span class="cx"> "text-line-through": {
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-line-through"
</span><span class="lines">@@ -3157,8 +3158,9 @@
</span><span class="cx"> },
</span><span class="cx"> "text-line-through-color": {
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-line-through-color"
</span><span class="lines">@@ -3169,8 +3171,9 @@
</span><span class="cx"> "continuous",
</span><span class="cx"> "skip-white-space"
</span><span class="cx"> ],
</span><ins>+ "status": "removed",
</ins><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="lines">@@ -3187,8 +3190,9 @@
</span><span class="cx"> "dot-dot-dash",
</span><span class="cx"> "wave"
</span><span class="cx"> ],
</span><ins>+ "status": "removed",
</ins><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="lines">@@ -3197,8 +3201,9 @@
</span><span class="cx"> },
</span><span class="cx"> "text-line-through-width": {
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-line-through-width"
</span><span class="lines">@@ -3216,8 +3221,9 @@
</span><span class="cx"> },
</span><span class="cx"> "text-overline": {
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline"
</span><span class="lines">@@ -3225,8 +3231,9 @@
</span><span class="cx"> },
</span><span class="cx"> "text-overline-color": {
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline-color"
</span><span class="lines">@@ -3238,8 +3245,9 @@
</span><span class="cx"> "skip-white-space"
</span><span class="cx"> ],
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline-mode"
</span><span class="lines">@@ -3256,8 +3264,9 @@
</span><span class="cx"> "wave"
</span><span class="cx"> ],
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline-style"
</span><span class="lines">@@ -3265,8 +3274,9 @@
</span><span class="cx"> },
</span><span class="cx"> "text-overline-width": {
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline-width"
</span><span class="lines">@@ -3302,8 +3312,9 @@
</span><span class="cx"> },
</span><span class="cx"> "text-underline": {
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline"
</span><span class="lines">@@ -3311,8 +3322,9 @@
</span><span class="cx"> },
</span><span class="cx"> "text-underline-color": {
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline-color"
</span><span class="lines">@@ -3324,8 +3336,9 @@
</span><span class="cx"> "skip-white-space"
</span><span class="cx"> ],
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline-mode"
</span><span class="lines">@@ -3342,8 +3355,9 @@
</span><span class="cx"> "wave"
</span><span class="cx"> ],
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline-style"
</span><span class="lines">@@ -3351,8 +3365,9 @@
</span><span class="cx"> },
</span><span class="cx"> "text-underline-width": {
</span><span class="cx"> "codegen-properties": {
</span><del>- "skip-builder": true
</del><ins>+ "skip-codegen": true
</ins><span class="cx"> },
</span><ins>+ "status": "removed",
</ins><span class="cx"> "specification": {
</span><span class="cx"> "category": "css3-text",
</span><span class="cx"> "url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline-width"
</span></span></pre></div>
<a id="trunkSourceWebCorecssparserCSSParserFastPathscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (213566 => 213567)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2017-03-08 05:46:52 UTC (rev 213566)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2017-03-08 06:06:41 UTC (rev 213567)
</span><span class="lines">@@ -846,15 +846,9 @@
</span><span class="cx"> case CSSPropertySpeak:
</span><span class="cx"> case CSSPropertyTableLayout:
</span><span class="cx"> case CSSPropertyTextAlign:
</span><del>- case CSSPropertyTextLineThroughMode:
- case CSSPropertyTextLineThroughStyle:
</del><span class="cx"> case CSSPropertyTextOverflow:
</span><del>- case CSSPropertyTextOverlineMode:
- case CSSPropertyTextOverlineStyle:
</del><span class="cx"> case CSSPropertyTextRendering:
</span><span class="cx"> case CSSPropertyTextTransform:
</span><del>- case CSSPropertyTextUnderlineMode:
- case CSSPropertyTextUnderlineStyle:
</del><span class="cx"> case CSSPropertyTransformStyle:
</span><span class="cx"> case CSSPropertyUnicodeBidi:
</span><span class="cx"> case CSSPropertyVisibility:
</span></span></pre>
</div>
</div>
</body>
</html>