<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213434] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213434">213434</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-05 03:10:10 -0800 (Sun, 05 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Two file reset tests are failing in the bots since they were added in <a href="http://trac.webkit.org/projects/webkit/changeset/213042">r213042</a>
https://bugs.webkit.org/show_bug.cgi?id=169126
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-03-05
Reviewed by Michael Catanzaro.
They are failing because the GTK+ event sender is not firing the second UIHelper.activateAt() after the change
event. In one case this causes that the reset button is not clicked, and in the other one the file input is not
unfocused. This is because the change event is emitted before the mouse up, and the GTK+ event sender ignores
mouse down events when the button is already down to not confuse Xvfb. So, we can easily fix theses tests by
using a timeout to ensure the next UIHelper.activateAt() happens in a different run loop iteration, after the
mouse up.
* fast/forms/file/file-input-reset-using-open-panel.html:
* fast/forms/file/file-reset-in-change-using-open-panel.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastformsfilefileinputresetusingopenpanelhtml">trunk/LayoutTests/fast/forms/file/file-input-reset-using-open-panel.html</a></li>
<li><a href="#trunkLayoutTestsfastformsfilefileresetinchangeusingopenpanelhtml">trunk/LayoutTests/fast/forms/file/file-reset-in-change-using-open-panel.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (213433 => 213434)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-05 08:37:34 UTC (rev 213433)
+++ trunk/LayoutTests/ChangeLog 2017-03-05 11:10:10 UTC (rev 213434)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2017-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ [GTK] Two file reset tests are failing in the bots since they were added in r213042
+ https://bugs.webkit.org/show_bug.cgi?id=169126
+
+ Reviewed by Michael Catanzaro.
+
+ They are failing because the GTK+ event sender is not firing the second UIHelper.activateAt() after the change
+ event. In one case this causes that the reset button is not clicked, and in the other one the file input is not
+ unfocused. This is because the change event is emitted before the mouse up, and the GTK+ event sender ignores
+ mouse down events when the button is already down to not confuse Xvfb. So, we can easily fix theses tests by
+ using a timeout to ensure the next UIHelper.activateAt() happens in a different run loop iteration, after the
+ mouse up.
+
+ * fast/forms/file/file-input-reset-using-open-panel.html:
+ * fast/forms/file/file-reset-in-change-using-open-panel.html:
+
</ins><span class="cx"> 2017-03-04 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r213379.
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsfilefileinputresetusingopenpanelhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/forms/file/file-input-reset-using-open-panel.html (213433 => 213434)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/file/file-input-reset-using-open-panel.html 2017-03-05 08:37:34 UTC (rev 213433)
+++ trunk/LayoutTests/fast/forms/file/file-input-reset-using-open-panel.html 2017-03-05 11:10:10 UTC (rev 213434)
</span><span class="lines">@@ -23,12 +23,15 @@
</span><span class="cx">
</span><span class="cx"> file.addEventListener("change", function() {
</span><span class="cx"> document.getElementById("console").innerHTML = file.value + " is selected.";
</span><del>- UIHelper.activateAt(reset.offsetLeft + reset.offsetWidth / 2, reset.offsetTop + reset.offsetHeight / 2).then(function() {
- // Move a cursor out of the reset button.
- UIHelper.activateAt(reset.offsetLeft + reset.offsetWidth + 10, reset.offsetTop + reset.offsetHeight + 10).then(function() {
- testRunner.notifyDone();
</del><ins>+ // The change event can be fired before the mouse up, so use a timeout here to ensure the next mouse down happens after the pending mouse up.
+ window.setTimeout(function() {
+ UIHelper.activateAt(reset.offsetLeft + reset.offsetWidth / 2, reset.offsetTop + reset.offsetHeight / 2).then(function() {
+ // Move a cursor out of the reset button.
+ UIHelper.activateAt(reset.offsetLeft + reset.offsetWidth + 10, reset.offsetTop + reset.offsetHeight + 10).then(function() {
+ testRunner.notifyDone();
+ });
</ins><span class="cx"> });
</span><del>- });
</del><ins>+ }, 0);
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> openFilesInElement(file, ["foo.txt"]);
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsfilefileresetinchangeusingopenpanelhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/forms/file/file-reset-in-change-using-open-panel.html (213433 => 213434)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/file/file-reset-in-change-using-open-panel.html 2017-03-05 08:37:34 UTC (rev 213433)
+++ trunk/LayoutTests/fast/forms/file/file-reset-in-change-using-open-panel.html 2017-03-05 11:10:10 UTC (rev 213434)
</span><span class="lines">@@ -15,9 +15,12 @@
</span><span class="cx">
</span><span class="cx"> function handleChange() {
</span><span class="cx"> file1.value = '';
</span><del>- UIHelper.activateAt(1, 1).then(function() {
- testRunner.notifyDone();
- });
</del><ins>+ // The change event can be fired before the mouse up, so use a timeout here to ensure the next mouse down happens after the pending mouse up.
+ window.setTimeout(function() {
+ UIHelper.activateAt(1, 1).then(function() {
+ testRunner.notifyDone();
+ });
+ }, 0);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (window.testRunner)
</span></span></pre>
</div>
</div>
</body>
</html>