<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213321] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213321">213321</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-02 16:10:24 -0800 (Thu, 02 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add ability to read bindings test results
https://bugs.webkit.org/show_bug.cgi?id=169063
Patch by Srinivasan Vijayaraghavan <svijayaraghavan@apple.com> on 2017-03-02
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/common/net/bindingstestresults.py: Added.
(BindingsTestResults): Conforms to the AbstractTestResults interface.
(BindingsTestResults.__init__): Constructor.
(BindingsTestResults.results_from_string): Generates BindingsTestResults object from JSON string.
(BindingsTestResults.is_subset): Compare failing tests in two BindingsTestResults objects.
(BindingsTestResults.equals): Checks if two BindingsTestResults objects contain the same failing test names.
(BindingsTestResults.all_passed): Return True if all bindings tests passed.
(BindingsTestResults.failing_tests): Returns a list of failing tests.
(BindingsTestResults.did_exceed_test_failure_limit): Always returns False, exists to conform to the interface.
* Scripts/webkitpy/common/net/bindingstestresults_unittest.py: Added.
(BindingsTestResultsTest): Class to test BindingsTestResults.
(BindingsTestResultsTest.test_results_from_string): Unit tests string -> BindingsTestResults conversion.
(BindingsTestResultsTest.test_results_from_string_success): Ditto, for success cases.
* Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Added.
(BindingsTestResultsReader): Conforms to the AbstractTestResultsReader interface.
(BindingsTestResultsReader.results): Reads the results file and returns a BindingsTestResults object.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkToolsScriptswebkitpycommonnetbindingstestresultspy">trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults.py</a></li>
<li><a href="#trunkToolsScriptswebkitpycommonnetbindingstestresults_unittestpy">trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults_unittest.py</a></li>
<li><a href="#trunkToolsScriptswebkitpytoolbotbindingstestresultsreaderpy">trunk/Tools/Scripts/webkitpy/tool/bot/bindingstestresultsreader.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (213320 => 213321)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-03-03 00:01:22 UTC (rev 213320)
+++ trunk/Tools/ChangeLog 2017-03-03 00:10:24 UTC (rev 213321)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2017-03-02 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
+
+ Add ability to read bindings test results
+ https://bugs.webkit.org/show_bug.cgi?id=169063
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/common/net/bindingstestresults.py: Added.
+ (BindingsTestResults): Conforms to the AbstractTestResults interface.
+ (BindingsTestResults.__init__): Constructor.
+ (BindingsTestResults.results_from_string): Generates BindingsTestResults object from JSON string.
+ (BindingsTestResults.is_subset): Compare failing tests in two BindingsTestResults objects.
+ (BindingsTestResults.equals): Checks if two BindingsTestResults objects contain the same failing test names.
+ (BindingsTestResults.all_passed): Return True if all bindings tests passed.
+ (BindingsTestResults.failing_tests): Returns a list of failing tests.
+ (BindingsTestResults.did_exceed_test_failure_limit): Always returns False, exists to conform to the interface.
+ * Scripts/webkitpy/common/net/bindingstestresults_unittest.py: Added.
+ (BindingsTestResultsTest): Class to test BindingsTestResults.
+ (BindingsTestResultsTest.test_results_from_string): Unit tests string -> BindingsTestResults conversion.
+ (BindingsTestResultsTest.test_results_from_string_success): Ditto, for success cases.
+ * Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Added.
+ (BindingsTestResultsReader): Conforms to the AbstractTestResultsReader interface.
+ (BindingsTestResultsReader.results): Reads the results file and returns a BindingsTestResults object.
+
</ins><span class="cx"> 2017-03-02 Aakash Jain <aakash_jain@apple.com>
</span><span class="cx">
</span><span class="cx"> Move stringMatchesWildcardString from WebKit2 to WebCore
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpycommonnetbindingstestresultspy"></a>
<div class="addfile"><h4>Added: trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults.py (0 => 213321)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults.py (rev 0)
+++ trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults.py 2017-03-03 00:10:24 UTC (rev 213321)
</span><span class="lines">@@ -0,0 +1,62 @@
</span><ins>+# Copyright (C) 2017 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import logging
+
+from webkitpy.common.net.abstracttestresults import AbstractTestResults
+
+_log = logging.getLogger(__name__)
+
+
+class BindingsTestResults(AbstractTestResults):
+ def __init__(self, failures, errors):
+ self._failures = failures
+ self._errors = errors
+
+ self._failing_test_names = failures + errors
+
+ @classmethod
+ def results_from_string(cls, string):
+ parsed_results = cls.parse_json_string(string)
+ if not parsed_results:
+ return None
+
+ if 'failures' not in parsed_results or 'errors' not in parsed_results:
+ return None
+
+ return cls(parsed_results['failures'], parsed_results['errors'])
+
+ def is_subset(self, other):
+ return set(self._failures) <= set(other._failures) and set(self._errors) <= set(other._errors)
+
+ def equals(self, other):
+ return set(self._failures) == set(other._failures) and set(self._errors) == set(other._errors)
+
+ def all_passed(self):
+ return not self._failures and not self._errors
+
+ def failing_tests(self):
+ return self._failing_test_names
+
+ # No defined failure limit for bindings tests.
+ def did_exceed_test_failure_limit(self):
+ return False
</ins></span></pre></div>
<a id="trunkToolsScriptswebkitpycommonnetbindingstestresults_unittestpy"></a>
<div class="addfile"><h4>Added: trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults_unittest.py (0 => 213321)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults_unittest.py (rev 0)
+++ trunk/Tools/Scripts/webkitpy/common/net/bindingstestresults_unittest.py 2017-03-03 00:10:24 UTC (rev 213321)
</span><span class="lines">@@ -0,0 +1,43 @@
</span><ins>+# Copyright (C) 2017 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import unittest
+
+from webkitpy.common.net.bindingstestresults import BindingsTestResults
+
+
+class BindingsTestResultsTest(unittest.TestCase):
+ def test_results_from_string(self):
+ incomplete_json_v1 = '{"failures": []}'
+ incomplete_json_v2 = '{"errors":[]}'
+ self.assertEqual(None, BindingsTestResults.results_from_string(incomplete_json_v1))
+ self.assertEqual(None, BindingsTestResults.results_from_string(incomplete_json_v2))
+
+ def test_results_from_string_success(self):
+ no_failures_string = '{"failures": [], "errors":[]}'
+ no_failures_results = BindingsTestResults([], [])
+ self.assertTrue(no_failures_results.equals(BindingsTestResults.results_from_string(no_failures_string)))
+ self.assertTrue(no_failures_results.all_passed())
+
+ test_string = '{"failures": ["failure1"], "errors": ["error1", "error2"]}'
+ test_results = BindingsTestResults(["failure1"], ["error1", "error2"])
+ self.assertTrue(test_results.equals(BindingsTestResults.results_from_string(test_string)))
</ins></span></pre></div>
<a id="trunkToolsScriptswebkitpytoolbotbindingstestresultsreaderpy"></a>
<div class="addfile"><h4>Added: trunk/Tools/Scripts/webkitpy/tool/bot/bindingstestresultsreader.py (0 => 213321)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/tool/bot/bindingstestresultsreader.py (rev 0)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/bindingstestresultsreader.py 2017-03-03 00:10:24 UTC (rev 213321)
</span><span class="lines">@@ -0,0 +1,35 @@
</span><ins>+# Copyright (C) 2017 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import logging
+
+from webkitpy.common.net.bindingstestresults import BindingsTestResults
+from webkitpy.tool.bot.abstracttestresultsreader import AbstractTestResultsReader
+
+_log = logging.getLogger(__name__)
+
+
+class BindingsTestResultsReader(AbstractTestResultsReader):
+ def results(self):
+ results_path = self._host.filesystem.join(self._results_directory, 'bindings_test_results.json')
+ contents = self._read_file_contents(results_path)
+ return BindingsTestResults.results_from_string(contents)
</ins></span></pre>
</div>
</div>
</body>
</html>