<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213348] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213348">213348</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-02 20:47:31 -0800 (Thu, 02 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[ios-simulator Debug WK2] LayoutTest media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=168668
<rdar://problem/30823677>
Patch by Antoine Quint <graouts@apple.com> on 2017-03-02
Reviewed by Simon Fraser.
This test would sometime fail for the first assertion because we may need more than just metadata
to determine that we can be in a state where the fullscreen button becomes enabled (see the logic
in FullscreenSupport). So we now use an asynchronous assertion to determine we've enabled the
fullscreen button and then force it to error to disable it.
* media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt:
* media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html:
* platform/ios-simulator/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsfullscreensupportfullscreensupportenabledexpectedtxt">trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsfullscreensupportfullscreensupportenabledhtml">trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorTestExpectations">trunk/LayoutTests/platform/ios-simulator/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (213347 => 213348)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-03 04:31:04 UTC (rev 213347)
+++ trunk/LayoutTests/ChangeLog 2017-03-03 04:47:31 UTC (rev 213348)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2017-03-02 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><ins>+ [ios-simulator Debug WK2] LayoutTest media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=168668
+ <rdar://problem/30823677>
+
+ Reviewed by Simon Fraser.
+
+ This test would sometime fail for the first assertion because we may need more than just metadata
+ to determine that we can be in a state where the fullscreen button becomes enabled (see the logic
+ in FullscreenSupport). So we now use an asynchronous assertion to determine we've enabled the
+ fullscreen button and then force it to error to disable it.
+
+ * media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt:
+ * media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html:
+ * platform/ios-simulator/TestExpectations:
+
+2017-03-02 Antoine Quint <graouts@apple.com>
+
</ins><span class="cx"> [iOS Release WK2] LayoutTest media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html is a flaky timeout
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168343
</span><span class="cx"> <rdar://problem/30823389>
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsfullscreensupportfullscreensupportenabledexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt (213347 => 213348)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt 2017-03-03 04:31:04 UTC (rev 213347)
+++ trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt 2017-03-03 04:47:31 UTC (rev 213348)
</span><span class="lines">@@ -3,7 +3,10 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS mediaController.controls.fullscreenButton.enabled is true
</del><ins>+Once media loads and we have tracks in the video, the fullscreen button should become enabled
+PASS mediaController.controls.fullscreenButton.enabled became true
+
+We now set the media source to be the empty string to force an error, which should disable the fullscreen button
</ins><span class="cx"> PASS mediaController.controls.fullscreenButton.enabled is false
</span><span class="cx">
</span><span class="cx"> PASS successfullyParsed is true
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsfullscreensupportfullscreensupportenabledhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html (213347 => 213348)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html 2017-03-03 04:31:04 UTC (rev 213347)
+++ trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html 2017-03-03 04:47:31 UTC (rev 213348)
</span><span class="lines">@@ -27,19 +27,20 @@
</span><span class="cx"> const media = document.querySelector("video");
</span><span class="cx"> const mediaController = createControls(container, media, null);
</span><span class="cx">
</span><del>-media.addEventListener("loadedmetadata", () => {
- shouldBeTrue("mediaController.controls.fullscreenButton.enabled");
</del><ins>+debug("Once media loads and we have tracks in the video, the fullscreen button should become enabled");
+shouldBecomeEqual("mediaController.controls.fullscreenButton.enabled", "true", () => {
+ media.addEventListener("error", () => {
+ shouldBeFalse("mediaController.controls.fullscreenButton.enabled");
+ debug("");
+ container.remove();
+ media.remove();
+ finishJSTest();
+ });
+ debug("");
+ debug("We now set the media source to be the empty string to force an error, which should disable the fullscreen button");
</ins><span class="cx"> media.src = "";
</span><span class="cx"> });
</span><span class="cx">
</span><del>-media.addEventListener("error", () => {
- shouldBeFalse("mediaController.controls.fullscreenButton.enabled");
- debug("");
- container.remove();
- media.remove();
- finishJSTest();
-});
-
</del><span class="cx"> </script>
</span><span class="cx"> <script src="../../../resources/js-test-post.js"></script>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (213347 => 213348)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-03-03 04:31:04 UTC (rev 213347)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-03-03 04:47:31 UTC (rev 213348)
</span><span class="lines">@@ -2848,8 +2848,6 @@
</span><span class="cx"> media/modern-media-controls/media-controller/media-controller-tight-padding.html [ Skip ]
</span><span class="cx"> media/modern-media-controls/media-controller/media-controller-toggle-compact-mode.html [ Skip ]
</span><span class="cx">
</span><del>-webkit.org/b/168668 media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html [ Pass Failure ]
-
</del><span class="cx"> # Form validation popover does not obey minimum font size setting on iOS but Dynamic Type instead.
</span><span class="cx"> fast/forms/validation-message-minimum-font-size.html [ Skip ]
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>