<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213330] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213330">213330</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-02 17:29:51 -0800 (Thu, 02 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Move part of NetworkRTCProvider::close implementation in NetworkRTCProvider destructor
https://bugs.webkit.org/show_bug.cgi?id=169104
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-02
Reviewed by Alex Christensen.
Improving NetworkRTCProvider clean-up by moving some member field cleaning to the destructor.
The remaining cleaning is still kept in NetworkRTCProvider::close as we need to go to the rtc network thread and
for that, we take a ref of NetworkRTCProvider.
Stopping any resolver before freeing them.
* NetworkProcess/webrtc/NetworkRTCMonitor.h:
* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::~NetworkRTCProvider):
(WebKit::NetworkRTCProvider::close):
* NetworkProcess/webrtc/NetworkRTCProvider.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcesswebrtcNetworkRTCMonitorh">trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCMonitor.h</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcesswebrtcNetworkRTCProvidercpp">trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.cpp</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcesswebrtcNetworkRTCProviderh">trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (213329 => 213330)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-03-03 01:10:51 UTC (rev 213329)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-03 01:29:51 UTC (rev 213330)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2017-03-02 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><ins>+ Move part of NetworkRTCProvider::close implementation in NetworkRTCProvider destructor
+ https://bugs.webkit.org/show_bug.cgi?id=169104
+
+ Reviewed by Alex Christensen.
+
+ Improving NetworkRTCProvider clean-up by moving some member field cleaning to the destructor.
+ The remaining cleaning is still kept in NetworkRTCProvider::close as we need to go to the rtc network thread and
+ for that, we take a ref of NetworkRTCProvider.
+ Stopping any resolver before freeing them.
+
+ * NetworkProcess/webrtc/NetworkRTCMonitor.h:
+ * NetworkProcess/webrtc/NetworkRTCProvider.cpp:
+ (WebKit::NetworkRTCProvider::~NetworkRTCProvider):
+ (WebKit::NetworkRTCProvider::close):
+ * NetworkProcess/webrtc/NetworkRTCProvider.h:
+
+2017-03-02 Youenn Fablet <youenn@apple.com>
+
</ins><span class="cx"> [iOS] Replicate NetworkProcess Mac sandboxing in iOS to allow TCP/UDP
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=169105
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcesswebrtcNetworkRTCMonitorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCMonitor.h (213329 => 213330)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCMonitor.h 2017-03-03 01:10:51 UTC (rev 213329)
+++ trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCMonitor.h 2017-03-03 01:29:51 UTC (rev 213330)
</span><span class="lines">@@ -48,6 +48,7 @@
</span><span class="cx">
</span><span class="cx"> void didReceiveMessage(IPC::Connection&, IPC::Decoder&);
</span><span class="cx"> void stopUpdating();
</span><ins>+ bool isStarted() const { return m_isStarted; }
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void startUpdating();
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcesswebrtcNetworkRTCProvidercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.cpp (213329 => 213330)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.cpp 2017-03-03 01:10:51 UTC (rev 213329)
+++ trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.cpp 2017-03-03 01:29:51 UTC (rev 213330)
</span><span class="lines">@@ -64,10 +64,19 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+NetworkRTCProvider::~NetworkRTCProvider()
+{
+ ASSERT(!m_connection);
+ ASSERT(!m_sockets.size());
+ ASSERT(!m_rtcMonitor.isStarted());
+
+ for (auto identifier : m_resolvers.keys())
+ stopResolver(identifier);
+}
+
</ins><span class="cx"> void NetworkRTCProvider::close()
</span><span class="cx"> {
</span><span class="cx"> m_connection = nullptr;
</span><del>- m_resolvers.clear();
</del><span class="cx"> m_rtcMonitor.stopUpdating();
</span><span class="cx">
</span><span class="cx"> callOnRTCNetworkThread([this]() {
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcesswebrtcNetworkRTCProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.h (213329 => 213330)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.h 2017-03-03 01:10:51 UTC (rev 213329)
+++ trunk/Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.h 2017-03-03 01:29:51 UTC (rev 213330)
</span><span class="lines">@@ -52,6 +52,7 @@
</span><span class="cx"> class NetworkRTCProvider : public ThreadSafeRefCounted<NetworkRTCProvider>, public rtc::MessageHandler {
</span><span class="cx"> public:
</span><span class="cx"> static Ref<NetworkRTCProvider> create(NetworkConnectionToWebProcess& connection) { return adoptRef(*new NetworkRTCProvider(connection)); }
</span><ins>+ ~NetworkRTCProvider();
</ins><span class="cx">
</span><span class="cx"> void didReceiveMessage(IPC::Connection&, IPC::Decoder&);
</span><span class="cx"> void didReceiveNetworkRTCMonitorMessage(IPC::Connection& connection, IPC::Decoder& decoder) { m_rtcMonitor.didReceiveMessage(connection, decoder); }
</span></span></pre>
</div>
</div>
</body>
</html>