<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213310] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213310">213310</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-02 15:39:40 -0800 (Thu, 02 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Activate some new webrtc tests
https://bugs.webkit.org/show_bug.cgi?id=168850
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-02
Reviewed by Alex Christensen.
Source/WebKit2:
* Shared/WebPreferencesDefinitions.h: Activating peer connection by default when libwebrtc is on.
This allows ensuring the network process will have its sandbox extension.
LayoutTests:
* TestExpectations: Marking webrtc/audio-peer-connection-webaudio.html as failing.
* webrtc/audio-peer-connection-webaudio.html: Making test nicer when failing.
* webrtc/datachannel/basic-expected.txt: Updated test expectation.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestswebrtcaudiopeerconnectionwebaudiohtml">trunk/LayoutTests/webrtc/audio-peer-connection-webaudio.html</a></li>
<li><a href="#trunkLayoutTestswebrtcdatachannelbasicexpectedtxt">trunk/LayoutTests/webrtc/datachannel/basic-expected.txt</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPreferencesDefinitionsh">trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (213309 => 213310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-02 22:50:57 UTC (rev 213309)
+++ trunk/LayoutTests/ChangeLog 2017-03-02 23:39:40 UTC (rev 213310)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-03-02 Youenn Fablet <youenn@apple.com>
+
+ Activate some new webrtc tests
+ https://bugs.webkit.org/show_bug.cgi?id=168850
+
+ Reviewed by Alex Christensen.
+
+ * TestExpectations: Marking webrtc/audio-peer-connection-webaudio.html as failing.
+ * webrtc/audio-peer-connection-webaudio.html: Making test nicer when failing.
+ * webrtc/datachannel/basic-expected.txt: Updated test expectation.
+
</ins><span class="cx"> 2017-03-02 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> flex-basis should be 0% (not 0px) when omitted
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (213309 => 213310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2017-03-02 22:50:57 UTC (rev 213309)
+++ trunk/LayoutTests/TestExpectations 2017-03-02 23:39:40 UTC (rev 213310)
</span><span class="lines">@@ -691,6 +691,8 @@
</span><span class="cx"> # WebRTC backend not enabled by default on Mac/iOS release bots.
</span><span class="cx"> # GTK enables some of this tests on their TestExpectations file.
</span><span class="cx"> [ Release ] webrtc [ Skip ]
</span><ins>+
+webrtc/audio-peer-connection-webaudio.html [ Failure ]
</ins><span class="cx"> fast/mediastream/getUserMedia-webaudio.html [ Skip ]
</span><span class="cx"> fast/mediastream/RTCPeerConnection-AddRemoveStream.html [ Skip ]
</span><span class="cx"> fast/mediastream/RTCPeerConnection-closed-state.html [ Skip ]
</span></span></pre></div>
<a id="trunkLayoutTestswebrtcaudiopeerconnectionwebaudiohtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/webrtc/audio-peer-connection-webaudio.html (213309 => 213310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/webrtc/audio-peer-connection-webaudio.html 2017-03-02 22:50:57 UTC (rev 213309)
+++ trunk/LayoutTests/webrtc/audio-peer-connection-webaudio.html 2017-03-02 23:39:40 UTC (rev 213310)
</span><span class="lines">@@ -8,9 +8,6 @@
</span><span class="cx"> <script src ="routines.js"></script>
</span><span class="cx"> <script>
</span><span class="cx"> var test = async_test(() => {
</span><del>- if (window.internals)
- internals.useMockRTCPeerConnectionFactory("TwoRealPeerConnections");
-
</del><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.setUserMediaPermission(true);
</span><span class="cx">
</span><span class="lines">@@ -19,10 +16,13 @@
</span><span class="cx"> var heardBip = false;
</span><span class="cx">
</span><span class="cx"> navigator.mediaDevices.getUserMedia({audio: true}).then((stream) => {
</span><ins>+ if (window.internals)
+ internals.useMockRTCPeerConnectionFactory("TwoRealPeerConnections");
+
</ins><span class="cx"> createConnections((firstConnection) => {
</span><span class="cx"> firstConnection.addStream(stream);
</span><span class="cx"> }, (secondConnection) => {
</span><del>- secondConnection.onaddstream = (streamEvent) => {
</del><ins>+ secondConnection.onaddstream = (streamEvent) => {
</ins><span class="cx"> var context = new webkitAudioContext();
</span><span class="cx"> var sourceNode = context.createMediaStreamSource(streamEvent.stream);
</span><span class="cx"> var analyser = context.createAnalyser();
</span><span class="lines">@@ -60,15 +60,15 @@
</span><span class="cx"> done();
</span><span class="cx"> };
</span><span class="cx">
</span><del>- var done = () => {
</del><ins>+ var done = test.step_func_done(() => {
</ins><span class="cx"> clearTimeout(timeout);
</span><span class="cx"> clearInterval(interval);
</span><span class="cx">
</span><del>- assert_true(heardHum);
- assert_true(heardBip);
- assert_true(heardBop);
</del><ins>+ assert_true(heardHum, "heard hum");
+ assert_true(heardBip, "heard bip");
+ assert_true(heardBop, "heard bop");
</ins><span class="cx"> test.done();
</span><del>- };
</del><ins>+ };);
</ins><span class="cx">
</span><span class="cx"> var timeout = setTimeout(done, 3000);
</span><span class="cx"> var interval = setInterval(analyse, 1000 / 30);
</span></span></pre></div>
<a id="trunkLayoutTestswebrtcdatachannelbasicexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/webrtc/datachannel/basic-expected.txt (213309 => 213310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/webrtc/datachannel/basic-expected.txt 2017-03-02 22:50:57 UTC (rev 213309)
+++ trunk/LayoutTests/webrtc/datachannel/basic-expected.txt 2017-03-02 23:39:40 UTC (rev 213310)
</span><span class="lines">@@ -1,4 +1,6 @@
</span><span class="cx">
</span><span class="cx"> PASS Basic data channel exchange from offerer to receiver
</span><span class="cx"> PASS Basic data channel exchange from receiver to offerer
</span><ins>+PASS Basic data channel exchange from offerer to receiver using UDP only
+PASS Basic data channel exchange from offerer to receiver using TCP only
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (213309 => 213310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-03-02 22:50:57 UTC (rev 213309)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-02 23:39:40 UTC (rev 213310)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2017-03-02 Youenn Fablet <youenn@apple.com>
+
+ Activate some new webrtc tests
+ https://bugs.webkit.org/show_bug.cgi?id=168850
+
+ Reviewed by Alex Christensen.
+
+ * Shared/WebPreferencesDefinitions.h: Activating peer connection by default when libwebrtc is on.
+ This allows ensuring the network process will have its sandbox extension.
+
</ins><span class="cx"> 2017-03-02 Brian Burg <bburg@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Automation: _WKAutomationSessionDelegate should work with WKWebViews
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPreferencesDefinitionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (213309 => 213310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-03-02 22:50:57 UTC (rev 213309)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-03-02 23:39:40 UTC (rev 213310)
</span><span class="lines">@@ -206,7 +206,7 @@
</span><span class="cx"> macro(SubpixelCSSOMElementMetricsEnabled, subpixelCSSOMElementMetricsEnabled, Bool, bool, false, "", "") \
</span><span class="cx"> macro(UseGiantTiles, useGiantTiles, Bool, bool, false, "", "") \
</span><span class="cx"> macro(MediaStreamEnabled, mediaStreamEnabled, Bool, bool, false, "", "") \
</span><del>- macro(PeerConnectionEnabled, peerConnectionEnabled, Bool, bool, false, "", "") \
</del><ins>+ macro(PeerConnectionEnabled, peerConnectionEnabled, Bool, bool, WebCore::LibWebRTCProvider::webRTCAvailable(), "", "") \
</ins><span class="cx"> macro(UseLegacyTextAlignPositionedElementBehavior, useLegacyTextAlignPositionedElementBehavior, Bool, bool, false, "", "") \
</span><span class="cx"> macro(SpatialNavigationEnabled, spatialNavigationEnabled, Bool, bool, false, "", "") \
</span><span class="cx"> macro(MediaSourceEnabled, mediaSourceEnabled, Bool, bool, true, "", "") \
</span></span></pre>
</div>
</div>
</body>
</html>