<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213264] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213264">213264</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-01 21:26:21 -0800 (Wed, 01 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[mac-wk1] LayoutTest media/modern-media-controls/tracks-button/tracks-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168476
<rdar://problem/30799198>
Patch by Antoine Quint <graouts@apple.com> on 2017-03-01
Reviewed by Jon Lee.
Write all tests as asynchronous assertions to improve robustness. Since this test should no longer be flaky,
mark it as Pass on platforms where it was marked as flaky.
* media/modern-media-controls/tracks-button/tracks-button-expected.txt:
* media/modern-media-controls/tracks-button/tracks-button.html:
* platform/mac-wk1/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolstracksbuttontracksbuttonexpectedtxt">trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolstracksbuttontracksbuttonhtml">trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk1TestExpectations">trunk/LayoutTests/platform/mac-wk1/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (213263 => 213264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-02 05:24:12 UTC (rev 213263)
+++ trunk/LayoutTests/ChangeLog 2017-03-02 05:26:21 UTC (rev 213264)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2017-03-01 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><ins>+ [mac-wk1] LayoutTest media/modern-media-controls/tracks-button/tracks-button.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=168476
+ <rdar://problem/30799198>
+
+ Reviewed by Jon Lee.
+
+ Write all tests as asynchronous assertions to improve robustness. Since this test should no longer be flaky,
+ mark it as Pass on platforms where it was marked as flaky.
+
+ * media/modern-media-controls/tracks-button/tracks-button-expected.txt:
+ * media/modern-media-controls/tracks-button/tracks-button.html:
+ * platform/mac-wk1/TestExpectations:
+
+2017-03-01 Antoine Quint <graouts@apple.com>
+
</ins><span class="cx"> [mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168409
</span><span class="cx"> <rdar://problem/30799198>
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolstracksbuttontracksbuttonexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button-expected.txt (213263 => 213264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button-expected.txt 2017-03-02 05:24:12 UTC (rev 213263)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button-expected.txt 2017-03-02 05:26:21 UTC (rev 213264)
</span><span class="lines">@@ -7,8 +7,8 @@
</span><span class="cx"> PASS tracksButton.element.classList.contains("icon") is true
</span><span class="cx"> PASS tracksButton.element.classList.contains("tracks") is true
</span><span class="cx"> PASS tracksButton.iconName is "media-selection"
</span><del>-PASS tracksButton.element.style.webkitMaskImage.includes("macOS/media-selection@") is true
-PASS fullscreenTracksButton.element.style.webkitMaskImage.includes("macOS/media-selection-fullscreen@") is true
</del><ins>+PASS tracksButton.element.style.webkitMaskImage.includes("macOS/media-selection@") became true
+PASS fullscreenTracksButton.element.style.webkitMaskImage.includes("macOS/media-selection-fullscreen@") became true
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolstracksbuttontracksbuttonhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button.html (213263 => 213264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button.html 2017-03-02 05:24:12 UTC (rev 213263)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button.html 2017-03-02 05:26:21 UTC (rev 213264)
</span><span class="lines">@@ -17,16 +17,10 @@
</span><span class="cx">
</span><span class="cx"> const fullscreenTracksButton = new TracksButton({ layoutTraits: LayoutTraits.macOS | LayoutTraits.Fullscreen });
</span><span class="cx">
</span><del>-scheduler.frameDidFire = function()
-{
- if ([tracksButton, fullscreenTracksButton].some(button => button.width == 0))
- return;
</del><ins>+shouldBecomeEqual('tracksButton.element.style.webkitMaskImage.includes("macOS/media-selection@")', "true", () => {
+ shouldBecomeEqual('fullscreenTracksButton.element.style.webkitMaskImage.includes("macOS/media-selection-fullscreen@")', "true", finishJSTest);
+});
</ins><span class="cx">
</span><del>- shouldBeTrue('tracksButton.element.style.webkitMaskImage.includes("macOS/media-selection@")');
- shouldBeTrue('fullscreenTracksButton.element.style.webkitMaskImage.includes("macOS/media-selection-fullscreen@")');
- finishMediaControlsTest();
-};
-
</del><span class="cx"> </script>
</span><span class="cx"> <script src="../../../resources/js-test-post.js"></script>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk1TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (213263 => 213264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-03-02 05:24:12 UTC (rev 213263)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-03-02 05:26:21 UTC (rev 213264)
</span><span class="lines">@@ -322,4 +322,3 @@
</span><span class="cx"> webkit.org/b/167857 pageoverlay/overlay-remove-reinsert-view.html [ Skip ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/168378 media/modern-media-controls/media-controller/media-controller-resize.html [ Pass Failure ]
</span><del>-webkit.org/b/168476 media/modern-media-controls/tracks-button/tracks-button.html [ Pass Timeout ]
</del></span></pre>
</div>
</div>
</body>
</html>