<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213258] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213258">213258</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-03-01 19:46:01 -0800 (Wed, 01 Mar 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>LayoutTest media/modern-media-controls/volume-down-support/volume-down-support.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=168935
<rdar://problem/30796699>
Patch by Antoine Quint <graouts@apple.com> on 2017-03-01
Reviewed by Dean Jackson.
Use asynchronous assertions to guarantee we've entered fullscreen and the volume down button
is present and leave a little room for error when checking the volume since we would sometime
see a value of 0.009 rather than 0.
* media/modern-media-controls/volume-down-support/volume-down-support-expected.txt:
* media/modern-media-controls/volume-down-support/volume-down-support.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsvolumedownsupportvolumedownsupportexpectedtxt">trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsvolumedownsupportvolumedownsupporthtml">trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (213257 => 213258)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-02 02:44:58 UTC (rev 213257)
+++ trunk/LayoutTests/ChangeLog 2017-03-02 03:46:01 UTC (rev 213258)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2017-03-01 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><ins>+ LayoutTest media/modern-media-controls/volume-down-support/volume-down-support.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=168935
+ <rdar://problem/30796699>
+
+ Reviewed by Dean Jackson.
+
+ Use asynchronous assertions to guarantee we've entered fullscreen and the volume down button
+ is present and leave a little room for error when checking the volume since we would sometime
+ see a value of 0.009 rather than 0.
+
+ * media/modern-media-controls/volume-down-support/volume-down-support-expected.txt:
+ * media/modern-media-controls/volume-down-support/volume-down-support.html:
+
+2017-03-01 Antoine Quint <graouts@apple.com>
+
</ins><span class="cx"> [mac-wk1] LayoutTest media/modern-media-controls/seek-backward-support/seek-backward-support.html is a flaky timeout
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=165386
</span><span class="cx"> <rdar://problem/30793480>
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsvolumedownsupportvolumedownsupportexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support-expected.txt (213257 => 213258)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support-expected.txt 2017-03-02 02:44:58 UTC (rev 213257)
+++ trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support-expected.txt 2017-03-02 03:46:01 UTC (rev 213258)
</span><span class="lines">@@ -3,10 +3,12 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><ins>+PASS !!window.internals.shadowRoot(media).lastChild.querySelector("button.volume-down") became true
+PASS media.webkitDisplayingFullscreen is true
</ins><span class="cx"> PASS media.volume is 1
</span><span class="cx">
</span><span class="cx"> Pressing on the volume down button
</span><del>-PASS media.volume is 0
</del><ins>+PASS media.volume is within 0.1 of 0
</ins><span class="cx">
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsvolumedownsupportvolumedownsupporthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support.html (213257 => 213258)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support.html 2017-03-02 02:44:58 UTC (rev 213257)
+++ trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support.html 2017-03-02 03:46:01 UTC (rev 213258)
</span><span class="lines">@@ -13,45 +13,26 @@
</span><span class="cx"> const media = document.querySelector("video");
</span><span class="cx"> const button = document.body.appendChild(document.createElement("button"));
</span><span class="cx">
</span><del>-media.addEventListener("webkitfullscreenchange", function() {
- if (media.webkitDisplayingFullscreen) {
- window.requestAnimationFrame(() => {
- window.requestAnimationFrame(() => {
- shouldBe("media.volume", "1");
</del><ins>+button.addEventListener("click", () => media.webkitEnterFullscreen());
</ins><span class="cx">
</span><del>- media.addEventListener("volumechange", () => {
- shouldBe("media.volume", "0");
- debug("");
- media.remove();
- button.remove();
- finishJSTest();
- });
</del><ins>+media.addEventListener("loadedmetadata", () => {
+ pressOnElement(button);
+ shouldBecomeEqual('!!window.internals.shadowRoot(media).lastChild.querySelector("button.volume-down")', "true", () => {
+ shouldBeTrue("media.webkitDisplayingFullscreen");
+ shouldBe("media.volume", "1");
</ins><span class="cx">
</span><del>- debug("");
- debug("Pressing on the volume down button");
- pressOnElement(window.internals.shadowRoot(media).lastElementChild.lastElementChild.querySelector("button.volume-down"));
- });
</del><ins>+ media.addEventListener("volumechange", () => {
+ shouldBeCloseTo("media.volume", 0, 0.1);
+ debug("");
+ media.remove();
+ button.remove();
+ finishJSTest();
</ins><span class="cx"> });
</span><del>- }
-});
</del><span class="cx">
</span><del>-media.addEventListener("loadedmetadata", () => {
- if (!("eventSender" in window)) {
- debug("This test is designed to run in DRT");
- return;
- }
-
- // Click a button so we may enter fullscreen.
- button.addEventListener("click", event => {
- try {
- media.webkitEnterFullscreen();
- } catch(e) {
- debug("Toggling fullscreen failed");
- finishJSTest();
- }
</del><ins>+ debug("");
+ debug("Pressing on the volume down button");
+ pressOnElement(window.internals.shadowRoot(media).lastElementChild.lastElementChild.querySelector("button.volume-down"));
</ins><span class="cx"> });
</span><del>-
- pressOnElement(button);
</del><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> </script>
</span></span></pre>
</div>
</div>
</body>
</html>