<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213185] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213185">213185</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-28 15:24:42 -0800 (Tue, 28 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add ability for webkitpy to run bindings tests
https://bugs.webkit.org/show_bug.cgi?id=168979
Patch by Srinivasan Vijayaraghavan <svijayaraghavan@apple.com> on 2017-02-28
Reviewed by Alexey Proskuryakov.
This allows the below command to run bindings tests with json output, and is a required part
of adding an EWS for bindings tests. (Note: this won't build because --build is not passed).
webkit-patch build-and-test --no-clean --no-update --test --non-interactive --group="bindings"
* Scripts/webkitpy/port/base.py:
(Port.bindings_results_directory): Return the directory to place JSON results for bindings tests.
* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run): Checks if we should be running bindings tests.
(RunTests._run_bindings_tests): Generates the command for bindings tests, and executes it.
* Scripts/webkitpy/tool/steps/steps_unittest.py:
(test_runtests_bindings): Unit test for the generated run-bindings-tests command.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpyportbasepy">trunk/Tools/Scripts/webkitpy/port/base.py</a></li>
<li><a href="#trunkToolsScriptswebkitpytoolstepsruntestspy">trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py</a></li>
<li><a href="#trunkToolsScriptswebkitpytoolstepssteps_unittestpy">trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (213184 => 213185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-02-28 23:22:31 UTC (rev 213184)
+++ trunk/Tools/ChangeLog 2017-02-28 23:24:42 UTC (rev 213185)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2017-02-28 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
+
+ Add ability for webkitpy to run bindings tests
+ https://bugs.webkit.org/show_bug.cgi?id=168979
+
+ Reviewed by Alexey Proskuryakov.
+
+ This allows the below command to run bindings tests with json output, and is a required part
+ of adding an EWS for bindings tests. (Note: this won't build because --build is not passed).
+ webkit-patch build-and-test --no-clean --no-update --test --non-interactive --group="bindings"
+
+ * Scripts/webkitpy/port/base.py:
+ (Port.bindings_results_directory): Return the directory to place JSON results for bindings tests.
+ * Scripts/webkitpy/tool/steps/runtests.py:
+ (RunTests.run): Checks if we should be running bindings tests.
+ (RunTests._run_bindings_tests): Generates the command for bindings tests, and executes it.
+ * Scripts/webkitpy/tool/steps/steps_unittest.py:
+ (test_runtests_bindings): Unit test for the generated run-bindings-tests command.
+
</ins><span class="cx"> 2017-02-28 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Test fix after r213163
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpyportbasepy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/port/base.py (213184 => 213185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/port/base.py 2017-02-28 23:22:31 UTC (rev 213184)
+++ trunk/Tools/Scripts/webkitpy/port/base.py 2017-02-28 23:24:42 UTC (rev 213185)
</span><span class="lines">@@ -811,6 +811,9 @@
</span><span class="cx"> def jsc_results_directory(self):
</span><span class="cx"> return self._build_path()
</span><span class="cx">
</span><ins>+ def bindings_results_directory(self):
+ return self._build_path()
+
</ins><span class="cx"> def results_directory(self):
</span><span class="cx"> """Absolute path to the place to store the test results (uses --results-directory)."""
</span><span class="cx"> if not self._results_directory:
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpytoolstepsruntestspy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py (213184 => 213185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2017-02-28 23:22:31 UTC (rev 213184)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2017-02-28 23:24:42 UTC (rev 213185)
</span><span class="lines">@@ -62,6 +62,10 @@
</span><span class="cx"> self._run_javascriptcore_tests()
</span><span class="cx"> return
</span><span class="cx">
</span><ins>+ if self._options.group == "bindings":
+ self._run_bindings_tests()
+ return
+
</ins><span class="cx"> if self._options.iterate_on_new_tests:
</span><span class="cx"> _log.info("Running run-webkit-tests on new tests")
</span><span class="cx"> self._run_webkit_tests(self._options.iterate_on_new_tests)
</span><span class="lines">@@ -157,3 +161,11 @@
</span><span class="cx"> results_file_path = self._tool.filesystem.join(results_directory, "jsc_test_results.json")
</span><span class="cx"> args.append("--json-output=%s" % results_file_path)
</span><span class="cx"> self._tool.executive.run_and_throw_if_fail(args, cwd=self._tool.scm().checkout_root)
</span><ins>+
+ def _run_bindings_tests(self):
+ args = self._tool.deprecated_port().run_bindings_tests_command()
+ results_directory = self._tool.port_factory.get(options=self._options).bindings_results_directory()
+ self._tool.filesystem.maybe_make_directory(results_directory)
+ results_file_path = self._tool.filesystem.join(results_directory, "bindings_test_results.json")
+ args.append("--json-output=%s" % results_file_path)
+ self._tool.executive.run_and_throw_if_fail(args, cwd=self._tool.scm().checkout_root)
</ins></span></pre></div>
<a id="trunkToolsScriptswebkitpytoolstepssteps_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py (213184 => 213185)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py 2017-02-28 23:22:31 UTC (rev 213184)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py 2017-02-28 23:24:42 UTC (rev 213185)
</span><span class="lines">@@ -243,3 +243,16 @@
</span><span class="cx"> """
</span><span class="cx"> with self.assertRaises(ScriptError):
</span><span class="cx"> OutputCapture().assert_outputs(self, step.run, [{}], expected_logs=expected_logs)
</span><ins>+
+ def test_runtests_bindings(self):
+ mock_options = self._step_options()
+ mock_options.non_interactive = False
+ mock_options.group = "bindings"
+ step = steps.RunTests(MockTool(log_executive=True), mock_options)
+ tool = MockTool(log_executive=True)
+ # FIXME: We shouldn't use a real port-object here, but there is too much to mock at the moment.
+ tool._deprecated_port = DeprecatedPort()
+ step = steps.RunTests(tool, mock_options)
+ expected_logs = """MOCK run_and_throw_if_fail: ['Tools/Scripts/run-bindings-tests', '--json-output=/tmp/bindings_test_results.json'], cwd=/mock-checkout
+"""
+ OutputCapture().assert_outputs(self, step.run, [{}], expected_logs=expected_logs)
</ins></span></pre>
</div>
</div>
</body>
</html>