<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213205] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213205">213205</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-28 21:29:32 -0800 (Tue, 28 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: RTL: expose the Layout Direction setting in Production builds, keep using LTR by default
https://bugs.webkit.org/show_bug.cgi?id=168999
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2017-02-28
Reviewed by Brian Burg.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/SettingsTabContentView.js:
(WebInspector.SettingsTabContentView.prototype.layout):
Remove the WebInspector.isDebugUIEnabled() check around the Layout Direction setting.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsSettingsTabContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (213204 => 213205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2017-03-01 03:55:41 UTC (rev 213204)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-03-01 05:29:32 UTC (rev 213205)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2017-02-28 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: RTL: expose the Layout Direction setting in Production builds, keep using LTR by default
+ https://bugs.webkit.org/show_bug.cgi?id=168999
+
+ Reviewed by Brian Burg.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WebInspector.SettingsTabContentView.prototype.layout):
+ Remove the WebInspector.isDebugUIEnabled() check around the Layout Direction setting.
+
+2017-02-28 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: It is possible to get the New Tab button in addition to the seven expected tabs
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168976
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (213204 => 213205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-03-01 03:55:41 UTC (rev 213204)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-03-01 05:29:32 UTC (rev 213205)
</span><span class="lines">@@ -456,8 +456,10 @@
</span><span class="cx"> localizedStrings["Layers"] = "Layers";
</span><span class="cx"> localizedStrings["Layout"] = "Layout";
</span><span class="cx"> localizedStrings["Layout & Rendering"] = "Layout & Rendering";
</span><ins>+localizedStrings["Layout Direction:"] = "Layout Direction:";
</ins><span class="cx"> localizedStrings["Layout Invalidated"] = "Layout Invalidated";
</span><span class="cx"> localizedStrings["Left"] = "Left";
</span><ins>+localizedStrings["Left to Right (LTR)"] = "Left to Right (LTR)";
</ins><span class="cx"> localizedStrings["Letter"] = "Letter";
</span><span class="cx"> localizedStrings["Ligatures"] = "Ligatures";
</span><span class="cx"> localizedStrings["Line %d"] = "Line %d";
</span><span class="lines">@@ -650,6 +652,7 @@
</span><span class="cx"> localizedStrings["Reveal in Original Resource"] = "Reveal in Original Resource";
</span><span class="cx"> localizedStrings["Reveal in Resources Tab"] = "Reveal in Resources Tab";
</span><span class="cx"> localizedStrings["Right"] = "Right";
</span><ins>+localizedStrings["Right to Left (RTL)"] = "Right to Left (RTL)";
</ins><span class="cx"> localizedStrings["Role"] = "Role";
</span><span class="cx"> localizedStrings["Rule"] = "Rule";
</span><span class="cx"> localizedStrings["Samples"] = "Samples";
</span><span class="lines">@@ -762,6 +765,7 @@
</span><span class="cx"> localizedStrings["Styles \u2014 Visual"] = "Styles \u2014 Visual";
</span><span class="cx"> localizedStrings["Stylesheet"] = "Stylesheet";
</span><span class="cx"> localizedStrings["Stylesheets"] = "Stylesheets";
</span><ins>+localizedStrings["System Default"] = "System Default";
</ins><span class="cx"> localizedStrings["Tab width:"] = "Tab width:";
</span><span class="cx"> localizedStrings["Tabs"] = "Tabs";
</span><span class="cx"> localizedStrings["Take snapshot"] = "Take snapshot";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsSettingsTabContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (213204 => 213205)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2017-03-01 03:55:41 UTC (rev 213204)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2017-03-01 05:29:32 UTC (rev 213205)
</span><span class="lines">@@ -191,30 +191,28 @@
</span><span class="cx"> });
</span><span class="cx"> });
</span><span class="cx">
</span><del>- if (WebInspector.isDebugUIEnabled()) {
- this.element.appendChild(document.createElement("br"));
</del><ins>+ this.element.appendChild(document.createElement("br"));
</ins><span class="cx">
</span><del>- createContainer(WebInspector.unlocalizedString("Layout Direction:"), (valueControllerContainer) => {
- let selectElement = valueControllerContainer.appendChild(document.createElement("select"));
- selectElement.addEventListener("change", (event) => {
- WebInspector.setLayoutDirection(selectElement.value);
- });
</del><ins>+ createContainer(WebInspector.UIString("Layout Direction:"), (valueControllerContainer) => {
+ let selectElement = valueControllerContainer.appendChild(document.createElement("select"));
+ selectElement.addEventListener("change", (event) => {
+ WebInspector.setLayoutDirection(selectElement.value);
+ });
</ins><span class="cx">
</span><del>- let currentLayoutDirection = WebInspector.settings.layoutDirection.value;
- let options = new Map([
- [WebInspector.LayoutDirection.System, WebInspector.unlocalizedString("System Default")],
- [WebInspector.LayoutDirection.LTR, WebInspector.unlocalizedString("Left to Right (LTR)")],
- [WebInspector.LayoutDirection.RTL, WebInspector.unlocalizedString("Right to Left (RTL)")],
- ]);
</del><ins>+ let currentLayoutDirection = WebInspector.settings.layoutDirection.value;
+ let options = new Map([
+ [WebInspector.LayoutDirection.System, WebInspector.UIString("System Default")],
+ [WebInspector.LayoutDirection.LTR, WebInspector.UIString("Left to Right (LTR)")],
+ [WebInspector.LayoutDirection.RTL, WebInspector.UIString("Right to Left (RTL)")],
+ ]);
</ins><span class="cx">
</span><del>- for (let [key, value] of options) {
- let optionElement = selectElement.appendChild(document.createElement("option"));
- optionElement.value = key;
- optionElement.textContent = value;
- optionElement.selected = currentLayoutDirection === key;
- }
- });
- }
</del><ins>+ for (let [key, value] of options) {
+ let optionElement = selectElement.appendChild(document.createElement("option"));
+ optionElement.value = key;
+ optionElement.textContent = value;
+ optionElement.selected = currentLayoutDirection === key;
+ }
+ });
</ins><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>