<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213196] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213196">213196</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-28 17:08:12 -0800 (Tue, 28 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>LayoutTest media/modern-media-controls/airplay-support/airplay-support.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167442
<rdar://problem/30770374>
Patch by Antoine Quint <graouts@apple.com> on 2017-02-28
Reviewed by Dean Jackson.
This test would sometime fail when calling media.webkitShowPlaybackTargetPicker() due to the requirement
that the media be playable for that call to succeed. So we add an event listener for the "canplay" event
before we proceed to ensure that this call will always succeed. The fact that the media is playing is
irrelevant so we remove the "autoplay" attribute.
* media/modern-media-controls/airplay-support/airplay-support.html:
* platform/mac/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsairplaysupportairplaysupporthtml">trunk/LayoutTests/media/modern-media-controls/airplay-support/airplay-support.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (213195 => 213196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-03-01 01:04:01 UTC (rev 213195)
+++ trunk/LayoutTests/ChangeLog 2017-03-01 01:08:12 UTC (rev 213196)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2017-02-28 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><ins>+ LayoutTest media/modern-media-controls/airplay-support/airplay-support.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=167442
+ <rdar://problem/30770374>
+
+ Reviewed by Dean Jackson.
+
+ This test would sometime fail when calling media.webkitShowPlaybackTargetPicker() due to the requirement
+ that the media be playable for that call to succeed. So we add an event listener for the "canplay" event
+ before we proceed to ensure that this call will always succeed. The fact that the media is playing is
+ irrelevant so we remove the "autoplay" attribute.
+
+ * media/modern-media-controls/airplay-support/airplay-support.html:
+ * platform/mac/TestExpectations:
+
+2017-02-28 Antoine Quint <graouts@apple.com>
+
</ins><span class="cx"> LayoutTest media/modern-media-controls/placard-support/placard-support-airplay.html is a flaky timeout
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=167441
</span><span class="cx"> <rdar://problem/30770034>
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsairplaysupportairplaysupporthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/modern-media-controls/airplay-support/airplay-support.html (213195 => 213196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/airplay-support/airplay-support.html 2017-03-01 01:04:01 UTC (rev 213195)
+++ trunk/LayoutTests/media/modern-media-controls/airplay-support/airplay-support.html 2017-03-01 01:08:12 UTC (rev 213196)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx"> <script src="../../../resources/js-test-pre.js"></script>
</span><span class="cx"> <script src="../resources/media-controls-loader.js" type="text/javascript"></script>
</span><span class="cx"> <body>
</span><del>-<video src="../../content/test.mp4" style="width: 320px; height: 240px;" autoplay></video>
</del><ins>+<video src="../../content/test.mp4" style="width: 320px; height: 240px;"></video>
</ins><span class="cx"> <div id="host"></div>
</span><span class="cx"> <script type="text/javascript">
</span><span class="cx">
</span><span class="lines">@@ -13,12 +13,14 @@
</span><span class="cx"> const media = document.querySelector("video");
</span><span class="cx"> const mediaController = createControls(container, media, null);
</span><span class="cx">
</span><del>-(function makeAirPlayAvailable()
</del><ins>+media.addEventListener("canplay", makeAirPlayAvailable);
+
+function makeAirPlayAvailable()
</ins><span class="cx"> {
</span><span class="cx"> debug("Making AirPlay routes available.");
</span><span class="cx"> media.addEventListener("webkitplaybacktargetavailabilitychanged", playbackTargetAvailabilityChangedOnce, true);
</span><span class="cx"> window.internals.setMockMediaPlaybackTargetPickerEnabled(true);
</span><del>-})();
</del><ins>+}
</ins><span class="cx">
</span><span class="cx"> function playbackTargetAvailabilityChangedOnce(event)
</span><span class="cx"> {
</span><span class="lines">@@ -41,7 +43,7 @@
</span><span class="cx"> shouldBeTrue("mediaController.controls.airplayButton.enabled");
</span><span class="cx"> shouldBeFalse("mediaController.controls.airplayButton.on");
</span><span class="cx">
</span><del>- window.setTimeout(enterAirPlay, 100);
</del><ins>+ enterAirPlay();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function enterAirPlay()
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (213195 => 213196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2017-03-01 01:04:01 UTC (rev 213195)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-03-01 01:08:12 UTC (rev 213196)
</span><span class="lines">@@ -1494,8 +1494,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/167396 media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Pass Failure ]
</span><span class="cx">
</span><del>-webkit.org/b/167442 media/modern-media-controls/airplay-support/airplay-support.html [ Pass Timeout ]
-
</del><span class="cx"> webkit.org/b/165874 streams/pipe-to.html [ Pass Failure ]
</span><span class="cx">
</span><span class="cx"> # New Encrypted Media API not enabled on Mac
</span></span></pre>
</div>
</div>
</body>
</html>