<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213117] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213117">213117</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-27 20:07:05 -0800 (Mon, 27 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Calling build() on a baseline point results in an exception
https://bugs.webkit.org/show_bug.cgi?id=168959
Reviewed by Joseph Pecoraro.
Some baseline points may lack the build information. e.g. A custom data point made by an user.
Only instantiate Build object in a point object returned by MeasurementAdaptor when the builder id
is available so that we don't hit an assertion inside Build's constructor.
* public/v3/models/measurement-adaptor.js:
(MeasurementAdaptor.prototype.applyTo..build): Only instantiate Build when builderId is set.
* unit-tests/measurement-adaptor-tests.js: Added a test case.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelsmeasurementadaptorjs">trunk/Websites/perf.webkit.org/public/v3/models/measurement-adaptor.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgunittestsmeasurementadaptortestsjs">trunk/Websites/perf.webkit.org/unit-tests/measurement-adaptor-tests.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (213116 => 213117)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2017-02-28 03:30:33 UTC (rev 213116)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2017-02-28 04:07:05 UTC (rev 213117)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2017-02-27 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ Calling build() on a baseline point results in an exception
+ https://bugs.webkit.org/show_bug.cgi?id=168959
+
+ Reviewed by Joseph Pecoraro.
+
+ Some baseline points may lack the build information. e.g. A custom data point made by an user.
+ Only instantiate Build object in a point object returned by MeasurementAdaptor when the builder id
+ is available so that we don't hit an assertion inside Build's constructor.
+
+ * public/v3/models/measurement-adaptor.js:
+ (MeasurementAdaptor.prototype.applyTo..build): Only instantiate Build when builderId is set.
+ * unit-tests/measurement-adaptor-tests.js: Added a test case.
+
+2017-02-27 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> Arrow key shouldn't move the indicator beyond the visible points
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168956
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelsmeasurementadaptorjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/measurement-adaptor.js (213116 => 213117)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/measurement-adaptor.js 2017-02-28 03:30:33 UTC (rev 213116)
+++ trunk/Websites/perf.webkit.org/public/v3/models/measurement-adaptor.js 2017-02-28 04:07:05 UTC (rev 213117)
</span><span class="lines">@@ -61,7 +61,7 @@
</span><span class="cx"> configType: null,
</span><span class="cx"> rootSet: function () { return MeasurementRootSet.ensureSingleton(id, row[self._revisionsIndex]); },
</span><span class="cx"> build: function () {
</span><del>- if (cachedBuild == null)
</del><ins>+ if (cachedBuild == null && builderId)
</ins><span class="cx"> cachedBuild = new Build(buildId, Builder.findById(builderId), row[self._buildNumberIndex], row[self._buildTimeIndex]);
</span><span class="cx"> return cachedBuild;
</span><span class="cx"> },
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgunittestsmeasurementadaptortestsjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/unit-tests/measurement-adaptor-tests.js (213116 => 213117)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/unit-tests/measurement-adaptor-tests.js 2017-02-28 03:30:33 UTC (rev 213116)
+++ trunk/Websites/perf.webkit.org/unit-tests/measurement-adaptor-tests.js 2017-02-28 04:07:05 UTC (rev 213117)
</span><span class="lines">@@ -5,7 +5,7 @@
</span><span class="cx"> require('../tools/js/v3-models.js');
</span><span class="cx"> let MockModels = require('./resources/mock-v3-models.js').MockModels;
</span><span class="cx">
</span><del>-var sampleCluster = {
</del><ins>+const sampleCluster = {
</ins><span class="cx"> 'clusterStart': 946684800000,
</span><span class="cx"> 'clusterSize': 5184000000,
</span><span class="cx"> 'configurations': {
</span><span class="lines">@@ -12,6 +12,9 @@
</span><span class="cx"> 'current': [
</span><span class="cx"> [28954983, 217.94607142857, 20, 4358.9214285714, 950303.02365434, false, [[111, 9, '10.11 15D21', 0], [222, 11, '192483', 1447707055576], [333, 999, 'some unknown revision', 0]], 1447707055576, 184629, 1447762266153, '178', 176],
</span><span class="cx"> [28952257, 220.11455357143, 20, 4402.2910714286, 969099.67509885, false, [[111, 9, '10.11 15D21', 0], [444, 11, '192486', 1447713500460]], 1447713500460, 184614, 1447760255683, '177', 176]
</span><ins>+ ],
+ 'baseline': [
+ [10548956, 312.59, 1, 0, 0, false, [], 1420070400000, 67724, 1420070400000, "0", 0]
</ins><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> 'formatMap': ['id', 'mean', 'iterationCount', 'sum', 'squareSum', 'markedOutlier', 'revisions',
</span><span class="lines">@@ -23,7 +26,8 @@
</span><span class="cx"> 'elapsedTime': 210.68406105042,
</span><span class="cx"> 'status': 'OK'
</span><span class="cx"> };
</span><del>-var sampleData = sampleCluster.configurations.current[0];
</del><ins>+const sampleData = sampleCluster.configurations.current[0];
+const sampleCustomBaselineData = sampleCluster.configurations.baseline[0];
</ins><span class="cx">
</span><span class="cx"> describe('MeasurementAdaptor', function () {
</span><span class="cx"> MockModels.inject();
</span><span class="lines">@@ -30,43 +34,48 @@
</span><span class="cx">
</span><span class="cx"> describe('applyTo', function () {
</span><span class="cx"> it('should adapt id', function () {
</span><del>- var adoptor = new MeasurementAdaptor(sampleCluster.formatMap);
- assert.equal(adoptor.applyTo(sampleData).id, 28954983);
</del><ins>+ var adaptor = new MeasurementAdaptor(sampleCluster.formatMap);
+ assert.equal(adaptor.applyTo(sampleData).id, 28954983);
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> it('should adapt mean, squareMean, and iteration count', function () {
</span><del>- var adoptor = new MeasurementAdaptor(sampleCluster.formatMap);
- assert.equal(adoptor.applyTo(sampleData).value, 217.94607142857);
- assert.equal(adoptor.applyTo(sampleData).sum, 4358.9214285714);
- assert.equal(adoptor.applyTo(sampleData).squareSum, 950303.02365434);
- assert.equal(adoptor.applyTo(sampleData).iterationCount, 20);
</del><ins>+ var adaptor = new MeasurementAdaptor(sampleCluster.formatMap);
+ assert.equal(adaptor.applyTo(sampleData).value, 217.94607142857);
+ assert.equal(adaptor.applyTo(sampleData).sum, 4358.9214285714);
+ assert.equal(adaptor.applyTo(sampleData).squareSum, 950303.02365434);
+ assert.equal(adaptor.applyTo(sampleData).iterationCount, 20);
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> it('should adapt commitTime as the canonical time', function () {
</span><del>- var adoptor = new MeasurementAdaptor(sampleCluster.formatMap);
- assert.equal(adoptor.applyTo(sampleData).time, 1447707055576);
</del><ins>+ var adaptor = new MeasurementAdaptor(sampleCluster.formatMap);
+ assert.equal(adaptor.applyTo(sampleData).time, 1447707055576);
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> it('should adapt build information as a Build object', function () {
</span><del>- var adoptor = new MeasurementAdaptor(sampleCluster.formatMap);
- assert.ok(adoptor.applyTo(sampleData).build() instanceof Build);
- assert.equal(adoptor.applyTo(sampleData).build().id(), 184629);
- assert.equal(adoptor.applyTo(sampleData).build().buildNumber(), '178');
- assert.equal(adoptor.applyTo(sampleData).build().builder(), MockModels.builder);
- assert.equal(adoptor.applyTo(sampleData).build().label(), 'Build 178 on WebKit Perf Builder');
- assert.equal(adoptor.applyTo(sampleData).build().url(), 'http://build.webkit.org/builders/WebKit Perf Builder/178');
</del><ins>+ var adaptor = new MeasurementAdaptor(sampleCluster.formatMap);
+ assert.ok(adaptor.applyTo(sampleData).build() instanceof Build);
+ assert.equal(adaptor.applyTo(sampleData).build().id(), 184629);
+ assert.equal(adaptor.applyTo(sampleData).build().buildNumber(), '178');
+ assert.equal(adaptor.applyTo(sampleData).build().builder(), MockModels.builder);
+ assert.equal(adaptor.applyTo(sampleData).build().label(), 'Build 178 on WebKit Perf Builder');
+ assert.equal(adaptor.applyTo(sampleData).build().url(), 'http://build.webkit.org/builders/WebKit Perf Builder/178');
</ins><span class="cx"> });
</span><span class="cx">
</span><ins>+ it('should adapt build information as null when the builder is not specified', function () {
+ var adaptor = new MeasurementAdaptor(sampleCluster.formatMap);
+ assert.equal(adaptor.applyTo(sampleCustomBaselineData).build(), null);
+ });
+
</ins><span class="cx"> it('should adapt revision information as a RootSet object', function () {
</span><del>- var adoptor = new MeasurementAdaptor(sampleCluster.formatMap);
- var rootSet = adoptor.applyTo(sampleData).rootSet();
</del><ins>+ var adaptor = new MeasurementAdaptor(sampleCluster.formatMap);
+ var rootSet = adaptor.applyTo(sampleData).rootSet();
</ins><span class="cx"> assert.ok(rootSet instanceof RootSet);
</span><span class="cx"> assert.equal(rootSet.latestCommitTime(), 1447707055576);
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> it('should adapt OS X version as a CommitLog object', function () {
</span><del>- var adoptor = new MeasurementAdaptor(sampleCluster.formatMap);
- var rootSet = adoptor.applyTo(sampleData).rootSet();
</del><ins>+ var adaptor = new MeasurementAdaptor(sampleCluster.formatMap);
+ var rootSet = adaptor.applyTo(sampleData).rootSet();
</ins><span class="cx"> assert.ok(rootSet instanceof RootSet);
</span><span class="cx"> assert.equal(rootSet.latestCommitTime(), 1447707055576);
</span><span class="cx">
</span><span class="lines">@@ -85,8 +94,8 @@
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> it('should adapt WebKit revision as a CommitLog object', function () {
</span><del>- var adoptor = new MeasurementAdaptor(sampleCluster.formatMap);
- var rootSet = adoptor.applyTo(sampleData).rootSet();
</del><ins>+ var adaptor = new MeasurementAdaptor(sampleCluster.formatMap);
+ var rootSet = adaptor.applyTo(sampleData).rootSet();
</ins><span class="cx">
</span><span class="cx"> assert.ok(rootSet.repositories().indexOf(MockModels.webkit) >= 0);
</span><span class="cx"> assert.equal(rootSet.revisionForRepository(MockModels.webkit), '192483');
</span><span class="lines">@@ -104,12 +113,12 @@
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> it('should not create separate CommitLog object for the same revision', function () {
</span><del>- var adoptor = new MeasurementAdaptor(sampleCluster.formatMap);
- assert.equal(adoptor.applyTo(sampleData).rootSet().commitForRepository(MockModels.webkit),
- adoptor.applyTo(sampleData).rootSet().commitForRepository(MockModels.webkit));
</del><ins>+ var adaptor = new MeasurementAdaptor(sampleCluster.formatMap);
+ assert.equal(adaptor.applyTo(sampleData).rootSet().commitForRepository(MockModels.webkit),
+ adaptor.applyTo(sampleData).rootSet().commitForRepository(MockModels.webkit));
</ins><span class="cx">
</span><del>- assert.equal(adoptor.applyTo(sampleData).rootSet().commitForRepository(MockModels.osx),
- adoptor.applyTo(sampleData).rootSet().commitForRepository(MockModels.osx));
</del><ins>+ assert.equal(adaptor.applyTo(sampleData).rootSet().commitForRepository(MockModels.osx),
+ adaptor.applyTo(sampleData).rootSet().commitForRepository(MockModels.osx));
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> });
</span></span></pre>
</div>
</div>
</body>
</html>