<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212998] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212998">212998</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-25 00:05:21 -0800 (Sat, 25 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: RTL: disclosure triangles in details section headers should be flipped and aligned right
https://bugs.webkit.org/show_bug.cgi?id=168283
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2017-02-25
Reviewed by Brian Burg.
* UserInterface/Views/DetailsSection.css:
(.details-section):
(.details-section > .header):
(body[dir=ltr] .details-section > .header):
(body[dir=rtl] .details-section > .header):
(.details-section > .header > .options > .navigation-bar):
(body[dir=ltr] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar), body[dir=rtl] .details-section > .header::before):
(body[dir=ltr] .details-section > .header::before, body[dir=rtl] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar)):
(.details-section > .header::before):
(body[dir=rtl] .details-section > .header::before):
(.details-section > .header > label):
(.details-section > .header > label > input[type="checkbox"]):
(body[dir=ltr] .details-section > .header > label > input[type="checkbox"]):
(body[dir=rtl] .details-section > .header > label > input[type="checkbox"]):
(.details-section > .header .go-to-arrow):
(body[dir=ltr] .details-section > .header .go-to-arrow):
(body[dir=rtl] .details-section > .header .go-to-arrow):
(.details-section > .content > .group > .row.simple > .label):
(body[dir=ltr] .details-section > .content > .group > .row.simple > .label):
(body[dir=rtl] .details-section > .content > .group > .row.simple > .label):
(.details-section > .content > .group > .row.simple > .value):
(body[dir=ltr] .details-section > .content > .group > .row.simple > .value):
(body[dir=rtl] .details-section > .content > .group > .row.simple > .value):
(.details-section > .content > .group > .row.simple > .value .go-to-arrow):
(body[dir=ltr] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
(body[dir=rtl] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
(.details-section > .header > :matches(.node-link, .go-to-arrow)): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDetailsSectioncss">trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (212997 => 212998)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 08:02:02 UTC (rev 212997)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 08:05:21 UTC (rev 212998)
</span><span class="lines">@@ -1,3 +1,38 @@
</span><ins>+2017-02-25 Devin Rousso <dcrousso+webkit@gmail.com>
+
+ Web Inspector: RTL: disclosure triangles in details section headers should be flipped and aligned right
+ https://bugs.webkit.org/show_bug.cgi?id=168283
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/DetailsSection.css:
+ (.details-section):
+ (.details-section > .header):
+ (body[dir=ltr] .details-section > .header):
+ (body[dir=rtl] .details-section > .header):
+ (.details-section > .header > .options > .navigation-bar):
+ (body[dir=ltr] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar), body[dir=rtl] .details-section > .header::before):
+ (body[dir=ltr] .details-section > .header::before, body[dir=rtl] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar)):
+ (.details-section > .header::before):
+ (body[dir=rtl] .details-section > .header::before):
+ (.details-section > .header > label):
+ (.details-section > .header > label > input[type="checkbox"]):
+ (body[dir=ltr] .details-section > .header > label > input[type="checkbox"]):
+ (body[dir=rtl] .details-section > .header > label > input[type="checkbox"]):
+ (.details-section > .header .go-to-arrow):
+ (body[dir=ltr] .details-section > .header .go-to-arrow):
+ (body[dir=rtl] .details-section > .header .go-to-arrow):
+ (.details-section > .content > .group > .row.simple > .label):
+ (body[dir=ltr] .details-section > .content > .group > .row.simple > .label):
+ (body[dir=rtl] .details-section > .content > .group > .row.simple > .label):
+ (.details-section > .content > .group > .row.simple > .value):
+ (body[dir=ltr] .details-section > .content > .group > .row.simple > .value):
+ (body[dir=rtl] .details-section > .content > .group > .row.simple > .value):
+ (.details-section > .content > .group > .row.simple > .value .go-to-arrow):
+ (body[dir=ltr] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
+ (body[dir=rtl] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
+ (.details-section > .header > :matches(.node-link, .go-to-arrow)): Deleted.
+
</ins><span class="cx"> 2017-02-24 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: RTL: add support for Error page
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDetailsSectioncss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css (212997 => 212998)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css 2017-02-25 08:02:02 UTC (rev 212997)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css 2017-02-25 08:05:21 UTC (rev 212998)
</span><span class="lines">@@ -27,6 +27,12 @@
</span><span class="cx"> font-size: 10px;
</span><span class="cx"> background-color: var(--panel-background-color);
</span><span class="cx"> border-bottom: 1px solid var(--border-color);
</span><ins>+
+ --details-section-header-padding-end: 5px;
+ --details-section-header-label-checkbox-margin-start: 5px;
+ --details-section-header-go-to-margin-start: -3px;
+ --details-section-content-row-simple-padding-start: 6px;
+ --details-section-content-group-row-simple-value-go-to-margin-start: 5px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .details-section .details-section {
</span><span class="lines">@@ -46,30 +52,43 @@
</span><span class="cx"> position: -webkit-sticky;
</span><span class="cx"> top: -1px;
</span><span class="cx"> height: 23px;
</span><del>-
</del><ins>+ padding: 4px 0;
+ font-size: 11px;
+ font-weight: bold;
+ white-space: nowrap;
+ text-overflow: ellipsis;
+ color: hsl(0, 0%, 22%);
</ins><span class="cx"> background-color: var(--panel-background-color);
</span><del>- color: hsl(0, 0%, 22%);
-
- white-space: nowrap;
</del><span class="cx"> overflow: hidden;
</span><del>- text-overflow: ellipsis;
</del><span class="cx">
</span><del>- font-size: 11px;
- font-weight: bold;
-
- padding: 4px 5px 4px 0;
-
</del><span class="cx"> /* Ensure the headers are displayed above scrollbars. */
</span><span class="cx"> z-index: var(--z-index-header);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .details-section > .header {
+ padding-right: var(--details-section-header-padding-end);
+}
+
+body[dir=rtl] .details-section > .header {
+ padding-left: var(--details-section-header-padding-end);
+}
+
</ins><span class="cx"> .details-section > .header > .options > .navigation-bar {
</span><span class="cx"> margin-top: 1px;
</span><span class="cx"> height: 100%;
</span><del>- float: right;
</del><span class="cx"> border: none;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar),
+body[dir=rtl] .details-section > .header::before {
+ float: right;
+}
+
+body[dir=ltr] .details-section > .header::before,
+body[dir=rtl] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar) {
+ float: left;
+}
+
</ins><span class="cx"> .details-section > .header > .options > .navigation-bar > .item {
</span><span class="cx"> width: 20px;
</span><span class="cx"> height: 100%;
</span><span class="lines">@@ -94,17 +113,17 @@
</span><span class="cx">
</span><span class="cx"> .details-section > .header::before {
</span><span class="cx"> display: block;
</span><del>- float: left;
-
</del><span class="cx"> width: 21px;
</span><span class="cx"> height: 100%;
</span><del>-
</del><ins>+ content: "";
</ins><span class="cx"> background-image: url(../Images/DisclosureTriangles.svg#open-normal);
</span><span class="cx"> background-repeat: no-repeat;
</span><span class="cx"> background-position: center;
</span><span class="cx"> background-size: 13px 13px;
</span><ins>+}
</ins><span class="cx">
</span><del>- content: "";
</del><ins>+body[dir=rtl] .details-section > .header::before {
+ transform: scaleX(-1);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .details-section > .header:not(.mouse-over-options-element):active::before {
</span><span class="lines">@@ -120,10 +139,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .details-section > .header > label {
</span><del>- float: right;
</del><span class="cx"> font-size: 10px;
</span><span class="cx"> color: hsla(0, 0%, 0%, 0.6);
</span><del>- text-align: right;
</del><ins>+ text-align: end;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .details-section.collapsed > .header > label {
</span><span class="lines">@@ -131,21 +149,32 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .details-section > .header > label > input[type="checkbox"] {
</span><del>- margin: 0 0 0 5px;
</del><ins>+ margin: 0;
</ins><span class="cx"> vertical-align: 1px;
</span><span class="cx"> font-size: 10px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.details-section > .header > :matches(.node-link, .go-to-arrow) {
- float: right;
</del><ins>+body[dir=ltr] .details-section > .header > label > input[type="checkbox"] {
+ margin-left: var(--details-section-header-label-checkbox-margin-start);
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=rtl] .details-section > .header > label > input[type="checkbox"] {
+ margin-right: var(--details-section-header-label-checkbox-margin-start);
+}
+
</ins><span class="cx"> .details-section > .header .go-to-arrow {
</span><span class="cx"> width: 10px;
</span><span class="cx"> height: 12px;
</span><del>- margin-left: 3px;
</del><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .details-section > .header .go-to-arrow {
+ margin-left: var(--details-section-header-go-to-margin-start);
+}
+
+body[dir=rtl] .details-section > .header .go-to-arrow {
+ margin-right: var(--details-section-header-go-to-margin-start);
+}
+
</ins><span class="cx"> .details-section > .content {
</span><span class="cx"> display: table;
</span><span class="cx"> width: 100%;
</span><span class="lines">@@ -214,30 +243,46 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .details-section > .content > .group > .row.simple > .label {
</span><ins>+ width: 85px;
</ins><span class="cx"> color: hsl(0, 0%, 20%);
</span><ins>+ text-align: end;
+}
</ins><span class="cx">
</span><del>- text-align: right;
</del><ins>+body[dir=ltr] .details-section > .content > .group > .row.simple > .label {
+ padding-left: var(--details-section-content-group-row-simple-padding-start);
+}
</ins><span class="cx">
</span><del>- padding-left: 6px;
-
- width: 85px;
</del><ins>+body[dir=rtl] .details-section > .content > .group > .row.simple > .label {
+ padding-right: var(--details-section-content-group-row-simple-padding-start);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .details-section > .content > .group > .row.simple > .value {
</span><span class="cx"> word-wrap: break-word;
</span><ins>+ cursor: text;
+ -webkit-user-select: text;
+}
</ins><span class="cx">
</span><del>- padding-right: 6px;
</del><ins>+body[dir=ltr] .details-section > .content > .group > .row.simple > .value {
+ padding-right: var(--details-section-content-group-row-simple-padding-start);
+}
</ins><span class="cx">
</span><del>- -webkit-user-select: text;
- cursor: text;
</del><ins>+body[dir=rtl] .details-section > .content > .group > .row.simple > .value {
+ padding-left: var(--details-section-content-group-row-simple-padding-start);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .details-section > .content > .group > .row.simple > .value .go-to-arrow {
</span><span class="cx"> width: 10px;
</span><span class="cx"> height: 12px;
</span><del>- margin-left: 5px;
</del><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .details-section > .content > .group > .row.simple > .value .go-to-arrow {
+ margin-right: var(--details-section-content-group-row-simple-value-go-to-margin-start);
+}
+
+body[dir=rtl] .details-section > .content > .group > .row.simple > .value .go-to-arrow {
+ margin-left: var(--details-section-content-group-row-simple-value-go-to-margin-start);
+}
+
</ins><span class="cx"> .details-section > .content > .group > .row.simple.data > .value {
</span><span class="cx"> word-break: break-all;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>