<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213000] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213000">213000</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-25 00:29:59 -0800 (Sat, 25 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: copying a search result out of Search Tab navigation sidebar does nothing
https://bugs.webkit.org/show_bug.cgi?id=167074
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2017-02-25
Reviewed by Brian Burg.
* UserInterface/Base/Main.js:
(WebInspector._copy):
* UserInterface/Views/SearchTabContentView.js:
(WebInspector.SearchTabContentView.prototype.handleCopyEvent):
Provide the container TabContentView with the opportunity to intercept the copy event.
* UserInterface/Models/SourceCodeTextRange.js:
(WebInspector.SourceCodeTextRange.prototype.get synthesizedTextValue):
* UserInterface/Views/SearchResultTreeElement.js:
(WebInspector.SearchResultTreeElement.prototype.get synthesizedTextValue):
Generate a string with the format `${url}:${lineNumber}:${resultLine}`.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseMainjs">trunk/Source/WebInspectorUI/UserInterface/Base/Main.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsSourceCodeTextRangejs">trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeTextRange.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsSearchResultTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/SearchResultTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsSearchTabContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/SearchTabContentView.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (212999 => 213000)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 08:08:27 UTC (rev 212999)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 08:29:59 UTC (rev 213000)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2017-02-25 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: copying a search result out of Search Tab navigation sidebar does nothing
+ https://bugs.webkit.org/show_bug.cgi?id=167074
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector._copy):
+ * UserInterface/Views/SearchTabContentView.js:
+ (WebInspector.SearchTabContentView.prototype.handleCopyEvent):
+ Provide the container TabContentView with the opportunity to intercept the copy event.
+
+ * UserInterface/Models/SourceCodeTextRange.js:
+ (WebInspector.SourceCodeTextRange.prototype.get synthesizedTextValue):
+ * UserInterface/Views/SearchResultTreeElement.js:
+ (WebInspector.SearchResultTreeElement.prototype.get synthesizedTextValue):
+ Generate a string with the format `${url}:${lineNumber}:${resultLine}`.
+
+2017-02-25 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: RTL: Styles - Rules sidebar icons are misaligned
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168807
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseMainjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (212999 => 213000)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-02-25 08:08:27 UTC (rev 212999)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-02-25 08:29:59 UTC (rev 213000)
</span><span class="lines">@@ -2108,6 +2108,12 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ let tabContentView = this.tabBrowser.selectedTabContentView;
+ if (tabContentView && typeof tabContentView.handleCopyEvent === "function") {
+ tabContentView.handleCopyEvent(event);
+ return;
+ }
+
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsSourceCodeTextRangejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeTextRange.js (212999 => 213000)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeTextRange.js 2017-02-25 08:08:27 UTC (rev 212999)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeTextRange.js 2017-02-25 08:29:59 UTC (rev 213000)
</span><span class="lines">@@ -105,6 +105,12 @@
</span><span class="cx"> return new WebInspector.TextRange(startLine, startColumn, endLine, endColumn);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ get synthesizedTextValue()
+ {
+ // Must add 1 to the lineNumber since it starts counting at 0.
+ return this._sourceCode.url + ":" + (this._startLocation.lineNumber + 1);
+ }
+
</ins><span class="cx"> // Private
</span><span class="cx">
</span><span class="cx"> _startAndEndLocationsInSameMappedResource()
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsSearchResultTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchResultTreeElement.js (212999 => 213000)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/SearchResultTreeElement.js 2017-02-25 08:08:27 UTC (rev 212999)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchResultTreeElement.js 2017-02-25 08:29:59 UTC (rev 213000)
</span><span class="lines">@@ -80,6 +80,11 @@
</span><span class="cx"> {
</span><span class="cx"> return {text: [this.representedObject.title]};
</span><span class="cx"> }
</span><ins>+
+ get synthesizedTextValue()
+ {
+ return this.representedObject.sourceCodeTextRange.synthesizedTextValue + ":" + this.representedObject.title;
+ }
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> WebInspector.SearchResultTreeElement.CharactersToShowBeforeSearchMatch = 15;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsSearchTabContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchTabContentView.js (212999 => 213000)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/SearchTabContentView.js 2017-02-25 08:08:27 UTC (rev 212999)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchTabContentView.js 2017-02-25 08:29:59 UTC (rev 213000)
</span><span class="lines">@@ -85,6 +85,17 @@
</span><span class="cx"> this.navigationSidebarPanel.performSearch(searchQuery);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ handleCopyEvent(event)
+ {
+ let selectedTreeElement = this.navigationSidebarPanel.contentTreeOutline.selectedTreeElement;
+ if (!selectedTreeElement)
+ return;
+
+ event.clipboardData.setData("text/plain", selectedTreeElement.synthesizedTextValue);
+ event.stopPropagation();
+ event.preventDefault();
+ }
+
</ins><span class="cx"> // Protected
</span><span class="cx">
</span><span class="cx"> initialLayout()
</span></span></pre>
</div>
</div>
</body>
</html>