<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212999] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212999">212999</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-25 00:08:27 -0800 (Sat, 25 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: RTL: Styles - Rules sidebar icons are misaligned
https://bugs.webkit.org/show_bug.cgi?id=168807
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2017-02-25
Reviewed by Brian Burg.
* UserInterface/Views/CSSStyleDeclarationSection.css:
(.style-declaration-section > .header):
(body[dir=ltr] .style-declaration-section > .header):
(body[dir=rtl] .style-declaration-section > .header):
(.style-declaration-section.locked > .header > .locked-icon):
(body[dir=ltr] .style-declaration-section.locked > .header > .locked-icon):
(body[dir=rtl] .style-declaration-section.locked > .header > .locked-icon):
(.style-declaration-section > .header > .icon):
(body[dir=ltr] .style-declaration-section > .header > .icon):
(body[dir=rtl] .style-declaration-section > .header > .icon):
(.style-declaration-section > .header > textarea):
(body[dir=ltr] .style-declaration-section > .header > textarea):
(body[dir=rtl] .style-declaration-section > .header > textarea):
(.style-declaration-section.invalid-selector > .header > .icon):
* UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .new-rule):
(body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .options-container > .new-rule):
(body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .options-container > .new-rule):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):
(body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):
(body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
(body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
(body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
* UserInterface/Views/Variables.css:
(:root):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsCSSStyleDeclarationSectioncss">trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsCSSStyleDetailsSidebarPanelcss">trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVariablescss">trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (212998 => 212999)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 08:05:21 UTC (rev 212998)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 08:08:27 UTC (rev 212999)
</span><span class="lines">@@ -1,5 +1,42 @@
</span><span class="cx"> 2017-02-25 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: RTL: Styles - Rules sidebar icons are misaligned
+ https://bugs.webkit.org/show_bug.cgi?id=168807
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/CSSStyleDeclarationSection.css:
+ (.style-declaration-section > .header):
+ (body[dir=ltr] .style-declaration-section > .header):
+ (body[dir=rtl] .style-declaration-section > .header):
+ (.style-declaration-section.locked > .header > .locked-icon):
+ (body[dir=ltr] .style-declaration-section.locked > .header > .locked-icon):
+ (body[dir=rtl] .style-declaration-section.locked > .header > .locked-icon):
+ (.style-declaration-section > .header > .icon):
+ (body[dir=ltr] .style-declaration-section > .header > .icon):
+ (body[dir=rtl] .style-declaration-section > .header > .icon):
+ (.style-declaration-section > .header > textarea):
+ (body[dir=ltr] .style-declaration-section > .header > textarea):
+ (body[dir=rtl] .style-declaration-section > .header > textarea):
+ (.style-declaration-section.invalid-selector > .header > .icon):
+
+ * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
+ (.sidebar > .panel.details.css-style > .content):
+ (.sidebar > .panel.details.css-style > .content ~ .options-container > .new-rule):
+ (body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .options-container > .new-rule):
+ (body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .options-container > .new-rule):
+ (.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):
+ (body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):
+ (body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):
+ (.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
+ (body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
+ (body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
+
+ * UserInterface/Views/Variables.css:
+ (:root):
+
+2017-02-25 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: RTL: disclosure triangles in details section headers should be flipped and aligned right
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168283
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsCSSStyleDeclarationSectioncss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css (212998 => 212999)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css 2017-02-25 08:05:21 UTC (rev 212998)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css 2017-02-25 08:08:27 UTC (rev 212999)
</span><span class="lines">@@ -55,29 +55,56 @@
</span><span class="cx">
</span><span class="cx"> .style-declaration-section > .header {
</span><span class="cx"> position: relative;
</span><del>- padding: var(--style-declaration-section-header-padding);
</del><span class="cx"> font-size: 11px;
</span><span class="cx"> line-height: 12px;
</span><ins>+
+ --style-declaration-section-header-padding-start: 25px;
+ --style-declaration-section-header-padding-end: 5px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .style-declaration-section > .header {
+ padding: 4px var(--style-declaration-section-header-padding-end) 3px var(--style-declaration-section-header-padding-start);
+}
+
+body[dir=rtl] .style-declaration-section > .header {
+ padding: 4px var(--style-declaration-section-header-padding-start) 3px var(--style-declaration-section-header-padding-end);
+}
+
</ins><span class="cx"> .style-declaration-section.locked > .header > .locked-icon {
</span><del>- float: right;
</del><span class="cx"> width: 8px;
</span><span class="cx"> height: 10px;
</span><del>- margin-left: 5px;
</del><span class="cx"> content: url(../Images/Locked.svg);
</span><ins>+
+ --style-declaration-section-locked-header-locked-icon-margin-start: 5px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .style-declaration-section.locked > .header > .locked-icon {
+ float: right;
+ margin-left: var(--style-declaration-section-locked-header-locked-icon-margin-start);
+}
+
+body[dir=rtl] .style-declaration-section.locked > .header > .locked-icon {
+ float: left;
+ margin-right: var(--style-declaration-section-locked-header-locked-icon-margin-start);
+}
+
</ins><span class="cx"> .style-declaration-section > .header > .icon {
</span><span class="cx"> position: absolute;
</span><del>-
</del><span class="cx"> top: 2px;
</span><del>- left: 4px;
-
</del><span class="cx"> width: 16px;
</span><span class="cx"> height: 16px;
</span><ins>+
+ --style-declaration-section-header-icon-offset-start: 4px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .style-declaration-section > .header > .icon {
+ left: var(--style-declaration-section-header-icon-offset-start);
+}
+
+body[dir=rtl] .style-declaration-section > .header > .icon {
+ right: var(--style-declaration-section-header-icon-offset-start);
+}
+
</ins><span class="cx"> .style-declaration-section > .header > .icon.toggle-able:hover {
</span><span class="cx"> filter: brightness(0.9);
</span><span class="cx"> }
</span><span class="lines">@@ -97,7 +124,6 @@
</span><span class="cx"> right: 0;
</span><span class="cx"> bottom: 0;
</span><span class="cx"> left: 0;
</span><del>- margin: var(--style-declaration-section-header-padding);
</del><span class="cx"> padding: 0;
</span><span class="cx"> font-family: Menlo, monospace;
</span><span class="cx"> color: black;
</span><span class="lines">@@ -107,8 +133,19 @@
</span><span class="cx"> opacity: 0;
</span><span class="cx"> resize: none;
</span><span class="cx"> -webkit-appearance: none;
</span><ins>+
+ --style-declaration-section-header-textarea-margin-start: var(--style-declaration-section-header-padding-start);
+ --style-declaration-section-header-textarea-margin-end: var(--style-declaration-section-header-padding-end);
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .style-declaration-section > .header > textarea {
+ margin: 4px var(--style-declaration-section-header-textarea-margin-end) 3px var(--style-declaration-section-header-textarea-margin-start);
+}
+
+body[dir=rtl] .style-declaration-section > .header > textarea {
+ margin: 4px var(--style-declaration-section-header-textarea-margin-start) 3px var(--style-declaration-section-header-textarea-margin-end);
+}
+
</ins><span class="cx"> .style-declaration-section > .header > textarea:focus {
</span><span class="cx"> opacity: 1;
</span><span class="cx"> }
</span><span class="lines">@@ -149,10 +186,11 @@
</span><span class="cx">
</span><span class="cx"> .style-declaration-section.invalid-selector > .header > .icon {
</span><span class="cx"> top: 4px;
</span><del>- left: 6px;
</del><span class="cx"> width: 12px;
</span><span class="cx"> height: 12px;
</span><span class="cx"> content: url(../Images/Error.svg);
</span><ins>+
+ --style-declaration-section-header-icon-offset-start: 6px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .style-declaration-section.invalid-selector > .header > .selector,
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsCSSStyleDetailsSidebarPanelcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css (212998 => 212999)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css 2017-02-25 08:05:21 UTC (rev 212998)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css 2017-02-25 08:08:27 UTC (rev 212999)
</span><span class="lines">@@ -29,7 +29,6 @@
</span><span class="cx"> left: 0;
</span><span class="cx"> right: 0;
</span><span class="cx"> bottom: 0;
</span><del>-
</del><span class="cx"> overflow-y: auto;
</span><span class="cx"> overflow-x: hidden;
</span><span class="cx"> }
</span><span class="lines">@@ -88,11 +87,20 @@
</span><span class="cx"> width: 15px;
</span><span class="cx"> min-width: 15px;
</span><span class="cx"> height: 15px;
</span><del>- margin-left: 6px;
</del><span class="cx"> content: url(../Images/Plus15.svg);
</span><span class="cx"> opacity: 0.7;
</span><ins>+
+ --panel-details-css-style-content-options-container-new-rule-margin-start: 6px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .options-container > .new-rule {
+ margin-left: var(--panel-details-css-style-content-options-container-new-rule-margin-start);
+}
+
+body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .options-container > .new-rule {
+ margin-right: var(--panel-details-css-style-content-options-container-new-rule-margin-start);
+}
+
</ins><span class="cx"> .sidebar > .panel.details.css-style > .content ~ .options-container > .filter-bar {
</span><span class="cx"> width: -webkit-fill-available;
</span><span class="cx"> background-color: transparent;
</span><span class="lines">@@ -99,7 +107,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle {
</span><del>- margin: 0 5px 1px 0;
</del><ins>+ margin: 0 0 1px;
</ins><span class="cx"> padding: 2px 4px 3px;
</span><span class="cx"> background: none;
</span><span class="cx"> border: none;
</span><span class="lines">@@ -106,8 +114,18 @@
</span><span class="cx"> border-radius: 3px;
</span><span class="cx"> white-space: nowrap;
</span><span class="cx"> -webkit-appearance: none;
</span><ins>+
+ --panel-details-css-style-content-options-container-toggle-class-toggle-margin-end: 5px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle {
+ margin-right: var(--panel-details-css-style-content-options-container-toggle-class-toggle-margin-end);
+}
+
+body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle {
+ margin-left: var(--panel-details-css-style-content-options-container-toggle-class-toggle-margin-end);
+}
+
</ins><span class="cx"> .sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle.selected {
</span><span class="cx"> color: var(--selected-foreground-color);
</span><span class="cx"> background-color: var(--selected-background-color);
</span><span class="lines">@@ -153,9 +171,19 @@
</span><span class="cx"> .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input {
</span><span class="cx"> width: 100px;
</span><span class="cx"> height: 18px;
</span><del>- margin: 0 0 0 2px;
</del><ins>+ margin: 0;
+
+ --panel-details-css-style-content-class-list-container-new-class-class-name-input-margin-start: 2px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input {
+ margin-left: var(--panel-details-css-style-content-class-list-container-new-class-class-name-input-margin-start);
+}
+
+body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input {
+ margin-right: var(--panel-details-css-style-content-class-list-container-new-class-class-name-input-margin-start);
+}
+
</ins><span class="cx"> .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class.active > .add-class-icon,
</span><span class="cx"> .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class:not(.active) > .class-name-input {
</span><span class="cx"> display: none;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVariablescss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css (212998 => 212999)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2017-02-25 08:05:21 UTC (rev 212998)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2017-02-25 08:08:27 UTC (rev 212999)
</span><span class="lines">@@ -84,8 +84,6 @@
</span><span class="cx"> --toolbar-height: 36px;
</span><span class="cx"> --tab-bar-height: 24px;
</span><span class="cx"> --navigation-bar-height: 29px;
</span><del>-
- --style-declaration-section-header-padding: 4px 5px 3px 25px;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> body.window-inactive {
</span></span></pre>
</div>
</div>
</body>
</html>