<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[213002] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/213002">213002</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-25 00:44:43 -0800 (Sat, 25 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: RTL: add support for Bezier/Spring editor
https://bugs.webkit.org/show_bug.cgi?id=168854
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2017-02-25
Reviewed by Brian Burg.
* UserInterface/Views/BezierEditor.css:
(.bezier-editor):
(body[dir=ltr] .bezier-editor):
(body[dir=rtl] .bezier-editor):
(.bezier-editor > .bezier-preview-timing):
(body[dir=ltr] .bezier-editor > .bezier-preview-timing):
(body[dir=rtl] .bezier-editor > .bezier-preview-timing):
(@keyframes bezierPreview):
(body[dir=rtl] .bezier-editor > .bezier-container):
(.bezier-editor > .number-input-container > input):
(body[dir=ltr] .bezier-editor > .number-input-container > input):
(body[dir=rtl] .bezier-editor > .number-input-container > input):
* UserInterface/Views/SpringEditor.css:
(.spring-editor > .spring-timing):
(.spring-editor > .spring-timing::before):
(.spring-editor > .spring-timing::after):
(body[dir=ltr] .spring-editor > .spring-timing::before, body[dir=rtl] .spring-editor > .spring-timing::after):
(body[dir=ltr] .spring-editor > .spring-timing::after, body[dir=rtl] .spring-editor > .spring-timing::before):
(.spring-editor > .number-input-container > .number-input-row > input):
* UserInterface/Views/SpringEditor.js:
(WebInspector.SpringEditor.prototype._updatePreviewAnimation):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsBezierEditorcss">trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsSpringEditorcss">trunk/Source/WebInspectorUI/UserInterface/Views/SpringEditor.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsSpringEditorjs">trunk/Source/WebInspectorUI/UserInterface/Views/SpringEditor.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (213001 => 213002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 08:43:29 UTC (rev 213001)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 08:44:43 UTC (rev 213002)
</span><span class="lines">@@ -1,5 +1,36 @@
</span><span class="cx"> 2017-02-25 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: RTL: add support for Bezier/Spring editor
+ https://bugs.webkit.org/show_bug.cgi?id=168854
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/BezierEditor.css:
+ (.bezier-editor):
+ (body[dir=ltr] .bezier-editor):
+ (body[dir=rtl] .bezier-editor):
+ (.bezier-editor > .bezier-preview-timing):
+ (body[dir=ltr] .bezier-editor > .bezier-preview-timing):
+ (body[dir=rtl] .bezier-editor > .bezier-preview-timing):
+ (@keyframes bezierPreview):
+ (body[dir=rtl] .bezier-editor > .bezier-container):
+ (.bezier-editor > .number-input-container > input):
+ (body[dir=ltr] .bezier-editor > .number-input-container > input):
+ (body[dir=rtl] .bezier-editor > .number-input-container > input):
+
+ * UserInterface/Views/SpringEditor.css:
+ (.spring-editor > .spring-timing):
+ (.spring-editor > .spring-timing::before):
+ (.spring-editor > .spring-timing::after):
+ (body[dir=ltr] .spring-editor > .spring-timing::before, body[dir=rtl] .spring-editor > .spring-timing::after):
+ (body[dir=ltr] .spring-editor > .spring-timing::after, body[dir=rtl] .spring-editor > .spring-timing::before):
+ (.spring-editor > .number-input-container > .number-input-row > input):
+
+ * UserInterface/Views/SpringEditor.js:
+ (WebInspector.SpringEditor.prototype._updatePreviewAnimation):
+
+2017-02-25 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: RTL: Elements tab Styles sidebar label/arrows need adjustment
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168746
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsBezierEditorcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css (213001 => 213002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css 2017-02-25 08:43:29 UTC (rev 213001)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css 2017-02-25 08:44:43 UTC (rev 213002)
</span><span class="lines">@@ -26,8 +26,19 @@
</span><span class="cx"> .bezier-editor {
</span><span class="cx"> width: 200px;
</span><span class="cx"> height: 258px;
</span><ins>+
+ --bezier-editor-preview-translateX: 170px;
+ --bezier-editor-preview-timing-margin-start: 11px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .bezier-editor {
+ --bezier-editor-preview-translateX-animate: var(--bezier-editor-preview-translateX);
+}
+
+body[dir=rtl] .bezier-editor {
+ --bezier-editor-preview-translateX-animate: calc(-1 * var(--bezier-editor-preview-translateX));
+}
+
</ins><span class="cx"> .bezier-editor > .bezier-preview {
</span><span class="cx"> width: calc(100% - 10px);
</span><span class="cx"> height: 25px;
</span><span class="lines">@@ -45,12 +56,19 @@
</span><span class="cx"> .bezier-editor > .bezier-preview-timing {
</span><span class="cx"> position: absolute;
</span><span class="cx"> top: 34px;
</span><del>- margin-left: 11px;
</del><span class="cx"> border-left: 4px solid transparent;
</span><span class="cx"> border-right: 4px solid transparent;
</span><span class="cx"> border-top: 4px solid black;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .bezier-editor > .bezier-preview-timing {
+ margin-left: var(--bezier-editor-preview-timing-margin-start);
+}
+
+body[dir=rtl] .bezier-editor > .bezier-preview-timing {
+ margin-right: var(--bezier-editor-preview-timing-margin-start);
+}
+
</ins><span class="cx"> .bezier-editor > .bezier-preview.animate > div,
</span><span class="cx"> .bezier-editor > .bezier-preview-timing.animate {
</span><span class="cx"> animation: bezierPreview 2.5s linear 250ms infinite;
</span><span class="lines">@@ -57,10 +75,10 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> @keyframes bezierPreview {
</span><del>- from { transform: translate(0, 0); }
- 10% { transform: translate(0, 0); }
- 90% { transform: translate(170px, 0); }
- to { transform: translate(170px, 0); }
</del><ins>+ from { transform: translateX(0); }
+ 10% { transform: translateX(0); }
+ 90% { transform: translateX(var(--bezier-editor-preview-translateX-animate)); }
+ to { transform: translateX(var(--bezier-editor-preview-translateX-animate)); }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .bezier-editor > .bezier-container {
</span><span class="lines">@@ -67,6 +85,10 @@
</span><span class="cx"> margin: 0 8px;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=rtl] .bezier-editor > .bezier-container {
+ transform: scaleX(-1);
+}
+
</ins><span class="cx"> .bezier-editor > .bezier-container .linear-curve {
</span><span class="cx"> fill: none;
</span><span class="cx"> stroke:lightgrey;
</span><span class="lines">@@ -108,7 +130,7 @@
</span><span class="cx"> .bezier-editor > .number-input-container > input {
</span><span class="cx"> width: 100%;
</span><span class="cx"> margin: 0 2px;
</span><del>- padding: 1px 0 1px 1px;
</del><ins>+ padding: 1px 0 1px;
</ins><span class="cx"> text-align: right;
</span><span class="cx"> font-size: 12px;
</span><span class="cx"> background-color: white;
</span><span class="lines">@@ -116,4 +138,14 @@
</span><span class="cx"> border-radius: 4px;
</span><span class="cx"> box-shadow: inset 0 0 1px 1px hsl(0, 0%, 89%);
</span><span class="cx"> outline: none;
</span><ins>+
+ --bezier-editor-number-input-padding-start: 1px;
</ins><span class="cx"> }
</span><ins>+
+body[dir=ltr] .bezier-editor > .number-input-container > input {
+ padding-left: var(--bezier-editor-number-input-padding-start);
+}
+
+body[dir=rtl] .bezier-editor > .number-input-container > input {
+ padding-right: var(--bezier-editor-number-input-padding-start);
+}
</ins></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsSpringEditorcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpringEditor.css (213001 => 213002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/SpringEditor.css 2017-02-25 08:43:29 UTC (rev 213001)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpringEditor.css 2017-02-25 08:44:43 UTC (rev 213002)
</span><span class="lines">@@ -48,6 +48,9 @@
</span><span class="cx"> position: relative;
</span><span class="cx"> margin: -0.5px calc(2 * var(--spring-editor-horizontal-margin)) 10px;
</span><span class="cx"> padding: 0 1px;
</span><ins>+
+ --spring-editor-timing-pseudo-offset-start: 0;
+ --spring-editor-timing-pseudo-offset-end: 0;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .spring-editor > .spring-timing > div {
</span><span class="lines">@@ -65,15 +68,23 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .spring-editor > .spring-timing::before {
</span><del>- left: 0;
</del><span class="cx"> content: "0s";
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .spring-editor > .spring-timing::after {
</span><del>- right: 0;
</del><span class="cx"> content: attr(data-duration) "s";
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .spring-editor > .spring-timing::before,
+body[dir=rtl] .spring-editor > .spring-timing::after {
+ left: var(--spring-editor-timing-pseudo-offset-start);
+}
+
+body[dir=ltr] .spring-editor > .spring-timing::after,
+body[dir=rtl] .spring-editor > .spring-timing::before {
+ right: var(--spring-editor-timing-pseudo-offset-end);
+}
+
</ins><span class="cx"> .spring-editor > :matches(.spring-preview, .spring-timing) > div {
</span><span class="cx"> transition-property: none;
</span><span class="cx"> }
</span><span class="lines">@@ -95,8 +106,8 @@
</span><span class="cx">
</span><span class="cx"> .spring-editor > .number-input-container > .number-input-row > input {
</span><span class="cx"> width: calc(25% - 2 * var(--spring-editor-horizontal-margin));
</span><del>- text-align: right;
</del><span class="cx"> margin: 0 var(--spring-editor-horizontal-margin);
</span><ins>+ text-align: end;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .spring-editor > .number-input-container > .number-input-row > input::-webkit-inner-spin-button {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsSpringEditorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpringEditor.js (213001 => 213002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/SpringEditor.js 2017-02-25 08:43:29 UTC (rev 213001)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpringEditor.js 2017-02-25 08:44:43 UTC (rev 213002)
</span><span class="lines">@@ -219,12 +219,18 @@
</span><span class="cx"> _updatePreviewAnimation(event)
</span><span class="cx"> {
</span><span class="cx"> this._previewContainer.classList.add("animate");
</span><del>- this._previewElement.style.transform = "translateX(85px)";
</del><span class="cx"> this._previewElement.style.transitionTimingFunction = this._spring.toString();
</span><span class="cx">
</span><span class="cx"> this._timingContainer.classList.add("animate");
</span><del>- this._timingElement.style.transform = "translateX(170px)";
</del><span class="cx">
</span><ins>+ if (WebInspector.resolvedLayoutDirection() === WebInspector.LayoutDirection.RTL) {
+ this._previewElement.style.transform = "translateX(-85px)";
+ this._timingElement.style.transform = "translateX(-170px)";
+ } else {
+ this._previewElement.style.transform = "translateX(85px)";
+ this._timingElement.style.transform = "translateX(170px)";
+ }
+
</ins><span class="cx"> // Only calculate the duration when a spring parameter is changed.
</span><span class="cx"> if (!event) {
</span><span class="cx"> let duration = this._spring.calculateDuration();
</span></span></pre>
</div>
</div>
</body>
</html>