<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212996] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212996">212996</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-24 23:53:35 -0800 (Fri, 24 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: RTL: add support for Error page
https://bugs.webkit.org/show_bug.cgi?id=168855
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2017-02-24
Reviewed by Brian Burg.
* UserInterface/Debug/UncaughtExceptionReporter.css:
(.uncaught-exception-sheet):
(body[dir=ltr] .uncaught-exception-sheet):
(body[dir=rtl] .uncaught-exception-sheet):
(.uncaught-exception-sheet h1 > img):
(body[dir=ltr] .uncaught-exception-sheet h1 > img):
(body[dir=rtl] .uncaught-exception-sheet h1 > img):
(.uncaught-exception-sheet h2 > img):
(body[dir=ltr] .uncaught-exception-sheet h2 > img):
(body[dir=rtl] .uncaught-exception-sheet h2 > img):
(.uncaught-exception-sheet dd):
(body[dir=ltr] .uncaught-exception-sheet dd):
(body[dir=rtl] .uncaught-exception-sheet dd):
(.uncaught-exception-sheet ul):
(body[dir=ltr] .uncaught-exception-sheet ul):
(body[dir=rtl] .uncaught-exception-sheet ul):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceDebugUncaughtExceptionReportercss">trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (212995 => 212996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 07:50:32 UTC (rev 212995)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 07:53:35 UTC (rev 212996)
</span><span class="lines">@@ -1,5 +1,29 @@
</span><span class="cx"> 2017-02-24 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: RTL: add support for Error page
+ https://bugs.webkit.org/show_bug.cgi?id=168855
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Debug/UncaughtExceptionReporter.css:
+ (.uncaught-exception-sheet):
+ (body[dir=ltr] .uncaught-exception-sheet):
+ (body[dir=rtl] .uncaught-exception-sheet):
+ (.uncaught-exception-sheet h1 > img):
+ (body[dir=ltr] .uncaught-exception-sheet h1 > img):
+ (body[dir=rtl] .uncaught-exception-sheet h1 > img):
+ (.uncaught-exception-sheet h2 > img):
+ (body[dir=ltr] .uncaught-exception-sheet h2 > img):
+ (body[dir=rtl] .uncaught-exception-sheet h2 > img):
+ (.uncaught-exception-sheet dd):
+ (body[dir=ltr] .uncaught-exception-sheet dd):
+ (body[dir=rtl] .uncaught-exception-sheet dd):
+ (.uncaught-exception-sheet ul):
+ (body[dir=ltr] .uncaught-exception-sheet ul):
+ (body[dir=rtl] .uncaught-exception-sheet ul):
+
+2017-02-24 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: Uncaught Exception: Unknown angle units "undefined"
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168851
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceDebugUncaughtExceptionReportercss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.css (212995 => 212996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.css 2017-02-25 07:50:32 UTC (rev 212995)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.css 2017-02-25 07:53:35 UTC (rev 212996)
</span><span class="lines">@@ -35,13 +35,26 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .uncaught-exception-sheet {
</span><del>- padding: 50px 55px 50px 65px;
</del><ins>+ min-width: 400px;
+ padding: 50px 0;
</ins><span class="cx"> font-family: '-webkit-system-font';
</span><span class="cx"> font-size: 11pt;
</span><del>- min-width: 400px;
</del><span class="cx"> color: hsl(0, 0%, 40%);
</span><ins>+
+ --uncaught-exception-sheet-margin-start: 65px;
+ --uncaught-exception-sheet-margin-end: 55px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .uncaught-exception-sheet {
+ margin-left: var(--uncaught-exception-sheet-margin-start);
+ margin-right: var(--uncaught-exception-sheet-margin-end);
+}
+
+body[dir=rtl] .uncaught-exception-sheet {
+ margin-left: var(--uncaught-exception-sheet-margin-end);
+ margin-right: var(--uncaught-exception-sheet-margin-start);
+}
+
</ins><span class="cx"> .uncaught-exception-sheet a {
</span><span class="cx"> text-decoration: underline;
</span><span class="cx"> color: hsl(240, 55%, 30%);
</span><span class="lines">@@ -68,21 +81,41 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .uncaught-exception-sheet h1 > img {
</span><ins>+ position: relative;
</ins><span class="cx"> height: 35px;
</span><del>- position: relative;
- margin-left: -50px;
</del><span class="cx"> margin-top: -5px;
</span><ins>+
+ --uncaught-exception-sheet-h1-img-margin-start: -50px;
+}
+
+body[dir=ltr] .uncaught-exception-sheet h1 > img {
</ins><span class="cx"> float: left;
</span><ins>+ margin-left: var(--uncaught-exception-sheet-h1-img-margin-start);
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=rtl] .uncaught-exception-sheet h1 > img {
+ float: right;
+ margin-right: var(--uncaught-exception-sheet-h1-img-margin-start);
+}
+
</ins><span class="cx"> .uncaught-exception-sheet h2 > img {
</span><ins>+ position: relative;
</ins><span class="cx"> height: 25px;
</span><del>- position: relative;
- margin-left: -45px;
- margin-top: 0px;
</del><ins>+ margin-top: 0;
+
+ --uncaught-exception-sheet-h2-img-margin-start: -45px;
+}
+
+body[dir=ltr] .uncaught-exception-sheet h2 > img {
</ins><span class="cx"> float: left;
</span><ins>+ margin-left: var(--uncaught-exception-sheet-h2-img-margin-start);
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=rtl] .uncaught-exception-sheet h2 > img {
+ float: right;
+ margin-right: var(--uncaught-exception-sheet-h2-img-margin-start);
+}
+
</ins><span class="cx"> .uncaught-exception-sheet dl {
</span><span class="cx"> max-width: 600px;
</span><span class="cx"> }
</span><span class="lines">@@ -93,19 +126,39 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .uncaught-exception-sheet dd {
</span><del>- margin: 10px 0 20px 10px;
</del><ins>+ margin: 10px 0 20px;
</ins><span class="cx"> font-size: 13px;
</span><span class="cx"> line-height: 18px;
</span><ins>+
+ --uncaught-exception-sheet-dd-margin-start: 10px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .uncaught-exception-sheet dd {
+ margin-left: var(--uncaught-exception-sheet-dd-margin-start);
+}
+
+body[dir=rtl] .uncaught-exception-sheet dd {
+ margin-right: var(--uncaught-exception-sheet-dd-margin-start);
+}
+
</ins><span class="cx"> .uncaught-exception-sheet ul {
</span><ins>+ margin: 0;
+ padding: 0;
</ins><span class="cx"> font-family: Menlo, monospace;
</span><span class="cx"> font-size: 12px;
</span><span class="cx"> line-height: 18px;
</span><del>- margin: 0 0 0 2px;
- padding: 0;
</del><ins>+
+ --uncaught-exception-sheet-ul-margin-start: 2px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .uncaught-exception-sheet ul {
+ margin-left: var(--uncaught-exception-sheet-ul-margin-start);
+}
+
+body[dir=rtl] .uncaught-exception-sheet ul {
+ margin-right: var(--uncaught-exception-sheet-ul-margin-start);
+}
+
</ins><span class="cx"> .uncaught-exception-sheet li {
</span><span class="cx"> margin-bottom: 20px;
</span><span class="cx"> word-break: break-word;
</span></span></pre>
</div>
</div>
</body>
</html>