<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212910] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212910">212910</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-23 11:55:10 -0800 (Thu, 23 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: RTL: navigation sidebar section disclosure triangles and tree element icons should be aligned right
https://bugs.webkit.org/show_bug.cgi?id=168284
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2017-02-23
Reviewed by Brian Burg.
* UserInterface/Views/TreeOutline.css:
(.tree-outline,):
(.tree-outline.large .item):
(body[dir=ltr] .tree-outline .item :matches(.disclosure-button, .icon)):
(body[dir=rtl] .tree-outline .item :matches(.disclosure-button, .icon)):
(body[dir=ltr] .tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon):
(body[dir=rtl] .tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon):
(.tree-outline .item .disclosure-button):
(body[dir=rtl] .tree-outline .item .disclosure-button):
(.tree-outline .item .icon):
(body[dir=ltr] .tree-outline .item .icon):
(body[dir=rtl] .tree-outline .item .icon):
(.tree-outline.large .item .icon):
(.tree-outline .item .status):
(body[dir=ltr] .tree-outline .item .status):
(body[dir=rtl] .tree-outline .item .status):
(.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon): Deleted.
* UserInterface/Views/TreeOutline.js:
(WebInspector.TreeOutline._generateStyleRulesIfNeeded):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlinecss">trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlinejs">trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (212909 => 212910)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2017-02-23 19:47:32 UTC (rev 212909)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-02-23 19:55:10 UTC (rev 212910)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2017-02-23 Devin Rousso <dcrousso+webkit@gmail.com>
+
+ Web Inspector: RTL: navigation sidebar section disclosure triangles and tree element icons should be aligned right
+ https://bugs.webkit.org/show_bug.cgi?id=168284
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/TreeOutline.css:
+ (.tree-outline,):
+ (.tree-outline.large .item):
+ (body[dir=ltr] .tree-outline .item :matches(.disclosure-button, .icon)):
+ (body[dir=rtl] .tree-outline .item :matches(.disclosure-button, .icon)):
+ (body[dir=ltr] .tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon):
+ (body[dir=rtl] .tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon):
+ (.tree-outline .item .disclosure-button):
+ (body[dir=rtl] .tree-outline .item .disclosure-button):
+ (.tree-outline .item .icon):
+ (body[dir=ltr] .tree-outline .item .icon):
+ (body[dir=rtl] .tree-outline .item .icon):
+ (.tree-outline.large .item .icon):
+ (.tree-outline .item .status):
+ (body[dir=ltr] .tree-outline .item .status):
+ (body[dir=rtl] .tree-outline .item .status):
+ (.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon): Deleted.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WebInspector.TreeOutline._generateStyleRulesIfNeeded):
+
</ins><span class="cx"> 2017-02-22 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: RTL: Sidebar borders are on the wrong side
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlinecss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.css (212909 => 212910)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.css 2017-02-23 19:47:32 UTC (rev 212909)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.css 2017-02-23 19:55:10 UTC (rev 212910)
</span><span class="lines">@@ -25,12 +25,15 @@
</span><span class="cx">
</span><span class="cx"> .tree-outline,
</span><span class="cx"> .tree-outline .children {
</span><ins>+ margin: 0;
</ins><span class="cx"> padding: 0;
</span><del>- margin: 0;
-
</del><ins>+ list-style: none;
</ins><span class="cx"> outline: none;
</span><span class="cx">
</span><del>- list-style: none;
</del><ins>+ --tree-outline-icon-margin-start: 16px;
+ --tree-outline-icon-margin-end: 3px;
+
+ --tree-outline-status-margin-start: 4px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .tree-outline .children {
</span><span class="lines">@@ -58,8 +61,18 @@
</span><span class="cx"> .tree-outline.large .item {
</span><span class="cx"> height: 36px;
</span><span class="cx"> line-height: 34px;
</span><ins>+
+ --tree-outline-icon-margin-end: 6px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .tree-outline .item :matches(.disclosure-button, .icon) {
+ float: left;
+}
+
+body[dir=rtl] .tree-outline .item :matches(.disclosure-button, .icon) {
+ float: right;
+}
+
</ins><span class="cx"> .tree-outline.hide-disclosure-buttons > .children {
</span><span class="cx"> display: none;
</span><span class="cx"> }
</span><span class="lines">@@ -68,29 +81,31 @@
</span><span class="cx"> display: none;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon {
- margin-left: 16px;
</del><ins>+body[dir=ltr] .tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon {
+ margin-left: var(--tree-outline-icon-margin-start);
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=rtl] .tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon {
+ margin-right: var(--tree-outline-icon-margin-start);
+}
+
</ins><span class="cx"> .tree-outline .item .disclosure-button {
</span><span class="cx"> display: none;
</span><del>-
- float: left;
-
</del><span class="cx"> width: 16px;
</span><span class="cx"> height: 16px;
</span><del>-
- border: 0;
-
</del><span class="cx"> background-color: transparent;
</span><span class="cx"> background-image: url(../Images/DisclosureTriangles.svg#closed-normal);
</span><span class="cx"> background-repeat: no-repeat;
</span><span class="cx"> background-position: center;
</span><span class="cx"> background-size: 13px 13px;
</span><del>-
</del><ins>+ border: none;
</ins><span class="cx"> -webkit-appearance: none;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=rtl] .tree-outline .item .disclosure-button {
+ transform: scaleX(-1);
+}
+
</ins><span class="cx"> .tree-outline.hide-disclosure-buttons .item .disclosure-button {
</span><span class="cx"> display: none;
</span><span class="cx"> }
</span><span class="lines">@@ -112,37 +127,45 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .tree-outline .item .icon {
</span><del>- float: left;
</del><span class="cx"> position: relative;
</span><del>-
</del><span class="cx"> width: 16px;
</span><span class="cx"> height: 16px;
</span><del>-
</del><span class="cx"> margin-top: 1px;
</span><del>- margin-right: 3px;
</del><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .tree-outline .item .icon {
+ margin-right: var(--tree-outline-icon-margin-end);
+}
+
+body[dir=rtl] .tree-outline .item .icon {
+ margin-left: var(--tree-outline-icon-margin-end);
+}
+
</ins><span class="cx"> .tree-outline.compact .item .icon {
</span><span class="cx"> margin-top: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .tree-outline.large .item .icon {
</span><del>- margin-top: 5px;
- margin-right: 6px;
-
</del><span class="cx"> width: 24px;
</span><span class="cx"> height: 24px;
</span><ins>+ margin-top: 5px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .tree-outline .item .status {
</span><del>- float: right;
-
- margin-left: 4px;
</del><span class="cx"> margin-top: 1px;
</span><del>-
</del><span class="cx"> line-height: 1em;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+body[dir=ltr] .tree-outline .item .status {
+ float: right;
+ margin-left: var(--tree-outline-status-margin-start);
+}
+
+body[dir=rtl] .tree-outline .item .status {
+ float: left;
+ margin-right: var(--tree-outline-status-margin-start);
+}
+
</ins><span class="cx"> .tree-outline.large .item .status {
</span><span class="cx"> margin-top: 9px;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlinejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (212909 => 212910)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2017-02-23 19:47:32 UTC (rev 212909)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2017-02-23 19:55:10 UTC (rev 212910)
</span><span class="lines">@@ -651,7 +651,13 @@
</span><span class="cx"> // Keep all the elements at the same depth once the maximum is reached.
</span><span class="cx"> childrenSubstring += i === maximumTreeDepth ? " .children" : " > .children";
</span><span class="cx"> styleText += `.${WebInspector.TreeOutline.ElementStyleClassName}:not(.${WebInspector.TreeOutline.CustomIndentStyleClassName})${childrenSubstring} > .item { `;
</span><del>- styleText += "padding-left: " + (baseLeftPadding + (depthPadding * i)) + "px; }\n";
</del><ins>+
+ if (WebInspector.resolvedLayoutDirection() === WebInspector.LayoutDirection.RTL)
+ styleText += "padding-right: ";
+ else
+ styleText += "padding-left: ";
+
+ styleText += (baseLeftPadding + (depthPadding * i)) + "px; }\n";
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> WebInspector.TreeOutline._styleElement.textContent = styleText;
</span></span></pre>
</div>
</div>
</body>
</html>