<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212729] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212729">212729</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2017-02-21 11:11:27 -0800 (Tue, 21 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Improve bot watcher's dashboard performance
https://bugs.webkit.org/show_bug.cgi?id=168624
<rdar://problem/30190109>
Reviewed by Daniel Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
There was an unnecessary linear complexity algorithm in indexOfRevision().</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsTracjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsTracjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js (212728 => 212729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js 2017-02-21 19:07:17 UTC (rev 212728)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js 2017-02-21 19:11:27 UTC (rev 212729)
</span><span class="lines">@@ -37,6 +37,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> this.recordedCommits = []; // Will be sorted in ascending order.
</span><ins>+ this.recordedCommitIndicesByRevisionNumber = {};
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> BaseObject.addConstructorFunctions(Trac);
</span><span class="lines">@@ -223,11 +224,6 @@
</span><span class="cx"> if (!dataDocument)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- var recordedRevisionNumbers = this.recordedCommits.reduce(function(previousResult, commit) {
- previousResult[commit.revisionNumber] = commit;
- return previousResult;
- }, {});
-
</del><span class="cx"> var knownCommitsWereUpdated = false;
</span><span class="cx"> var newCommits = [];
</span><span class="cx">
</span><span class="lines">@@ -235,11 +231,12 @@
</span><span class="cx"> var commitInfoElement;
</span><span class="cx"> while (commitInfoElement = commitInfoElements.iterateNext()) {
</span><span class="cx"> var commit = this._convertCommitInfoElementToObject(dataDocument, commitInfoElement);
</span><del>- if (commit.revisionNumber in recordedRevisionNumbers) {
</del><ins>+ var knownCommitIndex = this.recordedCommitIndicesByRevisionNumber[commit.revisionNumber];
+ if (knownCommitIndex >= 0) {
</ins><span class="cx"> // Author could have changed, as commit queue replaces it after the fact.
</span><del>- console.assert(recordedRevisionNumbers[commit.revisionNumber].revisionNumber === commit.revisionNumber);
- if (recordedRevisionNumbers[commit.revisionNumber].author != commit.author) {
- recordedRevisionNumbers[commit.revisionNumber].author = commit.author;
</del><ins>+ console.assert(this.recordedCommits[knownCommitIndex].revisionNumber === commit.revisionNumber);
+ if (this.recordedCommits[knownCommitIndex].author != commit.author) {
+ this.recordedCommits[knownCommitIndex].author = commit.author;
</ins><span class="cx"> knownCommitWasUpdated = true;
</span><span class="cx"> }
</span><span class="cx"> } else
</span><span class="lines">@@ -246,8 +243,13 @@
</span><span class="cx"> newCommits.push(commit);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (newCommits.length)
</del><ins>+ if (newCommits.length) {
</ins><span class="cx"> this.recordedCommits = newCommits.concat(this.recordedCommits).sort(function(a, b) { return a.date - b.date; });
</span><ins>+ this.recordedCommitIndicesByRevisionNumber = {};
+ this.recordedCommits.forEach(function(curentValue, index) {
+ this.recordedCommitIndicesByRevisionNumber[curentValue.revisionNumber] = index;
+ }, this);
+ }
</ins><span class="cx">
</span><span class="cx"> if (newCommits.length || knownCommitsWereUpdated)
</span><span class="cx"> this.dispatchEventToListeners(Trac.Event.CommitsUpdated, null);
</span><span class="lines">@@ -318,13 +320,12 @@
</span><span class="cx"> return Trac.NO_MORE_REVISIONS;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- indexOfRevision: function(revision)
</del><ins>+ indexOfRevision: function(revisionNumber)
</ins><span class="cx"> {
</span><del>- var commits = this.recordedCommits;
- for (var i = 0; i < commits.length; ++i) {
- if (commits[i].revisionNumber === revision)
- return i;
- }
- return -1;
</del><ins>+ var result = this.recordedCommitIndicesByRevisionNumber[revisionNumber];
+ // FIXME: Update callers to handle undefined result.
+ if (result === undefined)
+ return -1;
+ return result;
</ins><span class="cx"> },
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (212728 => 212729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-02-21 19:07:17 UTC (rev 212728)
+++ trunk/Tools/ChangeLog 2017-02-21 19:11:27 UTC (rev 212729)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-02-21 Alexey Proskuryakov <ap@apple.com>
+
+ Improve bot watcher's dashboard performance
+ https://bugs.webkit.org/show_bug.cgi?id=168624
+ <rdar://problem/30190109>
+
+ Reviewed by Daniel Bates.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
+ There was an unnecessary linear complexity algorithm in indexOfRevision().
+
</ins><span class="cx"> 2017-02-21 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r212699.
</span></span></pre>
</div>
</div>
</body>
</html>