<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212724] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212724">212724</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-21 10:24:51 -0800 (Tue, 21 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Reduce platform ifdefs in WebKit2 custom protocols implementation
https://bugs.webkit.org/show_bug.cgi?id=165028
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-02-21
Reviewed by Darin Adler.
Make mac implementation use the APICustomProtocolManagerClient to share more code with the soup based ports.
* CMakeLists.txt: Add CustomProtocolManagerProxy.cpp.
* PlatformEfl.cmake: Remove CustomProtocolManagerProxySoup.cpp.
* PlatformGTK.cmake: Ditto.
* PlatformMac.cmake: Remove CustomProtocolManagerProxyMac.mm.
* UIProcess/API/APICustomProtocolManagerClient.h:
(API::CustomProtocolManagerClient::startLoading): Make it void, since we were always returning true and the
returned value was ignored.
* UIProcess/API/efl/ewk_url_scheme_request.cpp:
(EwkUrlSchemeRequest::finish): Update to new CustomProtocolManagerProxy API.
* UIProcess/API/gtk/WebKitCustomProtocolManagerClient.cpp:
* UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
(webkitURISchemeRequestReadCallback): Ditto.
* UIProcess/Cocoa/CustomProtocolManagerClient.h: Added.
* UIProcess/Cocoa/CustomProtocolManagerClient.mm: Added.
(-[WKCustomProtocolLoader initWithCustomProtocolManagerProxy:customProtocolID:request:]):
(-[WKCustomProtocolLoader dealloc]):
(-[WKCustomProtocolLoader connection:didFailWithError:]):
(-[WKCustomProtocolLoader connection:didReceiveResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveData:]):
(-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]):
(-[WKCustomProtocolLoader connectionDidFinishLoading:]):
(WebKit::CustomProtocolManagerClient::startLoading):
(WebKit::CustomProtocolManagerClient::stopLoading):
(WebKit::CustomProtocolManagerClient::invalidate):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize): Set the CustomProtocolManagerClient.
(WebKit::WebProcessPool::platformInitializeNetworkProcess): Remove code that is now shared.
* UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.cpp: Added.
(WebKit::CustomProtocolManagerProxy::startLoading):
(WebKit::CustomProtocolManagerProxy::processDidClose):
(WebKit::CustomProtocolManagerProxy::wasRedirectedToRequest):
(WebKit::CustomProtocolManagerProxy::didReceiveResponse):
* UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::globalURLSchemesWithCustomProtocolHandlers): Just moved here to use it from ensureNetworkProcess().
(WebKit::WebProcessPool::WebProcessPool): Remove soup ifdefs.
(WebKit::WebProcessPool::setCustomProtocolManagerClient): Moved from the soup implementation.
(WebKit::WebProcessPool::ensureNetworkProcess): Initialize custom protocols parameters.
(WebKit::WebProcessPool::registerSchemeForCustomProtocol): Register the protocol if not already registered globally.
(WebKit::WebProcessPool::unregisterSchemeForCustomProtocol): Remove soup ifdefs.
* UIProcess/WebProcessPool.h: Remove soup ifdefs.
* UIProcess/efl/RequestManagerClientEfl.cpp:
* UIProcess/soup/WebProcessPoolSoup.cpp:
(WebKit::WebProcessPool::platformInitializeNetworkProcess): Remove code that is now shared.
* WebKit2.xcodeproj/project.pbxproj:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2CMakeListstxt">trunk/Source/WebKit2/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2PlatformGTKcmake">trunk/Source/WebKit2/PlatformGTK.cmake</a></li>
<li><a href="#trunkSourceWebKit2PlatformMaccmake">trunk/Source/WebKit2/PlatformMac.cmake</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIAPICustomProtocolManagerClienth">trunk/Source/WebKit2/UIProcess/API/APICustomProtocolManagerClient.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIgtkWebKitCustomProtocolManagerClientcpp">trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCustomProtocolManagerClient.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIgtkWebKitURISchemeRequestcpp">trunk/Source/WebKit2/UIProcess/API/gtk/WebKitURISchemeRequest.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessCocoaWebProcessPoolCocoamm">trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessNetworkCustomProtocolsCustomProtocolManagerProxyh">trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessPoolcpp">trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebProcessPoolh">trunk/Source/WebKit2/UIProcess/WebProcessPool.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcesssoupWebProcessPoolSoupcpp">trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebKit2xcodeprojprojectpbxproj">trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2UIProcessCocoaCustomProtocolManagerClienth">trunk/Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessCocoaCustomProtocolManagerClientmm">trunk/Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessNetworkCustomProtocolsCustomProtocolManagerProxycpp">trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.cpp</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li>trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/mac/</li>
<li>trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/soup/</li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2CMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/CMakeLists.txt (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/CMakeLists.txt 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/CMakeLists.txt 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -420,6 +420,8 @@
</span><span class="cx">
</span><span class="cx"> UIProcess/Launcher/ProcessLauncher.cpp
</span><span class="cx">
</span><ins>+ UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.cpp
+
</ins><span class="cx"> UIProcess/Network/NetworkProcessProxy.cpp
</span><span class="cx">
</span><span class="cx"> UIProcess/Notifications/NotificationPermissionRequest.cpp
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/ChangeLog 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -1,3 +1,58 @@
</span><ins>+2017-02-21 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ Reduce platform ifdefs in WebKit2 custom protocols implementation
+ https://bugs.webkit.org/show_bug.cgi?id=165028
+
+ Reviewed by Darin Adler.
+
+ Make mac implementation use the APICustomProtocolManagerClient to share more code with the soup based ports.
+
+ * CMakeLists.txt: Add CustomProtocolManagerProxy.cpp.
+ * PlatformEfl.cmake: Remove CustomProtocolManagerProxySoup.cpp.
+ * PlatformGTK.cmake: Ditto.
+ * PlatformMac.cmake: Remove CustomProtocolManagerProxyMac.mm.
+ * UIProcess/API/APICustomProtocolManagerClient.h:
+ (API::CustomProtocolManagerClient::startLoading): Make it void, since we were always returning true and the
+ returned value was ignored.
+ * UIProcess/API/efl/ewk_url_scheme_request.cpp:
+ (EwkUrlSchemeRequest::finish): Update to new CustomProtocolManagerProxy API.
+ * UIProcess/API/gtk/WebKitCustomProtocolManagerClient.cpp:
+ * UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
+ (webkitURISchemeRequestReadCallback): Ditto.
+ * UIProcess/Cocoa/CustomProtocolManagerClient.h: Added.
+ * UIProcess/Cocoa/CustomProtocolManagerClient.mm: Added.
+ (-[WKCustomProtocolLoader initWithCustomProtocolManagerProxy:customProtocolID:request:]):
+ (-[WKCustomProtocolLoader dealloc]):
+ (-[WKCustomProtocolLoader connection:didFailWithError:]):
+ (-[WKCustomProtocolLoader connection:didReceiveResponse:]):
+ (-[WKCustomProtocolLoader connection:didReceiveData:]):
+ (-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]):
+ (-[WKCustomProtocolLoader connectionDidFinishLoading:]):
+ (WebKit::CustomProtocolManagerClient::startLoading):
+ (WebKit::CustomProtocolManagerClient::stopLoading):
+ (WebKit::CustomProtocolManagerClient::invalidate):
+ * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+ (WebKit::WebProcessPool::platformInitialize): Set the CustomProtocolManagerClient.
+ (WebKit::WebProcessPool::platformInitializeNetworkProcess): Remove code that is now shared.
+ * UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.cpp: Added.
+ (WebKit::CustomProtocolManagerProxy::startLoading):
+ (WebKit::CustomProtocolManagerProxy::processDidClose):
+ (WebKit::CustomProtocolManagerProxy::wasRedirectedToRequest):
+ (WebKit::CustomProtocolManagerProxy::didReceiveResponse):
+ * UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
+ * UIProcess/WebProcessPool.cpp:
+ (WebKit::globalURLSchemesWithCustomProtocolHandlers): Just moved here to use it from ensureNetworkProcess().
+ (WebKit::WebProcessPool::WebProcessPool): Remove soup ifdefs.
+ (WebKit::WebProcessPool::setCustomProtocolManagerClient): Moved from the soup implementation.
+ (WebKit::WebProcessPool::ensureNetworkProcess): Initialize custom protocols parameters.
+ (WebKit::WebProcessPool::registerSchemeForCustomProtocol): Register the protocol if not already registered globally.
+ (WebKit::WebProcessPool::unregisterSchemeForCustomProtocol): Remove soup ifdefs.
+ * UIProcess/WebProcessPool.h: Remove soup ifdefs.
+ * UIProcess/efl/RequestManagerClientEfl.cpp:
+ * UIProcess/soup/WebProcessPoolSoup.cpp:
+ (WebKit::WebProcessPool::platformInitializeNetworkProcess): Remove code that is now shared.
+ * WebKit2.xcodeproj/project.pbxproj:
+
</ins><span class="cx"> 2017-02-21 Daewoong Jang <daewoong.jang@navercorp.com>
</span><span class="cx">
</span><span class="cx"> Remove unused files.
</span></span></pre></div>
<a id="trunkSourceWebKit2PlatformGTKcmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/PlatformGTK.cmake (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/PlatformGTK.cmake 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/PlatformGTK.cmake 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -302,8 +302,6 @@
</span><span class="cx">
</span><span class="cx"> UIProcess/linux/MemoryPressureMonitor.cpp
</span><span class="cx">
</span><del>- UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp
-
</del><span class="cx"> UIProcess/Plugins/gtk/PluginInfoCache.cpp
</span><span class="cx">
</span><span class="cx"> UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp
</span></span></pre></div>
<a id="trunkSourceWebKit2PlatformMaccmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/PlatformMac.cmake (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/PlatformMac.cmake 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/PlatformMac.cmake 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -259,8 +259,6 @@
</span><span class="cx">
</span><span class="cx"> UIProcess/Launcher/mac/ProcessLauncherMac.mm
</span><span class="cx">
</span><del>- UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm
-
</del><span class="cx"> UIProcess/Network/mac/NetworkProcessProxyMac.mm
</span><span class="cx">
</span><span class="cx"> UIProcess/Plugins/mac/PluginInfoStoreMac.mm
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIAPICustomProtocolManagerClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/APICustomProtocolManagerClient.h (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/APICustomProtocolManagerClient.h 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/UIProcess/API/APICustomProtocolManagerClient.h 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> public:
</span><span class="cx"> virtual ~CustomProtocolManagerClient() { }
</span><span class="cx">
</span><del>- virtual bool startLoading(WebKit::CustomProtocolManagerProxy&, uint64_t /* customProtocolID */, const WebCore::ResourceRequest&) { return false; }
</del><ins>+ virtual void startLoading(WebKit::CustomProtocolManagerProxy&, uint64_t /* customProtocolID */, const WebCore::ResourceRequest&) { }
</ins><span class="cx"> virtual void stopLoading(WebKit::CustomProtocolManagerProxy&, uint64_t /* customProtocolID */) { }
</span><span class="cx">
</span><span class="cx"> virtual void invalidate(WebKit::CustomProtocolManagerProxy&) { }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIgtkWebKitCustomProtocolManagerClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCustomProtocolManagerClient.cpp (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCustomProtocolManagerClient.cpp 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCustomProtocolManagerClient.cpp 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -36,10 +36,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- bool startLoading(CustomProtocolManagerProxy& manager, uint64_t customProtocolID, const ResourceRequest& request) override
</del><ins>+ void startLoading(CustomProtocolManagerProxy& manager, uint64_t customProtocolID, const ResourceRequest& request) override
</ins><span class="cx"> {
</span><span class="cx"> webkitWebContextStartLoadingCustomProtocol(m_webContext, customProtocolID, request, manager);
</span><del>- return true;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void stopLoading(CustomProtocolManagerProxy&, uint64_t customProtocolID) override
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIgtkWebKitURISchemeRequestcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitURISchemeRequest.cpp (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitURISchemeRequest.cpp 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitURISchemeRequest.cpp 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -193,7 +193,7 @@
</span><span class="cx"> // First chunk read. In case of empty reply an empty API::Data is sent to the networking process.
</span><span class="cx"> ResourceResponse response(URL(URL(), String::fromUTF8(priv->uri)), String::fromUTF8(priv->mimeType.data()),
</span><span class="cx"> priv->streamLength, emptyString());
</span><del>- priv->manager->didReceiveResponse(priv->requestID, response);
</del><ins>+ priv->manager->didReceiveResponse(priv->requestID, response, 0);
</ins><span class="cx"> priv->manager->didLoadData(priv->requestID, webData);
</span><span class="cx"> } else if (bytesRead || (!bytesRead && !priv->streamLength)) {
</span><span class="cx"> // Subsequent chunk read. We only send an empty API::Data to the networking process when stream length is unknown.
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessCocoaCustomProtocolManagerClienthfromrev212719trunkSourceWebKit2UIProcessAPIAPICustomProtocolManagerClienth"></a>
<div class="copfile"><h4>Copied: trunk/Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.h (from rev 212719, trunk/Source/WebKit2/UIProcess/API/APICustomProtocolManagerClient.h) (0 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.h (rev 0)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.h 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -0,0 +1,52 @@
</span><ins>+/*
+ * Copyright (C) 2017 Igalia S.L.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#pragma once
+
+#import "APICustomProtocolManagerClient.h"
+#import <wtf/HashMap.h>
+#import <wtf/RetainPtr.h>
+
+OBJC_CLASS WKCustomProtocolLoader;
+
+namespace WebCore {
+class ResourceRequest;
+}
+
+namespace WebKit {
+
+class CustomProtocolManagerProxy;
+
+class CustomProtocolManagerClient final : public API::CustomProtocolManagerClient {
+private:
+ void startLoading(CustomProtocolManagerProxy&, uint64_t /*customProtocolID*/, const WebCore::ResourceRequest&) final;
+ void stopLoading(CustomProtocolManagerProxy&, uint64_t /*customProtocolID*/) final;
+ void invalidate(CustomProtocolManagerProxy&) final;
+
+ HashMap<uint64_t, RetainPtr<WKCustomProtocolLoader>> m_loaderMap;
+};
+
+} // namespace WebKit
+
</ins></span></pre></div>
<a id="trunkSourceWebKit2UIProcessCocoaCustomProtocolManagerClientmmfromrev212719trunkSourceWebKit2UIProcessNetworkCustomProtocolsmacCustomProtocolManagerProxyMacmm"></a>
<div class="copfile"><h4>Copied: trunk/Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.mm (from rev 212719, trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm) (0 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.mm (rev 0)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.mm 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -0,0 +1,155 @@
</span><ins>+/*
+ * Copyright (C) 2012-2017 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import "config.h"
+#import "CustomProtocolManagerClient.h"
+
+#import "CustomProtocolManagerProxy.h"
+#import "DataReference.h"
+#import <WebCore/ResourceError.h>
+#import <WebCore/ResourceRequest.h>
+#import <WebCore/ResourceResponse.h>
+
+using namespace WebCore;
+using namespace WebKit;
+
+@interface WKCustomProtocolLoader : NSObject <NSURLConnectionDelegate> {
+@private
+ CustomProtocolManagerProxy* _customProtocolManagerProxy;
+ uint64_t _customProtocolID;
+ NSURLCacheStoragePolicy _storagePolicy;
+ NSURLConnection *_urlConnection;
+}
+- (id)initWithCustomProtocolManagerProxy:(CustomProtocolManagerProxy*)customProtocolManagerProxy customProtocolID:(uint64_t)customProtocolID request:(NSURLRequest *)request;
+- (void)customProtocolManagerProxyDestroyed;
+@end
+
+@implementation WKCustomProtocolLoader
+
+- (id)initWithCustomProtocolManagerProxy:(CustomProtocolManagerProxy*)customProtocolManagerProxy customProtocolID:(uint64_t)customProtocolID request:(NSURLRequest *)request
+{
+ self = [super init];
+ if (!self)
+ return nil;
+
+ ASSERT(customProtocolManagerProxy);
+ ASSERT(request);
+ _customProtocolManagerProxy = customProtocolManagerProxy;
+ _customProtocolID = customProtocolID;
+ _storagePolicy = NSURLCacheStorageNotAllowed;
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+ _urlConnection = [[NSURLConnection alloc] initWithRequest:request delegate:self startImmediately:NO];
+ [_urlConnection scheduleInRunLoop:[NSRunLoop mainRunLoop] forMode:NSRunLoopCommonModes];
+ [_urlConnection start];
+#pragma clang diagnostic pop
+
+ return self;
+}
+
+- (void)dealloc
+{
+ [_urlConnection cancel];
+ [_urlConnection release];
+ [super dealloc];
+}
+
+- (void)customProtocolManagerProxyDestroyed
+{
+ ASSERT(_customProtocolManagerProxy);
+ _customProtocolManagerProxy = nullptr;
+ [_urlConnection cancel];
+}
+
+- (void)connection:(NSURLConnection *)connection didFailWithError:(NSError *)error
+{
+ ResourceError coreError(error);
+ _customProtocolManagerProxy->didFailWithError(_customProtocolID, coreError);
+ _customProtocolManagerProxy->stopLoading(_customProtocolID);
+}
+
+- (NSCachedURLResponse *)connection:(NSURLConnection *)connection willCacheResponse:(NSCachedURLResponse *)cachedResponse
+{
+ ASSERT(_storagePolicy == NSURLCacheStorageNotAllowed);
+ _storagePolicy = [cachedResponse storagePolicy];
+ return cachedResponse;
+}
+
+- (void)connection:(NSURLConnection *)connection didReceiveResponse:(NSURLResponse *)response
+{
+ ResourceResponse coreResponse(response);
+ _customProtocolManagerProxy->didReceiveResponse(_customProtocolID, coreResponse, _storagePolicy);
+}
+
+- (void)connection:(NSURLConnection *)connection didReceiveData:(NSData *)data
+{
+ IPC::DataReference coreData(static_cast<const uint8_t*>([data bytes]), [data length]);
+ _customProtocolManagerProxy->didLoadData(_customProtocolID, coreData);
+}
+
+- (NSURLRequest *)connection:(NSURLConnection *)connection willSendRequest:(NSURLRequest *)request redirectResponse:(NSURLResponse *)redirectResponse
+{
+ if (redirectResponse) {
+ _customProtocolManagerProxy->wasRedirectedToRequest(_customProtocolID, request, redirectResponse);
+ return nil;
+ }
+ return request;
+}
+
+- (void)connectionDidFinishLoading:(NSURLConnection *)connection
+{
+ _customProtocolManagerProxy->didFinishLoading(_customProtocolID);
+ _customProtocolManagerProxy->stopLoading(_customProtocolID);
+}
+
+@end
+
+namespace WebKit {
+
+void CustomProtocolManagerClient::startLoading(CustomProtocolManagerProxy& manager, uint64_t customProtocolID, const ResourceRequest& coreRequest)
+{
+ NSURLRequest *request = coreRequest.nsURLRequest(DoNotUpdateHTTPBody);
+ if (!request)
+ return;
+
+ WKCustomProtocolLoader *loader = [[WKCustomProtocolLoader alloc] initWithCustomProtocolManagerProxy:&manager customProtocolID:customProtocolID request:request];
+ ASSERT(loader);
+ ASSERT(!m_loaderMap.contains(customProtocolID));
+ m_loaderMap.add(customProtocolID, loader);
+ [loader release];
+}
+
+void CustomProtocolManagerClient::stopLoading(CustomProtocolManagerProxy&, uint64_t customProtocolID)
+{
+ m_loaderMap.remove(customProtocolID);
+}
+
+void CustomProtocolManagerClient::invalidate(CustomProtocolManagerProxy&)
+{
+ for (auto& loader : m_loaderMap)
+ [loader.value customProtocolManagerProxyDestroyed];
+}
+
+} // namespace WebKit
</ins></span></pre></div>
<a id="trunkSourceWebKit2UIProcessCocoaWebProcessPoolCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -26,6 +26,7 @@
</span><span class="cx"> #import "config.h"
</span><span class="cx"> #import "WebProcessPool.h"
</span><span class="cx">
</span><ins>+#import "CustomProtocolManagerClient.h"
</ins><span class="cx"> #import "NetworkProcessCreationParameters.h"
</span><span class="cx"> #import "NetworkProcessMessages.h"
</span><span class="cx"> #import "NetworkProcessProxy.h"
</span><span class="lines">@@ -146,6 +147,8 @@
</span><span class="cx"> WebKit::WebMemoryPressureHandler::singleton();
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+ setCustomProtocolManagerClient(std::make_unique<CustomProtocolManagerClient>());
+
</ins><span class="cx"> if (m_websiteDataStore)
</span><span class="cx"> m_websiteDataStore->registerSharedResourceLoadObserver();
</span><span class="cx"> }
</span><span class="lines">@@ -265,9 +268,6 @@
</span><span class="cx"> parameters.parentProcessName = [[NSProcessInfo processInfo] processName];
</span><span class="cx"> parameters.uiProcessBundleIdentifier = [[NSBundle mainBundle] bundleIdentifier];
</span><span class="cx">
</span><del>- for (const auto& scheme : globalURLSchemesWithCustomProtocolHandlers())
- parameters.urlSchemesRegisteredForCustomProtocols.append(scheme);
-
</del><span class="cx"> NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
</span><span class="cx">
</span><span class="cx"> parameters.httpProxy = [defaults stringForKey:WebKit2HTTPProxyDefaultsKey];
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessNetworkCustomProtocolsCustomProtocolManagerProxycppfromrev212719trunkSourceWebKit2UIProcessNetworkCustomProtocolssoupCustomProtocolManagerProxySoupcpp"></a>
<div class="copfile"><h4>Copied: trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.cpp (from rev 212719, trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp) (0 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.cpp (rev 0)
+++ trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.cpp 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -0,0 +1,86 @@
</span><ins>+/*
+ * Copyright (C) 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2013 Igalia S.L.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public License
+ * along with this library; see the file COPYING.LIB. If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include "config.h"
+#include "CustomProtocolManagerProxy.h"
+
+#include "APICustomProtocolManagerClient.h"
+#include "ChildProcessProxy.h"
+#include "CustomProtocolManagerMessages.h"
+#include "CustomProtocolManagerProxyMessages.h"
+#include "WebProcessPool.h"
+#include <WebCore/ResourceRequest.h>
+
+namespace WebKit {
+
+CustomProtocolManagerProxy::CustomProtocolManagerProxy(ChildProcessProxy* childProcessProxy, WebProcessPool& processPool)
+ : m_childProcessProxy(childProcessProxy)
+ , m_processPool(processPool)
+{
+ ASSERT(m_childProcessProxy);
+ m_childProcessProxy->addMessageReceiver(Messages::CustomProtocolManagerProxy::messageReceiverName(), *this);
+}
+
+CustomProtocolManagerProxy::~CustomProtocolManagerProxy()
+{
+ m_childProcessProxy->removeMessageReceiver(Messages::CustomProtocolManagerProxy::messageReceiverName());
+}
+
+void CustomProtocolManagerProxy::startLoading(uint64_t customProtocolID, const WebCore::ResourceRequest& request)
+{
+ m_processPool.customProtocolManagerClient().startLoading(*this, customProtocolID, request);
+}
+
+void CustomProtocolManagerProxy::stopLoading(uint64_t customProtocolID)
+{
+ m_processPool.customProtocolManagerClient().stopLoading(*this, customProtocolID);
+}
+
+void CustomProtocolManagerProxy::processDidClose()
+{
+ m_processPool.customProtocolManagerClient().invalidate(*this);
+}
+
+void CustomProtocolManagerProxy::wasRedirectedToRequest(uint64_t customProtocolID, const WebCore::ResourceRequest& request, const WebCore::ResourceResponse& redirectResponse)
+{
+ m_childProcessProxy->send(Messages::CustomProtocolManager::WasRedirectedToRequest(customProtocolID, request, redirectResponse), 0);
+}
+
+void CustomProtocolManagerProxy::didReceiveResponse(uint64_t customProtocolID, const WebCore::ResourceResponse& response, uint32_t cacheStoragePolicy)
+{
+ m_childProcessProxy->send(Messages::CustomProtocolManager::DidReceiveResponse(customProtocolID, response, cacheStoragePolicy), 0);
+}
+
+void CustomProtocolManagerProxy::didLoadData(uint64_t customProtocolID, const IPC::DataReference& data)
+{
+ m_childProcessProxy->send(Messages::CustomProtocolManager::DidLoadData(customProtocolID, data), 0);
+}
+
+void CustomProtocolManagerProxy::didFailWithError(uint64_t customProtocolID, const WebCore::ResourceError& error)
+{
+ m_childProcessProxy->send(Messages::CustomProtocolManager::DidFailWithError(customProtocolID, error), 0);
+}
+
+void CustomProtocolManagerProxy::didFinishLoading(uint64_t customProtocolID)
+{
+ m_childProcessProxy->send(Messages::CustomProtocolManager::DidFinishLoading(customProtocolID), 0);
+}
+
+} // namespace WebKit
</ins></span></pre></div>
<a id="trunkSourceWebKit2UIProcessNetworkCustomProtocolsCustomProtocolManagerProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -59,12 +59,11 @@
</span><span class="cx">
</span><span class="cx"> void processDidClose();
</span><span class="cx">
</span><del>-#if USE(SOUP)
- void didReceiveResponse(uint64_t customProtocolID, const WebCore::ResourceResponse&);
</del><ins>+ void wasRedirectedToRequest(uint64_t customProtocolID, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
+ void didReceiveResponse(uint64_t customProtocolID, const WebCore::ResourceResponse&, uint32_t cacheStoragePolicy);
</ins><span class="cx"> void didLoadData(uint64_t customProtocolID, const IPC::DataReference&);
</span><span class="cx"> void didFailWithError(uint64_t customProtocolID, const WebCore::ResourceError&);
</span><span class="cx"> void didFinishLoading(uint64_t customProtocolID);
</span><del>-#endif
</del><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> // IPC::MessageReceiver
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessPoolcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -149,6 +149,12 @@
</span><span class="cx"> return configuration;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+static HashSet<String, ASCIICaseInsensitiveHash>& globalURLSchemesWithCustomProtocolHandlers()
+{
+ static NeverDestroyed<HashSet<String, ASCIICaseInsensitiveHash>> set;
+ return set;
+}
+
</ins><span class="cx"> WebProcessPool::WebProcessPool(API::ProcessPoolConfiguration& configuration)
</span><span class="cx"> : m_configuration(configuration.copy())
</span><span class="cx"> , m_haveInitialEmptyProcess(false)
</span><span class="lines">@@ -157,9 +163,7 @@
</span><span class="cx"> , m_automationClient(std::make_unique<API::AutomationClient>())
</span><span class="cx"> , m_downloadClient(std::make_unique<API::DownloadClient>())
</span><span class="cx"> , m_historyClient(std::make_unique<API::LegacyContextHistoryClient>())
</span><del>-#if USE(SOUP)
</del><span class="cx"> , m_customProtocolManagerClient(std::make_unique<API::CustomProtocolManagerClient>())
</span><del>-#endif
</del><span class="cx"> , m_visitedLinkStore(VisitedLinkStore::create())
</span><span class="cx"> , m_visitedLinksPopulated(false)
</span><span class="cx"> , m_plugInAutoStartProvider(this)
</span><span class="lines">@@ -300,6 +304,14 @@
</span><span class="cx"> m_automationClient = WTFMove(automationClient);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void WebProcessPool::setCustomProtocolManagerClient(std::unique_ptr<API::CustomProtocolManagerClient>&& customProtocolManagerClient)
+{
+ if (!customProtocolManagerClient)
+ m_customProtocolManagerClient = std::make_unique<API::CustomProtocolManagerClient>();
+ else
+ m_customProtocolManagerClient = WTFMove(customProtocolManagerClient);
+}
+
</ins><span class="cx"> void WebProcessPool::setMaximumNumberOfProcesses(unsigned maximumNumberOfProcesses)
</span><span class="cx"> {
</span><span class="cx"> // Guard against API misuse.
</span><span class="lines">@@ -353,6 +365,12 @@
</span><span class="cx"> parameters.diskCacheSizeOverride = m_configuration->diskCacheSizeOverride();
</span><span class="cx"> parameters.canHandleHTTPSServerTrustEvaluation = m_canHandleHTTPSServerTrustEvaluation;
</span><span class="cx">
</span><ins>+ for (auto& scheme : globalURLSchemesWithCustomProtocolHandlers())
+ parameters.urlSchemesRegisteredForCustomProtocols.append(scheme);
+
+ for (auto& scheme : m_urlSchemesRegisteredForCustomProtocols)
+ parameters.urlSchemesRegisteredForCustomProtocols.append(scheme);
+
</ins><span class="cx"> parameters.diskCacheDirectory = m_configuration->diskCacheDirectory();
</span><span class="cx"> if (!parameters.diskCacheDirectory.isEmpty())
</span><span class="cx"> SandboxExtension::createHandleForReadWriteDirectory(parameters.diskCacheDirectory, parameters.diskCacheDirectoryExtensionHandle);
</span><span class="lines">@@ -959,12 +977,6 @@
</span><span class="cx"> sendToAllProcesses(Messages::WebProcess::RegisterURLSchemeAsCORSEnabled(urlScheme));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-HashSet<String, ASCIICaseInsensitiveHash>& WebProcessPool::globalURLSchemesWithCustomProtocolHandlers()
-{
- static NeverDestroyed<HashSet<String, ASCIICaseInsensitiveHash>> set;
- return set;
-}
-
</del><span class="cx"> void WebProcessPool::registerGlobalURLSchemeAsHavingCustomProtocolHandlers(const String& urlScheme)
</span><span class="cx"> {
</span><span class="cx"> if (!urlScheme)
</span><span class="lines">@@ -1357,17 +1369,14 @@
</span><span class="cx">
</span><span class="cx"> void WebProcessPool::registerSchemeForCustomProtocol(const String& scheme)
</span><span class="cx"> {
</span><del>-#if USE(SOUP)
- m_urlSchemesRegisteredForCustomProtocols.add(scheme);
-#endif
</del><ins>+ if (!globalURLSchemesWithCustomProtocolHandlers().contains(scheme))
+ m_urlSchemesRegisteredForCustomProtocols.add(scheme);
</ins><span class="cx"> sendToNetworkingProcess(Messages::CustomProtocolManager::RegisterScheme(scheme));
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebProcessPool::unregisterSchemeForCustomProtocol(const String& scheme)
</span><span class="cx"> {
</span><del>-#if USE(SOUP)
</del><span class="cx"> m_urlSchemesRegisteredForCustomProtocols.remove(scheme);
</span><del>-#endif
</del><span class="cx"> sendToNetworkingProcess(Messages::CustomProtocolManager::UnregisterScheme(scheme));
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebProcessPoolh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.h (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebProcessPool.h 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.h 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -142,9 +142,7 @@
</span><span class="cx"> void setHistoryClient(std::unique_ptr<API::LegacyContextHistoryClient>);
</span><span class="cx"> void setDownloadClient(std::unique_ptr<API::DownloadClient>);
</span><span class="cx"> void setAutomationClient(std::unique_ptr<API::AutomationClient>);
</span><del>-#if USE(SOUP)
</del><span class="cx"> void setCustomProtocolManagerClient(std::unique_ptr<API::CustomProtocolManagerClient>&&);
</span><del>-#endif
</del><span class="cx">
</span><span class="cx"> void setMaximumNumberOfProcesses(unsigned); // Can only be called when there are no processes running.
</span><span class="cx"> unsigned maximumNumberOfProcesses() const { return !m_configuration->maximumProcessCount() ? UINT_MAX : m_configuration->maximumProcessCount(); }
</span><span class="lines">@@ -235,9 +233,7 @@
</span><span class="cx"> API::LegacyContextHistoryClient& historyClient() { return *m_historyClient; }
</span><span class="cx"> WebContextClient& client() { return m_client; }
</span><span class="cx">
</span><del>-#if USE(SOUP)
</del><span class="cx"> API::CustomProtocolManagerClient& customProtocolManagerClient() const { return *m_customProtocolManagerClient; }
</span><del>-#endif
</del><span class="cx">
</span><span class="cx"> WebIconDatabase* iconDatabase() const { return m_iconDatabase.get(); }
</span><span class="cx">
</span><span class="lines">@@ -336,7 +332,6 @@
</span><span class="cx"> void registerSchemeForCustomProtocol(const String&);
</span><span class="cx"> void unregisterSchemeForCustomProtocol(const String&);
</span><span class="cx">
</span><del>- static HashSet<String, ASCIICaseInsensitiveHash>& globalURLSchemesWithCustomProtocolHandlers();
</del><span class="cx"> static void registerGlobalURLSchemeAsHavingCustomProtocolHandlers(const String&);
</span><span class="cx"> static void unregisterGlobalURLSchemeAsHavingCustomProtocolHandlers(const String&);
</span><span class="cx">
</span><span class="lines">@@ -474,9 +469,7 @@
</span><span class="cx"> std::unique_ptr<API::AutomationClient> m_automationClient;
</span><span class="cx"> std::unique_ptr<API::DownloadClient> m_downloadClient;
</span><span class="cx"> std::unique_ptr<API::LegacyContextHistoryClient> m_historyClient;
</span><del>-#if USE(SOUP)
</del><span class="cx"> std::unique_ptr<API::CustomProtocolManagerClient> m_customProtocolManagerClient;
</span><del>-#endif
</del><span class="cx">
</span><span class="cx"> RefPtr<WebAutomationSession> m_automationSession;
</span><span class="cx">
</span><span class="lines">@@ -522,6 +515,7 @@
</span><span class="cx"> HTTPCookieAcceptPolicy m_initialHTTPCookieAcceptPolicy { HTTPCookieAcceptPolicyOnlyFromMainDocumentDomain };
</span><span class="cx"> WebCore::SoupNetworkProxySettings m_networkProxySettings;
</span><span class="cx"> #endif
</span><ins>+ HashSet<String, ASCIICaseInsensitiveHash> m_urlSchemesRegisteredForCustomProtocols;
</ins><span class="cx">
</span><span class="cx"> #if PLATFORM(MAC)
</span><span class="cx"> RetainPtr<NSObject> m_enhancedAccessibilityObserver;
</span><span class="lines">@@ -554,7 +548,6 @@
</span><span class="cx">
</span><span class="cx"> #if USE(SOUP)
</span><span class="cx"> bool m_ignoreTLSErrors { true };
</span><del>- HashSet<String, ASCIICaseInsensitiveHash> m_urlSchemesRegisteredForCustomProtocols;
</del><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> bool m_memoryCacheDisabled;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcesssoupWebProcessPoolSoupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -42,8 +42,6 @@
</span><span class="cx"> parameters.cookieAcceptPolicy = m_initialHTTPCookieAcceptPolicy;
</span><span class="cx"> parameters.ignoreTLSErrors = m_ignoreTLSErrors;
</span><span class="cx"> parameters.languages = WebCore::userPreferredLanguages();
</span><del>- for (const auto& scheme : m_urlSchemesRegisteredForCustomProtocols)
- parameters.urlSchemesRegisteredForCustomProtocols.append(scheme);
</del><span class="cx"> parameters.shouldEnableNetworkCacheEfficacyLogging = false;
</span><span class="cx"> parameters.proxySettings = m_networkProxySettings;
</span><span class="cx"> }
</span><span class="lines">@@ -55,14 +53,6 @@
</span><span class="cx"> networkProcess()->send(Messages::NetworkProcess::SetIgnoreTLSErrors(m_ignoreTLSErrors), 0);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebProcessPool::setCustomProtocolManagerClient(std::unique_ptr<API::CustomProtocolManagerClient>&& customProtocolManagerClient)
-{
- if (!customProtocolManagerClient)
- m_customProtocolManagerClient = std::make_unique<API::CustomProtocolManagerClient>();
- else
- m_customProtocolManagerClient = WTFMove(customProtocolManagerClient);
-}
-
</del><span class="cx"> void WebProcessPool::setNetworkProxySettings(const WebCore::SoupNetworkProxySettings& settings)
</span><span class="cx"> {
</span><span class="cx"> m_networkProxySettings = settings;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebKit2xcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (212723 => 212724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2017-02-21 18:21:36 UTC (rev 212723)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2017-02-21 18:24:51 UTC (rev 212724)
</span><span class="lines">@@ -600,7 +600,6 @@
</span><span class="cx"> 2984F588164BA095004BC0C6 /* CustomProtocolManagerMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2984F586164BA095004BC0C6 /* CustomProtocolManagerMessageReceiver.cpp */; };
</span><span class="cx"> 2984F589164BA095004BC0C6 /* CustomProtocolManagerMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = 2984F587164BA095004BC0C6 /* CustomProtocolManagerMessages.h */; };
</span><span class="cx"> 29AD3093164B4C5D0072DEA9 /* CustomProtocolManagerProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 29AD3092164B4C5D0072DEA9 /* CustomProtocolManagerProxy.h */; };
</span><del>- 29AD3096164B4C930072DEA9 /* CustomProtocolManagerProxyMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 29AD3095164B4C930072DEA9 /* CustomProtocolManagerProxyMac.mm */; };
</del><span class="cx"> 29CD55AA128E294F00133C85 /* WKAccessibilityWebPageObjectBase.h in Headers */ = {isa = PBXBuildFile; fileRef = 29CD55A8128E294F00133C85 /* WKAccessibilityWebPageObjectBase.h */; };
</span><span class="cx"> 29CD55AB128E294F00133C85 /* WKAccessibilityWebPageObjectBase.mm in Sources */ = {isa = PBXBuildFile; fileRef = 29CD55A9128E294F00133C85 /* WKAccessibilityWebPageObjectBase.mm */; };
</span><span class="cx"> 2D1087601D2C573E00B85F82 /* LoadParameters.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D10875E1D2C573E00B85F82 /* LoadParameters.cpp */; };
</span><span class="lines">@@ -1166,6 +1165,10 @@
</span><span class="cx"> 7A791EFA1C7CFCF100C4C52B /* WebResourceLoadStatisticsStoreMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7A791EF91C7CFB3700C4C52B /* WebResourceLoadStatisticsStoreMessageReceiver.cpp */; };
</span><span class="cx"> 7A791EFB1C7CFD0100C4C52B /* WebResourceLoadStatisticsStoreMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = 7A791EF81C7CFB1000C4C52B /* WebResourceLoadStatisticsStoreMessages.h */; };
</span><span class="cx"> 7A791EFC1C7D08C500C4C52B /* WebResourceLoadStatisticsStore.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7A9CD8C01C77984900D9F6C7 /* WebResourceLoadStatisticsStore.cpp */; };
</span><ins>+ 7A821F4A1E2F65E900604577 /* CustomProtocolManagerProxy.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7A821F491E2F65DD00604577 /* CustomProtocolManagerProxy.cpp */; };
+ 7A821F4C1E2F673900604577 /* CustomProtocolManagerClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 7A821F4B1E2F664800604577 /* CustomProtocolManagerClient.h */; };
+ 7A821F4E1E2F67A800604577 /* CustomProtocolManagerClient.mm in Sources */ = {isa = PBXBuildFile; fileRef = 7A821F4D1E2F679E00604577 /* CustomProtocolManagerClient.mm */; };
+ 7A821F501E2F7A7500604577 /* APICustomProtocolManagerClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 7A821F4F1E2F7A5C00604577 /* APICustomProtocolManagerClient.h */; };
</ins><span class="cx"> 7C065F2B1C8CD95F00C2D950 /* WebUserContentControllerDataTypes.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7C065F291C8CD95F00C2D950 /* WebUserContentControllerDataTypes.cpp */; };
</span><span class="cx"> 7C065F2C1C8CD95F00C2D950 /* WebUserContentControllerDataTypes.h in Headers */ = {isa = PBXBuildFile; fileRef = 7C065F2A1C8CD95F00C2D950 /* WebUserContentControllerDataTypes.h */; };
</span><span class="cx"> 7C135AA8173B0BCA00586AE2 /* WKPluginInformation.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7C135AA6173B0BCA00586AE2 /* WKPluginInformation.cpp */; };
</span><span class="lines">@@ -2733,7 +2736,6 @@
</span><span class="cx"> 2984F586164BA095004BC0C6 /* CustomProtocolManagerMessageReceiver.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CustomProtocolManagerMessageReceiver.cpp; sourceTree = "<group>"; };
</span><span class="cx"> 2984F587164BA095004BC0C6 /* CustomProtocolManagerMessages.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CustomProtocolManagerMessages.h; sourceTree = "<group>"; };
</span><span class="cx"> 29AD3092164B4C5D0072DEA9 /* CustomProtocolManagerProxy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = CustomProtocolManagerProxy.h; path = CustomProtocols/CustomProtocolManagerProxy.h; sourceTree = "<group>"; };
</span><del>- 29AD3095164B4C930072DEA9 /* CustomProtocolManagerProxyMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = CustomProtocolManagerProxyMac.mm; path = CustomProtocols/mac/CustomProtocolManagerProxyMac.mm; sourceTree = "<group>"; };
</del><span class="cx"> 29AD3097164B4E210072DEA9 /* CustomProtocolManagerProxy.messages.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name = CustomProtocolManagerProxy.messages.in; path = CustomProtocols/CustomProtocolManagerProxy.messages.in; sourceTree = "<group>"; };
</span><span class="cx"> 29CD55A8128E294F00133C85 /* WKAccessibilityWebPageObjectBase.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKAccessibilityWebPageObjectBase.h; sourceTree = "<group>"; };
</span><span class="cx"> 29CD55A9128E294F00133C85 /* WKAccessibilityWebPageObjectBase.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKAccessibilityWebPageObjectBase.mm; sourceTree = "<group>"; };
</span><span class="lines">@@ -3357,6 +3359,10 @@
</span><span class="cx"> 7A5E39491D5BD8A700B4B7CE /* com.macromedia.Flash Player ESR.plugin.sb */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = "com.macromedia.Flash Player ESR.plugin.sb"; sourceTree = "<group>"; };
</span><span class="cx"> 7A791EF81C7CFB1000C4C52B /* WebResourceLoadStatisticsStoreMessages.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebResourceLoadStatisticsStoreMessages.h; sourceTree = "<group>"; };
</span><span class="cx"> 7A791EF91C7CFB3700C4C52B /* WebResourceLoadStatisticsStoreMessageReceiver.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebResourceLoadStatisticsStoreMessageReceiver.cpp; sourceTree = "<group>"; };
</span><ins>+ 7A821F491E2F65DD00604577 /* CustomProtocolManagerProxy.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = CustomProtocolManagerProxy.cpp; path = CustomProtocols/CustomProtocolManagerProxy.cpp; sourceTree = "<group>"; };
+ 7A821F4B1E2F664800604577 /* CustomProtocolManagerClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CustomProtocolManagerClient.h; sourceTree = "<group>"; };
+ 7A821F4D1E2F679E00604577 /* CustomProtocolManagerClient.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = CustomProtocolManagerClient.mm; sourceTree = "<group>"; };
+ 7A821F4F1E2F7A5C00604577 /* APICustomProtocolManagerClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = APICustomProtocolManagerClient.h; sourceTree = "<group>"; };
</ins><span class="cx"> 7A9CD8C01C77984900D9F6C7 /* WebResourceLoadStatisticsStore.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebResourceLoadStatisticsStore.cpp; sourceTree = "<group>"; };
</span><span class="cx"> 7A9CD8C11C77984900D9F6C7 /* WebResourceLoadStatisticsStore.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebResourceLoadStatisticsStore.h; sourceTree = "<group>"; };
</span><span class="cx"> 7A9CD8C21C779AD600D9F6C7 /* WebResourceLoadStatisticsStore.messages.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = WebResourceLoadStatisticsStore.messages.in; sourceTree = "<group>"; };
</span><span class="lines">@@ -4990,6 +4996,8 @@
</span><span class="cx"> 99C81D561C20DFBE005C4C82 /* AutomationClient.mm */,
</span><span class="cx"> 990D28B71C6539A000986977 /* AutomationSessionClient.h */,
</span><span class="cx"> 990D28B81C6539A000986977 /* AutomationSessionClient.mm */,
</span><ins>+ 7A821F4B1E2F664800604577 /* CustomProtocolManagerClient.h */,
+ 7A821F4D1E2F679E00604577 /* CustomProtocolManagerClient.mm */,
</ins><span class="cx"> 83891B6A1A68C30B0030F386 /* DiagnosticLoggingClient.h */,
</span><span class="cx"> 83891B6B1A68C30B0030F386 /* DiagnosticLoggingClient.mm */,
</span><span class="cx"> A1DF631118E0B7C8003A3E2A /* DownloadClient.h */,
</span><span class="lines">@@ -5150,6 +5158,7 @@
</span><span class="cx"> children = (
</span><span class="cx"> 29AD3094164B4C830072DEA9 /* mac */,
</span><span class="cx"> 29AD3092164B4C5D0072DEA9 /* CustomProtocolManagerProxy.h */,
</span><ins>+ 7A821F491E2F65DD00604577 /* CustomProtocolManagerProxy.cpp */,
</ins><span class="cx"> 29AD3097164B4E210072DEA9 /* CustomProtocolManagerProxy.messages.in */,
</span><span class="cx"> );
</span><span class="cx"> name = CustomProtocols;
</span><span class="lines">@@ -5158,7 +5167,6 @@
</span><span class="cx"> 29AD3094164B4C830072DEA9 /* mac */ = {
</span><span class="cx"> isa = PBXGroup;
</span><span class="cx"> children = (
</span><del>- 29AD3095164B4C930072DEA9 /* CustomProtocolManagerProxyMac.mm */,
</del><span class="cx"> );
</span><span class="cx"> name = mac;
</span><span class="cx"> sourceTree = "<group>";
</span><span class="lines">@@ -6580,6 +6588,7 @@
</span><span class="cx"> 99C81D5B1C20E817005C4C82 /* APIAutomationClient.h */,
</span><span class="cx"> 990D28B31C6526D400986977 /* APIAutomationSessionClient.h */,
</span><span class="cx"> 076E884D1A13CADF005E90FC /* APIContextMenuClient.h */,
</span><ins>+ 7A821F4F1E2F7A5C00604577 /* APICustomProtocolManagerClient.h */,
</ins><span class="cx"> 83891B621A68B3420030F386 /* APIDiagnosticLoggingClient.h */,
</span><span class="cx"> 1F7D36C018DA513F00D9D659 /* APIDownloadClient.h */,
</span><span class="cx"> 317FE7C11C487A6600A0CA89 /* APIExperimentalFeature.cpp */,
</span><span class="lines">@@ -7868,6 +7877,7 @@
</span><span class="cx"> 7CA3793E1AC378B30079DC37 /* _WKUserContentExtensionStorePrivate.h in Headers */,
</span><span class="cx"> 7C89D2BA1A6B0F2C003A5FDE /* _WKUserContentFilter.h in Headers */,
</span><span class="cx"> 7C89D2BC1A6B0F5B003A5FDE /* _WKUserContentFilterInternal.h in Headers */,
</span><ins>+ 7A821F501E2F7A7500604577 /* APICustomProtocolManagerClient.h in Headers */,
</ins><span class="cx"> 7C882DF71C7E9965006BF731 /* _WKUserContentWorld.h in Headers */,
</span><span class="cx"> 7C882DF91C7E996F006BF731 /* _WKUserContentWorldInternal.h in Headers */,
</span><span class="cx"> 7CB365AA1D31DB70007158CA /* _WKUserInitiatedAction.h in Headers */,
</span><span class="lines">@@ -8176,6 +8186,7 @@
</span><span class="cx"> 41DC459F1E3DBDA500B11F51 /* WebRTCSocket.h in Headers */,
</span><span class="cx"> 1A0EC906124C0AB8007EF4A5 /* PluginProcessConnection.h in Headers */,
</span><span class="cx"> 1A0EC90F124C0AF5007EF4A5 /* PluginProcessConnectionManager.h in Headers */,
</span><ins>+ 7A821F4C1E2F673900604577 /* CustomProtocolManagerClient.h in Headers */,
</ins><span class="cx"> 1A7865BA16CAC71500ACE83A /* PluginProcessConnectionManagerMessages.h in Headers */,
</span><span class="cx"> 1A2BB6D114117B4D000F35D4 /* PluginProcessConnectionMessages.h in Headers */,
</span><span class="cx"> 1A2D90D21281C966001EB962 /* PluginProcessCreationParameters.h in Headers */,
</span><span class="lines">@@ -9493,7 +9504,6 @@
</span><span class="cx"> B878B616133428DC006888E9 /* CorrectionPanel.mm in Sources */,
</span><span class="cx"> 5C14271D1C23F8CF00D41183 /* CustomProtocolManagerCocoa.mm in Sources */,
</span><span class="cx"> 2984F588164BA095004BC0C6 /* CustomProtocolManagerMessageReceiver.cpp in Sources */,
</span><del>- 29AD3096164B4C930072DEA9 /* CustomProtocolManagerProxyMac.mm in Sources */,
</del><span class="cx"> 2984F57C164B915F004BC0C6 /* CustomProtocolManagerProxyMessageReceiver.cpp in Sources */,
</span><span class="cx"> 51E351FF180F5D0F00E53BE9 /* DatabaseProcess.cpp in Sources */,
</span><span class="cx"> 515E772B184008B90007203F /* DatabaseProcessCreationParameters.cpp in Sources */,
</span><span class="lines">@@ -10154,6 +10164,7 @@
</span><span class="cx"> 1AB40EE51BF677E300BA81BE /* WKMenuItemIdentifiers.mm in Sources */,
</span><span class="cx"> BC4075FD124FF0270068F20A /* WKMutableArray.cpp in Sources */,
</span><span class="cx"> BC4075FF124FF0270068F20A /* WKMutableDictionary.cpp in Sources */,
</span><ins>+ 7A821F4A1E2F65E900604577 /* CustomProtocolManagerProxy.cpp in Sources */,
</ins><span class="cx"> 1A5B1C501898606F004FCF9B /* WKNavigation.mm in Sources */,
</span><span class="cx"> 1A256E3718A1A788006FB922 /* WKNavigationAction.mm in Sources */,
</span><span class="cx"> 2D3A65DA1A7C3A1F00CAC637 /* WKNavigationActionRef.cpp in Sources */,
</span><span class="lines">@@ -10257,6 +10268,7 @@
</span><span class="cx"> 1AD60F5D18E20F4C0020C034 /* WKWindowFeatures.mm in Sources */,
</span><span class="cx"> 1A7C0DF61B7D1F1000A9B848 /* WKWindowFeaturesRef.cpp in Sources */,
</span><span class="cx"> BCBECDE716B6416800047A1A /* XPCServiceEntryPoint.mm in Sources */,
</span><ins>+ 7A821F4E1E2F67A800604577 /* CustomProtocolManagerClient.mm in Sources */,
</ins><span class="cx"> );
</span><span class="cx"> runOnlyForDeploymentPostprocessing = 0;
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>