<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212748] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212748">212748</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-21 13:53:28 -0800 (Tue, 21 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Readable Streams API] Add ReadableStreamBYOBRequest view getter
https://bugs.webkit.org/show_bug.cgi?id=168652
Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2017-02-21
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Updated test expectations.
* web-platform-tests/streams/readable-byte-streams/general-expected.txt:
* web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt:
Source/WebCore:
Implemented getter for ReadableStreamBYOBRequest view attribute.
Added 1 test checking that view length corresponds to autoAllocateChunkSize.
Also updated test expectations for W3C imported tests.
* Modules/streams/ReadableByteStreamInternals.js:
(isReadableStreamBYOBRequest): Added.
* Modules/streams/ReadableStreamBYOBRequest.js:
(view): Added.
LayoutTests:
Added 1 test checking that view length corresponds to autoAllocateChunkSize.
* streams/readable-stream-byob-request-expected.txt: Updated.
* streams/readable-stream-byob-request.js: Added 1 test.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamsreadablebytestreamsgeneralexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamsreadablebytestreamsgeneraldedicatedworkerexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreadablestreambyobrequestexpectedtxt">trunk/LayoutTests/streams/readable-stream-byob-request-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstreamsreadablestreambyobrequestjs">trunk/LayoutTests/streams/readable-stream-byob-request.js</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsReadableByteStreamInternalsjs">trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsReadableStreamBYOBRequestjs">trunk/Source/WebCore/Modules/streams/ReadableStreamBYOBRequest.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (212747 => 212748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-02-21 21:47:40 UTC (rev 212747)
+++ trunk/LayoutTests/ChangeLog 2017-02-21 21:53:28 UTC (rev 212748)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-02-21 Romain Bellessort <romain.bellessort@crf.canon.fr>
+
+ [Readable Streams API] Add ReadableStreamBYOBRequest view getter
+ https://bugs.webkit.org/show_bug.cgi?id=168652
+
+ Reviewed by Youenn Fablet.
+
+ Added 1 test checking that view length corresponds to autoAllocateChunkSize.
+
+ * streams/readable-stream-byob-request-expected.txt: Updated.
+ * streams/readable-stream-byob-request.js: Added 1 test.
+
</ins><span class="cx"> 2017-02-21 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r207669): Crash after mutating selector text
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (212747 => 212748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-02-21 21:47:40 UTC (rev 212747)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-02-21 21:53:28 UTC (rev 212748)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-02-21 Romain Bellessort <romain.bellessort@crf.canon.fr>
+
+ [Readable Streams API] Add ReadableStreamBYOBRequest view getter
+ https://bugs.webkit.org/show_bug.cgi?id=168652
+
+ Reviewed by Youenn Fablet.
+
+ Updated test expectations.
+
+ * web-platform-tests/streams/readable-byte-streams/general-expected.txt:
+ * web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt:
+
</ins><span class="cx"> 2017-02-21 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r212699.
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamsreadablebytestreamsgeneralexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt (212747 => 212748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt 2017-02-21 21:47:40 UTC (rev 212747)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt 2017-02-21 21:53:28 UTC (rev 212748)
</span><span class="lines">@@ -14,7 +14,7 @@
</span><span class="cx"> PASS ReadableStream with byte source: Automatic pull() after start()
</span><span class="cx"> PASS ReadableStream with byte source: Automatic pull() after start() and read()
</span><span class="cx"> FAIL ReadableStream with byte source: autoAllocateChunkSize assert_equals: pull() must have been invoked once expected 1 but got 0
</span><del>-FAIL ReadableStream with byte source: Mix of auto allocate and BYOB promise_test: Unhandled rejection with value: object "TypeError: ReadableByteStreamController view is not implemented"
</del><ins>+FAIL ReadableStream with byte source: Mix of auto allocate and BYOB promise_test: Unhandled rejection with value: object "TypeError: ReadableStreamBYOBRequest respond() is not implemented"
</ins><span class="cx"> PASS ReadableStream with byte source: Automatic pull() after start() and read(view)
</span><span class="cx"> PASS ReadableStream with byte source: enqueue(), getReader(), then read()
</span><span class="cx"> PASS ReadableStream with byte source: Push source that doesn't understand pull signal
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamsreadablebytestreamsgeneraldedicatedworkerexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt (212747 => 212748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt 2017-02-21 21:47:40 UTC (rev 212747)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt 2017-02-21 21:53:28 UTC (rev 212748)
</span><span class="lines">@@ -14,7 +14,7 @@
</span><span class="cx"> PASS ReadableStream with byte source: Automatic pull() after start()
</span><span class="cx"> PASS ReadableStream with byte source: Automatic pull() after start() and read()
</span><span class="cx"> FAIL ReadableStream with byte source: autoAllocateChunkSize assert_equals: pull() must have been invoked once expected 1 but got 0
</span><del>-FAIL ReadableStream with byte source: Mix of auto allocate and BYOB promise_test: Unhandled rejection with value: object "TypeError: ReadableByteStreamController view is not implemented"
</del><ins>+FAIL ReadableStream with byte source: Mix of auto allocate and BYOB promise_test: Unhandled rejection with value: object "TypeError: ReadableStreamBYOBRequest respond() is not implemented"
</ins><span class="cx"> PASS ReadableStream with byte source: Automatic pull() after start() and read(view)
</span><span class="cx"> PASS ReadableStream with byte source: enqueue(), getReader(), then read()
</span><span class="cx"> PASS ReadableStream with byte source: Push source that doesn't understand pull signal
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreadablestreambyobrequestexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/readable-stream-byob-request-expected.txt (212747 => 212748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/readable-stream-byob-request-expected.txt 2017-02-21 21:47:40 UTC (rev 212747)
+++ trunk/LayoutTests/streams/readable-stream-byob-request-expected.txt 2017-02-21 21:53:28 UTC (rev 212748)
</span><span class="lines">@@ -1,6 +1,8 @@
</span><span class="cx">
</span><span class="cx"> PASS ReadableStreamBYOBRequest instances should have the correct list of properties
</span><span class="cx"> PASS By default, byobRequest should be undefined
</span><ins>+PASS byobRequest.view length should be equal to autoAllocateChunkSize
</ins><span class="cx"> PASS ReadableStreamBYOBRequest instances should have the correct list of properties
</span><span class="cx"> PASS By default, byobRequest should be undefined
</span><ins>+PASS byobRequest.view length should be equal to autoAllocateChunkSize
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsstreamsreadablestreambyobrequestjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/streams/readable-stream-byob-request.js (212747 => 212748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/streams/readable-stream-byob-request.js 2017-02-21 21:47:40 UTC (rev 212747)
+++ trunk/LayoutTests/streams/readable-stream-byob-request.js 2017-02-21 21:53:28 UTC (rev 212748)
</span><span class="lines">@@ -66,4 +66,23 @@
</span><span class="cx"> assert_equals(controller.byobRequest, undefined, "by default byobRequest should be undefined");
</span><span class="cx"> }, "By default, byobRequest should be undefined");
</span><span class="cx">
</span><ins>+test(function() {
+
+ let controller;
+ const autoAllocateChunkSize = 128;
+ const rs = new ReadableStream({
+ autoAllocateChunkSize,
+ start: function(c) {
+ controller = c;
+ },
+ type: "bytes"
+ });
+
+ rs.getReader().read();
+ const byobReq = controller.byobRequest;
+
+ assert_equals(byobReq.view.length, autoAllocateChunkSize, "byobRequest length should be equal to autoAllocateChunkSize value")
+
+}, "byobRequest.view length should be equal to autoAllocateChunkSize")
+
</ins><span class="cx"> done();
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (212747 => 212748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-02-21 21:47:40 UTC (rev 212747)
+++ trunk/Source/WebCore/ChangeLog 2017-02-21 21:53:28 UTC (rev 212748)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2017-02-21 Romain Bellessort <romain.bellessort@crf.canon.fr>
+
+ [Readable Streams API] Add ReadableStreamBYOBRequest view getter
+ https://bugs.webkit.org/show_bug.cgi?id=168652
+
+ Reviewed by Youenn Fablet.
+
+ Implemented getter for ReadableStreamBYOBRequest view attribute.
+
+ Added 1 test checking that view length corresponds to autoAllocateChunkSize.
+ Also updated test expectations for W3C imported tests.
+
+ * Modules/streams/ReadableByteStreamInternals.js:
+ (isReadableStreamBYOBRequest): Added.
+ * Modules/streams/ReadableStreamBYOBRequest.js:
+ (view): Added.
+
</ins><span class="cx"> 2017-02-21 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Clarify the status of 'webkitSubtle' and 'subtle' attributes on the WebCrypto API.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsReadableByteStreamInternalsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js (212747 => 212748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js 2017-02-21 21:47:40 UTC (rev 212747)
+++ trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js 2017-02-21 21:53:28 UTC (rev 212748)
</span><span class="lines">@@ -95,6 +95,15 @@
</span><span class="cx"> return @isObject(controller) && !!controller.@underlyingByteSource;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+function isReadableStreamBYOBRequest(byobRequest)
+{
+ "use strict";
+
+ // Same test mechanism as in isReadableStreamDefaultController (ReadableStreamInternals.js).
+ // See corresponding function for explanations.
+ return @isObject(byobRequest) && !!byobRequest.@associatedReadableByteStreamController;
+}
+
</ins><span class="cx"> function isReadableStreamBYOBReader(reader)
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsReadableStreamBYOBRequestjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamBYOBRequest.js (212747 => 212748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/ReadableStreamBYOBRequest.js 2017-02-21 21:47:40 UTC (rev 212747)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamBYOBRequest.js 2017-02-21 21:53:28 UTC (rev 212748)
</span><span class="lines">@@ -45,6 +45,8 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- // FIXME: Implement appropriate behavior.
- @throwTypeError("ReadableByteStreamController view is not implemented");
</del><ins>+ if (!@isReadableStreamBYOBRequest(this))
+ throw @makeGetterTypeError("ReadableStreamBYOBRequest", "view");
+
+ return this.@view;
</ins><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>