<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212660] branches/safari-603-branch/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212660">212660</a></dd>
<dt>Author</dt> <dd>matthew_hanson@apple.com</dd>
<dt>Date</dt> <dd>2017-02-20 10:33:19 -0800 (Mon, 20 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>rdar://problem/30553220</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari603branchSourceJavaScriptCoreChangeLog">branches/safari-603-branch/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#branchessafari603branchSourceJavaScriptCoreruntimeOptionscpp">branches/safari-603-branch/Source/JavaScriptCore/runtime/Options.cpp</a></li>
<li><a href="#branchessafari603branchSourceJavaScriptCoreruntimeOptionsh">branches/safari-603-branch/Source/JavaScriptCore/runtime/Options.h</a></li>
<li><a href="#branchessafari603branchSourceWTFChangeLog">branches/safari-603-branch/Source/WTF/ChangeLog</a></li>
<li><a href="#branchessafari603branchSourceWTFWTFxcodeprojprojectpbxproj">branches/safari-603-branch/Source/WTF/WTF.xcodeproj/project.pbxproj</a></li>
<li><a href="#branchessafari603branchSourceWTFwtfCMakeListstxt">branches/safari-603-branch/Source/WTF/wtf/CMakeLists.txt</a></li>
<li><a href="#branchessafari603branchSourceWebCoreChangeLog">branches/safari-603-branch/Source/WebCore/ChangeLog</a></li>
<li><a href="#branchessafari603branchSourceWebCoreWebCorexcodeprojprojectpbxproj">branches/safari-603-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#branchessafari603branchSourceWebKit2ChangeLog">branches/safari-603-branch/Source/WebKit2/ChangeLog</a></li>
<li><a href="#branchessafari603branchSourceWebKit2WebProcessEntryPointmacXPCServiceWebContentServiceEntryPointmm">branches/safari-603-branch/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#branchessafari603branchSourceWTFwtfSplitTestcpp">branches/safari-603-branch/Source/WTF/wtf/SplitTest.cpp</a></li>
<li><a href="#branchessafari603branchSourceWTFwtfSplitTesth">branches/safari-603-branch/Source/WTF/wtf/SplitTest.h</a></li>
<li><a href="#branchessafari603branchSourceWebCoreplatformSplitTestInitializercpp">branches/safari-603-branch/Source/WebCore/platform/SplitTestInitializer.cpp</a></li>
<li><a href="#branchessafari603branchSourceWebCoreplatformSplitTestInitializerh">branches/safari-603-branch/Source/WebCore/platform/SplitTestInitializer.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari603branchSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-603-branch/Source/JavaScriptCore/ChangeLog (212659 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/JavaScriptCore/ChangeLog 2017-02-20 18:32:37 UTC (rev 212659)
+++ branches/safari-603-branch/Source/JavaScriptCore/ChangeLog 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2017-02-17 Matthew Hanson <matthew_hanson@apple.com>
+
+ A/B test concurrent GC
+ https://bugs.webkit.org/show_bug.cgi?id=168453
+ <rdar://problem/30553220>
+
+ Landed on behalf of JF Bastien.
+
+ Reviewed by Alexey Proskuryakov.
+
+ The concurrent GC may be causing more crashes, but it's hard to
+ tell. A/B test this by setting it off for 50% of users, based on
+ the UUID which crash tracer generates. From this we can look at
+ crashes and figure out whether the concurrent GC was on or off,
+ and derive whether fewer crashes occur when it's off.
+
+ * runtime/Options.cpp:
+ (JSC::recomputeDependentOptions):
+ * runtime/Options.h:
+
</ins><span class="cx"> 2017-02-20 Matthew Hanson <matthew_hanson@apple.com>
</span><span class="cx">
</span><span class="cx"> Merge r212618. rdar://problem/30475767
</span></span></pre></div>
<a id="branchessafari603branchSourceJavaScriptCoreruntimeOptionscpp"></a>
<div class="modfile"><h4>Modified: branches/safari-603-branch/Source/JavaScriptCore/runtime/Options.cpp (212659 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/JavaScriptCore/runtime/Options.cpp 2017-02-20 18:32:37 UTC (rev 212659)
+++ branches/safari-603-branch/Source/JavaScriptCore/runtime/Options.cpp 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -39,6 +39,7 @@
</span><span class="cx"> #include <wtf/Compiler.h>
</span><span class="cx"> #include <wtf/DataLog.h>
</span><span class="cx"> #include <wtf/NumberOfCores.h>
</span><ins>+#include <wtf/SplitTest.h>
</ins><span class="cx"> #include <wtf/StdLibExtras.h>
</span><span class="cx"> #include <wtf/StringExtras.h>
</span><span class="cx"> #include <wtf/text/StringBuilder.h>
</span><span class="lines">@@ -309,6 +310,17 @@
</span><span class="cx"> option.int32Val() *= scaleFactor;
</span><span class="cx"> option.int32Val() = std::max(option.int32Val(), optionsToScale[i].minVal);
</span><span class="cx"> }
</span><ins>+
+ if (Options::useConcurrentGCSplitTesting()) {
+ if (Options::useConcurrentGC()) {
+ // Run an A/B split test on concurrent GC: if it was going to be on,
+ // turn it off with some probability. Do this deterministically per
+ // unique user identifier so that crashes don't skew statistics, and
+ // do it in a manner which can be reconstructed from a crash trace.
+ std::optional<bool> enableExperiment = SplitTest::singleton().enableBooleanExperiment();
+ Options::useConcurrentGC() = enableExperiment.value_or(true);
+ }
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static void overrideDefaults()
</span></span></pre></div>
<a id="branchessafari603branchSourceJavaScriptCoreruntimeOptionsh"></a>
<div class="modfile"><h4>Modified: branches/safari-603-branch/Source/JavaScriptCore/runtime/Options.h (212659 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/JavaScriptCore/runtime/Options.h 2017-02-20 18:32:37 UTC (rev 212659)
+++ branches/safari-603-branch/Source/JavaScriptCore/runtime/Options.h 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -417,6 +417,8 @@
</span><span class="cx"> v(bool, useCodeCache, true, Normal, "If false, the unlinked byte code cache will not be used.") \
</span><span class="cx"> \
</span><span class="cx"> v(bool, useWebAssembly, false, Normal, "Expose the WebAssembly global object.") \
</span><ins>+ \
+ v(bool, useConcurrentGCSplitTesting, true, Normal, "If true, A/B split testing will be performed on the concurrent GC, yielding a 50% chance that concurrent GC is disabled.") \
</ins><span class="cx">
</span><span class="cx"> enum OptionEquivalence {
</span><span class="cx"> SameOption,
</span></span></pre></div>
<a id="branchessafari603branchSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-603-branch/Source/WTF/ChangeLog (212659 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/WTF/ChangeLog 2017-02-20 18:32:37 UTC (rev 212659)
+++ branches/safari-603-branch/Source/WTF/ChangeLog 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2017-02-17 Matthew Hanson <matthew_hanson@apple.com>
+
+ A/B test concurrent GC
+ https://bugs.webkit.org/show_bug.cgi?id=168453
+ <rdar://problem/30553220>
+
+ Landed on behalf of JF Bastien.
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add the SplitTest singleton which can be used for A/B split
+ testing of features. It is currently initialized for WebKit2
+ WebContent processes, but the class is usable anywhere WTF can be
+ used (it returns an optional, which is valueless if not
+ initialized).
+
+ * WTF.xcodeproj/project.pbxproj:
+ * wtf/CMakeLists.txt:
+ * wtf/SplitTest.cpp: Added.
+ (WTF::SplitTest::singleton):
+ (WTF::SplitTest::initialize):
+ (WTF::SplitTest::enableBooleanExperiment):
+ * wtf/SplitTest.h: Added.
+
</ins><span class="cx"> 2017-02-20 Matthew Hanson <matthew_hanson@apple.com>
</span><span class="cx">
</span><span class="cx"> Merge r212618. rdar://problem/30475767
</span></span></pre></div>
<a id="branchessafari603branchSourceWTFWTFxcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: branches/safari-603-branch/Source/WTF/WTF.xcodeproj/project.pbxproj (212659 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/WTF/WTF.xcodeproj/project.pbxproj 2017-02-20 18:32:37 UTC (rev 212659)
+++ branches/safari-603-branch/Source/WTF/WTF.xcodeproj/project.pbxproj 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -335,6 +335,8 @@
</span><span class="cx"> A8A47486151A825B004123FF /* WTFThreadData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8A4737A151A825B004123FF /* WTFThreadData.cpp */; };
</span><span class="cx"> A8A47487151A825B004123FF /* WTFThreadData.h in Headers */ = {isa = PBXBuildFile; fileRef = A8A4737B151A825B004123FF /* WTFThreadData.h */; };
</span><span class="cx"> A8A4748C151A8264004123FF /* config.h in Headers */ = {isa = PBXBuildFile; fileRef = A8A4748B151A8264004123FF /* config.h */; };
</span><ins>+ AD412B201E57BC92008AF157 /* SplitTest.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AD412B1E1E57BC92008AF157 /* SplitTest.cpp */; };
+ AD412B211E57BC92008AF157 /* SplitTest.h in Headers */ = {isa = PBXBuildFile; fileRef = AD412B1F1E57BC92008AF157 /* SplitTest.h */; };
</ins><span class="cx"> AD7C434B1DD2A4A70026888B /* Expected.h in Headers */ = {isa = PBXBuildFile; fileRef = AD7C434A1DD2A4A70026888B /* Expected.h */; };
</span><span class="cx"> ADF2CE661E39F106006889DB /* MemoryFootprint.h in Headers */ = {isa = PBXBuildFile; fileRef = ADF2CE641E39F106006889DB /* MemoryFootprint.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><span class="cx"> ADF2CE671E39F106006889DB /* MemoryFootprint.cpp in Sources */ = {isa = PBXBuildFile; fileRef = ADF2CE651E39F106006889DB /* MemoryFootprint.cpp */; };
</span><span class="lines">@@ -712,6 +714,8 @@
</span><span class="cx"> A8A4737A151A825B004123FF /* WTFThreadData.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WTFThreadData.cpp; sourceTree = "<group>"; };
</span><span class="cx"> A8A4737B151A825B004123FF /* WTFThreadData.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WTFThreadData.h; sourceTree = "<group>"; };
</span><span class="cx"> A8A4748B151A8264004123FF /* config.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = config.h; sourceTree = "<group>"; };
</span><ins>+ AD412B1E1E57BC92008AF157 /* SplitTest.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SplitTest.cpp; sourceTree = "<group>"; };
+ AD412B1F1E57BC92008AF157 /* SplitTest.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SplitTest.h; sourceTree = "<group>"; };
</ins><span class="cx"> AD7C434A1DD2A4A70026888B /* Expected.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Expected.h; sourceTree = "<group>"; };
</span><span class="cx"> ADF2CE641E39F106006889DB /* MemoryFootprint.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MemoryFootprint.h; sourceTree = "<group>"; };
</span><span class="cx"> ADF2CE651E39F106006889DB /* MemoryFootprint.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MemoryFootprint.cpp; sourceTree = "<group>"; };
</span><span class="lines">@@ -870,6 +874,8 @@
</span><span class="cx"> A876DBD6151816E500DADB95 /* wtf */ = {
</span><span class="cx"> isa = PBXGroup;
</span><span class="cx"> children = (
</span><ins>+ AD412B1E1E57BC92008AF157 /* SplitTest.cpp */,
+ AD412B1F1E57BC92008AF157 /* SplitTest.h */,
</ins><span class="cx"> 2CDED0F018115C3F004DBA70 /* cf */,
</span><span class="cx"> E4A0AD3B1A96251900536DF6 /* cocoa */,
</span><span class="cx"> A8A47281151A825A004123FF /* dtoa */,
</span><span class="lines">@@ -1456,6 +1462,7 @@
</span><span class="cx"> 0FC4488316FE9FE100844BE9 /* ProcessID.h in Headers */,
</span><span class="cx"> 143F61201565F0F900DB514A /* RAMSize.h in Headers */,
</span><span class="cx"> A8A47415151A825B004123FF /* RandomNumber.h in Headers */,
</span><ins>+ AD412B211E57BC92008AF157 /* SplitTest.h in Headers */,
</ins><span class="cx"> A8A47416151A825B004123FF /* RandomNumberSeed.h in Headers */,
</span><span class="cx"> 0F725CAC1C50461600AD943A /* RangeSet.h in Headers */,
</span><span class="cx"> 0F87105A16643F190090B0AD /* RawPointer.h in Headers */,
</span><span class="lines">@@ -1725,6 +1732,7 @@
</span><span class="cx"> A8A47443151A825B004123FF /* StringStatics.cpp in Sources */,
</span><span class="cx"> 93F1993E19D7958D00C2390B /* StringView.cpp in Sources */,
</span><span class="cx"> 93934BD518A1F16900D0D6A1 /* StringViewCF.cpp in Sources */,
</span><ins>+ AD412B201E57BC92008AF157 /* SplitTest.cpp in Sources */,
</ins><span class="cx"> 93934BD318A1E8C300D0D6A1 /* StringViewObjC.mm in Sources */,
</span><span class="cx"> A8A473B7151A825B004123FF /* strtod.cc in Sources */,
</span><span class="cx"> 52183012C99E476A84EEBEA8 /* SymbolImpl.cpp in Sources */,
</span></span></pre></div>
<a id="branchessafari603branchSourceWTFwtfCMakeListstxt"></a>
<div class="modfile"><h4>Modified: branches/safari-603-branch/Source/WTF/wtf/CMakeLists.txt (212659 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/WTF/wtf/CMakeLists.txt 2017-02-20 18:32:37 UTC (rev 212659)
+++ branches/safari-603-branch/Source/WTF/wtf/CMakeLists.txt 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -110,6 +110,7 @@
</span><span class="cx"> Seconds.h
</span><span class="cx"> SegmentedVector.h
</span><span class="cx"> SmallPtrSet.h
</span><ins>+ SplitTest.h
</ins><span class="cx"> StackBounds.h
</span><span class="cx"> StackStats.h
</span><span class="cx"> StaticConstructors.h
</span><span class="lines">@@ -222,6 +223,7 @@
</span><span class="cx"> SHA1.cpp
</span><span class="cx"> Seconds.cpp
</span><span class="cx"> SixCharacterHash.cpp
</span><ins>+ SplitTest.cpp
</ins><span class="cx"> StackBounds.cpp
</span><span class="cx"> StackStats.cpp
</span><span class="cx"> StringPrintStream.cpp
</span></span></pre></div>
<a id="branchessafari603branchSourceWTFwtfSplitTestcpp"></a>
<div class="addfile"><h4>Added: branches/safari-603-branch/Source/WTF/wtf/SplitTest.cpp (0 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/WTF/wtf/SplitTest.cpp (rev 0)
+++ branches/safari-603-branch/Source/WTF/wtf/SplitTest.cpp 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -0,0 +1,66 @@
</span><ins>+/*
+ * Copyright (C) 2017 Apple Inc. All Rights Reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "SplitTest.h"
+
+#include <wtf/Assertions.h>
+
+namespace WTF {
+
+SplitTest& SplitTest::singleton()
+{
+ static NeverDestroyed<SplitTest> splitTest;
+ return splitTest;
+}
+
+void SplitTest::initializeSingleton(uint64_t lo, uint64_t hi)
+{
+ // Double initialization with different values would be bad because it would
+ // provide different experiment results.
+ RELEASE_ASSERT(!m_initialized || (m_lo == lo && m_hi == hi));
+ m_lo = lo;
+ m_hi = hi;
+
+ m_initialized = true;
+}
+
+std::optional<bool> SplitTest::enableBooleanExperiment()
+{
+ if (!m_initialized)
+ return std::optional<bool>();
+
+ uint64_t value = m_lo ^ m_hi;
+ value = (value & 0xFFFFFFFFu) ^ (value >> 32);
+ value = (value & 0xFFFFu) ^ (value >> 16);
+ value = (value & 0xFFu) ^ (value >> 8);
+ value = (value & 0xFu) ^ (value >> 4);
+ value = (value & 0x3u) ^ (value >> 2);
+ value = (value & 0x1u) ^ (value >> 1);
+
+ return !!value;
+}
+
+} // namespace WTF
</ins></span></pre></div>
<a id="branchessafari603branchSourceWTFwtfSplitTesth"></a>
<div class="addfile"><h4>Added: branches/safari-603-branch/Source/WTF/wtf/SplitTest.h (0 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/WTF/wtf/SplitTest.h (rev 0)
+++ branches/safari-603-branch/Source/WTF/wtf/SplitTest.h 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -0,0 +1,60 @@
</span><ins>+/*
+ * Copyright (C) 2017 Apple Inc. All Rights Reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#pragma once
+
+#include <limits>
+#include <wtf/ExportMacros.h>
+#include <wtf/NeverDestroyed.h>
+#include <wtf/Optional.h>
+
+namespace WTF {
+
+class SplitTest {
+ WTF_MAKE_FAST_ALLOCATED;
+ friend class WTF::NeverDestroyed<SplitTest>;
+public:
+ WTF_EXPORT static SplitTest& singleton();
+
+ WTF_EXPORT void initializeSingleton(uint64_t lo, uint64_t hi);
+
+ // FIXME: Query with a per-experiment unique ID to determine which experiment
+ // bucket the user should fall into. It's important to "salt" with unique
+ // experiment IDs so that users don't all fall in the same set of experiments
+ // when there are multiple experiments.
+ // Also add a version which returns a number in a provided [min, max] range,
+ // which is more useful for bucketed experiments.
+ // https://bugs.webkit.org/show_bug.cgi?id=168467
+ WTF_EXPORT std::optional<bool> enableBooleanExperiment();
+
+private:
+ uint64_t m_lo;
+ uint64_t m_hi;
+ bool m_initialized { false };
+};
+
+} // namespace WTF
+
+using WTF::SplitTest;
</ins></span></pre></div>
<a id="branchessafari603branchSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (212659 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/WebCore/ChangeLog 2017-02-20 18:32:37 UTC (rev 212659)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2017-02-17 Matthew Hanson <matthew_hanson@apple.com>
+
+ A/B test concurrent GC
+ https://bugs.webkit.org/show_bug.cgi?id=168453
+ <rdar://problem/30553220>
+
+ Landed on behalf of JF Bastien.
+
+ Reviewed by Alexey Proskuryakov.
+
+ Initialize the WTF::SplitTest singleton using the anonymous UUID
+ from crash reporter. This makes it easy to figure out which A/B
+ split tests were enabled from a particular crash log.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/SplitTestInitializer.cpp: Added.
+ (getUUID):
+ (InitWebCoreSplitTest):
+ * platform/SplitTestInitializer.h: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm.
+
</ins><span class="cx"> 2017-02-20 Matthew Hanson <matthew_hanson@apple.com>
</span><span class="cx">
</span><span class="cx"> Merge r212652. rdar://problem/30435303
</span></span></pre></div>
<a id="branchessafari603branchSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: branches/safari-603-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj (212659 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-02-20 18:32:37 UTC (rev 212659)
+++ branches/safari-603-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -4538,6 +4538,8 @@
</span><span class="cx"> ABDDFE7A0A5C6E7000A3E11D /* RenderMenuList.h in Headers */ = {isa = PBXBuildFile; fileRef = ABDDFE740A5C6E7000A3E11D /* RenderMenuList.h */; };
</span><span class="cx"> AD03AAFA1468455300A39B5B /* CSSValue.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AD03AAF81468453900A39B5B /* CSSValue.cpp */; };
</span><span class="cx"> AD20B18D18E9D237005A8083 /* JSNodeListCustom.h in Headers */ = {isa = PBXBuildFile; fileRef = AD20B18C18E9D216005A8083 /* JSNodeListCustom.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><ins>+ AD412B241E57C766008AF157 /* SplitTestInitializer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AD412B221E57C6DE008AF157 /* SplitTestInitializer.cpp */; };
+ AD412B251E57C773008AF157 /* SplitTestInitializer.h in Headers */ = {isa = PBXBuildFile; fileRef = AD412B231E57C6DE008AF157 /* SplitTestInitializer.h */; settings = {ATTRIBUTES = (Private, ); }; };
</ins><span class="cx"> AD4495F3141FC08900541EDF /* EventListenerMap.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AD4495F1141FC08900541EDF /* EventListenerMap.cpp */; };
</span><span class="cx"> AD4495F4141FC08900541EDF /* EventListenerMap.h in Headers */ = {isa = PBXBuildFile; fileRef = AD4495F2141FC08900541EDF /* EventListenerMap.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><span class="cx"> AD49914318F0815100BF0092 /* HTMLUnknownElement.h in Headers */ = {isa = PBXBuildFile; fileRef = AD49914118F0815100BF0092 /* HTMLUnknownElement.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><span class="lines">@@ -12291,6 +12293,8 @@
</span><span class="cx"> ABDDFE740A5C6E7000A3E11D /* RenderMenuList.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = RenderMenuList.h; sourceTree = "<group>"; };
</span><span class="cx"> AD03AAF81468453900A39B5B /* CSSValue.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CSSValue.cpp; sourceTree = "<group>"; };
</span><span class="cx"> AD20B18C18E9D216005A8083 /* JSNodeListCustom.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSNodeListCustom.h; sourceTree = "<group>"; };
</span><ins>+ AD412B221E57C6DE008AF157 /* SplitTestInitializer.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SplitTestInitializer.cpp; sourceTree = "<group>"; };
+ AD412B231E57C6DE008AF157 /* SplitTestInitializer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SplitTestInitializer.h; sourceTree = "<group>"; };
</ins><span class="cx"> AD4495F1141FC08900541EDF /* EventListenerMap.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = EventListenerMap.cpp; sourceTree = "<group>"; };
</span><span class="cx"> AD4495F2141FC08900541EDF /* EventListenerMap.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EventListenerMap.h; sourceTree = "<group>"; };
</span><span class="cx"> AD49914118F0815100BF0092 /* HTMLUnknownElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HTMLUnknownElement.h; sourceTree = "<group>"; };
</span><span class="lines">@@ -22554,6 +22558,8 @@
</span><span class="cx"> BCF1A5BA097832090061A123 /* platform */ = {
</span><span class="cx"> isa = PBXGroup;
</span><span class="cx"> children = (
</span><ins>+ AD412B221E57C6DE008AF157 /* SplitTestInitializer.cpp */,
+ AD412B231E57C6DE008AF157 /* SplitTestInitializer.h */,
</ins><span class="cx"> 49E912A40EFAC8E6009D0CAF /* animation */,
</span><span class="cx"> FD31604012B026A300C1A359 /* audio */,
</span><span class="cx"> 1AE42F670AA4B8CB00C8612D /* cf */,
</span><span class="lines">@@ -28327,6 +28333,7 @@
</span><span class="cx"> 5B30695E18B3D3450099D5E8 /* WebGLDrawBuffers.h in Headers */,
</span><span class="cx"> 6EBF0E5512A8929800DB1709 /* WebGLExtension.h in Headers */,
</span><span class="cx"> 49C7B9CF1042D32F0009D447 /* WebGLFramebuffer.h in Headers */,
</span><ins>+ AD412B251E57C773008AF157 /* SplitTestInitializer.h in Headers */,
</ins><span class="cx"> 6E47E66110B7944B00B186C8 /* WebGLGetInfo.h in Headers */,
</span><span class="cx"> 463763091E26FDD7008CD46D /* CPUTime.h in Headers */,
</span><span class="cx"> 49FFBF3F11C93EE3006A7118 /* WebGLLayer.h in Headers */,
</span><span class="lines">@@ -30924,6 +30931,7 @@
</span><span class="cx"> 1A58E86D1D19E42D00C0EA73 /* PaymentCoordinator.cpp in Sources */,
</span><span class="cx"> 1ADA4A1C1D22F2C0005A9A15 /* PaymentMerchantSessionCocoa.mm in Sources */,
</span><span class="cx"> 1A8A646E1D19FF8700D0E00F /* PaymentMethodCocoa.mm in Sources */,
</span><ins>+ AD412B241E57C766008AF157 /* SplitTestInitializer.cpp in Sources */,
</ins><span class="cx"> 1A58E8671D19D80E00C0EA73 /* PaymentRequest.cpp in Sources */,
</span><span class="cx"> 1A8A64671D19FDFF00D0E00F /* PaymentRequestValidator.cpp in Sources */,
</span><span class="cx"> B27535640B053814002CE64F /* PDFDocumentImage.cpp in Sources */,
</span></span></pre></div>
<a id="branchessafari603branchSourceWebCoreplatformSplitTestInitializercpp"></a>
<div class="addfile"><h4>Added: branches/safari-603-branch/Source/WebCore/platform/SplitTestInitializer.cpp (0 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/WebCore/platform/SplitTestInitializer.cpp (rev 0)
+++ branches/safari-603-branch/Source/WebCore/platform/SplitTestInitializer.cpp 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -0,0 +1,120 @@
</span><ins>+/*
+ * Copyright (C) 2017 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "SplitTestInitializer.h"
+
+#if OS(DARWIN) && USE(APPLE_INTERNAL_SDK)
+
+#include <dlfcn.h>
+#include <mutex>
+#include <WebCore/SoftLinking.h>
+#include <wtf/ASCIICType.h>
+#include <wtf/Optional.h>
+#include <wtf/SplitTest.h>
+
+SOFT_LINK_PRIVATE_FRAMEWORK(CrashReporterSupport);
+SOFT_LINK(CrashReporterSupport, CRGetUserUUID, CFStringRef, (void), ());
+
+namespace {
+
+struct UUID {
+ uint64_t lo;
+ uint64_t hi;
+};
+
+std::optional<UUID> getUUID()
+{
+ // The UUID we're about to obtain contains 128-bit of data, encoded as a
+ // hexadecimal ASCII string with the following format:
+ // FFFFFFFF-FFFF-FFFF-FFFF-FFFFFFFFFFFF
+ static constexpr const size_t maxBytes = 37;
+ static bool failed = true;
+ static UUID uuid = { 0, 0 };
+ static std::once_flag once;
+
+ std::call_once(once, [] {
+ // Always soft-fail, which will simply disable split testing.
+
+ char userUUID[maxBytes] = { '\0' };
+ CFStringRef (*softLinkCRGetUserUUID)(void) = (CFStringRef (*)(void)) dlsym(CrashReporterSupportLibrary(), "CRGetUserUUID");
+ if (!softLinkCRGetUserUUID)
+ return;
+
+ CFStringRef userUUIDString = CRGetUserUUID();
+ CFIndex length = CFStringGetLength(userUUIDString);
+ CFRange range = CFRangeMake(0, length);
+ CFIndex numConvertedCharacters = CFStringGetBytes(userUUIDString, range, kCFStringEncodingASCII, 0, false, reinterpret_cast<UInt8*>(userUUID), maxBytes - 1, nullptr);
+ if (numConvertedCharacters <= 0 || static_cast<size_t>(numConvertedCharacters) >= maxBytes)
+ return;
+
+ size_t nibblesDecoded = 0;
+ for (size_t position = 0; position < maxBytes; ++position) {
+ uint64_t nibble;
+ int c = toASCIILowerUnchecked(userUUID[position]);
+
+ if (c >= 'a' && c <= 'f')
+ nibble = c - 'a' + 10;
+ else if (c >= '0' && c <= '9')
+ nibble = c - '0';
+ else
+ continue; // Ignore non-hexdecimal ASCII nibbles.
+
+ if (nibblesDecoded < 64 / 4) {
+ uuid.lo <<= 4;
+ uuid.lo |= nibble;
+ } else {
+ uuid.hi <<= 4;
+ uuid.hi |= nibble;
+ }
+
+ ++nibblesDecoded;
+ }
+
+ failed = false;
+ });
+
+ return failed ? std::optional<UUID>() : uuid;
+}
+
+} // anonymous namespace
+
+void initSplitTest()
+{
+ std::optional<UUID> uuid = getUUID();
+ if (!uuid)
+ return;
+
+ SplitTest::singleton().initializeSingleton(uuid->lo, uuid->hi);
+}
+
+#else
+
+void initSplitTest()
+{
+ // Don't do split testing on other platforms.
+}
+
+#endif
</ins></span></pre></div>
<a id="branchessafari603branchSourceWebCoreplatformSplitTestInitializerhfromrev212658branchessafari603branchSourceWebKit2WebProcessEntryPointmacXPCServiceWebContentServiceEntryPointmm"></a>
<div class="copfile"><h4>Copied: branches/safari-603-branch/Source/WebCore/platform/SplitTestInitializer.h (from rev 212658, branches/safari-603-branch/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm) (0 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/WebCore/platform/SplitTestInitializer.h (rev 0)
+++ branches/safari-603-branch/Source/WebCore/platform/SplitTestInitializer.h 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -0,0 +1,34 @@
</span><ins>+/*
+ * Copyright (C) 2017 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+WEBCORE_EXPORT void initSplitTest(void);
+
+#ifdef __cplusplus
+}
+#endif
</ins></span></pre></div>
<a id="branchessafari603branchSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-603-branch/Source/WebKit2/ChangeLog (212659 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/WebKit2/ChangeLog 2017-02-20 18:32:37 UTC (rev 212659)
+++ branches/safari-603-branch/Source/WebKit2/ChangeLog 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2017-02-17 Matthew Hanson <matthew_hanson@apple.com>
</span><span class="cx">
</span><ins>+ A/B test concurrent GC
+ https://bugs.webkit.org/show_bug.cgi?id=168453
+ <rdar://problem/30553220>
+
+ Landed on behalf of JF Bastien.
+
+ Reviewed by Alexey Proskuryakov.
+
+ Initialize WTF::SplitTest early enough that other initialization
+ can use it.
+
+ * WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
+ (WebContentServiceInitializer):
+
+2017-02-17 Matthew Hanson <matthew_hanson@apple.com>
+
</ins><span class="cx"> Merge r212244. rdar://problem/23676252
</span><span class="cx">
</span><span class="cx"> 2017-02-13 Antti Koivisto <antti@apple.com>
</span></span></pre></div>
<a id="branchessafari603branchSourceWebKit2WebProcessEntryPointmacXPCServiceWebContentServiceEntryPointmm"></a>
<div class="modfile"><h4>Modified: branches/safari-603-branch/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm (212659 => 212660)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm 2017-02-20 18:32:37 UTC (rev 212659)
+++ branches/safari-603-branch/Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm 2017-02-20 18:33:19 UTC (rev 212660)
</span><span class="lines">@@ -30,6 +30,8 @@
</span><span class="cx"> #import "WebProcess.h"
</span><span class="cx"> #import "XPCServiceEntryPoint.h"
</span><span class="cx">
</span><ins>+#import <WebCore/SplitTestInitializer.h>
+
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> #import <WebCore/GraphicsServicesSPI.h>
</span><span class="cx"> #import <WebCore/WebCoreThreadSystemInterface.h>
</span><span class="lines">@@ -51,5 +53,9 @@
</span><span class="cx"> InitWebCoreThreadSystemInterface();
</span><span class="cx"> #endif // PLATFORM(IOS)
</span><span class="cx">
</span><ins>+ // Initialize split testing early, so that other initialization can
+ // determine which experiments to run.
+ initSplitTest();
+
</ins><span class="cx"> XPCServiceInitializer<WebProcess, XPCServiceInitializerDelegate>(adoptOSObject(connection), initializerMessage, priorityBoostMessage);
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>