<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212610] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212610">212610</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-02-18 23:22:35 -0800 (Sat, 18 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre><input type=range readonly> doesn't act per spec
https://bugs.webkit.org/show_bug.cgi?id=168422
<rdar://problem/30593189>
Reviewed by Ryosuke Niwa.
Source/WebCore:
'readonly' attribute should not apply to <input type=range> as per the HTML
specification:
- https://html.spec.whatwg.org/#the-input-element:attr-input-readonly-3
Firefox and Edge already behave as per the specification.
No new tests, updated existing tests.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::handleTouchEvent):
(WebCore::RangeInputType::handleKeydownEvent):
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):
LayoutTests:
Update / rebaseline existing tests to reflect behavior change.
* fast/forms/range/range-drag-expected.txt:
* fast/forms/range/range-drag-when-toggled-disabled-expected.txt:
* fast/forms/range/range-drag-when-toggled-disabled.html:
* fast/forms/range/range-drag.html:
* fast/forms/range/range-keyoperation-expected.txt:
* fast/forms/range/range-keyoperation.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastformsrangerangedragexpectedtxt">trunk/LayoutTests/fast/forms/range/range-drag-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastformsrangerangedragwhentoggleddisabledexpectedtxt">trunk/LayoutTests/fast/forms/range/range-drag-when-toggled-disabled-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastformsrangerangedragwhentoggleddisabledhtml">trunk/LayoutTests/fast/forms/range/range-drag-when-toggled-disabled.html</a></li>
<li><a href="#trunkLayoutTestsfastformsrangerangedraghtml">trunk/LayoutTests/fast/forms/range/range-drag.html</a></li>
<li><a href="#trunkLayoutTestsfastformsrangerangekeyoperationexpectedtxt">trunk/LayoutTests/fast/forms/range/range-keyoperation-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastformsrangerangekeyoperationhtml">trunk/LayoutTests/fast/forms/range/range-keyoperation.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlRangeInputTypecpp">trunk/Source/WebCore/html/RangeInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowSliderThumbElementcpp">trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (212609 => 212610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-02-18 23:58:57 UTC (rev 212609)
+++ trunk/LayoutTests/ChangeLog 2017-02-19 07:22:35 UTC (rev 212610)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2017-02-18 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ <input type=range readonly> doesn't act per spec
+ https://bugs.webkit.org/show_bug.cgi?id=168422
+ <rdar://problem/30593189>
+
+ Reviewed by Ryosuke Niwa.
+
+ Update / rebaseline existing tests to reflect behavior change.
+
+ * fast/forms/range/range-drag-expected.txt:
+ * fast/forms/range/range-drag-when-toggled-disabled-expected.txt:
+ * fast/forms/range/range-drag-when-toggled-disabled.html:
+ * fast/forms/range/range-drag.html:
+ * fast/forms/range/range-keyoperation-expected.txt:
+ * fast/forms/range/range-keyoperation.html:
+
+2017-02-18 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Recursive MessagePort.postMessage() calls causes tab to become unresponsive
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168548
</span><span class="cx"> <rdar://problem/29808005>
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsrangerangedragexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/forms/range/range-drag-expected.txt (212609 => 212610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/range/range-drag-expected.txt 2017-02-18 23:58:57 UTC (rev 212609)
+++ trunk/LayoutTests/fast/forms/range/range-drag-expected.txt 2017-02-19 07:22:35 UTC (rev 212610)
</span><span class="lines">@@ -6,13 +6,13 @@
</span><span class="cx"> PASS inputEventCounter is >= lastInputEventCounter + 1
</span><span class="cx"> PASS changeEventCounter is lastChangeEventCounter + 1
</span><span class="cx"> readOnly=true
</span><del>-PASS input.value is "50"
-PASS lastInputEventCounter is inputEventCounter
-PASS lastChangeEventCounter is changeEventCounter
</del><ins>+PASS input.value is "100"
+PASS inputEventCounter is >= lastInputEventCounter + 1
+PASS changeEventCounter is lastChangeEventCounter + 1
</ins><span class="cx"> disabled=true
</span><span class="cx"> PASS input.value is "50"
</span><del>-PASS lastInputEventCounter is inputEventCounter
-PASS lastChangeEventCounter is changeEventCounter
</del><ins>+PASS inputEventCounter is lastInputEventCounter
+PASS changeEventCounter is lastChangeEventCounter
</ins><span class="cx">
</span><span class="cx"> Tests for range dragging from edge
</span><span class="cx"> readOnly=false, disabled=false
</span><span class="lines">@@ -20,13 +20,13 @@
</span><span class="cx"> PASS inputEventCounter is >= lastInputEventCounter + 1
</span><span class="cx"> PASS changeEventCounter is lastChangeEventCounter + 1
</span><span class="cx"> readOnly=true
</span><del>-PASS input.value is "50"
-PASS lastInputEventCounter is inputEventCounter
-PASS lastChangeEventCounter is changeEventCounter
</del><ins>+PASS input.value is "100"
+PASS inputEventCounter is >= lastInputEventCounter + 1
+PASS changeEventCounter is lastChangeEventCounter + 1
</ins><span class="cx"> disabled=true
</span><span class="cx"> PASS input.value is "50"
</span><del>-PASS lastInputEventCounter is inputEventCounter
-PASS lastChangeEventCounter is changeEventCounter
</del><ins>+PASS inputEventCounter is lastInputEventCounter
+PASS changeEventCounter is lastChangeEventCounter
</ins><span class="cx">
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsrangerangedragwhentoggleddisabledexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/forms/range/range-drag-when-toggled-disabled-expected.txt (212609 => 212610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/range/range-drag-when-toggled-disabled-expected.txt 2017-02-18 23:58:57 UTC (rev 212609)
+++ trunk/LayoutTests/fast/forms/range/range-drag-when-toggled-disabled-expected.txt 2017-02-19 07:22:35 UTC (rev 212610)
</span><span class="lines">@@ -7,8 +7,8 @@
</span><span class="cx"> PASS input.value is "0"
</span><span class="cx"> PASS inputEventCounter is >= lastInputEventCounter + 1
</span><span class="cx"> readOnly=true
</span><del>-PASS input.value is "0"
-PASS lastInputEventCounter is inputEventCounter
</del><ins>+PASS input.value is "100"
+PASS inputEventCounter is lastInputEventCounter + 1
</ins><span class="cx">
</span><span class="cx"> Tests for range dragging while it toggles to be disabled.
</span><span class="cx"> readOnly=false, disabled=false
</span><span class="lines">@@ -18,7 +18,7 @@
</span><span class="cx"> PASS inputEventCounter is >= lastInputEventCounter + 1
</span><span class="cx"> disabled=true
</span><span class="cx"> PASS input.value is "0"
</span><del>-PASS lastInputEventCounter is inputEventCounter
</del><ins>+PASS inputEventCounter is lastInputEventCounter
</ins><span class="cx">
</span><span class="cx"> PASS changeEventCounter is 1
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsrangerangedragwhentoggleddisabledhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/forms/range/range-drag-when-toggled-disabled.html (212609 => 212610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/range/range-drag-when-toggled-disabled.html 2017-02-18 23:58:57 UTC (rev 212609)
+++ trunk/LayoutTests/fast/forms/range/range-drag-when-toggled-disabled.html 2017-02-19 07:22:35 UTC (rev 212610)
</span><span class="lines">@@ -71,9 +71,14 @@
</span><span class="cx"> // Attempt to drag to right edge. Should not change.
</span><span class="cx"> lastInputEventCounter = inputEventCounter;
</span><span class="cx"> dragToRightEdge();
</span><del>- shouldBe('input.value', '"0"');
- shouldBe('lastInputEventCounter', 'inputEventCounter');
</del><span class="cx">
</span><ins>+ if (field == 'disabled') {
+ shouldBeEqualToString('input.value', '0');
+ shouldBe('inputEventCounter', 'lastInputEventCounter');
+ } else {
+ shouldBeEqualToString('input.value', '100');
+ shouldBe('inputEventCounter', 'lastInputEventCounter + 1');
+ }
</ins><span class="cx"> stopDrag();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsrangerangedraghtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/forms/range/range-drag.html (212609 => 212610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/range/range-drag.html 2017-02-18 23:58:57 UTC (rev 212609)
+++ trunk/LayoutTests/fast/forms/range/range-drag.html 2017-02-19 07:22:35 UTC (rev 212610)
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx"> lastInputEventCounter = inputEventCounter;
</span><span class="cx"> lastChangeEventCounter = changeEventCounter;
</span><span class="cx"> dragMouse();
</span><del>- shouldBe('input.value', '"100"');
</del><ins>+ shouldBeEqualToString('input.value', '100');
</ins><span class="cx"> shouldBeGreaterThanOrEqual('inputEventCounter', 'lastInputEventCounter + 1');
</span><span class="cx"> shouldBe('changeEventCounter', 'lastChangeEventCounter + 1');
</span><span class="cx">
</span><span class="lines">@@ -60,9 +60,9 @@
</span><span class="cx"> lastInputEventCounter = inputEventCounter;
</span><span class="cx"> lastChangeEventCounter = changeEventCounter;
</span><span class="cx"> dragMouse();
</span><del>- shouldBe('input.value', '"50"');
- shouldBe('lastInputEventCounter', 'inputEventCounter');
- shouldBe('lastChangeEventCounter', 'changeEventCounter');
</del><ins>+ shouldBeEqualToString('input.value', '100');
+ shouldBeGreaterThanOrEqual('inputEventCounter', 'lastInputEventCounter + 1');
+ shouldBe('changeEventCounter', 'lastChangeEventCounter + 1');
</ins><span class="cx">
</span><span class="cx"> debug('disabled=true');
</span><span class="cx"> input.readOnly = false;
</span><span class="lines">@@ -71,9 +71,9 @@
</span><span class="cx"> lastInputEventCounter = inputEventCounter;
</span><span class="cx"> lastChangeEventCounter = changeEventCounter;
</span><span class="cx"> dragMouse();
</span><del>- shouldBe('input.value', '"50"');
- shouldBe('lastInputEventCounter', 'inputEventCounter');
- shouldBe('lastChangeEventCounter', 'changeEventCounter');
</del><ins>+ shouldBeEqualToString('input.value', '50');
+ shouldBe('inputEventCounter', 'lastInputEventCounter');
+ shouldBe('changeEventCounter', 'lastChangeEventCounter');
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var parent = document.createElement('div');
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsrangerangekeyoperationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/forms/range/range-keyoperation-expected.txt (212609 => 212610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/range/range-keyoperation-expected.txt 2017-02-18 23:58:57 UTC (rev 212609)
+++ trunk/LayoutTests/fast/forms/range/range-keyoperation-expected.txt 2017-02-19 07:22:35 UTC (rev 212610)
</span><span class="lines">@@ -99,9 +99,9 @@
</span><span class="cx"> PASS input.value is "1"
</span><span class="cx"> PASS input.value is "1"
</span><span class="cx"> PASS input.value is "1"
</span><del>-PASS input.value is "1"
-PASS input.value is "1"
-PASS input.value is "1"
</del><ins>+PASS input.value is "2"
+PASS input.value is "100"
+PASS input.value is "100"
</ins><span class="cx">
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsrangerangekeyoperationhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/forms/range/range-keyoperation.html (212609 => 212610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/range/range-keyoperation.html 2017-02-18 23:58:57 UTC (rev 212609)
+++ trunk/LayoutTests/fast/forms/range/range-keyoperation.html 2017-02-19 07:22:35 UTC (rev 212610)
</span><span class="lines">@@ -257,11 +257,11 @@
</span><span class="cx">
</span><span class="cx"> input.readOnly = true;
</span><span class="cx"> sendKey(input, 'Up');
</span><del>-shouldBe('input.value', '"1"');
</del><ins>+shouldBeEqualToString('input.value', '2');
</ins><span class="cx"> sendKey(input, 'Home');
</span><del>-shouldBe('input.value', '"1"');
</del><ins>+shouldBeEqualToString('input.value', '100');
</ins><span class="cx"> sendKey(input, 'PageUp');
</span><del>-shouldBe('input.value', '"1"');
</del><ins>+shouldBeEqualToString('input.value', '100');
</ins><span class="cx"> input.readOnly = false;
</span><span class="cx">
</span><span class="cx"> debug('');
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (212609 => 212610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-02-18 23:58:57 UTC (rev 212609)
+++ trunk/Source/WebCore/ChangeLog 2017-02-19 07:22:35 UTC (rev 212610)
</span><span class="lines">@@ -1,5 +1,30 @@
</span><span class="cx"> 2017-02-18 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ <input type=range readonly> doesn't act per spec
+ https://bugs.webkit.org/show_bug.cgi?id=168422
+ <rdar://problem/30593189>
+
+ Reviewed by Ryosuke Niwa.
+
+ 'readonly' attribute should not apply to <input type=range> as per the HTML
+ specification:
+ - https://html.spec.whatwg.org/#the-input-element:attr-input-readonly-3
+
+ Firefox and Edge already behave as per the specification.
+
+ No new tests, updated existing tests.
+
+ * html/RangeInputType.cpp:
+ (WebCore::RangeInputType::handleMouseDownEvent):
+ (WebCore::RangeInputType::handleTouchEvent):
+ (WebCore::RangeInputType::handleKeydownEvent):
+ * html/shadow/SliderThumbElement.cpp:
+ (WebCore::SliderThumbElement::defaultEventHandler):
+ (WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
+ (WebCore::SliderThumbElement::willRespondToMouseClickEvents):
+
+2017-02-18 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Recursive MessagePort.postMessage() calls causes tab to become unresponsive
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168548
</span><span class="cx"> <rdar://problem/29808005>
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlRangeInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/RangeInputType.cpp (212609 => 212610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/RangeInputType.cpp 2017-02-18 23:58:57 UTC (rev 212609)
+++ trunk/Source/WebCore/html/RangeInputType.cpp 2017-02-19 07:22:35 UTC (rev 212610)
</span><span class="lines">@@ -136,7 +136,7 @@
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> void RangeInputType::handleMouseDownEvent(MouseEvent& event)
</span><span class="cx"> {
</span><del>- if (element().isDisabledOrReadOnly())
</del><ins>+ if (element().isDisabledFormControl())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> Node* targetNode = event.target()->toNode();
</span><span class="lines">@@ -158,7 +158,7 @@
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> typedSliderThumbElement().handleTouchEvent(event);
</span><span class="cx"> #elif ENABLE(TOUCH_SLIDER)
</span><del>- if (element().isDisabledOrReadOnly())
</del><ins>+ if (element().isDisabledFormControl())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (event.type() == eventNames().touchendEvent) {
</span><span class="lines">@@ -193,7 +193,7 @@
</span><span class="cx">
</span><span class="cx"> void RangeInputType::handleKeydownEvent(KeyboardEvent& event)
</span><span class="cx"> {
</span><del>- if (element().isDisabledOrReadOnly())
</del><ins>+ if (element().isDisabledFormControl())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> const String& key = event.keyIdentifier();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowSliderThumbElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp (212609 => 212610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2017-02-18 23:58:57 UTC (rev 212609)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2017-02-19 07:22:35 UTC (rev 212610)
</span><span class="lines">@@ -352,7 +352,7 @@
</span><span class="cx"> // FIXME: Should handle this readonly/disabled check in more general way.
</span><span class="cx"> // Missing this kind of check is likely to occur elsewhere if adding it in each shadow element.
</span><span class="cx"> HTMLInputElement* input = hostInput();
</span><del>- if (!input || input->isDisabledOrReadOnly()) {
</del><ins>+ if (!input || input->isDisabledFormControl()) {
</ins><span class="cx"> stopDragging();
</span><span class="cx"> HTMLDivElement::defaultEventHandler(event);
</span><span class="cx"> return;
</span><span class="lines">@@ -385,7 +385,7 @@
</span><span class="cx"> bool SliderThumbElement::willRespondToMouseMoveEvents()
</span><span class="cx"> {
</span><span class="cx"> const HTMLInputElement* input = hostInput();
</span><del>- if (input && !input->isDisabledOrReadOnly() && m_inDragMode)
</del><ins>+ if (input && !input->isDisabledFormControl() && m_inDragMode)
</ins><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> return HTMLDivElement::willRespondToMouseMoveEvents();
</span><span class="lines">@@ -394,7 +394,7 @@
</span><span class="cx"> bool SliderThumbElement::willRespondToMouseClickEvents()
</span><span class="cx"> {
</span><span class="cx"> const HTMLInputElement* input = hostInput();
</span><del>- if (input && !input->isDisabledOrReadOnly())
</del><ins>+ if (input && !input->isDisabledFormControl())
</ins><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> return HTMLDivElement::willRespondToMouseClickEvents();
</span></span></pre>
</div>
</div>
</body>
</html>