<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212552] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212552">212552</a></dd>
<dt>Author</dt> <dd>aakash_jain@apple.com</dd>
<dt>Date</dt> <dd>2017-02-17 09:09:52 -0800 (Fri, 17 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix tools that were broken by Efl removal
https://bugs.webkit.org/show_bug.cgi?id=168496
Reviewed by Alexey Proskuryakov.
* QueueStatusServer/config/queues.py:
* Scripts/webkitpy/common/config/ews.json:
* TestResultServer/static-dashboards/builders.jsonp:
* TestResultServer/static-dashboards/flakiness_dashboard.js:
* TestResultServer/static-dashboards/loader_unittests.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsQueueStatusServerconfigqueuespy">trunk/Tools/QueueStatusServer/config/queues.py</a></li>
<li><a href="#trunkToolsScriptswebkitpycommonconfigewsjson">trunk/Tools/Scripts/webkitpy/common/config/ews.json</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsbuildersjsonp">trunk/Tools/TestResultServer/static-dashboards/builders.jsonp</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsflakiness_dashboardjs">trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsloader_unittestsjs">trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (212551 => 212552)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-02-17 16:25:56 UTC (rev 212551)
+++ trunk/Tools/ChangeLog 2017-02-17 17:09:52 UTC (rev 212552)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-02-17 Aakash Jain <aakash_jain@apple.com>
+
+ Fix tools that were broken by Efl removal
+ https://bugs.webkit.org/show_bug.cgi?id=168496
+
+ Reviewed by Alexey Proskuryakov.
+
+ * QueueStatusServer/config/queues.py:
+ * Scripts/webkitpy/common/config/ews.json:
+ * TestResultServer/static-dashboards/builders.jsonp:
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+ * TestResultServer/static-dashboards/loader_unittests.js:
+
</ins><span class="cx"> 2017-02-16 Lucas Forschler <lforschler@apple.com>
</span><span class="cx">
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168442
</span></span></pre></div>
<a id="trunkToolsQueueStatusServerconfigqueuespy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/QueueStatusServer/config/queues.py (212551 => 212552)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/QueueStatusServer/config/queues.py 2017-02-17 16:25:56 UTC (rev 212551)
+++ trunk/Tools/QueueStatusServer/config/queues.py 2017-02-17 17:09:52 UTC (rev 212552)
</span><span class="lines">@@ -41,7 +41,6 @@
</span><span class="cx"> "mac-debug-ews",
</span><span class="cx"> "mac-32bit-ews",
</span><span class="cx"> "win-ews",
</span><del>- "efl-wk2-ews",
</del><span class="cx"> ]
</span><span class="cx">
</span><span class="cx"> # If the patch is still active after this much time, then a bot must have frozen or rebooted,
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpycommonconfigewsjson"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/common/config/ews.json (212551 => 212552)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/common/config/ews.json 2017-02-17 16:25:56 UTC (rev 212551)
+++ trunk/Tools/Scripts/webkitpy/common/config/ews.json 2017-02-17 17:09:52 UTC (rev 212552)
</span><span class="lines">@@ -5,12 +5,6 @@
</span><span class="cx"> "xan.lopez@gmail.com"
</span><span class="cx"> ]
</span><span class="cx"> },
</span><del>- "EFL WK2 EWS": {
- "port": "efl-wk2",
- "watchers": [
- "gyuyoung.kim@webkit.org"
- ]
- },
</del><span class="cx"> "Win EWS": {
</span><span class="cx"> "port": "win",
</span><span class="cx"> "watchers": [
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsbuildersjsonp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/builders.jsonp (212551 => 212552)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/builders.jsonp 2017-02-17 16:25:56 UTC (rev 212551)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.jsonp 2017-02-17 17:09:52 UTC (rev 212552)
</span><span class="lines">@@ -21,9 +21,9 @@
</span><span class="cx"> "Apple iOS 10 Simulator Debug WK2 (Tests)",
</span><span class="cx"> "Apple iOS 10 Simulator Release WK1 (Tests)",
</span><span class="cx"> "Apple iOS 10 Simulator Release WK2 (Tests)",
</span><del>- "EFL Linux 64-bit Release WK2",
</del><span class="cx"> "GTK Linux 64-bit Debug (Tests)",
</span><del>- "GTK Linux 64-bit Release (Tests)"
</del><ins>+ "GTK Linux 64-bit Release (Tests)",
+ "GTK Linux 64-bit Release Wayland (Tests)"
</ins><span class="cx"> ]
</span><span class="cx"> }
</span><span class="cx"> },
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsflakiness_dashboardjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (212551 => 212552)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2017-02-17 16:25:56 UTC (rev 212551)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2017-02-17 17:09:52 UTC (rev 212552)
</span><span class="lines">@@ -77,16 +77,6 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> },
</span><del>- 'EFL': {
- expectationsDirectory: 'efl',
- subPlatforms: {
- 'LINUX': {
- subPlatforms: {
- 'WK2': { fallbackPlatforms: ['EFL', 'WK2'], expectationsDirectory: 'efl-wk2' }
- }
- }
- }
- },
</del><span class="cx"> 'WK2': {
</span><span class="cx"> basePlatform: true,
</span><span class="cx"> expectationsDirectory: 'wk2'
</span><span class="lines">@@ -360,8 +350,6 @@
</span><span class="cx"> return determineWKPlatform(builderNameUpperCase, 'APPLE_IOS_SIMULATOR');
</span><span class="cx"> if (string.contains(builderNameUpperCase, 'GTK LINUX'))
</span><span class="cx"> return determineWKPlatform(builderNameUpperCase, 'GTK_LINUX');
</span><del>- if (string.contains(builderNameUpperCase, 'EFL'))
- return determineWKPlatform(builderNameUpperCase, 'EFL_LINUX');
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function platformAndBuildType(builderName)
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsloader_unittestsjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js (212551 => 212552)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js 2017-02-17 16:25:56 UTC (rev 212551)
+++ trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js 2017-02-17 17:09:52 UTC (rev 212552)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx"> test('expectations files loading', 1, function() {
</span><span class="cx"> resetGlobals();
</span><span class="cx"> g_history.parseCrossDashboardParameters();
</span><del>- var expectedLoadedPlatforms = ["efl", "efl-wk2", "gtk", "gtk-wk2",
</del><ins>+ var expectedLoadedPlatforms = ["gtk", "gtk-wk2",
</ins><span class="cx"> "mac", "mac-lion", "mac-wk2", "mac-wk2", "win", "wk2"];
</span><span class="cx"> var loadedPlatforms = [];
</span><span class="cx"> var resourceLoader = new loader.Loader();
</span></span></pre>
</div>
</div>
</body>
</html>