<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212470] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212470">212470</a></dd>
<dt>Author</dt> <dd>achristensen@apple.com</dd>
<dt>Date</dt> <dd>2017-02-16 15:13:45 -0800 (Thu, 16 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Special URLs without a host are invalid
https://bugs.webkit.org/show_bug.cgi?id=168461
Reviewed by Tim Horton.
LayoutTests/imported/w3c:
* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:
Source/WebCore:
http://? should be invalid. This matches Chrome and the spec and the intent of my implementation
of URLParser which already fails with urls like http:// and this was just an oversight.
Covered by newly passing web platform tests. Updated API tests.
* platform/URLParser.cpp:
(WebCore::URLParser::parse):
Tools:
* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
LayoutTests:
* fast/dom/DOMURL/set-href-attribute-protocol.html:
* fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js:
Rebase tests. The HTMLAnchorElement test is a little strange, but it'll be cleaned up once
url-setters.html in the web platform tests is cleaned up.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomDOMURLsethrefattributeprotocolhtml">trunk/LayoutTests/fast/dom/DOMURL/set-href-attribute-protocol.html</a></li>
<li><a href="#trunkLayoutTestsfastdomHTMLAnchorElementscripttestssethrefattributeprotocoljs">trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsurlaelementexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsurlaelementxhtmlexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsurlurlconstructorexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformURLParsercpp">trunk/Source/WebCore/platform/URLParser.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebCoreURLParsercpp">trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (212469 => 212470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2017-02-16 23:09:42 UTC (rev 212469)
+++ trunk/LayoutTests/ChangeLog        2017-02-16 23:13:45 UTC (rev 212470)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-02-16 Alex Christensen <achristensen@webkit.org>
+
+ Special URLs without a host are invalid
+ https://bugs.webkit.org/show_bug.cgi?id=168461
+
+ Reviewed by Tim Horton.
+
+ * fast/dom/DOMURL/set-href-attribute-protocol.html:
+ * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js:
+ Rebase tests. The HTMLAnchorElement test is a little strange, but it'll be cleaned up once
+ url-setters.html in the web platform tests is cleaned up.
+
</ins><span class="cx"> 2017-02-16 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Skip imported/w3c/web-platform-tests/resource-timing/rt-resource-ignored.html.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomDOMURLsethrefattributeprotocolhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/DOMURL/set-href-attribute-protocol.html (212469 => 212470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/DOMURL/set-href-attribute-protocol.html        2017-02-16 23:09:42 UTC (rev 212469)
+++ trunk/LayoutTests/fast/dom/DOMURL/set-href-attribute-protocol.html        2017-02-16 23:13:45 UTC (rev 212470)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx"> debug("Set protocol to http on malformed URL");
</span><span class="cx"> a.href = "foo:??bar";
</span><span class="cx"> a.protocol = "http";
</span><del>-shouldBe("a.href", "'http://??bar'");
</del><ins>+shouldBe("a.href", "'foo:??bar'");
</ins><span class="cx">
</span><span class="cx"> // IE8 keeps the protocol if it is 'c:'.
</span><span class="cx"> debug("Set protocol to a URL which points to a local file");
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLAnchorElementscripttestssethrefattributeprotocoljs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js (212469 => 212470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js        2017-02-16 23:09:42 UTC (rev 212469)
+++ trunk/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js        2017-02-16 23:13:45 UTC (rev 212470)
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> debug("Set protocol to http on malformed URL");
</span><span class="cx"> a.href = "foo:??bar";
</span><span class="cx"> a.protocol = "http";
</span><del>-shouldBe("a.href", "'http://??bar'");
</del><ins>+shouldBe("a.href", "'http:??bar'");
</ins><span class="cx">
</span><span class="cx"> // IE8 keeps the protocol if it is 'c:'.
</span><span class="cx"> debug("Set protocol to a URL which points to a local file");
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (212469 => 212470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog        2017-02-16 23:09:42 UTC (rev 212469)
+++ trunk/LayoutTests/imported/w3c/ChangeLog        2017-02-16 23:13:45 UTC (rev 212470)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-02-16 Alex Christensen <achristensen@webkit.org>
+
+ Special URLs without a host are invalid
+ https://bugs.webkit.org/show_bug.cgi?id=168461
+
+ Reviewed by Tim Horton.
+
+ * web-platform-tests/url/a-element-expected.txt:
+ * web-platform-tests/url/a-element-xhtml-expected.txt:
+ * web-platform-tests/url/url-constructor-expected.txt:
+
</ins><span class="cx"> 2017-02-16 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> [Resource Timing] Support Resource Timing in Workers
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsurlaelementexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt (212469 => 212470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt        2017-02-16 23:09:42 UTC (rev 212469)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt        2017-02-16 23:13:45 UTC (rev 212470)
</span><span class="lines">@@ -394,8 +394,8 @@
</span><span class="cx"> PASS Parsing: <file:?q=v> against <about:blank>
</span><span class="cx"> PASS Parsing: <file:#frag> against <about:blank>
</span><span class="cx"> PASS Parsing: <http://[1:0::]> against <http://example.net/>
</span><del>-FAIL Parsing: <http://?> against <about:blank> assert_unreached: Expected URL to fail parsing Reached unreachable code
-FAIL Parsing: <http://#> against <about:blank> assert_unreached: Expected URL to fail parsing Reached unreachable code
</del><ins>+PASS Parsing: <http://?> against <about:blank>
+PASS Parsing: <http://#> against <about:blank>
</ins><span class="cx"> PASS Parsing: <sc://ñ> against <about:blank>
</span><span class="cx"> PASS Parsing: <sc://ñ?x> against <about:blank>
</span><span class="cx"> PASS Parsing: <sc://ñ#x> against <about:blank>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsurlaelementxhtmlexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt (212469 => 212470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt        2017-02-16 23:09:42 UTC (rev 212469)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt        2017-02-16 23:13:45 UTC (rev 212470)
</span><span class="lines">@@ -394,8 +394,8 @@
</span><span class="cx"> PASS Parsing: <file:?q=v> against <about:blank>
</span><span class="cx"> PASS Parsing: <file:#frag> against <about:blank>
</span><span class="cx"> PASS Parsing: <http://[1:0::]> against <http://example.net/>
</span><del>-FAIL Parsing: <http://?> against <about:blank> assert_unreached: Expected URL to fail parsing Reached unreachable code
-FAIL Parsing: <http://#> against <about:blank> assert_unreached: Expected URL to fail parsing Reached unreachable code
</del><ins>+PASS Parsing: <http://?> against <about:blank>
+PASS Parsing: <http://#> against <about:blank>
</ins><span class="cx"> PASS Parsing: <sc://ñ> against <about:blank>
</span><span class="cx"> PASS Parsing: <sc://ñ?x> against <about:blank>
</span><span class="cx"> PASS Parsing: <sc://ñ#x> against <about:blank>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsurlurlconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt (212469 => 212470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt        2017-02-16 23:09:42 UTC (rev 212469)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt        2017-02-16 23:13:45 UTC (rev 212470)
</span><span class="lines">@@ -402,12 +402,8 @@
</span><span class="cx"> PASS Parsing: <file:?q=v> against <about:blank>
</span><span class="cx"> PASS Parsing: <file:#frag> against <about:blank>
</span><span class="cx"> PASS Parsing: <http://[1:0::]> against <http://example.net/>
</span><del>-FAIL Parsing: <http://?> against <about:blank> assert_throws: function "function () {
- bURL(expected.input, expected.base)
- }" did not throw
-FAIL Parsing: <http://#> against <about:blank> assert_throws: function "function () {
- bURL(expected.input, expected.base)
- }" did not throw
</del><ins>+PASS Parsing: <http://?> against <about:blank>
+PASS Parsing: <http://#> against <about:blank>
</ins><span class="cx"> PASS Parsing: <sc://ñ> against <about:blank>
</span><span class="cx"> PASS Parsing: <sc://ñ?x> against <about:blank>
</span><span class="cx"> PASS Parsing: <sc://ñ#x> against <about:blank>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (212469 => 212470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2017-02-16 23:09:42 UTC (rev 212469)
+++ trunk/Source/WebCore/ChangeLog        2017-02-16 23:13:45 UTC (rev 212470)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2017-02-16 Alex Christensen <achristensen@webkit.org>
+
+ Special URLs without a host are invalid
+ https://bugs.webkit.org/show_bug.cgi?id=168461
+
+ Reviewed by Tim Horton.
+
+ http://? should be invalid. This matches Chrome and the spec and the intent of my implementation
+ of URLParser which already fails with urls like http:// and this was just an oversight.
+ Covered by newly passing web platform tests. Updated API tests.
+
+ * platform/URLParser.cpp:
+ (WebCore::URLParser::parse):
+
</ins><span class="cx"> 2017-02-16 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Simple line layout: Add support for pagination.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformURLParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/URLParser.cpp (212469 => 212470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/URLParser.cpp        2017-02-16 23:09:42 UTC (rev 212469)
+++ trunk/Source/WebCore/platform/URLParser.cpp        2017-02-16 23:13:45 UTC (rev 212470)
</span><span class="lines">@@ -1449,6 +1449,8 @@
</span><span class="cx"> if (isSlash || *c == '?' || *c == '#') {
</span><span class="cx"> auto iterator = CodePointIterator<CharacterType>(authorityOrHostBegin, c);
</span><span class="cx"> if (iterator.atEnd()) {
</span><ins>+ if (m_urlIsSpecial)
+ return failure();
</ins><span class="cx"> m_url.m_userEnd = currentPosition(c);
</span><span class="cx"> m_url.m_passwordEnd = m_url.m_userEnd;
</span><span class="cx"> m_url.m_hostEnd = m_url.m_userEnd;
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (212469 => 212470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog        2017-02-16 23:09:42 UTC (rev 212469)
+++ trunk/Tools/ChangeLog        2017-02-16 23:13:45 UTC (rev 212470)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2017-02-16 Alex Christensen <achristensen@webkit.org>
+
+ Special URLs without a host are invalid
+ https://bugs.webkit.org/show_bug.cgi?id=168461
+
+ Reviewed by Tim Horton.
+
+ * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
+ (TestWebKitAPI::TEST_F):
+
</ins><span class="cx"> 2017-02-10 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> The collector thread should only start when the mutator doesn't have heap access
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebCoreURLParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp (212469 => 212470)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp        2017-02-16 23:09:42 UTC (rev 212469)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp        2017-02-16 23:13:45 UTC (rev 212470)
</span><span class="lines">@@ -919,11 +919,13 @@
</span><span class="cx"> {"", "", "", "", 0, "", "", "", "http://:"},
</span><span class="cx"> {"http", "", "", "", 0, "/", "", "", "http://:/"});
</span><span class="cx"> checkURLDifferences("http:##foo",
</span><del>- {"http", "", "", "", 0, "", "", "#foo", "http://##foo"},
</del><ins>+ {"", "", "", "", 0, "", "", "", "http:##foo"},
</ins><span class="cx"> {"http", "", "", "", 0, "/", "", "#foo", "http:/##foo"});
</span><span class="cx"> checkURLDifferences("http:??bar",
</span><del>- {"http", "", "", "", 0, "", "?bar", "", "http://??bar"},
</del><ins>+ {"", "", "", "", 0, "", "", "", "http:??bar"},
</ins><span class="cx"> {"http", "", "", "", 0, "/", "?bar", "", "http:/??bar"});
</span><ins>+ checkURL("asdf:##foo", {"asdf", "", "", "", 0, "", "", "#foo", "asdf:##foo"});
+ checkURL("asdf:??bar", {"asdf", "", "", "", 0, "", "?bar", "", "asdf:??bar"});
</ins><span class="cx"> checkRelativeURLDifferences("//C|/foo/bar", "file:///tmp/mock/path",
</span><span class="cx"> {"file", "", "", "", 0, "/C:/foo/bar", "", "", "file:///C:/foo/bar"},
</span><span class="cx"> {"", "", "", "", 0, "", "", "", "//C|/foo/bar"});
</span></span></pre>
</div>
</div>
</body>
</html>