<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212393] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212393">212393</a></dd>
<dt>Author</dt> <dd>wenson_hsieh@apple.com</dd>
<dt>Date</dt> <dd>2017-02-15 13:50:10 -0800 (Wed, 15 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Editing history scripts should not add the contenteditable attribute or override key events
https://bugs.webkit.org/show_bug.cgi?id=168389
<rdar://problem/30529945>
Reviewed by Dan Bernstein.
Clients that hook into editing history tracking should handle setting the contenteditable attribute on the body
rather than have the script add it to the body. Additionally, this script should NOT be overriding any keydown
events. These were initially added for compatibility with a test harness early on, and should have been removed
earlier.
* Scripts/DumpEditingHistory.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreScriptsDumpEditingHistoryjs">trunk/Source/WebCore/Scripts/DumpEditingHistory.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (212392 => 212393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-02-15 21:22:37 UTC (rev 212392)
+++ trunk/Source/WebCore/ChangeLog 2017-02-15 21:50:10 UTC (rev 212393)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2017-02-15 Wenson Hsieh <wenson_hsieh@apple.com>
+
+ Editing history scripts should not add the contenteditable attribute or override key events
+ https://bugs.webkit.org/show_bug.cgi?id=168389
+ <rdar://problem/30529945>
+
+ Reviewed by Dan Bernstein.
+
+ Clients that hook into editing history tracking should handle setting the contenteditable attribute on the body
+ rather than have the script add it to the body. Additionally, this script should NOT be overriding any keydown
+ events. These were initially added for compatibility with a test harness early on, and should have been removed
+ earlier.
+
+ * Scripts/DumpEditingHistory.js:
+
</ins><span class="cx"> 2017-02-15 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> Pass "RequiresCustomURLLoading" in AVURLAsset options dictionary
</span></span></pre></div>
<a id="trunkSourceWebCoreScriptsDumpEditingHistoryjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Scripts/DumpEditingHistory.js (212392 => 212393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Scripts/DumpEditingHistory.js 2017-02-15 21:22:37 UTC (rev 212392)
+++ trunk/Source/WebCore/Scripts/DumpEditingHistory.js 2017-02-15 21:50:10 UTC (rev 212393)
</span><span class="lines">@@ -41,7 +41,6 @@
</span><span class="cx"> lastKnownSelectionState = newSelectionState;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- document.body.setAttribute("contenteditable", true);
</del><span class="cx"> document.body.addEventListener("focus", () => {
</span><span class="cx"> if (initialized)
</span><span class="cx"> return;
</span><span class="lines">@@ -58,6 +57,7 @@
</span><span class="cx"> document.addEventListener("selectionchange", () => {
</span><span class="cx"> appendSelectionUpdateIfNecessary();
</span><span class="cx"> });
</span><ins>+
</ins><span class="cx"> document.addEventListener("beforeinput", event => {
</span><span class="cx"> appendDOMUpdatesFromRecords(mutationObserver.takeRecords());
</span><span class="cx"> beginProcessingTopLevelUpdate();
</span><span class="lines">@@ -70,17 +70,6 @@
</span><span class="cx"> endProcessingTopLevelUpdate(new EditingHistory.InputEventUpdate(globalNodeMap, currentChildUpdates, event.inputType, eventData, event.timeStamp));
</span><span class="cx"> });
</span><span class="cx">
</span><del>- document.addEventListener("keydown", event => {
- if (event.key !== "s" || !event.metaKey)
- return;
-
- let fakeLink = document.createElement("a");
- fakeLink.setAttribute("href", "data:text/plain;charset=utf-8," + encodeURIComponent(EditingHistory.getEditingHistoryAsJSONString()));
- fakeLink.setAttribute("download", "record.json");
- fakeLink.click();
- event.preventDefault();
- });
-
</del><span class="cx"> mutationObserver.observe(document, {
</span><span class="cx"> childList: true,
</span><span class="cx"> attributes: true,
</span></span></pre>
</div>
</div>
</body>
</html>