<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212404] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212404">212404</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2017-02-15 15:37:41 -0800 (Wed, 15 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Clean up WebProcessCreationParameters a little
https://bugs.webkit.org/show_bug.cgi?id=168349
Reviewed by Alex Christensen.
Initialize the data members better, and rearrange to group the types in a slightly more space-efficient manner.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
* Shared/WebProcessCreationParameters.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebProcessCreationParameterscpp">trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp</a></li>
<li><a href="#trunkSourceWebKit2SharedWebProcessCreationParametersh">trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (212403 => 212404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-02-15 23:32:35 UTC (rev 212403)
+++ trunk/Source/WebKit2/ChangeLog 2017-02-15 23:37:41 UTC (rev 212404)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-02-15 Simon Fraser <simon.fraser@apple.com>
+
+ Clean up WebProcessCreationParameters a little
+ https://bugs.webkit.org/show_bug.cgi?id=168349
+
+ Reviewed by Alex Christensen.
+
+ Initialize the data members better, and rearrange to group the types in a slightly more space-efficient manner.
+
+ * Shared/WebProcessCreationParameters.cpp:
+ (WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
+ * Shared/WebProcessCreationParameters.h:
+
</ins><span class="cx"> 2017-02-15 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r183937): Fullscreen Exit animation missing mask
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebProcessCreationParameterscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp (212403 => 212404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp 2017-02-15 23:32:35 UTC (rev 212403)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp 2017-02-15 23:37:41 UTC (rev 212404)
</span><span class="lines">@@ -35,20 +35,6 @@
</span><span class="cx"> namespace WebKit {
</span><span class="cx">
</span><span class="cx"> WebProcessCreationParameters::WebProcessCreationParameters()
</span><del>- : shouldAlwaysUseComplexTextCodePath(false)
- , shouldEnableMemoryPressureReliefLogging(false)
- , shouldUseFontSmoothing(true)
- , defaultRequestTimeoutInterval(INT_MAX)
-#if PLATFORM(COCOA)
- , shouldEnableJIT(false)
- , shouldEnableFTLJIT(false)
-#endif
- , memoryCacheDisabled(false)
-#if ENABLE(SERVICE_CONTROLS)
- , hasImageServices(false)
- , hasSelectionServices(false)
- , hasRichContentServices(false)
-#endif
</del><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebProcessCreationParametersh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h (212403 => 212404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h 2017-02-15 23:32:35 UTC (rev 212403)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h 2017-02-15 23:37:41 UTC (rev 212404)
</span><span class="lines">@@ -89,8 +89,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> String mediaKeyStorageDirectory;
</span><span class="cx">
</span><del>- bool shouldUseTestingNetworkSession;
-
</del><span class="cx"> Vector<String> urlSchemesRegisteredAsEmptyDocument;
</span><span class="cx"> Vector<String> urlSchemesRegisteredAsSecure;
</span><span class="cx"> Vector<String> urlSchemesRegisteredAsBypassingContentSecurityPolicy;
</span><span class="lines">@@ -102,48 +100,51 @@
</span><span class="cx"> Vector<String> urlSchemesRegisteredAsAlwaysRevalidated;
</span><span class="cx"> Vector<String> urlSchemesRegisteredAsCachePartitioned;
</span><span class="cx">
</span><ins>+ Vector<String> fontWhitelist;
+ Vector<String> languages;
+
</ins><span class="cx"> CacheModel cacheModel;
</span><span class="cx">
</span><del>- bool shouldAlwaysUseComplexTextCodePath;
- bool shouldEnableMemoryPressureReliefLogging;
</del><ins>+ double defaultRequestTimeoutInterval { INT_MAX };
+
+ bool shouldUseTestingNetworkSession { false };
+ bool shouldAlwaysUseComplexTextCodePath { false };
+ bool shouldEnableMemoryPressureReliefLogging { false };
</ins><span class="cx"> bool shouldSuppressMemoryPressureHandler { false };
</span><del>- bool shouldUseFontSmoothing;
</del><ins>+ bool shouldUseFontSmoothing { true };
</ins><span class="cx"> bool resourceLoadStatisticsEnabled { false };
</span><span class="cx"> bool urlParserEnabled { false };
</span><ins>+ bool iconDatabaseEnabled { false };
+ bool fullKeyboardAccessEnabled { false };
+ bool memoryCacheDisabled { false };
</ins><span class="cx">
</span><del>- Vector<String> fontWhitelist;
</del><ins>+#if ENABLE(SERVICE_CONTROLS)
+ bool hasImageServices { false };
+ bool hasSelectionServices { false };
+ bool hasRichContentServices { false };
+#endif
</ins><span class="cx">
</span><del>- bool iconDatabaseEnabled;
</del><ins>+ double terminationTimeout { 0 };
</ins><span class="cx">
</span><del>- double terminationTimeout;
-
- Vector<String> languages;
-
</del><span class="cx"> TextCheckerState textCheckerState;
</span><span class="cx">
</span><del>- bool fullKeyboardAccessEnabled;
-
- double defaultRequestTimeoutInterval;
-
</del><span class="cx"> #if PLATFORM(COCOA) || USE(CFURLCONNECTION)
</span><span class="cx"> String uiProcessBundleIdentifier;
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(COCOA)
</span><del>- pid_t presenterApplicationPid;
</del><ins>+ pid_t presenterApplicationPid { 0 };
</ins><span class="cx">
</span><del>- bool accessibilityEnhancedUserInterfaceEnabled;
-
</del><span class="cx"> WebCore::MachSendRight acceleratedCompositingPort;
</span><span class="cx">
</span><span class="cx"> String uiProcessBundleResourcePath;
</span><span class="cx"> SandboxExtension::Handle uiProcessBundleResourcePathExtensionHandle;
</span><span class="cx">
</span><del>- bool shouldEnableJIT;
- bool shouldEnableFTLJIT;
</del><ins>+ bool shouldEnableJIT { false };
+ bool shouldEnableFTLJIT { false };
+ bool accessibilityEnhancedUserInterfaceEnabled { false };
</ins><span class="cx">
</span><span class="cx"> RefPtr<API::Data> bundleParameterData;
</span><del>-
</del><span class="cx"> #endif // PLATFORM(COCOA)
</span><span class="cx">
</span><span class="cx"> #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
</span><span class="lines">@@ -153,14 +154,6 @@
</span><span class="cx"> HashMap<WebCore::SessionID, HashMap<unsigned, double>> plugInAutoStartOriginHashes;
</span><span class="cx"> Vector<String> plugInAutoStartOrigins;
</span><span class="cx">
</span><del>- bool memoryCacheDisabled;
-
-#if ENABLE(SERVICE_CONTROLS)
- bool hasImageServices;
- bool hasSelectionServices;
- bool hasRichContentServices;
-#endif
-
</del><span class="cx"> #if ENABLE(NETSCAPE_PLUGIN_API)
</span><span class="cx"> HashMap<String, HashMap<String, HashMap<String, uint8_t>>> pluginLoadClientPolicies;
</span><span class="cx"> #endif
</span></span></pre>
</div>
</div>
</body>
</html>