<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212306] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212306">212306</a></dd>
<dt>Author</dt> <dd>clopez@igalia.com</dd>
<dt>Date</dt> <dd>2017-02-14 10:07:39 -0800 (Tue, 14 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CMake] build-webkit should allow building with the default cmake configuration
https://bugs.webkit.org/show_bug.cgi?id=168323
Reviewed by Michael Catanzaro.
Add a --default-cmake-features switch that makes the script pass
no value for any of the features defined by build-webkit, that
way the default values from the port cmake config will be used.
* Scripts/build-webkit:
(cMakeArgsFromFeatures):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsbuildwebkit">trunk/Tools/Scripts/build-webkit</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (212305 => 212306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-02-14 17:51:25 UTC (rev 212305)
+++ trunk/Tools/ChangeLog 2017-02-14 18:07:39 UTC (rev 212306)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2017-02-14 Carlos Alberto Lopez Perez <clopez@igalia.com>
+
+ [CMake] build-webkit should allow building with the default cmake configuration
+ https://bugs.webkit.org/show_bug.cgi?id=168323
+
+ Reviewed by Michael Catanzaro.
+
+ Add a --default-cmake-features switch that makes the script pass
+ no value for any of the features defined by build-webkit, that
+ way the default values from the port cmake config will be used.
+
+ * Scripts/build-webkit:
+ (cMakeArgsFromFeatures):
+
</ins><span class="cx"> 2017-02-14 Jonathan Bedard <jbedard@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed build-fix after r212297.
</span></span></pre></div>
<a id="trunkToolsScriptsbuildwebkit"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/build-webkit (212305 => 212306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/build-webkit 2017-02-14 17:51:25 UTC (rev 212305)
+++ trunk/Tools/Scripts/build-webkit 2017-02-14 18:07:39 UTC (rev 212306)
</span><span class="lines">@@ -52,6 +52,7 @@
</span><span class="cx">
</span><span class="cx"> my $showHelp = 0;
</span><span class="cx"> my $clean = 0;
</span><ins>+my $defaultCMakeFeatures = 0;
</ins><span class="cx"> my $minimal = 0;
</span><span class="cx"> my $installHeaders;
</span><span class="cx"> my $installLibs;
</span><span class="lines">@@ -104,6 +105,7 @@
</span><span class="cx"> --cmakeargs=<arguments> One or more optional CMake flags (e.g. --cmakeargs="-DFOO=bar -DCMAKE_PREFIX_PATH=/usr/local")
</span><span class="cx">
</span><span class="cx"> --minimal No optional features, unless explicitly enabled
</span><ins>+ --default-cmake-features Use the default CMake features enabled for the port (CMake based ports)
</ins><span class="cx">
</span><span class="cx"> --only-webkit Build only the WebKit project
</span><span class="cx">
</span><span class="lines">@@ -121,6 +123,7 @@
</span><span class="cx"> 'only-webkit' => \$onlyWebKitProject,
</span><span class="cx"> 'coverage' => \$coverageSupport,
</span><span class="cx"> 'analyze' => \$shouldRunStaticAnalyzer,
</span><ins>+ 'default-cmake-features' => \$defaultCMakeFeatures,
</ins><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> # Build usage text and options list from features
</span><span class="lines">@@ -306,11 +309,13 @@
</span><span class="cx"> sub cMakeArgsFromFeatures()
</span><span class="cx"> {
</span><span class="cx"> my @args;
</span><del>- foreach (@features) {
- my $featureName = $_->{define};
- if ($featureName) {
- my $featureEnabled = ${$_->{value}} ? "ON" : "OFF";
- push @args, "-D$featureName=$featureEnabled";
</del><ins>+ if (!$defaultCMakeFeatures) {
+ foreach (@features) {
+ my $featureName = $_->{define};
+ if ($featureName) {
+ my $featureEnabled = ${$_->{value}} ? "ON" : "OFF";
+ push @args, "-D$featureName=$featureEnabled";
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> return @args;
</span></span></pre>
</div>
</div>
</body>
</html>