<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212270] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212270">212270</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-13 18:11:09 -0800 (Mon, 13 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Source/WebCore:
Added the other missing BSTR roles tag names.
https://bugs.webkit.org/show_bug.cgi?id=165545
Patch by Karim H <karim@karhm.com> on 2017-02-13
Reviewed by Chris Fleizach.
Test: accessibility/win/bstr-elements-role.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::shouldReturnTagNameAsRoleForMSAA):
LayoutTests:
Added the BSTR roles tag test for Windows.
https://bugs.webkit.org/show_bug.cgi?id=165545
Patch by Karim H <karim@karhm.com> on 2017-02-13
Reviewed by Chris Fleizach.
* accessibility/win/bstr-elements-role-expected.txt: Added.
* accessibility/win/bstr-elements-role.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsaccessibilitywinbstrelementsroleexpectedtxt">trunk/LayoutTests/accessibility/win/bstr-elements-role-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilitywinbstrelementsrolehtml">trunk/LayoutTests/accessibility/win/bstr-elements-role.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (212269 => 212270)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-02-14 02:09:03 UTC (rev 212269)
+++ trunk/LayoutTests/ChangeLog 2017-02-14 02:11:09 UTC (rev 212270)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2017-02-13 Karim H <karim@karhm.com>
+
+ Added the BSTR roles tag test for Windows.
+ https://bugs.webkit.org/show_bug.cgi?id=165545
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/win/bstr-elements-role-expected.txt: Added.
+ * accessibility/win/bstr-elements-role.html: Added.
+
</ins><span class="cx"> 2017-02-13 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> The current frame of an image should not deleted if another frame is asynchronously being decoded
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitywinbstrelementsroleexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/win/bstr-elements-role-expected.txt (0 => 212270)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/win/bstr-elements-role-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/win/bstr-elements-role-expected.txt 2017-02-14 02:11:09 UTC (rev 212270)
</span><span class="lines">@@ -0,0 +1,62 @@
</span><ins>+abbr
+
+acronym
+
+blockquote
+
+dd
+
+dl
+
+dt
+
+form
+
+frame
+
+h1
+
+h2
+
+h3
+
+h4
+
+h5
+
+h6
+
+iframe
+
+q
+
+tbody
+
+tfoot
+
+thead
+
+This test verifies that on Windows, the following elements: abbr, acronym, blockquote, dd, dl, dt, form, frame, h1, h2, h3, h4, h5, h6, iframe, q, tbody, tfoot, thead return their tag name for their 'role' property.
+
+Bug 165545 - WebCore::AccessibilityRenderObject add the other tag names that should be returned as the role
+
+PASS e.role is "AXRole: ABBR"
+PASS e.role is "AXRole: ACRONYM"
+PASS e.role is "AXRole: BLOCKQUOTE"
+PASS e.role is "AXRole: DD"
+PASS e.role is "AXRole: DL"
+PASS e.role is "AXRole: DT"
+PASS e.role is "AXRole: FORM"
+PASS e.role is "AXRole: FRAME"
+PASS e.role is "AXRole: H1"
+PASS e.role is "AXRole: H2"
+PASS e.role is "AXRole: H3"
+PASS e.role is "AXRole: H4"
+PASS e.role is "AXRole: H5"
+PASS e.role is "AXRole: H6"
+PASS e.role is "AXRole: IFRAME"
+PASS e.role is "AXRole: Q"
+PASS e.role is "AXRole: TBODY"
+PASS e.role is "AXRole: TFOOT"
+PASS e.role is "AXRole: THEAD"
+
</ins></span></pre></div>
<a id="trunkLayoutTestsaccessibilitywinbstrelementsrolehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/win/bstr-elements-role.html (0 => 212270)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/win/bstr-elements-role.html (rev 0)
+++ trunk/LayoutTests/accessibility/win/bstr-elements-role.html 2017-02-14 02:11:09 UTC (rev 212270)
</span><span class="lines">@@ -0,0 +1,105 @@
</span><ins>+<html>
+ <head>
+ <script src="../../resources/js-test-pre.js"></script>
+
+ <script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+ </script>
+ </head>
+ <body id="body">
+ <abbr>abbr</abbr>
+ <acronym>acronym</acronym>
+ <blockquote>blockquote</blockquote>
+ <dd>dd</dd>
+ <dl>dl</dl>
+ <dt>dt</dt>
+ <form>form</form>
+ <frame>frame</frame>
+ <h1>h1</h1>
+ <h2>h2</h2>
+ <h3>h3</h3>
+ <h4>h4</h4>
+ <h5>h5</h5>
+ <h6>h6</h6>
+ <iframe>iframe</iframe>
+ <q>q</q>
+ <tbody>tbody</tbody>
+ <tfoot>tfoot</tfoot>
+ <thead>thead</thead>
+
+
+ <p>
+ This test verifies that on Windows, the following elements: <b>abbr, acronym, blockquote, dd, dl, dt, form, frame, h1, h2, h3, h4, h5, h6,
+ iframe, q, tbody, tfoot, thead</b> return their
+ tag name for their 'role' property.
+ <br><br>
+ <a href="https://bugs.webkit.org/show_bug.cgi?id=165545">WebCore::AccessibilityRenderObject add the other tag names that should be returned as the role</a>
+ </p>
+
+ <p id="console"></p>
+
+ <script>
+ if (window.accessibilityController) {
+ document.getElementById("body").focus();
+
+ var e = accessibilityController.focusedElement.childAtIndex(0);
+ shouldBe('e.role', '"AXRole: ABBR"');
+
+ e = accessibilityController.focusedElement.childAtIndex(1);
+ shouldBe('e.role', '"AXRole: ACRONYM"');
+
+ e = accessibilityController.focusedElement.childAtIndex(2);
+ shouldBe('e.role', '"AXRole: BLOCKQUOTE"');
+
+ e = accessibilityController.focusedElement.childAtIndex(3);
+ shouldBe('e.role', '"AXRole: DD"');
+
+ e = accessibilityController.focusedElement.childAtIndex(4);
+ shouldBe('e.role', '"AXRole: DL"');
+
+ e = accessibilityController.focusedElement.childAtIndex(5);
+ shouldBe('e.role', '"AXRole: DT"');
+
+ e = accessibilityController.focusedElement.childAtIndex(6);
+ shouldBe('e.role', '"AXRole: FORM"');
+
+ e = accessibilityController.focusedElement.childAtIndex(7);
+ shouldBe('e.role', '"AXRole: FRAME"');
+
+ e = accessibilityController.focusedElement.childAtIndex(8);
+ shouldBe('e.role', '"AXRole: H1"');
+
+ e = accessibilityController.focusedElement.childAtIndex(9);
+ shouldBe('e.role', '"AXRole: H2"');
+
+ e = accessibilityController.focusedElement.childAtIndex(10);
+ shouldBe('e.role', '"AXRole: H3"');
+
+ e = accessibilityController.focusedElement.childAtIndex(11);
+ shouldBe('e.role', '"AXRole: H4"');
+
+ e = accessibilityController.focusedElement.childAtIndex(12);
+ shouldBe('e.role', '"AXRole: H5"');
+
+ e = accessibilityController.focusedElement.childAtIndex(13);
+ shouldBe('e.role', '"AXRole: H6"');
+
+ e = accessibilityController.focusedElement.childAtIndex(14);
+ shouldBe('e.role', '"AXRole: IFRAME"');
+
+ e = accessibilityController.focusedElement.childAtIndex(15);
+ shouldBe('e.role', '"AXRole: Q"');
+
+ e = accessibilityController.focusedElement.childAtIndex(16);
+ shouldBe('e.role', '"AXRole: TBODY"');
+
+ e = accessibilityController.focusedElement.childAtIndex(17);
+ shouldBe('e.role', '"AXRole: TFOOT"');
+
+ e = accessibilityController.focusedElement.childAtIndex(18);
+ shouldBe('e.role', '"AXRole: THEAD"');
+ }
+ </script>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (212269 => 212270)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-02-14 02:09:03 UTC (rev 212269)
+++ trunk/Source/WebCore/ChangeLog 2017-02-14 02:11:09 UTC (rev 212270)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-02-13 Karim H <karim@karhm.com>
+
+ Added the other missing BSTR roles tag names.
+ https://bugs.webkit.org/show_bug.cgi?id=165545
+
+ Reviewed by Chris Fleizach.
+
+ Test: accessibility/win/bstr-elements-role.html
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::shouldReturnTagNameAsRoleForMSAA):
+
</ins><span class="cx"> 2017-02-13 Youenn Fablet <youennf@gmail.com>
</span><span class="cx">
</span><span class="cx"> [WebRTC] Creating RTCPeerConnection with libwebrtc backend is crashing on rwt
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (212269 => 212270)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2017-02-14 02:09:03 UTC (rev 212269)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2017-02-14 02:11:09 UTC (rev 212270)
</span><span class="lines">@@ -3566,12 +3566,16 @@
</span><span class="cx">
</span><span class="cx"> static bool shouldReturnTagNameAsRoleForMSAA(const Element& element)
</span><span class="cx"> {
</span><del>- // See "document structure",
- // https://wiki.mozilla.org/Accessibility/AT-Windows-API
- // FIXME: Add the other tag names that should be returned as the role.
- return element.hasTagName(h1Tag) || element.hasTagName(h2Tag)
</del><ins>+ return element.hasTagName(abbrTag) || element.hasTagName(acronymTag)
+ || element.hasTagName(blockquoteTag) || element.hasTagName(ddTag)
+ || element.hasTagName(dlTag) || element.hasTagName(dtTag)
+ || element.hasTagName(formTag) || element.hasTagName(frameTag)
+ || element.hasTagName(h1Tag) || element.hasTagName(h2Tag)
</ins><span class="cx"> || element.hasTagName(h3Tag) || element.hasTagName(h4Tag)
</span><del>- || element.hasTagName(h5Tag) || element.hasTagName(h6Tag);
</del><ins>+ || element.hasTagName(h5Tag) || element.hasTagName(h6Tag)
+ || element.hasTagName(iframeTag) || element.hasTagName(qTag)
+ || element.hasTagName(tbodyTag) || element.hasTagName(tfootTag)
+ || element.hasTagName(theadTag);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String AccessibilityRenderObject::stringRoleForMSAA() const
</span></span></pre>
</div>
</div>
</body>
</html>