<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212215] branches/safari-603-branch/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212215">212215</a></dd>
<dt>Author</dt> <dd>bshafiei@apple.com</dd>
<dt>Date</dt> <dd>2017-02-12 18:32:23 -0800 (Sun, 12 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/211609">r211609</a>. rdar://problem/30479663</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari603branchSourceJavaScriptCoreChangeLog">branches/safari-603-branch/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#branchessafari603branchSourceJavaScriptCoretoolsVMInspectorcpp">branches/safari-603-branch/Source/JavaScriptCore/tools/VMInspector.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari603branchSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-603-branch/Source/JavaScriptCore/ChangeLog (212214 => 212215)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/JavaScriptCore/ChangeLog 2017-02-13 02:01:26 UTC (rev 212214)
+++ branches/safari-603-branch/Source/JavaScriptCore/ChangeLog 2017-02-13 02:32:23 UTC (rev 212215)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-02-12 Babak Shafiei <bshafiei@apple.com>
+
+ Merge r211609.
+
+ 2017-02-02 Mark Lam <mark.lam@apple.com>
+
+ Add a SIGILL crash analyzer to make debugging SIGILLs easier.
+ https://bugs.webkit.org/show_bug.cgi?id=167714
+ <rdar://problem/30318237>
+
+ Not reviewed.
+
+ Build fix for CLOOP build.
+
+ * tools/VMInspector.cpp:
+
</ins><span class="cx"> 2017-02-09 Matthew Hanson <matthew_hanson@apple.com>
</span><span class="cx">
</span><span class="cx"> Merge r212022. rdar://problem/30198083
</span><span class="lines">@@ -488,8 +504,8 @@
</span><span class="cx"> sum of the depths of its nodes, with a node's depth equal to the number
</span><span class="cx"> of frames in its associated call stack. For any stack trace,
</span><span class="cx">
</span><del>- S = { s𝟶, s𝟷, …, s𝑘 }, with endpoints s𝟶, s𝑘
- depth(S) = depth(s𝟶) + depth(s𝟷) + … + depth(s𝑘)
</del><ins>+ S = { sퟶ, sퟷ, …, s푘 }, with endpoints sퟶ, s푘
+ depth(S) = depth(sퟶ) + depth(sퟷ) + … + depth(s푘)
</ins><span class="cx">
</span><span class="cx"> A stack trace is truncated when it exceeds the maximum depth. Truncation
</span><span class="cx"> occurs on node boundaries, not call frames, consequently the maximum depth
</span><span class="lines">@@ -496,7 +512,7 @@
</span><span class="cx"> is more of a target than a guarantee:
</span><span class="cx">
</span><span class="cx"> d = maximum stack trace depth
</span><del>- for all S, depth(S) ≤ d + depth(s𝑘)
</del><ins>+ for all S, depth(S) ≤ d + depth(s푘)
</ins><span class="cx">
</span><span class="cx"> Because nodes can belong to multiple stack traces, it may be necessary
</span><span class="cx"> to clone the tail of a stack trace being truncated to prevent other traces
</span></span></pre></div>
<a id="branchessafari603branchSourceJavaScriptCoretoolsVMInspectorcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-603-branch/Source/JavaScriptCore/tools/VMInspector.cpp (212214 => 212215)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-603-branch/Source/JavaScriptCore/tools/VMInspector.cpp 2017-02-13 02:01:26 UTC (rev 212214)
+++ branches/safari-603-branch/Source/JavaScriptCore/tools/VMInspector.cpp 2017-02-13 02:32:23 UTC (rev 212215)
</span><span class="lines">@@ -84,6 +84,7 @@
</span><span class="cx"> return LockToken::LockedValue;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+#if ENABLE(JIT)
</ins><span class="cx"> static bool ensureIsSafeToLock(Lock& lock)
</span><span class="cx"> {
</span><span class="cx"> unsigned maxRetries = 2;
</span><span class="lines">@@ -98,9 +99,11 @@
</span><span class="cx"> }
</span><span class="cx"> return false;
</span><span class="cx"> };
</span><ins>+#endif // ENABLE(JIT)
</ins><span class="cx">
</span><span class="cx"> auto VMInspector::isValidExecutableMemory(VMInspector::LockToken, void* machinePC) -> Expected<bool, Error>
</span><span class="cx"> {
</span><ins>+#if ENABLE(JIT)
</ins><span class="cx"> bool found = false;
</span><span class="cx"> bool hasTimeout = false;
</span><span class="cx"> iterate([&] (VM& vm) -> FunctorStatus {
</span><span class="lines">@@ -124,10 +127,15 @@
</span><span class="cx"> if (!found && hasTimeout)
</span><span class="cx"> return makeUnexpected(Error::TimedOut);
</span><span class="cx"> return found;
</span><ins>+#else
+ UNUSED_PARAM(machinePC);
+ return false;
+#endif
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> auto VMInspector::codeBlockForMachinePC(VMInspector::LockToken, void* machinePC) -> Expected<CodeBlock*, Error>
</span><span class="cx"> {
</span><ins>+#if ENABLE(JIT)
</ins><span class="cx"> CodeBlock* codeBlock = nullptr;
</span><span class="cx"> bool hasTimeout = false;
</span><span class="cx"> iterate([&] (VM& vm) {
</span><span class="lines">@@ -178,6 +186,10 @@
</span><span class="cx"> if (!codeBlock && hasTimeout)
</span><span class="cx"> return makeUnexpected(Error::TimedOut);
</span><span class="cx"> return codeBlock;
</span><ins>+#else
+ UNUSED_PARAM(machinePC);
+ return nullptr;
+#endif
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace JSC
</span></span></pre>
</div>
</div>
</body>
</html>