<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212201] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212201">212201</a></dd>
<dt>Author</dt> <dd>weinig@apple.com</dd>
<dt>Date</dt> <dd>2017-02-11 20:59:10 -0800 (Sat, 11 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove custom bindings for XSLTProcessor.idl
https://bugs.webkit.org/show_bug.cgi?id=168174
Reviewed by Andreas Kling.
Source/WebCore:
* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSXSLTProcessorCustom.cpp: Removed.
Remove file.
* bindings/js/JSDOMBinding.cpp:
(WebCore::jsStringOrUndefined): Deleted.
* bindings/js/JSDOMBinding.h:
Remove now unused jsStringOrUndefined.
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::setParameter):
(WebCore::XSLTProcessor::getParameter):
(WebCore::XSLTProcessor::removeParameter):
* xml/XSLTProcessor.idl:
Replace custom bindings bindings with early returns. One subtle difference
between the custom bindings and this, is that getParameter will return
jsNull() rather than jsUndefined() for null String returns. This matches
all other bindings.
LayoutTests:
* fast/xsl/xslt-processor-expected.txt:
* fast/xsl/xslt-processor.html:
Update test / results for subtle new no-result behavior.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastxslxsltprocessorexpectedtxt">trunk/LayoutTests/fast/xsl/xslt-processor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastxslxsltprocessorhtml">trunk/LayoutTests/fast/xsl/xslt-processor.html</a></li>
<li><a href="#trunkSourceWebCoreCMakeListstxt">trunk/Source/WebCore/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSBindingsAllInOnecpp">trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMBindingcpp">trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMBindingh">trunk/Source/WebCore/bindings/js/JSDOMBinding.h</a></li>
<li><a href="#trunkSourceWebCorexmlXSLTProcessorcpp">trunk/Source/WebCore/xml/XSLTProcessor.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlXSLTProcessoridl">trunk/Source/WebCore/xml/XSLTProcessor.idl</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceWebCorebindingsjsJSXSLTProcessorCustomcpp">trunk/Source/WebCore/bindings/js/JSXSLTProcessorCustom.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (212200 => 212201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-02-12 04:14:22 UTC (rev 212200)
+++ trunk/LayoutTests/ChangeLog 2017-02-12 04:59:10 UTC (rev 212201)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-02-11 Sam Weinig <sam@webkit.org>
+
+ Remove custom bindings for XSLTProcessor.idl
+ https://bugs.webkit.org/show_bug.cgi?id=168174
+
+ Reviewed by Andreas Kling.
+
+ * fast/xsl/xslt-processor-expected.txt:
+ * fast/xsl/xslt-processor.html:
+ Update test / results for subtle new no-result behavior.
+
</ins><span class="cx"> 2017-02-11 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> LayoutTest fast/scrolling/page-cache-back-overflow-scroll-restore.html is a flaky failure
</span></span></pre></div>
<a id="trunkLayoutTestsfastxslxsltprocessorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/xsl/xslt-processor-expected.txt (212200 => 212201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/xsl/xslt-processor-expected.txt 2017-02-12 04:14:22 UTC (rev 212200)
+++ trunk/LayoutTests/fast/xsl/xslt-processor-expected.txt 2017-02-12 04:59:10 UTC (rev 212201)
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx"> 5.0 Value getParameter(in DOMString namespaceURI, in DOMString localName):
</span><span class="cx">
</span><span class="cx"> 5.1 pass getParameter an undefined name:
</span><del>-****Failure**** (expected exception, instead got result: "undefined")
</del><ins>+****Failure**** (expected exception, instead got result: "null")
</ins><span class="cx"> 5.2 pass getParameter a name which has not been set:
</span><span class="cx"> Success
</span><span class="cx"> 5.3 verify getParameter actually gets (and set sets):
</span></span></pre></div>
<a id="trunkLayoutTestsfastxslxsltprocessorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/xsl/xslt-processor.html (212200 => 212201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/xsl/xslt-processor.html 2017-02-12 04:14:22 UTC (rev 212200)
+++ trunk/LayoutTests/fast/xsl/xslt-processor.html 2017-02-12 04:59:10 UTC (rev 212201)
</span><span class="lines">@@ -244,7 +244,7 @@
</span><span class="cx"> // 5.2 pass getParameter a name which has not been set
</span><span class="cx">
</span><span class="cx"> var testname = "pass getParameter a name which has not been set";
</span><del>-addResultExpectValue(testname, processor.getParameter(undefined, "hasnotbeenset"), undefined);
</del><ins>+addResultExpectValue(testname, processor.getParameter(undefined, "hasnotbeenset"), null);
</ins><span class="cx">
</span><span class="cx"> // 5.3 verify getParameter actually gets (and set sets)
</span><span class="cx"> processor.setParameter(null, "test", "testValue");
</span><span class="lines">@@ -267,7 +267,7 @@
</span><span class="cx"> processor.setParameter(undefined, "test", "testValue");
</span><span class="cx"> processor.removeParameter(undefined, "test");
</span><span class="cx"> var testname = "verify removeParameter actually removes using undefined namespace";
</span><del>-addResultExpectValue(testname, processor.getParameter(null, "test"), undefined);
</del><ins>+addResultExpectValue(testname, processor.getParameter(null, "test"), null);
</ins><span class="cx">
</span><span class="cx"> // 6.3 pass removeParameter undefined name
</span><span class="cx">
</span><span class="lines">@@ -285,7 +285,7 @@
</span><span class="cx"> processor.setParameter(null, "test", "testValue");
</span><span class="cx"> processor.removeParameter(null, "test");
</span><span class="cx"> var testname = "verify removeParameter actually removes";
</span><del>-addResultExpectValue(testname, processor.getParameter(null, "test"), undefined);
</del><ins>+addResultExpectValue(testname, processor.getParameter(null, "test"), null);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -296,7 +296,7 @@
</span><span class="cx"> processor.setParameter(null, "test", "testValue");
</span><span class="cx"> processor.clearParameters();
</span><span class="cx"> var testname = "verify that clearParameters does";
</span><del>-addResultExpectValue(testname, processor.getParameter(null, "test"), undefined);
</del><ins>+addResultExpectValue(testname, processor.getParameter(null, "test"), null);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> // 8.0 void reset();
</span><span class="lines">@@ -308,7 +308,7 @@
</span><span class="cx">
</span><span class="cx"> // 8.1 call, verify that parameters are cleared after reset()
</span><span class="cx"> var testname = "verify that parameters have been cleared";
</span><del>-addResultExpectValue(testname, processor.getParameter(null, "test"), undefined);
</del><ins>+addResultExpectValue(testname, processor.getParameter(null, "test"), null);
</ins><span class="cx">
</span><span class="cx"> // 8.2 call, verify that stylesheet has been cleared after reset()
</span><span class="cx"> var testname = "verify that stylesheet has been cleared";
</span></span></pre></div>
<a id="trunkSourceWebCoreCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/CMakeLists.txt (212200 => 212201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/CMakeLists.txt 2017-02-12 04:14:22 UTC (rev 212200)
+++ trunk/Source/WebCore/CMakeLists.txt 2017-02-12 04:59:10 UTC (rev 212201)
</span><span class="lines">@@ -1190,7 +1190,6 @@
</span><span class="cx"> bindings/js/JSXMLHttpRequestCustom.cpp
</span><span class="cx"> bindings/js/JSXPathNSResolverCustom.cpp
</span><span class="cx"> bindings/js/JSXPathResultCustom.cpp
</span><del>- bindings/js/JSXSLTProcessorCustom.cpp
</del><span class="cx"> bindings/js/ReadableStreamDefaultController.cpp
</span><span class="cx"> bindings/js/ScheduledAction.cpp
</span><span class="cx"> bindings/js/ScriptCachedFrameData.cpp
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (212200 => 212201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-02-12 04:14:22 UTC (rev 212200)
+++ trunk/Source/WebCore/ChangeLog 2017-02-12 04:59:10 UTC (rev 212201)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2017-02-11 Sam Weinig <sam@webkit.org>
+
+ Remove custom bindings for XSLTProcessor.idl
+ https://bugs.webkit.org/show_bug.cgi?id=168174
+
+ Reviewed by Andreas Kling.
+
+ * CMakeLists.txt:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSBindingsAllInOne.cpp:
+ * bindings/js/JSXSLTProcessorCustom.cpp: Removed.
+ Remove file.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::jsStringOrUndefined): Deleted.
+ * bindings/js/JSDOMBinding.h:
+ Remove now unused jsStringOrUndefined.
+
+ * xml/XSLTProcessor.cpp:
+ (WebCore::XSLTProcessor::setParameter):
+ (WebCore::XSLTProcessor::getParameter):
+ (WebCore::XSLTProcessor::removeParameter):
+ * xml/XSLTProcessor.idl:
+ Replace custom bindings bindings with early returns. One subtle difference
+ between the custom bindings and this, is that getParameter will return
+ jsNull() rather than jsUndefined() for null String returns. This matches
+ all other bindings.
+
</ins><span class="cx"> 2017-02-11 Olivier Blin <olivier.blin@softathome.com>
</span><span class="cx">
</span><span class="cx"> [GStreamer][MSE][EME] Fix decryptor assignment
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (212200 => 212201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-02-12 04:14:22 UTC (rev 212200)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-02-12 04:59:10 UTC (rev 212201)
</span><span class="lines">@@ -5638,7 +5638,6 @@
</span><span class="cx"> BCEF45F60E687B5C001C1287 /* JSTextMetrics.h in Headers */ = {isa = PBXBuildFile; fileRef = BCEF45F40E687B5C001C1287 /* JSTextMetrics.h */; };
</span><span class="cx"> BCEF869F0E844E9D00A85CD5 /* ScrollbarThemeMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = BCEF869E0E844E9D00A85CD5 /* ScrollbarThemeMac.mm */; };
</span><span class="cx"> BCEFAF4E0C317E6900FA81F6 /* JSEventCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCEFAF4D0C317E6900FA81F6 /* JSEventCustom.cpp */; };
</span><del>- BCEFE1E50DCA5F3300739219 /* JSXSLTProcessorCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCEFE1E40DCA5F3300739219 /* JSXSLTProcessorCustom.cpp */; };
</del><span class="cx"> BCEFE1EA0DCA5F6400739219 /* JSXSLTProcessor.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCEFE1E80DCA5F6400739219 /* JSXSLTProcessor.cpp */; };
</span><span class="cx"> BCEFE1EB0DCA5F6400739219 /* JSXSLTProcessor.h in Headers */ = {isa = PBXBuildFile; fileRef = BCEFE1E90DCA5F6400739219 /* JSXSLTProcessor.h */; };
</span><span class="cx"> BCF34A3711A231CD00C71804 /* NamedNodeMap.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCF34A3611A231CD00C71804 /* NamedNodeMap.cpp */; };
</span><span class="lines">@@ -13692,7 +13691,6 @@
</span><span class="cx"> BCEF869E0E844E9D00A85CD5 /* ScrollbarThemeMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ScrollbarThemeMac.mm; sourceTree = "<group>"; };
</span><span class="cx"> BCEFAF4D0C317E6900FA81F6 /* JSEventCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSEventCustom.cpp; sourceTree = "<group>"; };
</span><span class="cx"> BCEFE1DC0DCA5CFD00739219 /* XSLTProcessor.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = XSLTProcessor.idl; sourceTree = "<group>"; };
</span><del>- BCEFE1E40DCA5F3300739219 /* JSXSLTProcessorCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSXSLTProcessorCustom.cpp; sourceTree = "<group>"; };
</del><span class="cx"> BCEFE1E80DCA5F6400739219 /* JSXSLTProcessor.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSXSLTProcessor.cpp; sourceTree = "<group>"; };
</span><span class="cx"> BCEFE1E90DCA5F6400739219 /* JSXSLTProcessor.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSXSLTProcessor.h; sourceTree = "<group>"; };
</span><span class="cx"> BCF34A3611A231CD00C71804 /* NamedNodeMap.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = NamedNodeMap.cpp; sourceTree = "<group>"; };
</span><span class="lines">@@ -22533,7 +22531,6 @@
</span><span class="cx"> E1CA5CBB0E8CDCAF00E8EF90 /* JSWorkerCustom.cpp */,
</span><span class="cx"> E18258AB0EF3CD7000933242 /* JSWorkerGlobalScopeCustom.cpp */,
</span><span class="cx"> BC348BBD0DB7F531004ABAB9 /* JSXMLHttpRequestCustom.cpp */,
</span><del>- BCEFE1E40DCA5F3300739219 /* JSXSLTProcessorCustom.cpp */,
</del><span class="cx"> );
</span><span class="cx"> name = Custom;
</span><span class="cx"> sourceTree = "<group>";
</span><span class="lines">@@ -31014,7 +31011,6 @@
</span><span class="cx"> 1A762C790A074F2600989F5B /* JSXPathResult.cpp in Sources */,
</span><span class="cx"> A1C7FAA2133A5D3500D6732D /* JSXPathResultCustom.cpp in Sources */,
</span><span class="cx"> BCEFE1EA0DCA5F6400739219 /* JSXSLTProcessor.cpp in Sources */,
</span><del>- BCEFE1E50DCA5F3300739219 /* JSXSLTProcessorCustom.cpp in Sources */,
</del><span class="cx"> 85031B430A44EFC700F992E0 /* KeyboardEvent.cpp in Sources */,
</span><span class="cx"> 517A63C31B74318700E7DCDC /* KeyedDecoderCF.cpp in Sources */,
</span><span class="cx"> 517A63C41B74318B00E7DCDC /* KeyedEncoderCF.cpp in Sources */,
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSBindingsAllInOnecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp (212200 => 212201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp 2017-02-12 04:14:22 UTC (rev 212200)
+++ trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp 2017-02-12 04:59:10 UTC (rev 212201)
</span><span class="lines">@@ -117,7 +117,6 @@
</span><span class="cx"> #include "JSXMLHttpRequestCustom.cpp"
</span><span class="cx"> #include "JSXPathNSResolverCustom.cpp"
</span><span class="cx"> #include "JSXPathResultCustom.cpp"
</span><del>-#include "JSXSLTProcessorCustom.cpp"
</del><span class="cx"> #include "ScheduledAction.cpp"
</span><span class="cx"> #include "ScriptCachedFrameData.cpp"
</span><span class="cx"> #include "ScriptController.cpp"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMBindingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp (212200 => 212201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp 2017-02-12 04:14:22 UTC (rev 212200)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp 2017-02-12 04:59:10 UTC (rev 212201)
</span><span class="lines">@@ -33,13 +33,6 @@
</span><span class="cx"> commonVM().addImpureProperty(propertyName);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-JSValue jsStringOrUndefined(ExecState* exec, const String& s)
-{
- if (s.isNull())
- return jsUndefined();
- return jsStringWithCache(exec, s);
-}
-
</del><span class="cx"> bool hasIteratorMethod(JSC::ExecState& state, JSC::JSValue value)
</span><span class="cx"> {
</span><span class="cx"> auto& vm = state.vm();
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMBindingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (212200 => 212201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2017-02-12 04:14:22 UTC (rev 212200)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2017-02-12 04:59:10 UTC (rev 212201)
</span><span class="lines">@@ -49,8 +49,6 @@
</span><span class="cx">
</span><span class="cx"> void addImpureProperty(const AtomicString&);
</span><span class="cx">
</span><del>-JSC::JSValue jsStringOrUndefined(JSC::ExecState*, const String&); // undefined if the string is null
-
</del><span class="cx"> WEBCORE_EXPORT bool hasIteratorMethod(JSC::ExecState&, JSC::JSValue);
</span><span class="cx">
</span><span class="cx"> template<JSC::NativeFunction nativeFunction, int length> JSC::EncodedJSValue nonCachingStaticFunctionGetter(JSC::ExecState* exec, JSC::EncodedJSValue, JSC::PropertyName propertyName)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSXSLTProcessorCustomcpp"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/bindings/js/JSXSLTProcessorCustom.cpp (212200 => 212201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSXSLTProcessorCustom.cpp 2017-02-12 04:14:22 UTC (rev 212200)
+++ trunk/Source/WebCore/bindings/js/JSXSLTProcessorCustom.cpp 2017-02-12 04:59:10 UTC (rev 212201)
</span><span class="lines">@@ -1,82 +0,0 @@
</span><del>-/*
- * Copyright (C) 2008 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- * 3. Neither the name of Apple Inc. ("Apple") nor the names of
- * its contributors may be used to endorse or promote products derived
- * from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-
-#if ENABLE(XSLT)
-
-#include "JSXSLTProcessor.h"
-
-#include "Document.h"
-#include "DocumentFragment.h"
-#include "JSDocument.h"
-#include "JSDocumentFragment.h"
-#include "JSNode.h"
-#include "Node.h"
-#include "XSLTProcessor.h"
-#include "JSDOMBinding.h"
-#include <wtf/text/WTFString.h>
-
-using namespace JSC;
-
-namespace WebCore {
-
-JSValue JSXSLTProcessor::setParameter(ExecState& state)
-{
- if (state.argument(1).isUndefinedOrNull() || state.argument(2).isUndefinedOrNull())
- return jsUndefined(); // Throw exception?
- String namespaceURI = state.uncheckedArgument(0).toWTFString(&state);
- String localName = state.uncheckedArgument(1).toWTFString(&state);
- String value = state.uncheckedArgument(2).toWTFString(&state);
- wrapped().setParameter(namespaceURI, localName, value);
- return jsUndefined();
-}
-
-JSValue JSXSLTProcessor::getParameter(ExecState& state)
-{
- if (state.argument(1).isUndefinedOrNull())
- return jsUndefined();
- String namespaceURI = state.uncheckedArgument(0).toWTFString(&state);
- String localName = state.uncheckedArgument(1).toWTFString(&state);
- String value = wrapped().getParameter(namespaceURI, localName);
- return jsStringOrUndefined(&state, value);
-}
-
-JSValue JSXSLTProcessor::removeParameter(ExecState& state)
-{
- if (state.argument(1).isUndefinedOrNull())
- return jsUndefined();
- String namespaceURI = state.uncheckedArgument(0).toWTFString(&state);
- String localName = state.uncheckedArgument(1).toWTFString(&state);
- wrapped().removeParameter(namespaceURI, localName);
- return jsUndefined();
-}
-
-} // namespace WebCore
-
-#endif // ENABLE(XSLT)
</del></span></pre></div>
<a id="trunkSourceWebCorexmlXSLTProcessorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XSLTProcessor.cpp (212200 => 212201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XSLTProcessor.cpp 2017-02-12 04:14:22 UTC (rev 212200)
+++ trunk/Source/WebCore/xml/XSLTProcessor.cpp 2017-02-12 04:59:10 UTC (rev 212201)
</span><span class="lines">@@ -141,6 +141,9 @@
</span><span class="cx">
</span><span class="cx"> void XSLTProcessor::setParameter(const String& /*namespaceURI*/, const String& localName, const String& value)
</span><span class="cx"> {
</span><ins>+ if (localName.isNull() || value.isNull())
+ return;
+
</ins><span class="cx"> // FIXME: namespace support?
</span><span class="cx"> // should make a QualifiedName here but we'd have to expose the impl
</span><span class="cx"> m_parameters.set(localName, value);
</span><span class="lines">@@ -148,6 +151,9 @@
</span><span class="cx">
</span><span class="cx"> String XSLTProcessor::getParameter(const String& /*namespaceURI*/, const String& localName) const
</span><span class="cx"> {
</span><ins>+ if (localName.isNull())
+ return { };
+
</ins><span class="cx"> // FIXME: namespace support?
</span><span class="cx"> // should make a QualifiedName here but we'd have to expose the impl
</span><span class="cx"> return m_parameters.get(localName);
</span><span class="lines">@@ -155,6 +161,9 @@
</span><span class="cx">
</span><span class="cx"> void XSLTProcessor::removeParameter(const String& /*namespaceURI*/, const String& localName)
</span><span class="cx"> {
</span><ins>+ if (localName.isNull())
+ return;
+
</ins><span class="cx"> // FIXME: namespace support?
</span><span class="cx"> m_parameters.remove(localName);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorexmlXSLTProcessoridl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XSLTProcessor.idl (212200 => 212201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XSLTProcessor.idl 2017-02-12 04:14:22 UTC (rev 212200)
+++ trunk/Source/WebCore/xml/XSLTProcessor.idl 2017-02-12 04:59:10 UTC (rev 212201)
</span><span class="lines">@@ -35,17 +35,14 @@
</span><span class="cx"> Constructor,
</span><span class="cx"> ImplementationLacksVTable,
</span><span class="cx"> ] interface XSLTProcessor {
</span><del>-
</del><span class="cx"> void importStylesheet(optional Node? stylesheet = null);
</span><span class="cx"> DocumentFragment transformToFragment(optional Node? source = null, optional Document? docVal = null);
</span><span class="cx"> Document transformToDocument(optional Node? source = null);
</span><span class="cx">
</span><del>- [Custom] void setParameter(DOMString namespaceURI, DOMString localName, DOMString value);
- [Custom] DOMString getParameter(DOMString namespaceURI, DOMString localName);
- [Custom] void removeParameter(DOMString namespaceURI, DOMString localName);
</del><ins>+ void setParameter(DOMString? namespaceURI, DOMString? localName, DOMString? value);
+ DOMString? getParameter(DOMString? namespaceURI, DOMString? localName);
+ void removeParameter(DOMString? namespaceURI, DOMString? localName);
</ins><span class="cx"> void clearParameters();
</span><span class="cx">
</span><span class="cx"> void reset();
</span><del>-
</del><span class="cx"> };
</span><del>-
</del></span></pre>
</div>
</div>
</body>
</html>