<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[212150] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/212150">212150</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-10 14:28:56 -0800 (Fri, 10 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Resource Timing] Enable Resource Timing by default in Tests
https://bugs.webkit.org/show_bug.cgi?id=168145
Reviewed by Ryosuke Niwa.
Source/WebCore:
* loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setResourceTimingEnabled): Deleted.
* testing/InternalSettings.h:
* testing/InternalSettings.idl:
No longer needed for tests.
Source/WebKit/mac:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences resourceTimingEnabled]):
(-[WebPreferences setResourceTimingEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/win:
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setResourceTimingEnabled):
(WebPreferences::resourceTimingEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetResourceTimingEnabled):
(WKPreferencesGetResourceTimingEnabled):
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
LayoutTests:
* fast/dom/Window/window-properties-performance-resource-timing.html:
* http/tests/misc/resource-timing-resolution.html:
* http/tests/performance/performance-resource-timing-cached-entries-expected.txt:
* http/tests/performance/performance-resource-timing-cached-entries.html:
* http/tests/performance/performance-resource-timing-entries-iterable.html:
* http/tests/performance/performance-resource-timing-entries.html:
* http/tests/performance/performance-resource-timing-initiator-css.html:
* http/tests/performance/performance-resource-timing-initiator-no-override.html:
* http/tests/performance/performance-resource-timing-xhr-single-entry.html:
* http/tests/preload/dynamic_remove_preload_href-expected.txt:
* http/tests/preload/dynamic_remove_preload_href.html:
* http/tests/preload/dynamic_removing_preload.html:
* http/tests/preload/not_evicting_preload_at_onload.html:
* http/tests/preload/single_download_preload-expected.txt:
* http/tests/preload/single_download_preload.html:
* resources/testharnessreport.js:
Eliminate the internals setResourceTimingEnabled way to toggle a runtime feature.
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:
Update results when ResourceTiming is enabled.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomWindowwindowpropertiesperformanceresourcetiminghtml">trunk/LayoutTests/fast/dom/Window/window-properties-performance-resource-timing.html</a></li>
<li><a href="#trunkLayoutTestshttptestsmiscresourcetimingresolutionhtml">trunk/LayoutTests/http/tests/misc/resource-timing-resolution.html</a></li>
<li><a href="#trunkLayoutTestshttptestsperformanceperformanceresourcetimingcachedentriesexpectedtxt">trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestsperformanceperformanceresourcetimingcachedentrieshtml">trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries.html</a></li>
<li><a href="#trunkLayoutTestshttptestsperformanceperformanceresourcetimingentriesiterablehtml">trunk/LayoutTests/http/tests/performance/performance-resource-timing-entries-iterable.html</a></li>
<li><a href="#trunkLayoutTestshttptestsperformanceperformanceresourcetimingentrieshtml">trunk/LayoutTests/http/tests/performance/performance-resource-timing-entries.html</a></li>
<li><a href="#trunkLayoutTestshttptestsperformanceperformanceresourcetiminginitiatorcsshtml">trunk/LayoutTests/http/tests/performance/performance-resource-timing-initiator-css.html</a></li>
<li><a href="#trunkLayoutTestshttptestsperformanceperformanceresourcetiminginitiatornooverridehtml">trunk/LayoutTests/http/tests/performance/performance-resource-timing-initiator-no-override.html</a></li>
<li><a href="#trunkLayoutTestshttptestsperformanceperformanceresourcetimingxhrsingleentryhtml">trunk/LayoutTests/http/tests/performance/performance-resource-timing-xhr-single-entry.html</a></li>
<li><a href="#trunkLayoutTestshttptestspreloaddynamic_remove_preload_hrefexpectedtxt">trunk/LayoutTests/http/tests/preload/dynamic_remove_preload_href-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestspreloaddynamic_remove_preload_hrefhtml">trunk/LayoutTests/http/tests/preload/dynamic_remove_preload_href.html</a></li>
<li><a href="#trunkLayoutTestshttptestspreloaddynamic_removing_preloadhtml">trunk/LayoutTests/http/tests/preload/dynamic_removing_preload.html</a></li>
<li><a href="#trunkLayoutTestshttptestspreloadnot_evicting_preload_at_onloadhtml">trunk/LayoutTests/http/tests/preload/not_evicting_preload_at_onload.html</a></li>
<li><a href="#trunkLayoutTestshttptestspreloadsingle_download_preloadexpectedtxt">trunk/LayoutTests/http/tests/preload/single_download_preload-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestspreloadsingle_download_preloadhtml">trunk/LayoutTests/http/tests/preload/single_download_preload.html</a></li>
<li><a href="#trunkLayoutTestsplatformefljsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkjsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacjsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacelcapitanjsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk1jsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacyosemitejsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformwinjsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsresourcestestharnessreportjs">trunk/LayoutTests/resources/testharnessreport.js</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreloaderResourceTimingInformationcpp">trunk/Source/WebCore/loader/ResourceTimingInformation.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingInternalSettingscpp">trunk/Source/WebCore/testing/InternalSettings.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingInternalSettingsh">trunk/Source/WebCore/testing/InternalSettings.h</a></li>
<li><a href="#trunkSourceWebCoretestingInternalSettingsidl">trunk/Source/WebCore/testing/InternalSettings.idl</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesmm">trunk/Source/WebKit/mac/WebView/WebPreferences.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinInterfacesIWebPreferencesPrivateidl">trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferenceKeysPrivateh">trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferencescpp">trunk/Source/WebKit/win/WebPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferencesh">trunk/Source/WebKit/win/WebPreferences.h</a></li>
<li><a href="#trunkSourceWebKitwinWebViewcpp">trunk/Source/WebKit/win/WebView.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPreferencesDefinitionsh">trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencescpp">trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh">trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreemacDumpRenderTreemm">trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm</a></li>
<li><a href="#trunkToolsDumpRenderTreewinDumpRenderTreecpp">trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerTestControllercpp">trunk/Tools/WebKitTestRunner/TestController.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/ChangeLog 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,3 +1,37 @@
</span><ins>+2017-02-10 Joseph Pecoraro <pecoraro@apple.com>
+
+ [Resource Timing] Enable Resource Timing by default in Tests
+ https://bugs.webkit.org/show_bug.cgi?id=168145
+
+ Reviewed by Ryosuke Niwa.
+
+ * fast/dom/Window/window-properties-performance-resource-timing.html:
+ * http/tests/misc/resource-timing-resolution.html:
+ * http/tests/performance/performance-resource-timing-cached-entries-expected.txt:
+ * http/tests/performance/performance-resource-timing-cached-entries.html:
+ * http/tests/performance/performance-resource-timing-entries-iterable.html:
+ * http/tests/performance/performance-resource-timing-entries.html:
+ * http/tests/performance/performance-resource-timing-initiator-css.html:
+ * http/tests/performance/performance-resource-timing-initiator-no-override.html:
+ * http/tests/performance/performance-resource-timing-xhr-single-entry.html:
+ * http/tests/preload/dynamic_remove_preload_href-expected.txt:
+ * http/tests/preload/dynamic_remove_preload_href.html:
+ * http/tests/preload/dynamic_removing_preload.html:
+ * http/tests/preload/not_evicting_preload_at_onload.html:
+ * http/tests/preload/single_download_preload-expected.txt:
+ * http/tests/preload/single_download_preload.html:
+ * resources/testharnessreport.js:
+ Eliminate the internals setResourceTimingEnabled way to toggle a runtime feature.
+
+ * platform/efl/js/dom/global-constructors-attributes-expected.txt:
+ * platform/gtk/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac/js/dom/global-constructors-attributes-expected.txt:
+ * platform/win/js/dom/global-constructors-attributes-expected.txt:
+ Update results when ResourceTiming is enabled.
+
</ins><span class="cx"> 2017-02-10 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Update LayoutTests/resources/testharness.js
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomWindowwindowpropertiesperformanceresourcetiminghtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Window/window-properties-performance-resource-timing.html (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Window/window-properties-performance-resource-timing.html 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/fast/dom/Window/window-properties-performance-resource-timing.html 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -6,9 +6,6 @@
</span><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.dumpAsText();
</span><span class="cx">
</span><del>-if (window.internals)
- internals.settings.setResourceTimingEnabled(true);
-
</del><span class="cx"> var logBuffer = [];
</span><span class="cx"> function log(s)
</span><span class="cx"> {
</span><span class="lines">@@ -99,6 +96,4 @@
</span><span class="cx"> window.performance = 'performance is replaceable';
</span><span class="cx"> logValue('window.performance');
</span><span class="cx"> flushLog();
</span><del>-if (window.internals)
- internals.settings.setResourceTimingEnabled(false);
</del><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsmiscresourcetimingresolutionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/misc/resource-timing-resolution.html (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/misc/resource-timing-resolution.html 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/misc/resource-timing-resolution.html 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -3,8 +3,6 @@
</span><span class="cx"> <script src="../../js-test-resources/js-test-pre.js"></script>
</span><span class="cx"> <script>
</span><span class="cx"> window.jsTestIsAsync = true;
</span><del>- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(true);
</del><span class="cx"> </script>
</span><span class="cx"> </head>
</span><span class="cx"> <body>
</span><span class="lines">@@ -26,8 +24,6 @@
</span><span class="cx"> var integerMultipleOfResolution = (t1 - t0) / expectedResolutionMilliseconds;
</span><span class="cx"> shouldBeNearZeroOrOne = integerMultipleOfResolution % 1;
</span><span class="cx"> shouldBe("shouldBeNearZeroOrOne < 1e-10 || Math.abs(shouldBeNearZeroOrOne - 1) < 1e-10", "true");
</span><del>- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(false);
</del><span class="cx"> finishJSTest();
</span><span class="cx"> });
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsperformanceperformanceresourcetimingcachedentriesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries-expected.txt (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries-expected.txt 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries-expected.txt 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,6 +1,6 @@
</span><del>-CONSOLE MESSAGE: line 11: current entries: 0
-CONSOLE MESSAGE: line 20: entry: http://127.0.0.1:8000/resources/js-test-pre.js
-CONSOLE MESSAGE: line 20: entry: http://127.0.0.1:8000/resources/square100.png
-CONSOLE MESSAGE: line 20: entry: http://127.0.0.1:8000/resources/square100.png
</del><ins>+CONSOLE MESSAGE: line 9: current entries: 0
+CONSOLE MESSAGE: line 18: entry: http://127.0.0.1:8000/resources/js-test-pre.js
+CONSOLE MESSAGE: line 18: entry: http://127.0.0.1:8000/resources/square100.png
+CONSOLE MESSAGE: line 18: entry: http://127.0.0.1:8000/resources/square100.png
</ins><span class="cx"> PASS foundResource is 2
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsperformanceperformanceresourcetimingcachedentrieshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries.html (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries.html 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries.html 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,8 +1,6 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <html>
</span><span class="cx"> <script>
</span><del>- if (window.internals)
- internals.settings.setResourceTimingEnabled(true);
</del><span class="cx"> if (window.testRunner) {
</span><span class="cx"> testRunner.dumpAsText()
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="lines">@@ -22,8 +20,6 @@
</span><span class="cx"> ++foundResource;
</span><span class="cx"> };
</span><span class="cx"> shouldBe("foundResource", "2");
</span><del>- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(false);
</del><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.notifyDone();
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsperformanceperformanceresourcetimingentriesiterablehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/performance/performance-resource-timing-entries-iterable.html (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/performance/performance-resource-timing-entries-iterable.html 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/performance/performance-resource-timing-entries-iterable.html 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,8 +1,6 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <html>
</span><span class="cx"> <script>
</span><del>- if (window.internals)
- internals.settings.setResourceTimingEnabled(true);
</del><span class="cx"> function resolve(path) {
</span><span class="cx"> var a = document.createElement("a");
</span><span class="cx"> a.href = path;
</span><span class="lines">@@ -26,8 +24,6 @@
</span><span class="cx"> shouldBeDefined("resources[0]");
</span><span class="cx"> entryTypes = resources.map((entry) => entry.entryType);
</span><span class="cx"> shouldBeEqualToString("entryTypes[0]", "resource");
</span><del>- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(false);
</del><span class="cx"> finishJSTest();
</span><span class="cx"> });
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsperformanceperformanceresourcetimingentrieshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/performance/performance-resource-timing-entries.html (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/performance/performance-resource-timing-entries.html 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/performance/performance-resource-timing-entries.html 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,8 +1,6 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <html>
</span><span class="cx"> <script>
</span><del>- if (window.internals)
- internals.settings.setResourceTimingEnabled(true);
</del><span class="cx"> var url = "../../resources/square100.png?";
</span><span class="cx"> url += Math.random();
</span><span class="cx"> document.write("<img src='" + url + "'>");
</span><span class="lines">@@ -20,8 +18,6 @@
</span><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx"> shouldBeTrue("foundImg");
</span><del>- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(false);
</del><span class="cx"> });
</span><span class="cx"> </script>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsperformanceperformanceresourcetiminginitiatorcsshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/performance/performance-resource-timing-initiator-css.html (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/performance/performance-resource-timing-initiator-css.html 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/performance/performance-resource-timing-initiator-css.html 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,8 +1,6 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <html>
</span><span class="cx"> <script>
</span><del>- if (window.internals)
- internals.settings.setResourceTimingEnabled(true);
</del><span class="cx"> if (window.testRunner) {
</span><span class="cx"> testRunner.dumpAsText()
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="lines">@@ -23,8 +21,6 @@
</span><span class="cx"> shouldBeEqualToString("initiator", "css");
</span><span class="cx"> }
</span><span class="cx"> };
</span><del>- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(false);
</del><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.notifyDone();
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsperformanceperformanceresourcetiminginitiatornooverridehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/performance/performance-resource-timing-initiator-no-override.html (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/performance/performance-resource-timing-initiator-no-override.html 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/performance/performance-resource-timing-initiator-no-override.html 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,8 +1,6 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <html>
</span><span class="cx"> <script>
</span><del>- if (window.internals)
- internals.settings.setResourceTimingEnabled(true);
</del><span class="cx"> if (window.testRunner) {
</span><span class="cx"> testRunner.dumpAsText()
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="lines">@@ -27,8 +25,6 @@
</span><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx"> shouldBe("foundResources", "1");
</span><del>- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(false);
</del><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.notifyDone();
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsperformanceperformanceresourcetimingxhrsingleentryhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/performance/performance-resource-timing-xhr-single-entry.html (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/performance/performance-resource-timing-xhr-single-entry.html 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/performance/performance-resource-timing-xhr-single-entry.html 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,8 +1,6 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <html>
</span><span class="cx"> <script>
</span><del>- if (window.internals)
- internals.settings.setResourceTimingEnabled(true);
</del><span class="cx"> if (window.testRunner) {
</span><span class="cx"> testRunner.dumpAsText()
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="lines">@@ -22,8 +20,6 @@
</span><span class="cx"> };
</span><span class="cx"> shouldBe("foundResource", "1");
</span><span class="cx"> shouldBeEqualToString("initiator", "xmlhttprequest");
</span><del>- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(false);
</del><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.notifyDone();
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkLayoutTestshttptestspreloaddynamic_remove_preload_hrefexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/preload/dynamic_remove_preload_href-expected.txt (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/preload/dynamic_remove_preload_href-expected.txt 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/preload/dynamic_remove_preload_href-expected.txt 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><del>-CONSOLE MESSAGE: line 18: <link rel=preload> has an invalid `href` value
</del><ins>+CONSOLE MESSAGE: line 14: <link rel=preload> has an invalid `href` value
</ins><span class="cx"> PASS downloadedImage is false
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestshttptestspreloaddynamic_remove_preload_hrefhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/preload/dynamic_remove_preload_href.html (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/preload/dynamic_remove_preload_href.html 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/preload/dynamic_remove_preload_href.html 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,10 +1,6 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <html>
</span><span class="cx"> <head>
</span><del>-<script>
- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(true);
-</script>
</del><span class="cx"> <script src="/js-test-resources/js-test.js"></script>
</span><span class="cx"> <body>
</span><span class="cx"> <script>
</span><span class="lines">@@ -23,8 +19,6 @@
</span><span class="cx"> downloadedImage = true;
</span><span class="cx"> }
</span><span class="cx"> shouldBeFalse("downloadedImage");
</span><del>- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(false);
</del><span class="cx"> });
</span><span class="cx"> </script>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="trunkLayoutTestshttptestspreloaddynamic_removing_preloadhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/preload/dynamic_removing_preload.html (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/preload/dynamic_removing_preload.html 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/preload/dynamic_removing_preload.html 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,10 +1,6 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <html>
</span><span class="cx"> <head>
</span><del>-<script>
- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(true);
-</script>
</del><span class="cx"> <script src="/js-test-resources/js-test.js"></script>
</span><span class="cx"> <body>
</span><span class="cx"> <script>
</span></span></pre></div>
<a id="trunkLayoutTestshttptestspreloadnot_evicting_preload_at_onloadhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/preload/not_evicting_preload_at_onload.html (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/preload/not_evicting_preload_at_onload.html 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/preload/not_evicting_preload_at_onload.html 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,7 +1,5 @@
</span><span class="cx"> <!DOCTYPE html>
</span><span class="cx"> <script>
</span><del>- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(true);
</del><span class="cx"> if (window.testRunner) {
</span><span class="cx"> testRunner.dumpAsText()
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="lines">@@ -16,8 +14,6 @@
</span><span class="cx"> var entries = performance.getEntriesByName(imageURL).length;
</span><span class="cx"> shouldBe(entries.toString(), "1");
</span><span class="cx">
</span><del>- if (window.internals)
- window.internals.settings.setResourceTimingEnabled(false);
</del><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.notifyDone();
</span><span class="cx"> }, 0);
</span></span></pre></div>
<a id="trunkLayoutTestshttptestspreloadsingle_download_preloadexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/preload/single_download_preload-expected.txt (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/preload/single_download_preload-expected.txt 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/preload/single_download_preload-expected.txt 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><del>-CONSOLE MESSAGE: line 19: <link rel=preload> must have a valid `as` value
</del><ins>+CONSOLE MESSAGE: line 15: <link rel=preload> must have a valid `as` value
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> PASS Makes sure that preloaded resources are not downloaded again when used
</span></span></pre></div>
<a id="trunkLayoutTestshttptestspreloadsingle_download_preloadhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/preload/single_download_preload.html (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/preload/single_download_preload.html 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/http/tests/preload/single_download_preload.html 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,8 +1,4 @@
</span><span class="cx"> <!DOCTYPE html>
</span><del>-<script>
- if (window.internals)
- internals.settings.setResourceTimingEnabled(true);
-</script>
</del><span class="cx"> <script src="/js-test-resources/testharness.js"></script>
</span><span class="cx"> <script src="/js-test-resources/testharnessreport.js"></script>
</span><span class="cx"> <script>
</span><span class="lines">@@ -59,8 +55,6 @@
</span><span class="cx"> // FIXME: XHR should trigger a single download, but it downloads 2 resources instead.
</span><span class="cx"> verifyDownloadNumber("http://127.0.0.1:8000/resources/dummy.xml", 2);
</span><span class="cx"> // FIXME: We should verify for video and audio as well, but they seem to (flakily?) trigger multiple partial requests.
</span><del>- if (window.internals)
- internals.settings.setResourceTimingEnabled(false);
</del><span class="cx"> t.done();
</span><span class="cx"> }), 100);
</span><span class="cx"> }));
</span></span></pre></div>
<a id="trunkLayoutTestsplatformefljsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1038,6 +1038,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').value is PerformanceResourceTiming
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').value is PerformanceTiming
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkjsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1168,6 +1168,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').value is PerformanceResourceTiming
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').value is PerformanceTiming
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacjsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1208,6 +1208,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').value is PerformanceResourceTiming
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').value is PerformanceTiming
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacelcapitanjsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1203,6 +1203,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').value is PerformanceResourceTiming
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').value is PerformanceTiming
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk1jsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1203,6 +1203,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').value is PerformanceResourceTiming
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').value is PerformanceTiming
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacyosemitejsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1198,6 +1198,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').value is PerformanceResourceTiming
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').value is PerformanceTiming
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinjsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -898,6 +898,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceObserverEntryList').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').value is PerformanceResourceTiming
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'PerformanceResourceTiming').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').value is PerformanceTiming
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsresourcestestharnessreportjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/resources/testharnessreport.js (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/resources/testharnessreport.js 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/LayoutTests/resources/testharnessreport.js 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -87,8 +87,4 @@
</span><span class="cx"> testRunner.notifyDone();
</span><span class="cx"> }, 0);
</span><span class="cx"> });
</span><del>-
- if (window.internals) {
- internals.settings.setResourceTimingEnabled(true);
- }
</del><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebCore/ChangeLog 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2017-02-10 Joseph Pecoraro <pecoraro@apple.com>
+
+ [Resource Timing] Enable Resource Timing by default in Tests
+ https://bugs.webkit.org/show_bug.cgi?id=168145
+
+ Reviewed by Ryosuke Niwa.
+
+ * loader/ResourceTimingInformation.cpp:
+ (WebCore::ResourceTimingInformation::addResourceTiming):
+ * testing/InternalSettings.cpp:
+ (WebCore::InternalSettings::Backup::Backup):
+ (WebCore::InternalSettings::Backup::restoreTo):
+ (WebCore::InternalSettings::setResourceTimingEnabled): Deleted.
+ * testing/InternalSettings.h:
+ * testing/InternalSettings.idl:
+ No longer needed for tests.
+
</ins><span class="cx"> 2017-02-10 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> [Cocoa] Add shouldChangeSelectedRange to WKWebProcessPlugInEditingDelegate
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderResourceTimingInformationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/ResourceTimingInformation.cpp (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/ResourceTimingInformation.cpp 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebCore/loader/ResourceTimingInformation.cpp 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -49,9 +49,12 @@
</span><span class="cx"> Document* initiatorDocument = &document;
</span><span class="cx"> if (resource->type() == CachedResource::MainResource)
</span><span class="cx"> initiatorDocument = document.parentDocument();
</span><del>- ASSERT(initiatorDocument);
- ASSERT(initiatorDocument->domWindow());
- ASSERT(initiatorDocument->domWindow()->performance());
</del><ins>+ if (!initiatorDocument)
+ return;
+ if (!initiatorDocument->domWindow())
+ return;
+ if (!initiatorDocument->domWindow()->performance())
+ return;
</ins><span class="cx"> const InitiatorInfo& info = initiatorIt->value;
</span><span class="cx"> initiatorDocument->domWindow()->performance()->addResourceTiming(info.name, resource->resourceRequest().url(), resource->response(), loadTiming);
</span><span class="cx"> initiatorIt->value.added = Added;
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalSettingscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/InternalSettings.cpp 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -94,7 +94,6 @@
</span><span class="cx"> , m_forcedColorsAreInvertedAccessibilityValue(settings.forcedColorsAreInvertedAccessibilityValue())
</span><span class="cx"> , m_forcedDisplayIsMonochromeAccessibilityValue(settings.forcedDisplayIsMonochromeAccessibilityValue())
</span><span class="cx"> , m_forcedPrefersReducedMotionAccessibilityValue(settings.forcedPrefersReducedMotionAccessibilityValue())
</span><del>- , m_resourceTimingEnabled(RuntimeEnabledFeatures::sharedFeatures().resourceTimingEnabled())
</del><span class="cx"> #if ENABLE(INDEXED_DATABASE_IN_WORKERS)
</span><span class="cx"> , m_indexedDBWorkersEnabled(RuntimeEnabledFeatures::sharedFeatures().indexedDBWorkersEnabled())
</span><span class="cx"> #endif
</span><span class="lines">@@ -182,7 +181,6 @@
</span><span class="cx"> settings.setForcedPrefersReducedMotionAccessibilityValue(m_forcedPrefersReducedMotionAccessibilityValue);
</span><span class="cx"> Settings::setAllowsAnySSLCertificate(false);
</span><span class="cx">
</span><del>- RuntimeEnabledFeatures::sharedFeatures().setResourceTimingEnabled(m_resourceTimingEnabled);
</del><span class="cx"> #if ENABLE(INDEXED_DATABASE_IN_WORKERS)
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setIndexedDBWorkersEnabled(m_indexedDBWorkersEnabled);
</span><span class="cx"> #endif
</span><span class="lines">@@ -673,11 +671,6 @@
</span><span class="cx"> return { };
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InternalSettings::setResourceTimingEnabled(bool enabled)
-{
- RuntimeEnabledFeatures::sharedFeatures().setResourceTimingEnabled(enabled);
-}
-
</del><span class="cx"> void InternalSettings::setIndexedDBWorkersEnabled(bool enabled)
</span><span class="cx"> {
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE_IN_WORKERS)
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalSettingsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/InternalSettings.h (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/InternalSettings.h 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebCore/testing/InternalSettings.h 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -110,7 +110,6 @@
</span><span class="cx"> void setForcedPrefersReducedMotionAccessibilityValue(ForcedAccessibilityValue);
</span><span class="cx">
</span><span class="cx"> // RuntimeEnabledFeatures.
</span><del>- static void setResourceTimingEnabled(bool);
</del><span class="cx"> static void setIndexedDBWorkersEnabled(bool);
</span><span class="cx"> static void setCSSGridLayoutEnabled(bool);
</span><span class="cx"> static void setWebGL2Enabled(bool);
</span><span class="lines">@@ -187,7 +186,6 @@
</span><span class="cx"> Settings::ForcedAccessibilityValue m_forcedPrefersReducedMotionAccessibilityValue;
</span><span class="cx">
</span><span class="cx"> // Runtime enabled settings.
</span><del>- bool m_resourceTimingEnabled;
</del><span class="cx"> bool m_indexedDBWorkersEnabled;
</span><span class="cx"> bool m_cssGridLayoutEnabled;
</span><span class="cx"> bool m_webGL2Enabled;
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalSettingsidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/InternalSettings.idl (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/InternalSettings.idl 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebCore/testing/InternalSettings.idl 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -83,7 +83,6 @@
</span><span class="cx"> [MayThrowException] void setInlineMediaPlaybackRequiresPlaysInlineAttribute(boolean requires);
</span><span class="cx">
</span><span class="cx"> // RuntimeEnabledFeatures.
</span><del>- void setResourceTimingEnabled(boolean enabled);
</del><span class="cx"> void setIndexedDBWorkersEnabled(boolean enabled);
</span><span class="cx"> void setCSSGridLayoutEnabled(boolean enabled);
</span><span class="cx"> void setWebGL2Enabled(boolean enabled);
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit/mac/ChangeLog 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-02-10 Joseph Pecoraro <pecoraro@apple.com>
+
+ [Resource Timing] Enable Resource Timing by default in Tests
+ https://bugs.webkit.org/show_bug.cgi?id=168145
+
+ Reviewed by Ryosuke Niwa.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences resourceTimingEnabled]):
+ (-[WebPreferences setResourceTimingEnabled:]):
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
</ins><span class="cx"> 2017-02-10 Aakash Jain <aakash_jain@apple.com>
</span><span class="cx">
</span><span class="cx"> cleanup WebLocalizableStrings.
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -225,3 +225,4 @@
</span><span class="cx"> #define WebKitAttachmentElementEnabledPreferenceKey @"WebKitAttachmentElementEnabled"
</span><span class="cx"> #define WebKitIntersectionObserverEnabledPreferenceKey @"WebKitIntersectionObserverEnabled"
</span><span class="cx"> #define WebKitUserTimingEnabledPreferenceKey @"WebKitUserTimingEnabled"
</span><ins>+#define WebKitResourceTimingEnabledPreferenceKey @"WebKitResourceTimingEnabled"
</ins></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -652,6 +652,7 @@
</span><span class="cx"> @NO, WebKitIntersectionObserverEnabledPreferenceKey,
</span><span class="cx"> #endif
</span><span class="cx"> @NO, WebKitUserTimingEnabledPreferenceKey,
</span><ins>+ @NO, WebKitResourceTimingEnabledPreferenceKey,
</ins><span class="cx"> nil];
</span><span class="cx">
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="lines">@@ -2945,6 +2946,16 @@
</span><span class="cx"> [self _setBoolValue:flag forKey:WebKitUserTimingEnabledPreferenceKey];
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (BOOL)resourceTimingEnabled
+{
+ return [self _boolValueForKey:WebKitResourceTimingEnabledPreferenceKey];
+}
+
+- (void)setResourceTimingEnabled:(BOOL)flag
+{
+ [self _setBoolValue:flag forKey:WebKitResourceTimingEnabledPreferenceKey];
+}
+
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> - (BOOL)quickLookDocumentSavingEnabled
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -529,6 +529,7 @@
</span><span class="cx"> @property (nonatomic) BOOL allowsInlineMediaPlaybackAfterFullscreen;
</span><span class="cx"> @property (nonatomic) BOOL intersectionObserverEnabled;
</span><span class="cx"> @property (nonatomic) BOOL userTimingEnabled;
</span><ins>+@property (nonatomic) BOOL resourceTimingEnabled;
</ins><span class="cx"> @property (nonatomic) BOOL linkPreloadEnabled;
</span><span class="cx">
</span><span class="cx"> #if TARGET_OS_IPHONE
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -2912,7 +2912,7 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setUserTimingEnabled(preferences.userTimingEnabled);
</span><del>-
</del><ins>+ RuntimeEnabledFeatures::sharedFeatures().setResourceTimingEnabled(preferences.resourceTimingEnabled);
</ins><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setLinkPreloadEnabled(preferences.linkPreloadEnabled);
</span><span class="cx">
</span><span class="cx"> NSTimeInterval timeout = [preferences incrementalRenderingSuppressionTimeoutInSeconds];
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit/win/ChangeLog 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2017-02-10 Joseph Pecoraro <pecoraro@apple.com>
+
+ [Resource Timing] Enable Resource Timing by default in Tests
+ https://bugs.webkit.org/show_bug.cgi?id=168145
+
+ Reviewed by Ryosuke Niwa.
+
+ * Interfaces/IWebPreferencesPrivate.idl:
+ * WebPreferenceKeysPrivate.h:
+ * WebPreferences.cpp:
+ (WebPreferences::initializeDefaultSettings):
+ (WebPreferences::setResourceTimingEnabled):
+ (WebPreferences::resourceTimingEnabled):
+ * WebPreferences.h:
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged):
+
</ins><span class="cx"> 2017-02-06 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> More build fixes after r211751
</span></span></pre></div>
<a id="trunkSourceWebKitwinInterfacesIWebPreferencesPrivateidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -196,6 +196,8 @@
</span><span class="cx"> HRESULT setWebAnimationsEnabled([in] BOOL enabled);
</span><span class="cx"> HRESULT userTimingEnabled([out, retval] BOOL*);
</span><span class="cx"> HRESULT setUserTimingEnabled([in] BOOL enabled);
</span><ins>+ HRESULT resourceTimingEnabled([out, retval] BOOL*);
+ HRESULT setResourceTimingEnabled([in] BOOL enabled);
</ins><span class="cx"> HRESULT linkPreloadEnabled([out, retval] BOOL*);
</span><span class="cx"> HRESULT setLinkPreloadEnabled([in] BOOL enabled);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -181,4 +181,6 @@
</span><span class="cx">
</span><span class="cx"> #define WebKitUserTimingEnabledPreferenceKey "WebKitUserTimingEnabled"
</span><span class="cx">
</span><ins>+#define WebKitResourceTimingEnabledPreferenceKey "WebKitResourceTimingEnabled"
+
</ins><span class="cx"> #define WebKitLinkPreloadEnabledPreferenceKey "WebKitLinkPreloadEnabled"
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferences.cpp (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferences.cpp 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit/win/WebPreferences.cpp 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -309,6 +309,8 @@
</span><span class="cx">
</span><span class="cx"> CFDictionaryAddValue(defaults, CFSTR(WebKitUserTimingEnabledPreferenceKey), kCFBooleanFalse);
</span><span class="cx">
</span><ins>+ CFDictionaryAddValue(defaults, CFSTR(WebKitResourceTimingEnabledPreferenceKey), kCFBooleanFalse);
+
</ins><span class="cx"> CFDictionaryAddValue(defaults, CFSTR(WebKitLinkPreloadEnabledPreferenceKey), kCFBooleanFalse);
</span><span class="cx">
</span><span class="cx"> defaultSettings = defaults;
</span><span class="lines">@@ -2057,3 +2059,17 @@
</span><span class="cx"> *enabled = boolValueForKey(WebKitUserTimingEnabledPreferenceKey);
</span><span class="cx"> return S_OK;
</span><span class="cx"> }
</span><ins>+
+HRESULT WebPreferences::setResourceTimingEnabled(BOOL enabled)
+{
+ setBoolValue(WebKitResourceTimingEnabledPreferenceKey, enabled);
+ return S_OK;
+}
+
+HRESULT WebPreferences::resourceTimingEnabled(_Out_ BOOL* enabled)
+{
+ if (!enabled)
+ return E_POINTER;
+ *enabled = boolValueForKey(WebKitResourceTimingEnabledPreferenceKey);
+ return S_OK;
+}
</ins></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferencesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferences.h (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferences.h 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit/win/WebPreferences.h 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -249,6 +249,8 @@
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE setWebAnimationsEnabled(BOOL);
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE userTimingEnabled(_Out_ BOOL*);
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE setUserTimingEnabled(BOOL);
</span><ins>+ virtual HRESULT STDMETHODCALLTYPE resourceTimingEnabled(_Out_ BOOL*);
+ virtual HRESULT STDMETHODCALLTYPE setResourceTimingEnabled(BOOL);
</ins><span class="cx"> virtual HRESULT STDMETHODCALLTYPE linkPreloadEnabled(_Out_ BOOL*);
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE setLinkPreloadEnabled(BOOL);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebView.cpp (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebView.cpp 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit/win/WebView.cpp 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -5267,6 +5267,11 @@
</span><span class="cx"> return hr;
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setUserTimingEnabled(!!enabled);
</span><span class="cx">
</span><ins>+ hr = prefsPrivate->resourceTimingEnabled(&enabled);
+ if (FAILED(hr))
+ return hr;
+ RuntimeEnabledFeatures::sharedFeatures().setResourceTimingEnabled(!!enabled);
+
</ins><span class="cx"> hr = preferences->privateBrowsingEnabled(&enabled);
</span><span class="cx"> if (FAILED(hr))
</span><span class="cx"> return hr;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit2/ChangeLog 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2017-02-10 Joseph Pecoraro <pecoraro@apple.com>
+
+ [Resource Timing] Enable Resource Timing by default in Tests
+ https://bugs.webkit.org/show_bug.cgi?id=168145
+
+ Reviewed by Ryosuke Niwa.
+
+ * Shared/WebPreferencesDefinitions.h:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetResourceTimingEnabled):
+ (WKPreferencesGetResourceTimingEnabled):
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
</ins><span class="cx"> 2017-02-10 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> [Cocoa] Add shouldChangeSelectedRange to WKWebProcessPlugInEditingDelegate
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPreferencesDefinitionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -247,6 +247,7 @@
</span><span class="cx"> macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, DEFAULT_HTML_INTERACTIVE_FORM_VALIDATION_ENABLED, "HTML Interactive Form Validation", "HTML interactive form validation") \
</span><span class="cx"> macro(ShouldSuppressKeyboardInputDuringProvisionalNavigation, shouldSuppressKeyboardInputDuringProvisionalNavigation, Bool, bool, false, "", "") \
</span><span class="cx"> macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, true, "CSS Grid", "CSS Grid Layout Module support") \
</span><ins>+ macro(ResourceTimingEnabled, resourceTimingEnabled, Bool, bool, false, "Resource Timing", "Enable ResourceTiming API") \
</ins><span class="cx"> \
</span><span class="cx">
</span><span class="cx"> #define FOR_EACH_WEBKIT_DOUBLE_PREFERENCE(macro) \
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1591,6 +1591,16 @@
</span><span class="cx"> return toImpl(preferencesRef)->userTimingEnabled();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void WKPreferencesSetResourceTimingEnabled(WKPreferencesRef preferencesRef, bool flag)
+{
+ toImpl(preferencesRef)->setResourceTimingEnabled(flag);
+}
+
+bool WKPreferencesGetResourceTimingEnabled(WKPreferencesRef preferencesRef)
+{
+ return toImpl(preferencesRef)->resourceTimingEnabled();
+}
+
</ins><span class="cx"> void WKPreferencesSetSelectionPaintingWithoutSelectionGapsEnabled(WKPreferencesRef preferencesRef, bool flag)
</span><span class="cx"> {
</span><span class="cx"> toImpl(preferencesRef)->setSelectionPaintingWithoutSelectionGapsEnabled(flag);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -453,6 +453,10 @@
</span><span class="cx"> WK_EXPORT void WKPreferencesSetUserTimingEnabled(WKPreferencesRef, bool flag);
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetUserTimingEnabled(WKPreferencesRef);
</span><span class="cx">
</span><ins>+// Defaults to false
+WK_EXPORT void WKPreferencesSetResourceTimingEnabled(WKPreferencesRef, bool flag);
+WK_EXPORT bool WKPreferencesGetResourceTimingEnabled(WKPreferencesRef);
+
</ins><span class="cx"> // Defaults to true
</span><span class="cx"> WK_EXPORT void WKPreferencesSetSubtleCryptoEnabled(WKPreferencesRef, bool flag);
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetSubtleCryptoEnabled(WKPreferencesRef);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -3229,8 +3229,6 @@
</span><span class="cx">
</span><span class="cx"> // Experimental Features.
</span><span class="cx">
</span><del>- RuntimeEnabledFeatures::sharedFeatures().setLinkPreloadEnabled(store.getBoolValueForKey(WebPreferencesKey::linkPreloadEnabledKey()));
-
</del><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setCSSGridLayoutEnabled(store.getBoolValueForKey(WebPreferencesKey::cssGridLayoutEnabledKey()));
</span><span class="cx"> #endif
</span><span class="lines">@@ -3259,6 +3257,8 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setUserTimingEnabled(store.getBoolValueForKey(WebPreferencesKey::userTimingEnabledKey()));
</span><ins>+ RuntimeEnabledFeatures::sharedFeatures().setResourceTimingEnabled(store.getBoolValueForKey(WebPreferencesKey::resourceTimingEnabledKey()));
+ RuntimeEnabledFeatures::sharedFeatures().setLinkPreloadEnabled(store.getBoolValueForKey(WebPreferencesKey::linkPreloadEnabledKey()));
</ins><span class="cx">
</span><span class="cx"> bool processSuppressionEnabled = store.getBoolValueForKey(WebPreferencesKey::pageVisibilityBasedProcessSuppressionEnabledKey());
</span><span class="cx"> if (m_processSuppressionEnabled != processSuppressionEnabled) {
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Tools/ChangeLog 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2017-02-10 Joseph Pecoraro <pecoraro@apple.com>
+
+ [Resource Timing] Enable Resource Timing by default in Tests
+ https://bugs.webkit.org/show_bug.cgi?id=168145
+
+ Reviewed by Ryosuke Niwa.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues):
+ * DumpRenderTree/win/DumpRenderTree.cpp:
+ (resetWebPreferencesToConsistentValues):
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues):
+
</ins><span class="cx"> 2017-02-10 Jonathan Bedard <jbedard@apple.com>
</span><span class="cx">
</span><span class="cx"> Removing LayoutTestRelay
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacDumpRenderTreemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -1017,6 +1017,8 @@
</span><span class="cx"> [preferences setMediaStreamEnabled:YES];
</span><span class="cx"> [preferences setPeerConnectionEnabled:YES];
</span><span class="cx">
</span><ins>+ [preferences setResourceTimingEnabled:YES];
+
</ins><span class="cx"> [WebPreferences _clearNetworkLoaderSession];
</span><span class="cx"> [WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain];
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreewinDumpRenderTreecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -879,6 +879,7 @@
</span><span class="cx"> prefsPrivate4->setShadowDOMEnabled(TRUE);
</span><span class="cx"> prefsPrivate4->setCustomElementsEnabled(TRUE);
</span><span class="cx"> prefsPrivate4->setModernMediaControlsEnabled(FALSE);
</span><ins>+ prefsPrivate4->setResourceTimingEnabled(TRUE);
</ins><span class="cx"> prefsPrivate4->setLinkPreloadEnabled(TRUE);
</span><span class="cx">
</span><span class="cx"> setAlwaysAcceptCookies(false);
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerTestControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (212149 => 212150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/TestController.cpp 2017-02-10 22:16:19 UTC (rev 212149)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2017-02-10 22:28:56 UTC (rev 212150)
</span><span class="lines">@@ -697,6 +697,8 @@
</span><span class="cx"> // FIXME: We should be testing the default.
</span><span class="cx"> WKPreferencesSetStorageBlockingPolicy(preferences, kWKAllowAllStorage);
</span><span class="cx">
</span><ins>+ WKPreferencesSetResourceTimingEnabled(preferences, true);
+
</ins><span class="cx"> WKPreferencesSetMediaPlaybackAllowsInline(preferences, true);
</span><span class="cx"> WKPreferencesSetInlineMediaPlaybackRequiresPlaysInlineAttribute(preferences, false);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>