<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211955] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211955">211955</a></dd>
<dt>Author</dt> <dd>graouts@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-09 08:20:18 -0800 (Thu, 09 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Modern Media Controls] Playing an <audio> element on iOS makes the controls disappear
https://bugs.webkit.org/show_bug.cgi?id=168047
<rdar://problem/30441939>
Reviewed by Eric Carlson.
Source/WebCore:
The controls bar auto-hide behavior is disabled for <audio> elements, but on iOS we have
a TapGestureRecognizer to identify when controls are tapped to toggle controls visibility.
This gesture recognizer would be on at all times, but it should only be enabled when
fadesToIdle is set to true.
Test: media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html
* Modules/modern-media-controls/controls/controls-bar.js:
(ControlsBar.prototype.set fadesWhileIdle):
LayoutTests:
Add a new iOS-specific test that checks the TapGestureRecognizer is only enabled when
fadesToIdle is true.
* media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt: Added.
* media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html: Added.
* platform/mac/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmodernmediacontrolscontrolscontrolsbarjs">trunk/Source/WebCore/Modules/modern-media-controls/controls/controls-bar.js</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsmediacontrollermediacontrolleriosonlyenabletapgesturerecognizerwithfadeswhenidleexpectedtxt">trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsmediacontrollermediacontrolleriosonlyenabletapgesturerecognizerwithfadeswhenidlehtml">trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (211954 => 211955)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-02-09 16:03:05 UTC (rev 211954)
+++ trunk/LayoutTests/ChangeLog 2017-02-09 16:20:18 UTC (rev 211955)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2017-02-09 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><ins>+ [Modern Media Controls] Playing an <audio> element on iOS makes the controls disappear
+ https://bugs.webkit.org/show_bug.cgi?id=168047
+ <rdar://problem/30441939>
+
+ Reviewed by Eric Carlson.
+
+ Add a new iOS-specific test that checks the TapGestureRecognizer is only enabled when
+ fadesToIdle is true.
+
+ * media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt: Added.
+ * media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html: Added.
+ * platform/mac/TestExpectations:
+
+2017-02-09 Antoine Quint <graouts@apple.com>
+
</ins><span class="cx"> [Modern Media Controls] <audio> element does not show any background on iOS
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168046
</span><span class="cx"> <rdar://problem/30441872>
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsmediacontrollermediacontrolleriosonlyenabletapgesturerecognizerwithfadeswhenidleexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt (0 => 211955)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt 2017-02-09 16:20:18 UTC (rev 211955)
</span><span class="lines">@@ -0,0 +1,22 @@
</span><ins>+Testing the MediaController controls bar tap gesture recognizer is only enabled when fadesWhileIdle is true.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Default state
+PASS controlsBar.fadesWhileIdle is false
+PASS controlsBar._tapGestureRecognizer.enabled is false
+
+controlsBar.fadesWhileIdle = true
+PASS controlsBar.fadesWhileIdle is true
+PASS controlsBar._tapGestureRecognizer.enabled is true
+
+controlsBar.fadesWhileIdle = false
+PASS controlsBar.fadesWhileIdle is false
+PASS controlsBar._tapGestureRecognizer.enabled is false
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
+
</ins></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsmediacontrollermediacontrolleriosonlyenabletapgesturerecognizerwithfadeswhenidlehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html (0 => 211955)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html 2017-02-09 16:20:18 UTC (rev 211955)
</span><span class="lines">@@ -0,0 +1,35 @@
</span><ins>+<script src="../../../resources/js-test-pre.js"></script>
+<script src="../resources/media-controls-loader.js" type="text/javascript"></script>
+<body>
+<audio src="../../content/test.wav" controls style="width: 300px; pointer-events: none; opacity: 0;"></audio>
+<div id="shadow" style="width: 300px; height: 50px;"></div>
+<script type="text/javascript">
+
+description("Testing the <code>MediaController</code> controls bar tap gesture recognizer is only enabled when fadesWhileIdle is true.");
+
+const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
+const media = document.querySelector("audio");
+const mediaController = createControls(shadowRoot, media, null);
+const controlsBar = mediaController.controls.controlsBar ;
+
+debug("Default state");
+shouldBeFalse("controlsBar.fadesWhileIdle");
+shouldBeFalse("controlsBar._tapGestureRecognizer.enabled");
+
+controlsBar.fadesWhileIdle = true;
+debug("");
+debug("controlsBar.fadesWhileIdle = true")
+shouldBeTrue("controlsBar.fadesWhileIdle");
+shouldBeTrue("controlsBar._tapGestureRecognizer.enabled");
+
+controlsBar.fadesWhileIdle = false;
+debug("");
+debug("controlsBar.fadesWhileIdle = false")
+shouldBeFalse("controlsBar.fadesWhileIdle");
+shouldBeFalse("controlsBar._tapGestureRecognizer.enabled");
+
+debug("");
+
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (211954 => 211955)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2017-02-09 16:03:05 UTC (rev 211954)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-02-09 16:20:18 UTC (rev 211955)
</span><span class="lines">@@ -1468,6 +1468,7 @@
</span><span class="cx"> media/modern-media-controls/placard-support/ipad/placard-support-pip.html [ Skip ]
</span><span class="cx"> media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html [ Skip ]
</span><span class="cx"> media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html [ Skip ]
</span><ins>+media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html [ Skip ]
</ins><span class="cx">
</span><span class="cx"> # This one always times out on the bots, cannot reproduce locally.
</span><span class="cx"> webkit.org/b/165234 media/modern-media-controls/audio/audio-controls-buttons.html [ Skip ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (211954 => 211955)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-02-09 16:03:05 UTC (rev 211954)
+++ trunk/Source/WebCore/ChangeLog 2017-02-09 16:20:18 UTC (rev 211955)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2017-02-09 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><ins>+ [Modern Media Controls] Playing an <audio> element on iOS makes the controls disappear
+ https://bugs.webkit.org/show_bug.cgi?id=168047
+ <rdar://problem/30441939>
+
+ Reviewed by Eric Carlson.
+
+ The controls bar auto-hide behavior is disabled for <audio> elements, but on iOS we have
+ a TapGestureRecognizer to identify when controls are tapped to toggle controls visibility.
+ This gesture recognizer would be on at all times, but it should only be enabled when
+ fadesToIdle is set to true.
+
+ Test: media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html
+
+ * Modules/modern-media-controls/controls/controls-bar.js:
+ (ControlsBar.prototype.set fadesWhileIdle):
+
+2017-02-09 Antoine Quint <graouts@apple.com>
+
</ins><span class="cx"> [Modern Media Controls] <audio> element does not show any background on iOS
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168046
</span><span class="cx"> <rdar://problem/30441872>
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmodernmediacontrolscontrolscontrolsbarjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/controls-bar.js (211954 => 211955)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/modern-media-controls/controls/controls-bar.js 2017-02-09 16:03:05 UTC (rev 211954)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/controls-bar.js 2017-02-09 16:20:18 UTC (rev 211955)
</span><span class="lines">@@ -33,13 +33,13 @@
</span><span class="cx"> this._translation = new DOMPoint;
</span><span class="cx"> this._mediaControls = mediaControls;
</span><span class="cx">
</span><ins>+ if (GestureRecognizer.SupportsTouches)
+ this._tapGestureRecognizer = new TapGestureRecognizer(this._mediaControls.element, this);
+
</ins><span class="cx"> this.autoHideDelay = ControlsBar.DefaultAutoHideDelay;
</span><span class="cx">
</span><span class="cx"> this.fadesWhileIdle = false;
</span><span class="cx"> this.userInteractionEnabled = true;
</span><del>-
- if (GestureRecognizer.SupportsTouches)
- this._tapGestureRecognizer = new TapGestureRecognizer(this._mediaControls.element, this);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Public
</span><span class="lines">@@ -84,7 +84,9 @@
</span><span class="cx">
</span><span class="cx"> this._fadesWhileIdle = flag;
</span><span class="cx">
</span><del>- if (!GestureRecognizer.SupportsTouches) {
</del><ins>+ if (GestureRecognizer.SupportsTouches)
+ this._tapGestureRecognizer.enabled = flag;
+ else {
</ins><span class="cx"> if (flag) {
</span><span class="cx"> this._mediaControls.element.addEventListener("mousemove", this);
</span><span class="cx"> this._mediaControls.element.addEventListener("mouseleave", this);
</span></span></pre>
</div>
</div>
</body>
</html>