<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211953] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211953">211953</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-09 07:59:22 -0800 (Thu, 09 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Modern Media Controls] <audio> element does not show any background on iOS
https://bugs.webkit.org/show_bug.cgi?id=168046
<rdar://problem/30441872>
Patch by Antoine Quint <graouts@apple.com> on 2017-02-09
Reviewed by Eric Carlson.
Source/WebCore:
Use a solid gray background for <audio> elements on iOS.
Test: media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html
* Modules/modern-media-controls/controls/ios-inline-media-controls.css:
(:host(audio) .media-controls.ios.inline > .controls-bar:before):
LayoutTests:
Add an iOS-specific test that checks that <audio> elements have a solid gray background.
* media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background-expected.txt: Added.
* media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html: Added.
* platform/mac/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmodernmediacontrolscontrolsiosinlinemediacontrolscss">trunk/Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.css</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsiosinlinemediacontrolsiosinlinemediacontrolsaudiobackgroundexpectedtxt">trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamodernmediacontrolsiosinlinemediacontrolsiosinlinemediacontrolsaudiobackgroundhtml">trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (211952 => 211953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-02-09 15:13:29 UTC (rev 211952)
+++ trunk/LayoutTests/ChangeLog 2017-02-09 15:59:22 UTC (rev 211953)
</span><span class="lines">@@ -1,5 +1,19 @@
</span><span class="cx"> 2017-02-09 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><ins>+ [Modern Media Controls] <audio> element does not show any background on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=168046
+ <rdar://problem/30441872>
+
+ Reviewed by Eric Carlson.
+
+ Add an iOS-specific test that checks that <audio> elements have a solid gray background.
+
+ * media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background-expected.txt: Added.
+ * media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html: Added.
+ * platform/mac/TestExpectations:
+
+2017-02-09 Antoine Quint <graouts@apple.com>
+
</ins><span class="cx"> [Modern Media Controls] Controls fail to instantiate in an XHTML document
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168045
</span><span class="cx"> <rdar://problem/30290095>
</span></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsiosinlinemediacontrolsiosinlinemediacontrolsaudiobackgroundexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background-expected.txt (0 => 211953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background-expected.txt (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background-expected.txt 2017-02-09 15:59:22 UTC (rev 211953)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+Testing that we show a gray background for iOS audio elements.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS mediaControls.querySelector('.controls-bar') instanceof HTMLDivElement became true
+PASS getComputedStyle(mediaControls.querySelector('.controls-bar'), ':before').webkitAppearance is "none"
+PASS getComputedStyle(mediaControls.querySelector('.controls-bar'), ':before').backgroundColor is "rgb(212, 212, 212)"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsmediamodernmediacontrolsiosinlinemediacontrolsiosinlinemediacontrolsaudiobackgroundhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html (0 => 211953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html 2017-02-09 15:59:22 UTC (rev 211953)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+<!DOCTYPE html>
+<script src="../../../resources/js-test-pre.js"></script>
+<body>
+<audio src="../../content/test.wav" style="width: 300px;" controls></audio>
+<script type="text/javascript">
+
+window.jsTestIsAsync = true;
+
+description("Testing that we show a gray background for iOS audio elements.");
+
+const mediaControls = window.internals.shadowRoot(document.querySelector('audio')).lastElementChild;
+
+shouldBecomeEqual("mediaControls.querySelector('.controls-bar') instanceof HTMLDivElement", "true", () => {
+ shouldBeEqualToString("getComputedStyle(mediaControls.querySelector('.controls-bar'), ':before').webkitAppearance", "none");
+ shouldBeEqualToString("getComputedStyle(mediaControls.querySelector('.controls-bar'), ':before').backgroundColor", "rgb(212, 212, 212)");
+ finishJSTest();
+});
+
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (211952 => 211953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2017-02-09 15:13:29 UTC (rev 211952)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-02-09 15:59:22 UTC (rev 211953)
</span><span class="lines">@@ -1461,12 +1461,13 @@
</span><span class="cx"> [ ElCapitan ] media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html [ Skip ]
</span><span class="cx"> [ ElCapitan ] media/modern-media-controls/placard-support/placard-support-pip.html [ Skip ]
</span><span class="cx">
</span><del>-# iPad-specific tests
</del><ins>+# iOS or iPad-specific tests
</ins><span class="cx"> media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html [ Skip ]
</span><span class="cx"> media/modern-media-controls/pip-support/ipad/pip-support-enabled.html [ Skip ]
</span><span class="cx"> media/modern-media-controls/pip-support/ipad/pip-support-tap.html [ Skip ]
</span><span class="cx"> media/modern-media-controls/placard-support/ipad/placard-support-pip.html [ Skip ]
</span><span class="cx"> media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html [ Skip ]
</span><ins>+media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html [ Skip ]
</ins><span class="cx">
</span><span class="cx"> # This one always times out on the bots, cannot reproduce locally.
</span><span class="cx"> webkit.org/b/165234 media/modern-media-controls/audio/audio-controls-buttons.html [ Skip ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (211952 => 211953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-02-09 15:13:29 UTC (rev 211952)
+++ trunk/Source/WebCore/ChangeLog 2017-02-09 15:59:22 UTC (rev 211953)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2017-02-09 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><ins>+ [Modern Media Controls] <audio> element does not show any background on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=168046
+ <rdar://problem/30441872>
+
+ Reviewed by Eric Carlson.
+
+ Use a solid gray background for <audio> elements on iOS.
+
+ Test: media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html
+
+ * Modules/modern-media-controls/controls/ios-inline-media-controls.css:
+ (:host(audio) .media-controls.ios.inline > .controls-bar:before):
+
+2017-02-09 Antoine Quint <graouts@apple.com>
+
</ins><span class="cx"> [Modern Media Controls] Controls fail to instantiate in an XHTML document
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=168045
</span><span class="cx"> <rdar://problem/30290095>
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmodernmediacontrolscontrolsiosinlinemediacontrolscss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.css (211952 => 211953)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.css 2017-02-09 15:13:29 UTC (rev 211952)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.css 2017-02-09 15:59:22 UTC (rev 211953)
</span><span class="lines">@@ -43,6 +43,11 @@
</span><span class="cx"> will-change: transform;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+:host(audio) .media-controls.ios.inline > .controls-bar:before {
+ -webkit-appearance: none;
+ background-color: rgb(212, 212, 212);
+}
+
</ins><span class="cx"> .media-controls.ios.inline .time-control {
</span><span class="cx"> position: absolute;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>