<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211886] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211886">211886</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-02-08 10:54:55 -0800 (Wed, 08 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>RTCPeerConnection constructor can take null as input
https://bugs.webkit.org/show_bug.cgi?id=167992
Patch by Youenn Fablet <youenn@apple.com> on 2017-02-08
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
* web-platform-tests/webrtc/datachannel-emptystring-expected.txt:
* web-platform-tests/webrtc/no-media-call-expected.txt:
* web-platform-tests/webrtc/promises-call-expected.txt:
* web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:
* web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt:
Source/WebCore:
Covered by updated test.
RTCPeerConnection takes an optional Dictionary as input.
As per https://heycam.github.io/webidl/#es-dictionary, null is converted to an empty dictionary.
* Modules/mediastream/RTCPeerConnection.js:
(initializeRTCPeerConnection):
LayoutTests:
Covered by updated and rebased tests.
* fast/mediastream/RTCPeerConnection-expected.txt:
* fast/mediastream/RTCPeerConnection.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionexpectedtxt">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestswebrtcdatachannelemptystringexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/datachannel-emptystring-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestswebrtcnomediacallexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/no-media-call-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestswebrtcpromisescallexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/promises-call-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestswebrtcrtcpeerconnectionrtcpeerconnectionconstructorexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestswebrtcrtcpeerconnectionrtcpeerconnectionidlexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCPeerConnectionjs">trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (211885 => 211886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-02-08 18:37:13 UTC (rev 211885)
+++ trunk/LayoutTests/ChangeLog 2017-02-08 18:54:55 UTC (rev 211886)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-02-08 Youenn Fablet <youenn@apple.com>
+
+ RTCPeerConnection constructor can take null as input
+ https://bugs.webkit.org/show_bug.cgi?id=167992
+
+ Reviewed by Chris Dumez.
+
+ Covered by updated and rebased tests.
+
+ * fast/mediastream/RTCPeerConnection-expected.txt:
+ * fast/mediastream/RTCPeerConnection.html:
+
</ins><span class="cx"> 2017-02-08 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed GTK+ gardening. Mark several imported w3c fetch API tests as failing.
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt (211885 => 211886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt 2017-02-08 18:37:13 UTC (rev 211885)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt 2017-02-08 18:54:55 UTC (rev 211886)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS new RTCPeerConnection(null); threw exception TypeError: RTCPeerConnection argument must be a valid dictionary.
</del><ins>+PASS new RTCPeerConnection(null); did not throw exception.
</ins><span class="cx"> PASS new RTCPeerConnection(''); threw exception TypeError: RTCPeerConnection argument must be a valid dictionary.
</span><span class="cx"> PASS new RTCPeerConnection({}); did not throw exception.
</span><span class="cx"> PASS new RTCPeerConnection({iceServers:[]}); did not throw exception.
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html (211885 => 211886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html 2017-02-08 18:37:13 UTC (rev 211885)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html 2017-02-08 18:54:55 UTC (rev 211886)
</span><span class="lines">@@ -7,7 +7,7 @@
</span><span class="cx"> <script>
</span><span class="cx"> description("Tests the RTCPeerConnection constructor.");
</span><span class="cx">
</span><del>- shouldThrow("new RTCPeerConnection(null);");
</del><ins>+ shouldNotThrow("new RTCPeerConnection(null);");
</ins><span class="cx"> shouldThrow("new RTCPeerConnection('');");
</span><span class="cx"> shouldNotThrow("new RTCPeerConnection({});");
</span><span class="cx"> shouldNotThrow("new RTCPeerConnection({iceServers:[]});");
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (211885 => 211886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-02-08 18:37:13 UTC (rev 211885)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-02-08 18:54:55 UTC (rev 211886)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-02-08 Youenn Fablet <youenn@apple.com>
+
+ RTCPeerConnection constructor can take null as input
+ https://bugs.webkit.org/show_bug.cgi?id=167992
+
+ Reviewed by Chris Dumez.
+
+ * web-platform-tests/webrtc/datachannel-emptystring-expected.txt:
+ * web-platform-tests/webrtc/no-media-call-expected.txt:
+ * web-platform-tests/webrtc/promises-call-expected.txt:
+ * web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:
+ * web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt:
+
</ins><span class="cx"> 2017-02-07 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> Use a JSON file to define which WPT files/folders to import
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestswebrtcdatachannelemptystringexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/datachannel-emptystring-expected.txt (211885 => 211886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/datachannel-emptystring-expected.txt 2017-02-08 18:37:13 UTC (rev 211885)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/datachannel-emptystring-expected.txt 2017-02-08 18:54:55 UTC (rev 211886)
</span><span class="lines">@@ -1,5 +1,9 @@
</span><span class="cx">
</span><del>-FAIL Can send empty strings across a WebRTC data channel. RTCPeerConnection argument must be a valid dictionary
</del><ins>+Harness Error (TIMEOUT), message = null
+
+TIMEOUT Can send empty strings across a WebRTC data channel. Test timed out
</ins><span class="cx"> Messages exchanged
</span><span class="cx">
</span><ins>+Sent: [empty string]
+Sent: "done"
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestswebrtcnomediacallexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/no-media-call-expected.txt (211885 => 211886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/no-media-call-expected.txt 2017-02-08 18:37:13 UTC (rev 211885)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/no-media-call-expected.txt 2017-02-08 18:54:55 UTC (rev 211886)
</span><span class="lines">@@ -1,5 +1,7 @@
</span><span class="cx">
</span><del>-FAIL Can set up a basic WebRTC call with no data. RTCPeerConnection argument must be a valid dictionary
</del><ins>+Harness Error (TIMEOUT), message = null
+
+TIMEOUT Can set up a basic WebRTC call with no data. Test timed out
</ins><span class="cx"> iceConnectionState info
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestswebrtcpromisescallexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/promises-call-expected.txt (211885 => 211886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/promises-call-expected.txt 2017-02-08 18:37:13 UTC (rev 211885)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/promises-call-expected.txt 2017-02-08 18:54:55 UTC (rev 211886)
</span><span class="lines">@@ -1,5 +1,7 @@
</span><span class="cx">
</span><del>-FAIL Can set up a basic WebRTC call with only data using promises. RTCPeerConnection argument must be a valid dictionary
</del><ins>+Harness Error (TIMEOUT), message = null
+
+TIMEOUT Can set up a basic WebRTC call with only data using promises. Test timed out
</ins><span class="cx"> iceConnectionState info
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestswebrtcrtcpeerconnectionrtcpeerconnectionconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt (211885 => 211886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt 2017-02-08 18:37:13 UTC (rev 211885)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt 2017-02-08 18:54:55 UTC (rev 211886)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx">
</span><span class="cx"> PASS RTCPeerConnection.length
</span><span class="cx"> PASS new RTCPeerConnection()
</span><del>-FAIL new RTCPeerConnection(null) RTCPeerConnection argument must be a valid dictionary
</del><ins>+PASS new RTCPeerConnection(null)
</ins><span class="cx"> PASS new RTCPeerConnection(undefined)
</span><span class="cx"> PASS new RTCPeerConnection({})
</span><span class="cx"> PASS new RTCPeerConnection({ iceServers: null })
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestswebrtcrtcpeerconnectionrtcpeerconnectionidlexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt (211885 => 211886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt 2017-02-08 18:37:13 UTC (rev 211885)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt 2017-02-08 18:54:55 UTC (rev 211886)
</span><span class="lines">@@ -1,9 +1,134 @@
</span><del>-CONSOLE MESSAGE: line 100: TypeError: RTCPeerConnection argument must be a valid dictionary
</del><span class="cx"> Description
</span><span class="cx">
</span><span class="cx"> This test verifies the availability of the RTCPeerConnection interface.
</span><span class="cx">
</span><span class="cx">
</span><del>-Harness Error (FAIL), message = TypeError: RTCPeerConnection argument must be a valid dictionary
</del><ins>+PASS EventTarget interface: existence and properties of interface object
+PASS EventTarget interface object length
+PASS EventTarget interface object name
+PASS EventTarget interface: existence and properties of interface prototype object
+PASS EventTarget interface: existence and properties of interface prototype object's "constructor" property
+PASS RTCPeerConnection interface: existence and properties of interface object
+PASS RTCPeerConnection interface object length
+PASS RTCPeerConnection interface object name
+PASS RTCPeerConnection interface: existence and properties of interface prototype object
+PASS RTCPeerConnection interface: existence and properties of interface prototype object's "constructor" property
+PASS RTCPeerConnection interface: operation createOffer(RTCOfferOptions)
+PASS RTCPeerConnection interface: operation createAnswer(RTCAnswerOptions)
+FAIL RTCPeerConnection interface: operation setLocalDescription(RTCSessionDescription) assert_equals: property has wrong .length expected 1 but got 0
+PASS RTCPeerConnection interface: attribute localDescription
+PASS RTCPeerConnection interface: attribute currentLocalDescription
+PASS RTCPeerConnection interface: attribute pendingLocalDescription
+FAIL RTCPeerConnection interface: operation setRemoteDescription(RTCSessionDescription) assert_equals: property has wrong .length expected 1 but got 0
+PASS RTCPeerConnection interface: attribute remoteDescription
+PASS RTCPeerConnection interface: attribute currentRemoteDescription
+PASS RTCPeerConnection interface: attribute pendingRemoteDescription
+FAIL RTCPeerConnection interface: operation addIceCandidate(RTCIceCandidate) assert_equals: property has wrong .length expected 1 but got 0
+PASS RTCPeerConnection interface: attribute signalingState
+PASS RTCPeerConnection interface: attribute iceGatheringState
+PASS RTCPeerConnection interface: attribute iceConnectionState
+FAIL RTCPeerConnection interface: attribute canTrickleIceCandidates assert_true: The prototype object must have a property "canTrickleIceCandidates" expected true got false
+PASS RTCPeerConnection interface: operation getConfiguration()
+PASS RTCPeerConnection interface: operation setConfiguration(RTCConfiguration)
+PASS RTCPeerConnection interface: operation close()
+PASS RTCPeerConnection interface: attribute onnegotiationneeded
+PASS RTCPeerConnection interface: attribute onicecandidate
+PASS RTCPeerConnection interface: attribute onsignalingstatechange
+PASS RTCPeerConnection interface: attribute oniceconnectionstatechange
+PASS RTCPeerConnection interface: attribute onicegatheringstatechange
+FAIL RTCPeerConnection interface: operation createOffer(RTCSessionDescriptionCallback,RTCPeerConnectionErrorCallback,RTCOfferOptions) assert_throws: calling operation with this = null didn't throw TypeError function "function () {
+ fn.apply(obj, args);
+ }" did not throw
+FAIL RTCPeerConnection interface: operation setLocalDescription(RTCSessionDescription,VoidFunction,RTCPeerConnectionErrorCallback) assert_equals: property has wrong .length expected 1 but got 0
+FAIL RTCPeerConnection interface: operation createAnswer(RTCSessionDescriptionCallback,RTCPeerConnectionErrorCallback) assert_throws: calling operation with this = null didn't throw TypeError function "function () {
+ fn.apply(obj, args);
+ }" did not throw
+FAIL RTCPeerConnection interface: operation setRemoteDescription(RTCSessionDescription,VoidFunction,RTCPeerConnectionErrorCallback) assert_equals: property has wrong .length expected 1 but got 0
+FAIL RTCPeerConnection interface: operation addIceCandidate(RTCIceCandidate,VoidFunction,RTCPeerConnectionErrorCallback) assert_equals: property has wrong .length expected 1 but got 0
+FAIL RTCPeerConnection interface: operation getStats(MediaStreamTrack,RTCStatsCallback,RTCPeerConnectionErrorCallback) assert_throws: calling operation with this = null didn't throw TypeError function "function () {
+ fn.apply(obj, args);
+ }" did not throw
+FAIL RTCPeerConnection interface: operation generateCertificate(AlgorithmIdentifier) assert_own_property: interface object missing static operation expected property "generateCertificate" missing
+PASS RTCPeerConnection interface: operation getSenders()
+PASS RTCPeerConnection interface: operation getReceivers()
+PASS RTCPeerConnection interface: operation addTrack(MediaStreamTrack,MediaStream)
+PASS RTCPeerConnection interface: operation removeTrack(RTCRtpSender)
+PASS RTCPeerConnection interface: attribute ontrack
+PASS RTCPeerConnection interface: operation createDataChannel(DOMString,RTCDataChannelInit)
+PASS RTCPeerConnection interface: attribute ondatachannel
+FAIL RTCPeerConnection interface: attribute dtmf assert_true: The prototype object must have a property "dtmf" expected true got false
+PASS RTCPeerConnection interface: operation getStats(MediaStreamTrack)
+FAIL RTCPeerConnection interface: operation setIdentityProvider(DOMString,DOMString,DOMString) assert_own_property: interface prototype object missing non-static operation expected property "setIdentityProvider" missing
+FAIL RTCPeerConnection interface: operation getIdentityAssertion() assert_own_property: interface prototype object missing non-static operation expected property "getIdentityAssertion" missing
+FAIL RTCPeerConnection interface: attribute peerIdentity assert_true: The prototype object must have a property "peerIdentity" expected true got false
+FAIL RTCPeerConnection interface: attribute idpLoginUrl assert_true: The prototype object must have a property "idpLoginUrl" expected true got false
+PASS RTCPeerConnection must be primary interface of pc
+PASS Stringification of pc
+PASS RTCPeerConnection interface: pc must inherit property "createOffer" with the proper type (0)
+PASS RTCPeerConnection interface: calling createOffer(RTCOfferOptions) on pc with too few arguments must throw TypeError
+PASS RTCPeerConnection interface: pc must inherit property "createAnswer" with the proper type (1)
+PASS RTCPeerConnection interface: calling createAnswer(RTCAnswerOptions) on pc with too few arguments must throw TypeError
+PASS RTCPeerConnection interface: pc must inherit property "setLocalDescription" with the proper type (2)
+PASS RTCPeerConnection interface: calling setLocalDescription(RTCSessionDescription) on pc with too few arguments must throw TypeError
+PASS RTCPeerConnection interface: pc must inherit property "localDescription" with the proper type (3)
+PASS RTCPeerConnection interface: pc must inherit property "currentLocalDescription" with the proper type (4)
+PASS RTCPeerConnection interface: pc must inherit property "pendingLocalDescription" with the proper type (5)
+PASS RTCPeerConnection interface: pc must inherit property "setRemoteDescription" with the proper type (6)
+PASS RTCPeerConnection interface: calling setRemoteDescription(RTCSessionDescription) on pc with too few arguments must throw TypeError
+PASS RTCPeerConnection interface: pc must inherit property "remoteDescription" with the proper type (7)
+PASS RTCPeerConnection interface: pc must inherit property "currentRemoteDescription" with the proper type (8)
+PASS RTCPeerConnection interface: pc must inherit property "pendingRemoteDescription" with the proper type (9)
+PASS RTCPeerConnection interface: pc must inherit property "addIceCandidate" with the proper type (10)
+PASS RTCPeerConnection interface: calling addIceCandidate(RTCIceCandidate) on pc with too few arguments must throw TypeError
+FAIL RTCPeerConnection interface: pc must inherit property "signalingState" with the proper type (11) Unrecognized type RTCSignalingState
+FAIL RTCPeerConnection interface: pc must inherit property "iceGatheringState" with the proper type (12) Unrecognized type RTCIceGatheringState
+FAIL RTCPeerConnection interface: pc must inherit property "iceConnectionState" with the proper type (13) Unrecognized type RTCIceConnectionState
+FAIL RTCPeerConnection interface: pc must inherit property "canTrickleIceCandidates" with the proper type (14) assert_inherits: property "canTrickleIceCandidates" not found in prototype chain
+PASS RTCPeerConnection interface: pc must inherit property "getConfiguration" with the proper type (15)
+PASS RTCPeerConnection interface: pc must inherit property "setConfiguration" with the proper type (16)
+PASS RTCPeerConnection interface: calling setConfiguration(RTCConfiguration) on pc with too few arguments must throw TypeError
+PASS RTCPeerConnection interface: pc must inherit property "close" with the proper type (17)
+FAIL RTCPeerConnection interface: pc must inherit property "onnegotiationneeded" with the proper type (18) Unrecognized type EventHandler
+FAIL RTCPeerConnection interface: pc must inherit property "onicecandidate" with the proper type (19) Unrecognized type EventHandler
+FAIL RTCPeerConnection interface: pc must inherit property "onsignalingstatechange" with the proper type (20) Unrecognized type EventHandler
+FAIL RTCPeerConnection interface: pc must inherit property "oniceconnectionstatechange" with the proper type (21) Unrecognized type EventHandler
+FAIL RTCPeerConnection interface: pc must inherit property "onicegatheringstatechange" with the proper type (22) Unrecognized type EventHandler
+PASS RTCPeerConnection interface: pc must inherit property "createOffer" with the proper type (23)
+PASS RTCPeerConnection interface: calling createOffer(RTCSessionDescriptionCallback,RTCPeerConnectionErrorCallback,RTCOfferOptions) on pc with too few arguments must throw TypeError
+PASS RTCPeerConnection interface: pc must inherit property "setLocalDescription" with the proper type (24)
+FAIL RTCPeerConnection interface: calling setLocalDescription(RTCSessionDescription,VoidFunction,RTCPeerConnectionErrorCallback) on pc with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
+ fn.apply(obj, args);
+ }" did not throw
+PASS RTCPeerConnection interface: pc must inherit property "createAnswer" with the proper type (25)
+PASS RTCPeerConnection interface: calling createAnswer(RTCSessionDescriptionCallback,RTCPeerConnectionErrorCallback) on pc with too few arguments must throw TypeError
+PASS RTCPeerConnection interface: pc must inherit property "setRemoteDescription" with the proper type (26)
+FAIL RTCPeerConnection interface: calling setRemoteDescription(RTCSessionDescription,VoidFunction,RTCPeerConnectionErrorCallback) on pc with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
+ fn.apply(obj, args);
+ }" did not throw
+PASS RTCPeerConnection interface: pc must inherit property "addIceCandidate" with the proper type (27)
+FAIL RTCPeerConnection interface: calling addIceCandidate(RTCIceCandidate,VoidFunction,RTCPeerConnectionErrorCallback) on pc with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
+ fn.apply(obj, args);
+ }" did not throw
+PASS RTCPeerConnection interface: pc must inherit property "getStats" with the proper type (28)
+PASS RTCPeerConnection interface: calling getStats(MediaStreamTrack,RTCStatsCallback,RTCPeerConnectionErrorCallback) on pc with too few arguments must throw TypeError
+PASS RTCPeerConnection interface: pc must inherit property "generateCertificate" with the proper type (29)
+FAIL RTCPeerConnection interface: calling generateCertificate(AlgorithmIdentifier) on pc with too few arguments must throw TypeError assert_unreached: Throws "TypeError: undefined is not an object (evaluating 'fn.apply')" instead of rejecting promise Reached unreachable code
+PASS RTCPeerConnection interface: pc must inherit property "getSenders" with the proper type (30)
+PASS RTCPeerConnection interface: pc must inherit property "getReceivers" with the proper type (31)
+PASS RTCPeerConnection interface: pc must inherit property "addTrack" with the proper type (32)
+PASS RTCPeerConnection interface: calling addTrack(MediaStreamTrack,MediaStream) on pc with too few arguments must throw TypeError
+PASS RTCPeerConnection interface: pc must inherit property "removeTrack" with the proper type (33)
+PASS RTCPeerConnection interface: calling removeTrack(RTCRtpSender) on pc with too few arguments must throw TypeError
+FAIL RTCPeerConnection interface: pc must inherit property "ontrack" with the proper type (34) Unrecognized type EventHandler
+PASS RTCPeerConnection interface: pc must inherit property "createDataChannel" with the proper type (35)
+PASS RTCPeerConnection interface: calling createDataChannel(DOMString,RTCDataChannelInit) on pc with too few arguments must throw TypeError
+FAIL RTCPeerConnection interface: pc must inherit property "ondatachannel" with the proper type (36) Unrecognized type EventHandler
+FAIL RTCPeerConnection interface: pc must inherit property "dtmf" with the proper type (37) assert_inherits: property "dtmf" not found in prototype chain
+PASS RTCPeerConnection interface: pc must inherit property "getStats" with the proper type (38)
+PASS RTCPeerConnection interface: calling getStats(MediaStreamTrack) on pc with too few arguments must throw TypeError
+FAIL RTCPeerConnection interface: pc must inherit property "setIdentityProvider" with the proper type (39) assert_inherits: property "setIdentityProvider" not found in prototype chain
+FAIL RTCPeerConnection interface: calling setIdentityProvider(DOMString,DOMString,DOMString) on pc with too few arguments must throw TypeError assert_inherits: property "setIdentityProvider" not found in prototype chain
+FAIL RTCPeerConnection interface: pc must inherit property "getIdentityAssertion" with the proper type (40) assert_inherits: property "getIdentityAssertion" not found in prototype chain
+FAIL RTCPeerConnection interface: pc must inherit property "peerIdentity" with the proper type (41) assert_inherits: property "peerIdentity" not found in prototype chain
+FAIL RTCPeerConnection interface: pc must inherit property "idpLoginUrl" with the proper type (42) assert_inherits: property "idpLoginUrl" not found in prototype chain
</ins><span class="cx">
</span><del>-
</del></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (211885 => 211886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-02-08 18:37:13 UTC (rev 211885)
+++ trunk/Source/WebCore/ChangeLog 2017-02-08 18:54:55 UTC (rev 211886)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2017-02-08 Youenn Fablet <youenn@apple.com>
+
+ RTCPeerConnection constructor can take null as input
+ https://bugs.webkit.org/show_bug.cgi?id=167992
+
+ Reviewed by Chris Dumez.
+
+ Covered by updated test.
+
+ RTCPeerConnection takes an optional Dictionary as input.
+ As per https://heycam.github.io/webidl/#es-dictionary, null is converted to an empty dictionary.
+
+ * Modules/mediastream/RTCPeerConnection.js:
+ (initializeRTCPeerConnection):
+
</ins><span class="cx"> 2017-02-08 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> No need for CachedFrame to detach custom scrollbars.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCPeerConnectionjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.js (211885 => 211886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.js 2017-02-08 18:37:13 UTC (rev 211885)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.js 2017-02-08 18:54:55 UTC (rev 211886)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (configuration === @undefined)
</del><ins>+ if (configuration == null)
</ins><span class="cx"> configuration = {};
</span><span class="cx"> else if (!@isObject(configuration))
</span><span class="cx"> @throwTypeError("RTCPeerConnection argument must be a valid dictionary");
</span></span></pre>
</div>
</div>
</body>
</html>