<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211835] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211835">211835</a></dd>
<dt>Author</dt> <dd>achristensen@apple.com</dd>
<dt>Date</dt> <dd>2017-02-07 13:29:50 -0800 (Tue, 07 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Revert <a href="http://trac.webkit.org/projects/webkit/changeset/166597">r166597</a>
https://bugs.webkit.org/show_bug.cgi?id=167951
Reviewed by Andreas Kling.
Source/WebCore:
* platform/spi/cf/CFNetworkSPI.h:
Remove now-unused SPI declaration.
Source/WebKit2:
CFURLConnectionInvalidateConnectionCache is not commonly called and is likely causing
CFNetwork to be in a strange state when using NSURLSession and invalidating the connection
cache during authentication, especially server trust evaluation. Right now we only call
it when handling memory pressure, and it isn't worth getting into such a strange state
in a poorly tested situation. See rdar://problem/27439617
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::lowMemoryHandler):
(WebKit::NetworkProcess::initializeSandbox):
(WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformspicfCFNetworkSPIh">trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessNetworkProcesscpp">trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessNetworkProcessh">trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcesscocoaNetworkProcessCocoamm">trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (211834 => 211835)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebCore/ChangeLog 2017-02-07 21:29:50 UTC (rev 211835)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2017-02-07 Alex Christensen <achristensen@webkit.org>
+
+ Revert r166597
+ https://bugs.webkit.org/show_bug.cgi?id=167951
+
+ Reviewed by Andreas Kling.
+
+ * platform/spi/cf/CFNetworkSPI.h:
+ Remove now-unused SPI declaration.
+
</ins><span class="cx"> 2017-02-07 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Try to fix the windows build.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformspicfCFNetworkSPIh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h (211834 => 211835)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h 2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h 2017-02-07 21:29:50 UTC (rev 211835)
</span><span class="lines">@@ -155,8 +155,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> #endif // PLATFORM(COCOA)
</span><span class="cx">
</span><del>-void CFURLConnectionInvalidateConnectionCache();
-
</del><span class="cx"> extern CFStringRef const kCFHTTPCookieLocalFileDomain;
</span><span class="cx"> extern const CFStringRef kCFHTTPVersion1_1;
</span><span class="cx"> extern const CFStringRef kCFURLRequestAllowAllPOSTCaching;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (211834 => 211835)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebKit2/ChangeLog 2017-02-07 21:29:50 UTC (rev 211835)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2017-02-07 Alex Christensen <achristensen@webkit.org>
+
+ Revert r166597
+ https://bugs.webkit.org/show_bug.cgi?id=167951
+
+ Reviewed by Andreas Kling.
+
+ CFURLConnectionInvalidateConnectionCache is not commonly called and is likely causing
+ CFNetwork to be in a strange state when using NSURLSession and invalidating the connection
+ cache during authentication, especially server trust evaluation. Right now we only call
+ it when handling memory pressure, and it isn't worth getting into such a strange state
+ in a poorly tested situation. See rdar://problem/27439617
+
+ * NetworkProcess/NetworkProcess.cpp:
+ (WebKit::NetworkProcess::lowMemoryHandler):
+ (WebKit::NetworkProcess::initializeSandbox):
+ (WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.
+ * NetworkProcess/NetworkProcess.h:
+ * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+ (WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.
+
</ins><span class="cx"> 2017-02-07 Brian Burg <bburg@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac] Web Automation: NSEventType not initialized in WebAutomationSession::platformSimulateMouseInteraction
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessNetworkProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (211834 => 211835)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2017-02-07 21:29:50 UTC (rev 211835)
</span><span class="lines">@@ -195,7 +195,6 @@
</span><span class="cx"> if (m_suppressMemoryPressureHandler)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- platformLowMemoryHandler(critical);
</del><span class="cx"> WTF::releaseFastMallocFreeMemory();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -655,10 +654,6 @@
</span><span class="cx"> void NetworkProcess::initializeSandbox(const ChildProcessInitializationParameters&, SandboxInitializationParameters&)
</span><span class="cx"> {
</span><span class="cx"> }
</span><del>-
-void NetworkProcess::platformLowMemoryHandler(Critical)
-{
-}
</del><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> } // namespace WebKit
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessNetworkProcessh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h (211834 => 211835)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2017-02-07 21:29:50 UTC (rev 211835)
</span><span class="lines">@@ -128,7 +128,6 @@
</span><span class="cx"> void platformTerminate();
</span><span class="cx">
</span><span class="cx"> void lowMemoryHandler(WebCore::Critical);
</span><del>- void platformLowMemoryHandler(WebCore::Critical);
</del><span class="cx">
</span><span class="cx"> // ChildProcess
</span><span class="cx"> void initializeProcess(const ChildProcessInitializationParameters&) override;
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcesscocoaNetworkProcessCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm (211834 => 211835)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2017-02-07 21:29:50 UTC (rev 211835)
</span><span class="lines">@@ -43,11 +43,6 @@
</span><span class="cx">
</span><span class="cx"> namespace WebKit {
</span><span class="cx">
</span><del>-void NetworkProcess::platformLowMemoryHandler(WebCore::Critical)
-{
- CFURLConnectionInvalidateConnectionCache();
-}
-
</del><span class="cx"> static void initializeNetworkSettings()
</span><span class="cx"> {
</span><span class="cx"> static const unsigned preferredConnectionCount = 6;
</span></span></pre>
</div>
</div>
</body>
</html>