<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211719] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211719">211719</a></dd>
<dt>Author</dt> <dd>achristensen@apple.com</dd>
<dt>Date</dt> <dd>2017-02-06 01:28:21 -0800 (Mon, 06 Feb 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Rebase API tests after <a href="http://trac.webkit.org/projects/webkit/changeset/211638">r211638</a>
https://bugs.webkit.org/show_bug.cgi?id=167779
* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
URLs with non-special schemes and characters like % in the host now fail to parse,
more like their special counterparts and according to spec.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebCoreURLParsercpp">trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (211718 => 211719)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-02-06 08:51:48 UTC (rev 211718)
+++ trunk/Tools/ChangeLog 2017-02-06 09:28:21 UTC (rev 211719)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2017-02-06 Alex Christensen <achristensen@webkit.org>
+
+ Rebase API tests after r211638
+ https://bugs.webkit.org/show_bug.cgi?id=167779
+
+ * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
+ (TestWebKitAPI::TEST_F):
+ URLs with non-special schemes and characters like % in the host now fail to parse,
+ more like their special counterparts and according to spec.
+
</ins><span class="cx"> 2017-02-06 Csaba Osztrogonác <ossy@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed trivial fix after r211697.
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebCoreURLParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp (211718 => 211719)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp 2017-02-06 08:51:48 UTC (rev 211718)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp 2017-02-06 09:28:21 UTC (rev 211719)
</span><span class="lines">@@ -980,8 +980,12 @@
</span><span class="cx"> {"http", "", "", "f", 10, "/c", "", "", "http://f:10/c"},
</span><span class="cx"> {"http", "", "", "f", 10, "/c", "", "", "http://f:010/c"});
</span><span class="cx"> checkURL("notspecial://HoSt", {"notspecial", "", "", "HoSt", 0, "", "", "", "notspecial://HoSt"});
</span><del>- checkURL("notspecial://H%6FSt", {"notspecial", "", "", "H%6FSt", 0, "", "", "", "notspecial://H%6FSt"});
- checkURL("notspecial://H%4fSt", {"notspecial", "", "", "H%4fSt", 0, "", "", "", "notspecial://H%4fSt"});
</del><ins>+ checkURLDifferences("notspecial://H%6FSt",
+ {"", "", "", "", 0, "", "", "", "notspecial://H%6FSt"},
+ {"notspecial", "", "", "H%6FSt", 0, "", "", "", "notspecial://H%6FSt"});
+ checkURLDifferences("notspecial://H%4fSt",
+ {"", "", "", "", 0, "", "", "", "notspecial://H%4fSt"},
+ {"notspecial", "", "", "H%4fSt", 0, "", "", "", "notspecial://H%4fSt"});
</ins><span class="cx"> checkURLDifferences(utf16String(u"notspecial://H😍ßt"),
</span><span class="cx"> {"notspecial", "", "", "H%F0%9F%98%8D%C3%9Ft", 0, "", "", "", "notspecial://H%F0%9F%98%8D%C3%9Ft"},
</span><span class="cx"> {"notspecial", "", "", "xn--hsst-qc83c", 0, "", "", "", "notspecial://xn--hsst-qc83c"}, testTabsValueForSurrogatePairs);
</span><span class="lines">@@ -1069,9 +1073,15 @@
</span><span class="cx"> {"asdf", "", "", "[::a:b:c:d]", 0, "", "", "", "asdf://[::a:b:c:d]"},
</span><span class="cx"> {"asdf", "", "", "[0:0:0:0:a:b:c:d]", 0, "", "", "", "asdf://[0:0:0:0:a:b:c:d]"}, TestTabs::No);
</span><span class="cx"> shouldFail("a://%:a");
</span><del>- checkURL("a://%:/", {"a", "", "", "%", 0, "/", "", "", "a://%/"});
- checkURL("a://%:", {"a", "", "", "%", 0, "", "", "", "a://%"});
- checkURL("a://%:1/", {"a", "", "", "%", 1, "/", "", "", "a://%:1/"});
</del><ins>+ checkURLDifferences("a://%:/",
+ {"", "", "", "", 0, "", "", "", "a://%:/"},
+ {"a", "", "", "%", 0, "/", "", "", "a://%/"});
+ checkURLDifferences("a://%:",
+ {"", "", "", "", 0, "", "", "", "a://%:"},
+ {"a", "", "", "%", 0, "", "", "", "a://%"});
+ checkURLDifferences("a://%:1/",
+ {"", "", "", "", 0, "", "", "", "a://%:1/"},
+ {"a", "", "", "%", 1, "/", "", "", "a://%:1/"});
</ins><span class="cx"> checkURLDifferences("http://%:",
</span><span class="cx"> {"", "", "", "", 0, "", "", "", "http://%:"},
</span><span class="cx"> {"http", "", "", "%", 0, "/", "", "", "http://%/"});
</span><span class="lines">@@ -1270,9 +1280,7 @@
</span><span class="cx"> shouldFail("http://[a:b:c:d:e:f:g:h:127.0.0.1]");
</span><span class="cx"> shouldFail("http://[a:b:c:d:e:f:127.0.0.0x11]"); // Chrome treats this as hex, Firefox and the spec fail
</span><span class="cx"> shouldFail("http://[a:b:c:d:e:f:127.0.-0.1]");
</span><del>- checkURLDifferences("asdf://space In\aHost",
- {"asdf", "", "", "space In%07Host", 0, "", "", "", "asdf://space In%07Host"},
- {"", "", "", "", 0, "", "", "", "asdf://space In\aHost"});
</del><ins>+ shouldFail("asdf://space In\aHost");
</ins><span class="cx"> shouldFail("asdf://[0:0:0:0:a:b:c:d");
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>