<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211454] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211454">211454</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-01-31 15:38:47 -0800 (Tue, 31 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove unused/rarely used bindings helpers
https://bugs.webkit.org/show_bug.cgi?id=167648
Patch by Sam Weinig <sam@webkit.org> on 2017-01-31
Reviewed by Anders Carlsson.
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
(WebCore::jsString): Deleted.
(WebCore::jsStringOrUndefined): Deleted.
(WebCore::finiteInt32Value): Deleted.
(WebCore::toJS): Deleted.
Remove unused functions. The toJS overrides can be replaced with their
modern JSDOMConvert counterparts.
* bindings/js/JSDOMExceptionHandling.h:
(WebCore::toJS): Deleted.
(WebCore::toJSNewlyCreated): Deleted.
Remove unused functions.
* bindings/js/JSDOMIterator.h:
Add more specific include of JSDOMConvert.h to fix compile.
* bindings/js/JSDOMPromise.cpp:
(WebCore::DeferredPromise::reject):
Create the Symbol directly, instead of using the toJS override.
* bindings/js/JSWorkerCustom.cpp:
(WebCore::constructJSWorker):
Use JSDOMConvert toJS function.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::retrieveResponse):
Use JSDOMConvert toJS functions.
* bindings/js/ScriptController.h:
Add missing forward declaration of URL.
* bindings/js/ScriptModuleLoader.cpp:
(WebCore::ScriptModuleLoader::resolve):
Create the Symbol directly, instead of using the toJS override.
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
Use JSDOMConvert toJS functions.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMBindingcpp">trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMBindingh">trunk/Source/WebCore/bindings/js/JSDOMBinding.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMExceptionHandlingh">trunk/Source/WebCore/bindings/js/JSDOMExceptionHandling.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMIteratorh">trunk/Source/WebCore/bindings/js/JSDOMIterator.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMPromisecpp">trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSWorkerCustomcpp">trunk/Source/WebCore/bindings/js/JSWorkerCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSXMLHttpRequestCustomcpp">trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsScriptControllerh">trunk/Source/WebCore/bindings/js/ScriptController.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsScriptModuleLoadercpp">trunk/Source/WebCore/bindings/js/ScriptModuleLoader.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLPlugInImageElementcpp">trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (211453 => 211454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-31 23:28:22 UTC (rev 211453)
+++ trunk/Source/WebCore/ChangeLog 2017-01-31 23:38:47 UTC (rev 211454)
</span><span class="lines">@@ -1,3 +1,50 @@
</span><ins>+2017-01-31 Sam Weinig <sam@webkit.org>
+
+ Remove unused/rarely used bindings helpers
+ https://bugs.webkit.org/show_bug.cgi?id=167648
+
+ Reviewed by Anders Carlsson.
+
+ * bindings/js/JSDOMBinding.cpp:
+ * bindings/js/JSDOMBinding.h:
+ (WebCore::jsString): Deleted.
+ (WebCore::jsStringOrUndefined): Deleted.
+ (WebCore::finiteInt32Value): Deleted.
+ (WebCore::toJS): Deleted.
+ Remove unused functions. The toJS overrides can be replaced with their
+ modern JSDOMConvert counterparts.
+
+ * bindings/js/JSDOMExceptionHandling.h:
+ (WebCore::toJS): Deleted.
+ (WebCore::toJSNewlyCreated): Deleted.
+ Remove unused functions.
+
+ * bindings/js/JSDOMIterator.h:
+ Add more specific include of JSDOMConvert.h to fix compile.
+
+ * bindings/js/JSDOMPromise.cpp:
+ (WebCore::DeferredPromise::reject):
+ Create the Symbol directly, instead of using the toJS override.
+
+ * bindings/js/JSWorkerCustom.cpp:
+ (WebCore::constructJSWorker):
+ Use JSDOMConvert toJS function.
+
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ (WebCore::JSXMLHttpRequest::retrieveResponse):
+ Use JSDOMConvert toJS functions.
+
+ * bindings/js/ScriptController.h:
+ Add missing forward declaration of URL.
+
+ * bindings/js/ScriptModuleLoader.cpp:
+ (WebCore::ScriptModuleLoader::resolve):
+ Create the Symbol directly, instead of using the toJS override.
+
+ * html/HTMLPlugInImageElement.cpp:
+ (WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
+ Use JSDOMConvert toJS functions.
+
</ins><span class="cx"> 2017-01-31 Wenson Hsieh <wenson_hsieh@apple.com>
</span><span class="cx">
</span><span class="cx"> WebItemProviderPasteboard should be robust when UIItemProvider fails to initialize an object
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMBindingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp (211453 => 211454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp 2017-01-31 23:28:22 UTC (rev 211453)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp 2017-01-31 23:38:47 UTC (rev 211454)
</span><span class="lines">@@ -56,18 +56,6 @@
</span><span class="cx"> return jsStringWithCache(exec, s);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-JSValue jsString(ExecState* exec, const URL& url)
-{
- return jsStringWithCache(exec, url.string());
-}
-
-JSValue jsStringOrUndefined(ExecState* exec, const URL& url)
-{
- if (url.isNull())
- return jsUndefined();
- return jsStringWithCache(exec, url.string());
-}
-
</del><span class="cx"> static inline String stringToByteString(ExecState& state, JSC::ThrowScope& scope, String&& string)
</span><span class="cx"> {
</span><span class="cx"> if (!string.containsOnlyLatin1()) {
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMBindingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (211453 => 211454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2017-01-31 23:28:22 UTC (rev 211453)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2017-01-31 23:38:47 UTC (rev 211454)
</span><span class="lines">@@ -53,14 +53,9 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class URL;
-
</del><span class="cx"> void addImpureProperty(const AtomicString&);
</span><span class="cx">
</span><del>-JSC::JSValue jsString(JSC::ExecState*, const URL&); // empty if the URL is null
-
</del><span class="cx"> JSC::JSValue jsStringOrUndefined(JSC::ExecState*, const String&); // undefined if the string is null
</span><del>-JSC::JSValue jsStringOrUndefined(JSC::ExecState*, const URL&); // undefined if the URL is null
</del><span class="cx">
</span><span class="cx"> // See JavaScriptCore for explanation: Should be used for any string that is already owned by another
</span><span class="cx"> // object, to let the engine know that collecting the JSString wrapper is unlikely to save memory.
</span><span class="lines">@@ -74,8 +69,6 @@
</span><span class="cx"> WEBCORE_EXPORT String identifierToUSVString(JSC::ExecState&, const JSC::Identifier&);
</span><span class="cx"> WEBCORE_EXPORT String valueToUSVString(JSC::ExecState&, JSC::JSValue);
</span><span class="cx">
</span><del>-int32_t finiteInt32Value(JSC::JSValue, JSC::ExecState*, bool& okay);
-
</del><span class="cx"> // The following functions convert values to integers as per the WebIDL specification.
</span><span class="cx"> // The conversion fails if the value cannot be converted to a number or, if EnforceRange is specified,
</span><span class="cx"> // the value is outside the range of the destination integer type.
</span><span class="lines">@@ -114,11 +107,6 @@
</span><span class="cx"> JSC::JSValue toJS(JSC::ExecState*, JSC::JSGlobalObject*, JSC::ArrayBufferView&);
</span><span class="cx"> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, JSC::ArrayBuffer*);
</span><span class="cx"> JSC::JSValue toJS(JSC::ExecState*, JSC::JSGlobalObject*, JSC::ArrayBufferView*);
</span><del>-template<typename T> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, Ref<T>&&);
-template<typename T> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, RefPtr<T>&&);
-template<typename T> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, const Vector<T>&);
-template<typename T> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, const Vector<RefPtr<T>>&);
-JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, const JSC::PrivateName&);
</del><span class="cx">
</span><span class="cx"> RefPtr<JSC::ArrayBufferView> toPossiblySharedArrayBufferView(JSC::VM&, JSC::JSValue);
</span><span class="cx"> RefPtr<JSC::Int8Array> toPossiblySharedInt8Array(JSC::VM&, JSC::JSValue);
</span><span class="lines">@@ -152,13 +140,6 @@
</span><span class="cx">
</span><span class="cx"> // Inline functions and template definitions.
</span><span class="cx">
</span><del>-inline int32_t finiteInt32Value(JSC::JSValue value, JSC::ExecState* exec, bool& okay)
-{
- double number = value.toNumber(exec);
- okay = std::isfinite(number);
- return JSC::toInt32(number);
-}
-
</del><span class="cx"> inline JSC::JSValue toJS(JSC::ExecState* state, JSDOMGlobalObject* globalObject, JSC::ArrayBuffer& buffer)
</span><span class="cx"> {
</span><span class="cx"> if (auto result = getCachedWrapper(globalObject->world(), buffer))
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMExceptionHandlingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMExceptionHandling.h (211453 => 211454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMExceptionHandling.h 2017-01-31 23:28:22 UTC (rev 211453)
+++ trunk/Source/WebCore/bindings/js/JSDOMExceptionHandling.h 2017-01-31 23:38:47 UTC (rev 211454)
</span><span class="lines">@@ -87,15 +87,8 @@
</span><span class="cx"> JSC::JSValue createDOMException(JSC::ExecState*, ExceptionCode, const String&);
</span><span class="cx">
</span><span class="cx"> // Convert a DOM implementation exception into a JavaScript exception in the execution state.
</span><del>-void propagateException(JSC::ExecState&, JSC::ThrowScope&, Exception&&);
</del><span class="cx"> WEBCORE_EXPORT void propagateExceptionSlowPath(JSC::ExecState&, JSC::ThrowScope&, Exception&&);
</span><span class="cx">
</span><del>-// ExceptionOr handling.
-void propagateException(JSC::ExecState&, JSC::ThrowScope&, ExceptionOr<void>&&);
-template<typename T> JSC::JSValue toJS(JSC::ExecState&, JSDOMGlobalObject&, JSC::ThrowScope&, ExceptionOr<T>&&);
-template<typename T> JSC::JSValue toJSNewlyCreated(JSC::ExecState&, JSDOMGlobalObject&, JSC::ThrowScope&, ExceptionOr<T>&& value);
-
-
</del><span class="cx"> ALWAYS_INLINE void propagateException(JSC::ExecState& state, JSC::ThrowScope& throwScope, Exception&& exception)
</span><span class="cx"> {
</span><span class="cx"> if (throwScope.exception())
</span><span class="lines">@@ -109,22 +102,4 @@
</span><span class="cx"> propagateException(state, throwScope, value.releaseException());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-template<typename T> inline JSC::JSValue toJS(JSC::ExecState& state, JSDOMGlobalObject& globalObject, JSC::ThrowScope& throwScope, ExceptionOr<T>&& value)
-{
- if (UNLIKELY(value.hasException())) {
- propagateException(state, throwScope, value.releaseException());
- return { };
- }
- return toJS(&state, &globalObject, value.releaseReturnValue());
-}
-
-template<typename T> inline JSC::JSValue toJSNewlyCreated(JSC::ExecState& state, JSDOMGlobalObject& globalObject, JSC::ThrowScope& throwScope, ExceptionOr<T>&& value)
-{
- if (UNLIKELY(value.hasException())) {
- propagateException(state, throwScope, value.releaseException());
- return { };
- }
- return toJSNewlyCreated(&state, &globalObject, value.releaseReturnValue());
-}
-
</del><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMIteratorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMIterator.h (211453 => 211454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMIterator.h 2017-01-31 23:28:22 UTC (rev 211453)
+++ trunk/Source/WebCore/bindings/js/JSDOMIterator.h 2017-01-31 23:38:47 UTC (rev 211454)
</span><span class="lines">@@ -26,7 +26,7 @@
</span><span class="cx">
</span><span class="cx"> #pragma once
</span><span class="cx">
</span><del>-#include "JSDOMBinding.h"
</del><ins>+#include "JSDOMConvert.h"
</ins><span class="cx"> #include <runtime/IteratorPrototype.h>
</span><span class="cx"> #include <runtime/JSDestructibleObject.h>
</span><span class="cx"> #include <type_traits>
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMPromisecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp (211453 => 211454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp 2017-01-31 23:28:22 UTC (rev 211453)
+++ trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp 2017-01-31 23:38:47 UTC (rev 211454)
</span><span class="lines">@@ -149,7 +149,7 @@
</span><span class="cx"> ASSERT(m_globalObject);
</span><span class="cx"> JSC::ExecState* state = m_globalObject->globalExec();
</span><span class="cx"> JSC::JSLockHolder locker(state);
</span><del>- reject(*state, toJS(state, m_globalObject.get(), privateName));
</del><ins>+ reject(*state, JSC::Symbol::create(state->vm(), privateName.uid()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void rejectPromiseWithExceptionIfAny(JSC::ExecState& state, JSDOMGlobalObject& globalObject, JSPromiseDeferred& promiseDeferred)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSWorkerCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSWorkerCustom.cpp (211453 => 211454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSWorkerCustom.cpp 2017-01-31 23:28:22 UTC (rev 211453)
+++ trunk/Source/WebCore/bindings/js/JSWorkerCustom.cpp 2017-01-31 23:38:47 UTC (rev 211454)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx"> auto& window = asJSDOMWindow(state.lexicalGlobalObject())->wrapped();
</span><span class="cx">
</span><span class="cx"> ASSERT(window.document());
</span><del>- return JSValue::encode(toJSNewlyCreated(state, globalObject, scope, Worker::create(*window.document(), scriptURL, globalObject.runtimeFlags())));
</del><ins>+ return JSValue::encode(toJSNewlyCreated<IDLInterface<Worker>>(state, globalObject, scope, Worker::create(*window.document(), scriptURL, globalObject.runtimeFlags())));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSXMLHttpRequestCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp (211453 => 211454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp 2017-01-31 23:28:22 UTC (rev 211453)
+++ trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp 2017-01-31 23:38:47 UTC (rev 211454)
</span><span class="lines">@@ -39,6 +39,7 @@
</span><span class="cx"> #include "HTMLDocument.h"
</span><span class="cx"> #include "InspectorInstrumentation.h"
</span><span class="cx"> #include "JSBlob.h"
</span><ins>+#include "JSDOMConvert.h"
</ins><span class="cx"> #include "JSDOMFormData.h"
</span><span class="cx"> #include "JSDOMWindowCustom.h"
</span><span class="cx"> #include "JSDocument.h"
</span><span class="lines">@@ -189,16 +190,16 @@
</span><span class="cx"> case XMLHttpRequest::ResponseType::Document: {
</span><span class="cx"> auto document = wrapped().responseXML();
</span><span class="cx"> ASSERT(!document.hasException());
</span><del>- value = toJS(&state, globalObject(), document.releaseReturnValue());
</del><ins>+ value = toJS<IDLInterface<Document>>(state, *globalObject(), document.releaseReturnValue());
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> case XMLHttpRequest::ResponseType::Blob:
</span><del>- value = toJSNewlyCreated(&state, globalObject(), wrapped().createResponseBlob());
</del><ins>+ value = toJSNewlyCreated<IDLInterface<Blob>>(state, *globalObject(), wrapped().createResponseBlob());
</ins><span class="cx"> break;
</span><span class="cx">
</span><span class="cx"> case XMLHttpRequest::ResponseType::Arraybuffer:
</span><del>- value = toJS(&state, globalObject(), wrapped().createResponseArrayBuffer());
</del><ins>+ value = toJS<IDLInterface<ArrayBuffer>>(state, *globalObject(), wrapped().createResponseArrayBuffer());
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsScriptControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/ScriptController.h (211453 => 211454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/ScriptController.h 2017-01-31 23:28:22 UTC (rev 211453)
+++ trunk/Source/WebCore/bindings/js/ScriptController.h 2017-01-31 23:38:47 UTC (rev 211454)
</span><span class="lines">@@ -58,6 +58,7 @@
</span><span class="cx"> class LoadableModuleScript;
</span><span class="cx"> class ScriptSourceCode;
</span><span class="cx"> class SecurityOrigin;
</span><ins>+class URL;
</ins><span class="cx"> class Widget;
</span><span class="cx"> struct ExceptionDetails;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsScriptModuleLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/ScriptModuleLoader.cpp (211453 => 211454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/ScriptModuleLoader.cpp 2017-01-31 23:28:22 UTC (rev 211453)
+++ trunk/Source/WebCore/bindings/js/ScriptModuleLoader.cpp 2017-01-31 23:38:47 UTC (rev 211454)
</span><span class="lines">@@ -90,7 +90,7 @@
</span><span class="cx"> // So there is no correct URL to retrieve the module source code. If the module name
</span><span class="cx"> // value is a Symbol, it is used directly as a module key.
</span><span class="cx"> if (moduleNameValue.isSymbol()) {
</span><del>- promise->resolve<IDLAny>(toJS(exec, &globalObject, asSymbol(moduleNameValue)->privateName()));
</del><ins>+ promise->resolve<IDLAny>(JSC::Symbol::create(exec->vm(), asSymbol(moduleNameValue)->privateName().uid()));
</ins><span class="cx"> return jsPromise.promise();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLPlugInImageElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp (211453 => 211454)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2017-01-31 23:28:22 UTC (rev 211453)
+++ trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2017-01-31 23:38:47 UTC (rev 211454)
</span><span class="lines">@@ -356,13 +356,13 @@
</span><span class="cx"> auto& state = *globalObject.globalExec();
</span><span class="cx">
</span><span class="cx"> JSC::MarkedArgumentBuffer argList;
</span><del>- argList.append(toJS(&state, &globalObject, root));
- argList.append(jsString(&state, titleText(*page, mimeType)));
- argList.append(jsString(&state, subtitleText(*page, mimeType)));
</del><ins>+ argList.append(toJS<IDLInterface<ShadowRoot>>(state, globalObject, root));
+ argList.append(toJS<IDLDOMString>(state, titleText(*page, mimeType)));
+ argList.append(toJS<IDLDOMString>(state, subtitleText(*page, mimeType)));
</ins><span class="cx">
</span><span class="cx"> // This parameter determines whether or not the snapshot overlay should always be visible over the plugin snapshot.
</span><span class="cx"> // If no snapshot was found then we want the overlay to be visible.
</span><del>- argList.append(JSC::jsBoolean(!m_snapshotImage));
</del><ins>+ argList.append(toJS<IDLBoolean>(!m_snapshotImage));
</ins><span class="cx">
</span><span class="cx"> // It is expected the JS file provides a createOverlay(shadowRoot, title, subtitle) function.
</span><span class="cx"> auto* overlay = globalObject.get(&state, JSC::Identifier::fromString(&state, "createOverlay")).toObject(&state);
</span></span></pre>
</div>
</div>
</body>
</html>