<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211445] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211445">211445</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-01-31 13:04:27 -0800 (Tue, 31 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: User Settings: Secondary-clicking the New Tab and Settings tabs should not produce a context menu
https://bugs.webkit.org/show_bug.cgi?id=167651
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2017-01-31
Reviewed by Joseph Pecoraro.
* UserInterface/Views/PinnedTabBarItem.js:
(WebInspector.PinnedTabBarItem):
(WebInspector.PinnedTabBarItem.prototype._handleContextMenuEvent):
Always preventDefault() to ensure that the system context menu is never shown.
* UserInterface/Views/TabBar.js:
(WebInspector.TabBar):
(WebInspector.TabBar.prototype.get newTabTabBarItem):
(WebInspector.TabBar.prototype._handleNewTabContextMenu): Deleted.
Move the event dispatch to WebInspector.PinnedTabBarItem to give all instances a contextmenu
event handler.
* UserInterface/Views/TabBrowser.js:
(WebInspector.TabBrowser):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsPinnedTabBarItemjs">trunk/Source/WebInspectorUI/UserInterface/Views/PinnedTabBarItem.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTabBarjs">trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTabBrowserjs">trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (211444 => 211445)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2017-01-31 20:45:45 UTC (rev 211444)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-01-31 21:04:27 UTC (rev 211445)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2017-01-31 Devin Rousso <dcrousso+webkit@gmail.com>
+
+ Web Inspector: User Settings: Secondary-clicking the New Tab and Settings tabs should not produce a context menu
+ https://bugs.webkit.org/show_bug.cgi?id=167651
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/PinnedTabBarItem.js:
+ (WebInspector.PinnedTabBarItem):
+ (WebInspector.PinnedTabBarItem.prototype._handleContextMenuEvent):
+ Always preventDefault() to ensure that the system context menu is never shown.
+
+ * UserInterface/Views/TabBar.js:
+ (WebInspector.TabBar):
+ (WebInspector.TabBar.prototype.get newTabTabBarItem):
+ (WebInspector.TabBar.prototype._handleNewTabContextMenu): Deleted.
+ Move the event dispatch to WebInspector.PinnedTabBarItem to give all instances a contextmenu
+ event handler.
+
+ * UserInterface/Views/TabBrowser.js:
+ (WebInspector.TabBrowser):
+
</ins><span class="cx"> 2017-01-31 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Address some ESLint warnings
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsPinnedTabBarItemjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/PinnedTabBarItem.js (211444 => 211445)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/PinnedTabBarItem.js 2017-01-31 20:45:45 UTC (rev 211444)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/PinnedTabBarItem.js 2017-01-31 21:04:27 UTC (rev 211445)
</span><span class="lines">@@ -30,5 +30,22 @@
</span><span class="cx"> super(image, title, representedObject);
</span><span class="cx">
</span><span class="cx"> this.element.classList.add("pinned");
</span><ins>+
+ this.element.addEventListener("contextmenu", this._handleContextMenuEvent.bind(this));
</ins><span class="cx"> }
</span><ins>+
+ // Private
+
+ _handleContextMenuEvent(event)
+ {
+ event.preventDefault();
+
+ let contextMenu = WebInspector.ContextMenu.createFromEvent(event);
+
+ this.dispatchEventToListeners(WebInspector.PinnedTabBarItem.Event.ContextMenu, {contextMenu});
+ }
</ins><span class="cx"> };
</span><ins>+
+WebInspector.PinnedTabBarItem.Event = {
+ ContextMenu: "pinned-tab-bar-item-context-menu",
+};
</ins></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTabBarjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js (211444 => 211445)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js 2017-01-31 20:45:45 UTC (rev 211444)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js 2017-01-31 21:04:27 UTC (rev 211445)
</span><span class="lines">@@ -49,12 +49,13 @@
</span><span class="cx"> this._newTabTabBarItem = new WebInspector.PinnedTabBarItem("Images/NewTabPlus.svg", WebInspector.UIString("Create a new tab"));
</span><span class="cx"> this._newTabTabBarItem.element.addEventListener("mouseenter", this._handleNewTabMouseEnter.bind(this));
</span><span class="cx"> this._newTabTabBarItem.element.addEventListener("click", this._handleNewTabClick.bind(this));
</span><del>- this._newTabTabBarItem.element.addEventListener("contextmenu", this._handleNewTabContextMenu.bind(this));
</del><span class="cx"> this.addTabBarItem(this._newTabTabBarItem, true);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Public
</span><span class="cx">
</span><ins>+ get newTabTabBarItem() { return this._newTabTabBarItem; }
+
</ins><span class="cx"> updateNewTabTabBarItemState()
</span><span class="cx"> {
</span><span class="cx"> let newTabExists = !WebInspector.isNewTabWithTypeAllowed(WebInspector.NewTabContentView.Type);
</span><span class="lines">@@ -729,13 +730,6 @@
</span><span class="cx"> WebInspector.showNewTabTab(shouldAnimate);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- _handleNewTabContextMenu(event)
- {
- let contextMenu = WebInspector.ContextMenu.createFromEvent(event);
-
- this.dispatchEventToListeners(WebInspector.TabBar.Event.NewTabContextMenu, {contextMenu});
- }
-
</del><span class="cx"> _handleNewTabMouseEnter(event)
</span><span class="cx"> {
</span><span class="cx"> if (!this._tabAnimatedClosedSinceMouseEnter || !this.element.classList.contains("static-layout") || this.element.classList.contains("animating"))
</span><span class="lines">@@ -750,6 +744,5 @@
</span><span class="cx"> TabBarItemAdded: "tab-bar-tab-bar-item-added",
</span><span class="cx"> TabBarItemRemoved: "tab-bar-tab-bar-item-removed",
</span><span class="cx"> TabBarItemsReordered: "tab-bar-tab-bar-items-reordered",
</span><del>- NewTabContextMenu: "tab-bar-new-tab-contextmenu",
</del><span class="cx"> OpenDefaultTab: "tab-bar-open-default-tab"
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTabBrowserjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js (211444 => 211445)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js 2017-01-31 20:45:45 UTC (rev 211444)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js 2017-01-31 21:04:27 UTC (rev 211445)
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx"> this._tabBar.addEventListener(WebInspector.TabBar.Event.TabBarItemSelected, this._tabBarItemSelected, this);
</span><span class="cx"> this._tabBar.addEventListener(WebInspector.TabBar.Event.TabBarItemAdded, this._tabBarItemAdded, this);
</span><span class="cx"> this._tabBar.addEventListener(WebInspector.TabBar.Event.TabBarItemRemoved, this._tabBarItemRemoved, this);
</span><del>- this._tabBar.addEventListener(WebInspector.TabBar.Event.NewTabContextMenu, this._handleNewTabContextMenu, this);
</del><ins>+ this._tabBar.newTabTabBarItem.addEventListener(WebInspector.PinnedTabBarItem.Event.ContextMenu, this._handleNewTabContextMenu, this);
</ins><span class="cx">
</span><span class="cx"> this._recentTabContentViews = [];
</span><span class="cx"> this._closedTabClasses = new Set;
</span></span></pre>
</div>
</div>
</body>
</html>