<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211395] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211395">211395</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-01-30 16:22:27 -0800 (Mon, 30 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Drop legacy Attributes.isId attribute
https://bugs.webkit.org/show_bug.cgi?id=167603
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
* web-platform-tests/dom/historical-expected.txt:
Source/WebCore:
Drop legacy Attributes.isId attribute.
This attribute is not in the specification:
- https://dom.spec.whatwg.org/#interface-attr
Both Firefox and Chrome currently do not expose this attribute.
No new tests, rebaselined existing test.
* dom/Attr.cpp:
* dom/Attr.h:
* dom/Attr.idl:
Source/WebKit/mac:
Keep Attr.isId in ObjC bindings.
* DOM/DOMAttr.mm:
(-[DOMAttr isId]):
LayoutTests:
Drop outdated tests.
* dom/xhtml/level3/core/attrisid04-expected.txt: Removed.
* dom/xhtml/level3/core/attrisid04.xhtml: Removed.
* dom/xhtml/level3/core/attrisid05-expected.txt: Removed.
* dom/xhtml/level3/core/attrisid05.xhtml: Removed.
* fast/dom/Attr/change-id-via-attr-node-value-expected.txt:
* fast/dom/Attr/change-id-via-attr-node-value.html:
* fast/dom/Element/attrisid-extra01-expected.txt: Removed.
* fast/dom/Element/attrisid-extra01.html: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomAttrchangeidviaattrnodevalueexpectedtxt">trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomAttrchangeidviaattrnodevaluehtml">trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomhistoricalexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomAttrcpp">trunk/Source/WebCore/dom/Attr.cpp</a></li>
<li><a href="#trunkSourceWebCoredomAttrh">trunk/Source/WebCore/dom/Attr.h</a></li>
<li><a href="#trunkSourceWebCoredomAttridl">trunk/Source/WebCore/dom/Attr.idl</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacDOMDOMAttrmm">trunk/Source/WebKit/mac/DOM/DOMAttr.mm</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsdomxhtmllevel3coreattrisid04expectedtxt">trunk/LayoutTests/dom/xhtml/level3/core/attrisid04-expected.txt</a></li>
<li><a href="#trunkLayoutTestsdomxhtmllevel3coreattrisid04xhtml">trunk/LayoutTests/dom/xhtml/level3/core/attrisid04.xhtml</a></li>
<li><a href="#trunkLayoutTestsdomxhtmllevel3coreattrisid05expectedtxt">trunk/LayoutTests/dom/xhtml/level3/core/attrisid05-expected.txt</a></li>
<li><a href="#trunkLayoutTestsdomxhtmllevel3coreattrisid05xhtml">trunk/LayoutTests/dom/xhtml/level3/core/attrisid05.xhtml</a></li>
<li><a href="#trunkLayoutTestsfastdomElementattrisidextra01expectedtxt">trunk/LayoutTests/fast/dom/Element/attrisid-extra01-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomElementattrisidextra01html">trunk/LayoutTests/fast/dom/Element/attrisid-extra01.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/ChangeLog 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2017-01-30 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Drop legacy Attributes.isId attribute
+ https://bugs.webkit.org/show_bug.cgi?id=167603
+
+ Reviewed by Ryosuke Niwa.
+
+ Drop outdated tests.
+
+ * dom/xhtml/level3/core/attrisid04-expected.txt: Removed.
+ * dom/xhtml/level3/core/attrisid04.xhtml: Removed.
+ * dom/xhtml/level3/core/attrisid05-expected.txt: Removed.
+ * dom/xhtml/level3/core/attrisid05.xhtml: Removed.
+ * fast/dom/Attr/change-id-via-attr-node-value-expected.txt:
+ * fast/dom/Attr/change-id-via-attr-node-value.html:
+ * fast/dom/Element/attrisid-extra01-expected.txt: Removed.
+ * fast/dom/Element/attrisid-extra01.html: Removed.
+
+2017-01-30 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Drop legacy constants on Event interface
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=167602
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsdomxhtmllevel3coreattrisid04expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/dom/xhtml/level3/core/attrisid04-expected.txt (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/dom/xhtml/level3/core/attrisid04-expected.txt 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/dom/xhtml/level3/core/attrisid04-expected.txt 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -1,2 +0,0 @@
</span><del>-Test http://www.w3.org/2001/DOM-Test-Suite/level3/core/attrisid04
-Status Success
</del></span></pre></div>
<a id="trunkLayoutTestsdomxhtmllevel3coreattrisid04xhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/dom/xhtml/level3/core/attrisid04.xhtml (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/dom/xhtml/level3/core/attrisid04.xhtml 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/dom/xhtml/level3/core/attrisid04.xhtml 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -1,73 +0,0 @@
</span><del>-<?xml version="1.0"?><?TEST-STYLE PIDATA?>
-<!DOCTYPE html
- PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
- "xhtml1-strict.dtd" [
- <!ENTITY alpha "&#945;">
- <!ENTITY beta "&#946;">
- <!ENTITY gamma "&#947;">
- <!ENTITY delta "&#948;">
- <!ENTITY epsilon "&#949;">
- <!ENTITY alpha "&#950;">
- <!NOTATION notation1 PUBLIC "notation1File">
- <!NOTATION notation2 SYSTEM "notation2File">
- <!ATTLIST p
- dir CDATA 'rtl'
- xmlns:dmstc CDATA #IMPLIED
- xmlns:nm CDATA #IMPLIED
- xmlns:emp2 CDATA #IMPLIED>
- <!ATTLIST html
- xmlns:xsi CDATA #IMPLIED
- xsi:schemaLocation CDATA #IMPLIED>
- <!ATTLIST acronym xsi:noNamespaceSchemaLocation CDATA #IMPLIED>
- <!ENTITY ent4 "<span xmlns='http://www.w3.org/1999/xhtml'>Element data</span><?PItarget PIdata?>">
- <!ATTLIST span xmlns CDATA #IMPLIED>
-]>
-<!-- This is comment number 1.-->
-<html xmlns='http://www.w3.org/1999/xhtml'
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://www.w3.org/1999/xhtml hc_staff.xsd"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/><title>hc_staff</title><script type="text/javascript" src="selfxhtml.js"/><script charset="UTF-8" type="text/javascript" src="attrisid04.js"/><script type='text/javascript'>function loadComplete() { startTest(); }</script></head><body onload="loadComplete()">
- <p xmlns:dmstc="http://www.usa.com">
- <em>EMP0001</em>
- <strong>Margaret Martin</strong>
- <code>Accountant</code>
- <sup>56,000</sup>
- <var>Female</var>
- <acronym title="Yes" xsi:noNamespaceSchemaLocation="Yes">1230 North Ave. Dallas, Texas 98551</acronym>
- </p>
- <p xmlns:dmstc="http://www.usa.com">
- <em>EMP0002</em>
- <strong>Martha Raynolds
-<![CDATA[This is a CDATASection with EntityReference number 2 &ent2;]]>
-<![CDATA[This is an adjacent CDATASection with a reference to a tab &tab;]]></strong>
- <code>Secretary</code>
- <sup>35,000</sup>
- <var>Female</var>
- <acronym title="Yes" class="Yes" xsi:noNamespaceSchemaLocation="Yes">&beta; Dallas, &gamma;
- 98554</acronym>
- </p>
- <p xmlns:dmstc="http://www.netzero.com">
- <em>EMP0003</em>
- <strong>Roger
- Jones</strong>
- <code>Department Manager</code>
- <sup>100,000</sup>
- <var>&ent4;</var>
- <acronym title="Yes" class="No" id="_98553" xsi:noNamespaceSchemaLocation="Yes">PO Box 27 Irving, texas 98553</acronym>
- </p>
- <p xmlns:nm="http://www.altavista.com">
- <em>EMP0004</em>
- <strong>Jeny Oconnor</strong>
- <code>Personnel Director</code>
- <sup>95,000</sup>
- <var>Female</var>
- <acronym title="Yes" class="Y&alpha;" id="_98556" xsi:noNamespaceSchemaLocation="Yes">27 South Road. Dallas, Texas 98556</acronym>
- </p>
- <p xmlns:emp2="http://www.nist.gov">
- <em>EMP0005</em>
- <strong>Robert Myers</strong>
- <code>Computer Specialist</code>
- <sup>90,000</sup>
- <var>male</var>
- <acronym title="Yes" class="Yes" xsi:noNamespaceSchemaLocation="Yes">1821 Nordic. Road, Irving Texas 98558</acronym>
- </p>
-</body></html>
</del></span></pre></div>
<a id="trunkLayoutTestsdomxhtmllevel3coreattrisid05expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/dom/xhtml/level3/core/attrisid05-expected.txt (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/dom/xhtml/level3/core/attrisid05-expected.txt 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/dom/xhtml/level3/core/attrisid05-expected.txt 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -1,2 +0,0 @@
</span><del>-Test http://www.w3.org/2001/DOM-Test-Suite/level3/core/attrisid05
-Status Success
</del></span></pre></div>
<a id="trunkLayoutTestsdomxhtmllevel3coreattrisid05xhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/dom/xhtml/level3/core/attrisid05.xhtml (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/dom/xhtml/level3/core/attrisid05.xhtml 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/dom/xhtml/level3/core/attrisid05.xhtml 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -1,73 +0,0 @@
</span><del>-<?xml version="1.0"?><?TEST-STYLE PIDATA?>
-<!DOCTYPE html
- PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
- "xhtml1-strict.dtd" [
- <!ENTITY alpha "&#945;">
- <!ENTITY beta "&#946;">
- <!ENTITY gamma "&#947;">
- <!ENTITY delta "&#948;">
- <!ENTITY epsilon "&#949;">
- <!ENTITY alpha "&#950;">
- <!NOTATION notation1 PUBLIC "notation1File">
- <!NOTATION notation2 SYSTEM "notation2File">
- <!ATTLIST p
- dir CDATA 'rtl'
- xmlns:dmstc CDATA #IMPLIED
- xmlns:nm CDATA #IMPLIED
- xmlns:emp2 CDATA #IMPLIED>
- <!ATTLIST html
- xmlns:xsi CDATA #IMPLIED
- xsi:schemaLocation CDATA #IMPLIED>
- <!ATTLIST acronym xsi:noNamespaceSchemaLocation CDATA #IMPLIED>
- <!ENTITY ent4 "<span xmlns='http://www.w3.org/1999/xhtml'>Element data</span><?PItarget PIdata?>">
- <!ATTLIST span xmlns CDATA #IMPLIED>
-]>
-<!-- This is comment number 1.-->
-<html xmlns='http://www.w3.org/1999/xhtml'
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://www.w3.org/1999/xhtml hc_staff.xsd"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/><title>hc_staff</title><script type="text/javascript" src="selfxhtml.js"/><script charset="UTF-8" type="text/javascript" src="attrisid05.js"/><script type='text/javascript'>function loadComplete() { startTest(); }</script></head><body onload="loadComplete()">
- <p xmlns:dmstc="http://www.usa.com">
- <em>EMP0001</em>
- <strong>Margaret Martin</strong>
- <code>Accountant</code>
- <sup>56,000</sup>
- <var>Female</var>
- <acronym title="Yes" xsi:noNamespaceSchemaLocation="Yes">1230 North Ave. Dallas, Texas 98551</acronym>
- </p>
- <p xmlns:dmstc="http://www.usa.com">
- <em>EMP0002</em>
- <strong>Martha Raynolds
-<![CDATA[This is a CDATASection with EntityReference number 2 &ent2;]]>
-<![CDATA[This is an adjacent CDATASection with a reference to a tab &tab;]]></strong>
- <code>Secretary</code>
- <sup>35,000</sup>
- <var>Female</var>
- <acronym title="Yes" class="Yes" xsi:noNamespaceSchemaLocation="Yes">&beta; Dallas, &gamma;
- 98554</acronym>
- </p>
- <p xmlns:dmstc="http://www.netzero.com">
- <em>EMP0003</em>
- <strong>Roger
- Jones</strong>
- <code>Department Manager</code>
- <sup>100,000</sup>
- <var>&ent4;</var>
- <acronym title="Yes" class="No" id="_98553" xsi:noNamespaceSchemaLocation="Yes">PO Box 27 Irving, texas 98553</acronym>
- </p>
- <p xmlns:nm="http://www.altavista.com">
- <em>EMP0004</em>
- <strong>Jeny Oconnor</strong>
- <code>Personnel Director</code>
- <sup>95,000</sup>
- <var>Female</var>
- <acronym title="Yes" class="Y&alpha;" id="_98556" xsi:noNamespaceSchemaLocation="Yes">27 South Road. Dallas, Texas 98556</acronym>
- </p>
- <p xmlns:emp2="http://www.nist.gov">
- <em>EMP0005</em>
- <strong>Robert Myers</strong>
- <code>Computer Specialist</code>
- <sup>90,000</sup>
- <var>male</var>
- <acronym title="Yes" class="Yes" xsi:noNamespaceSchemaLocation="Yes">1821 Nordic. Road, Irving Texas 98558</acronym>
- </p>
-</body></html>
</del></span></pre></div>
<a id="trunkLayoutTestsfastdomAttrchangeidviaattrnodevalueexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -7,7 +7,6 @@
</span><span class="cx"> 1. Check id after parsing.
</span><span class="cx"> PASS document.getElementById("a") is document.body
</span><span class="cx"> PASS document.body.id is "a"
</span><del>-PASS document.body.getAttributeNode("id").isId is true
</del><span class="cx"> PASS document.body.getAttributeNode("id").textContent is "a"
</span><span class="cx">
</span><span class="cx"> 2. Change Attr.value.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomAttrchangeidviaattrnodevaluehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value.html (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value.html 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value.html 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -11,7 +11,6 @@
</span><span class="cx"> debug("\n1. Check id after parsing.");
</span><span class="cx"> shouldBe('document.getElementById("a")', 'document.body');
</span><span class="cx"> shouldBe('document.body.id', '"a"');
</span><del>-shouldBe('document.body.getAttributeNode("id").isId', 'true');
</del><span class="cx"> shouldBe('document.body.getAttributeNode("id").textContent', '"a"');
</span><span class="cx">
</span><span class="cx"> debug("\n2. Change Attr.value.");
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomElementattrisidextra01expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/dom/Element/attrisid-extra01-expected.txt (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Element/attrisid-extra01-expected.txt 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/fast/dom/Element/attrisid-extra01-expected.txt 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -1,11 +0,0 @@
</span><del>-Test Attr.isId where Attr is created without element.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS attr.isId is false
-PASS attr.isId is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="trunkLayoutTestsfastdomElementattrisidextra01html"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/dom/Element/attrisid-extra01.html (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Element/attrisid-extra01.html 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/fast/dom/Element/attrisid-extra01.html 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -1,18 +0,0 @@
</span><del>-<html>
-<head>
-<script src="../../../resources/js-test-pre.js"></script>
-</head>
-<body>
-
-<script>
-description("Test Attr.isId where Attr is created without element.");
-
-var attr = document.createAttributeNS("http://www.w3.org/XML/1998/namespace","xml:lang");
-shouldBeFalse('attr.isId');
-
-var attr = document.createAttributeNS("","id");
-shouldBeTrue('attr.isId');
-</script>
-<script src="../../../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2017-01-30 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Drop legacy Attributes.isId attribute
+ https://bugs.webkit.org/show_bug.cgi?id=167603
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline W3C test now that one more check is passing.
+
+ * web-platform-tests/dom/historical-expected.txt:
+
+2017-01-30 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Drop legacy constants on Event interface
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=167602
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomhistoricalexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -37,7 +37,7 @@
</span><span class="cx"> PASS Historical DOM features must be removed: setIdAttributeNS
</span><span class="cx"> PASS Historical DOM features must be removed: setIdAttributeNode
</span><span class="cx"> PASS Attr member must be nuked: schemaTypeInfo
</span><del>-FAIL Attr member must be nuked: isId assert_equals: expected (undefined) undefined but got (boolean) false
</del><ins>+PASS Attr member must be nuked: isId
</ins><span class="cx"> PASS DocumentType member must be nuked: entities
</span><span class="cx"> PASS DocumentType member must be nuked: notations
</span><span class="cx"> PASS DocumentType member must be nuked: internalSubset
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/Source/WebCore/ChangeLog 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2017-01-30 Chris Dumez <cdumez@apple.com>
+
+ Drop legacy Attributes.isId attribute
+ https://bugs.webkit.org/show_bug.cgi?id=167603
+
+ Reviewed by Ryosuke Niwa.
+
+ Drop legacy Attributes.isId attribute.
+
+ This attribute is not in the specification:
+ - https://dom.spec.whatwg.org/#interface-attr
+
+ Both Firefox and Chrome currently do not expose this attribute.
+
+ No new tests, rebaselined existing test.
+
+ * dom/Attr.cpp:
+ * dom/Attr.h:
+ * dom/Attr.idl:
+
</ins><span class="cx"> 2017-01-30 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Simple line layout: Small tweaks to improve performance.
</span></span></pre></div>
<a id="trunkSourceWebCoredomAttrcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.cpp (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Attr.cpp 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/Source/WebCore/dom/Attr.cpp 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -171,11 +171,6 @@
</span><span class="cx"> m_element->attributeChanged(qualifiedName(), oldValue, newValue);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool Attr::isId() const
-{
- return qualifiedName().matches(HTMLNames::idAttr);
-}
-
</del><span class="cx"> CSSStyleDeclaration* Attr::style()
</span><span class="cx"> {
</span><span class="cx"> // This function only exists to support the Obj-C bindings.
</span></span></pre></div>
<a id="trunkSourceWebCoredomAttrh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.h (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Attr.h 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/Source/WebCore/dom/Attr.h 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -56,8 +56,6 @@
</span><span class="cx">
</span><span class="cx"> const QualifiedName& qualifiedName() const { return m_name; }
</span><span class="cx">
</span><del>- WEBCORE_EXPORT bool isId() const;
-
</del><span class="cx"> WEBCORE_EXPORT CSSStyleDeclaration* style();
</span><span class="cx">
</span><span class="cx"> void attachToElement(Element&);
</span></span></pre></div>
<a id="trunkSourceWebCoredomAttridl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.idl (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Attr.idl 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/Source/WebCore/dom/Attr.idl 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -31,8 +31,6 @@
</span><span class="cx">
</span><span class="cx"> readonly attribute Element ownerElement;
</span><span class="cx">
</span><del>- readonly attribute boolean isId;
-
</del><span class="cx"> readonly attribute DOMString? namespaceURI;
</span><span class="cx"> readonly attribute DOMString? prefix;
</span><span class="cx"> readonly attribute DOMString localName;
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/Source/WebKit/mac/ChangeLog 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-01-30 Chris Dumez <cdumez@apple.com>
+
+ Drop legacy Attributes.isId attribute
+ https://bugs.webkit.org/show_bug.cgi?id=167603
+
+ Reviewed by Ryosuke Niwa.
+
+ Keep Attr.isId in ObjC bindings.
+
+ * DOM/DOMAttr.mm:
+ (-[DOMAttr isId]):
+
</ins><span class="cx"> 2017-01-30 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.
</span></span></pre></div>
<a id="trunkSourceWebKitmacDOMDOMAttrmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/DOM/DOMAttr.mm (211394 => 211395)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/DOM/DOMAttr.mm 2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/Source/WebKit/mac/DOM/DOMAttr.mm 2017-01-31 00:22:27 UTC (rev 211395)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx"> - (BOOL)isId
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- return IMPL->isId();
</del><ins>+ return IMPL->qualifiedName().matches(WebCore::HTMLNames::idAttr);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (DOMCSSStyleDeclaration *)style
</span></span></pre>
</div>
</div>
</body>
</html>