<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211393] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211393">211393</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-01-30 16:11:49 -0800 (Mon, 30 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Drop legacy constants on Event interface
https://bugs.webkit.org/show_bug.cgi?id=167602
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
* web-platform-tests/dom/historical-expected.txt:
Source/WebCore:
Drop legacy constants on Event interface:
MOUSEDOWN, MOUSEUP, MOUSEOVER, MOUSEOUT, MOUSEMOVE, MOUSEDRAG,
CLICK, DBLCLICK, KEYDOWN, KEYUP, KEYPRESS, DRAGDROP, FOCUS,
BLUR, SELECT, and CHANGE.
Those constants are not used for anything, they are not in the
specification and Chrome / Firefox do not have them.
No new tests, rebaselined existing test.
* dom/Event.idl:
LayoutTests:
Update / Rebaseline existing tests to stop covering those constants.
* fast/dom/constants-expected.txt:
* fast/dom/constants.html:
* fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* http/tests/workers/worker-importScriptsOnError-expected.txt:
* inspector/model/remote-object-get-properties-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomconstantsexpectedtxt">trunk/LayoutTests/fast/dom/constants-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomconstantshtml">trunk/LayoutTests/fast/dom/constants.html</a></li>
<li><a href="#trunkLayoutTestsfastxmlhttprequestxmlhttprequestgetexpectedtxt">trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestsworkersworkerimportScriptsOnErrorexpectedtxt">trunk/LayoutTests/http/tests/workers/worker-importScriptsOnError-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomhistoricalexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectormodelremoteobjectgetpropertiesexpectedtxt">trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomEventh">trunk/Source/WebCore/dom/Event.h</a></li>
<li><a href="#trunkSourceWebCoredomEventidl">trunk/Source/WebCore/dom/Event.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (211392 => 211393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/ChangeLog 2017-01-31 00:11:49 UTC (rev 211393)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2017-01-30 Chris Dumez <cdumez@apple.com>
+
+ Drop legacy constants on Event interface
+ https://bugs.webkit.org/show_bug.cgi?id=167602
+
+ Reviewed by Sam Weinig.
+
+ Update / Rebaseline existing tests to stop covering those constants.
+
+ * fast/dom/constants-expected.txt:
+ * fast/dom/constants.html:
+ * fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
+ * http/tests/workers/worker-importScriptsOnError-expected.txt:
+ * inspector/model/remote-object-get-properties-expected.txt:
+
</ins><span class="cx"> 2017-01-30 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] position:fixed inside touch-scrollable overflow is mispositioned
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomconstantsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/constants-expected.txt (211392 => 211393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/constants-expected.txt 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/fast/dom/constants-expected.txt 2017-01-31 00:11:49 UTC (rev 211393)
</span><span class="lines">@@ -44,39 +44,7 @@
</span><span class="cx"> PASS: event.CAPTURING_PHASE should be 1 and is.
</span><span class="cx"> PASS: event.AT_TARGET should be 2 and is.
</span><span class="cx"> PASS: event.BUBBLING_PHASE should be 3 and is.
</span><del>-PASS: event.MOUSEDOWN should be 1 and is.
-PASS: event.MOUSEUP should be 2 and is.
-PASS: event.MOUSEOVER should be 4 and is.
-PASS: event.MOUSEOUT should be 8 and is.
-PASS: event.MOUSEMOVE should be 16 and is.
-PASS: event.MOUSEDRAG should be 32 and is.
-PASS: event.CLICK should be 64 and is.
-PASS: event.DBLCLICK should be 128 and is.
-PASS: event.KEYDOWN should be 256 and is.
-PASS: event.KEYUP should be 512 and is.
-PASS: event.KEYPRESS should be 1024 and is.
-PASS: event.DRAGDROP should be 2048 and is.
-PASS: event.FOCUS should be 4096 and is.
-PASS: event.BLUR should be 8192 and is.
-PASS: event.SELECT should be 16384 and is.
-PASS: event.CHANGE should be 32768 and is.
</del><span class="cx"> PASS: window.Event.NONE should be 0 and is.
</span><span class="cx"> PASS: window.Event.CAPTURING_PHASE should be 1 and is.
</span><span class="cx"> PASS: window.Event.AT_TARGET should be 2 and is.
</span><span class="cx"> PASS: window.Event.BUBBLING_PHASE should be 3 and is.
</span><del>-PASS: window.Event.MOUSEDOWN should be 1 and is.
-PASS: window.Event.MOUSEUP should be 2 and is.
-PASS: window.Event.MOUSEOVER should be 4 and is.
-PASS: window.Event.MOUSEOUT should be 8 and is.
-PASS: window.Event.MOUSEMOVE should be 16 and is.
-PASS: window.Event.MOUSEDRAG should be 32 and is.
-PASS: window.Event.CLICK should be 64 and is.
-PASS: window.Event.DBLCLICK should be 128 and is.
-PASS: window.Event.KEYDOWN should be 256 and is.
-PASS: window.Event.KEYUP should be 512 and is.
-PASS: window.Event.KEYPRESS should be 1024 and is.
-PASS: window.Event.DRAGDROP should be 2048 and is.
-PASS: window.Event.FOCUS should be 4096 and is.
-PASS: window.Event.BLUR should be 8192 and is.
-PASS: window.Event.SELECT should be 16384 and is.
-PASS: window.Event.CHANGE should be 32768 and is.
</del></span></pre></div>
<a id="trunkLayoutTestsfastdomconstantshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/constants.html (211392 => 211393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/constants.html 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/fast/dom/constants.html 2017-01-31 00:11:49 UTC (rev 211393)
</span><span class="lines">@@ -88,43 +88,11 @@
</span><span class="cx"> shouldBe("event.CAPTURING_PHASE", 1);
</span><span class="cx"> shouldBe("event.AT_TARGET", 2);
</span><span class="cx"> shouldBe("event.BUBBLING_PHASE", 3);
</span><del>- shouldBe("event.MOUSEDOWN", 1);
- shouldBe("event.MOUSEUP", 2);
- shouldBe("event.MOUSEOVER", 4);
- shouldBe("event.MOUSEOUT", 8);
- shouldBe("event.MOUSEMOVE", 16);
- shouldBe("event.MOUSEDRAG", 32);
- shouldBe("event.CLICK", 64);
- shouldBe("event.DBLCLICK", 128);
- shouldBe("event.KEYDOWN", 256);
- shouldBe("event.KEYUP", 512);
- shouldBe("event.KEYPRESS", 1024);
- shouldBe("event.DRAGDROP", 2048);
- shouldBe("event.FOCUS", 4096);
- shouldBe("event.BLUR", 8192);
- shouldBe("event.SELECT", 16384);
- shouldBe("event.CHANGE", 32768);
</del><span class="cx">
</span><span class="cx"> shouldBe("window.Event.NONE", 0);
</span><span class="cx"> shouldBe("window.Event.CAPTURING_PHASE", 1);
</span><span class="cx"> shouldBe("window.Event.AT_TARGET", 2);
</span><span class="cx"> shouldBe("window.Event.BUBBLING_PHASE", 3);
</span><del>- shouldBe("window.Event.MOUSEDOWN", 1);
- shouldBe("window.Event.MOUSEUP", 2);
- shouldBe("window.Event.MOUSEOVER", 4);
- shouldBe("window.Event.MOUSEOUT", 8);
- shouldBe("window.Event.MOUSEMOVE", 16);
- shouldBe("window.Event.MOUSEDRAG", 32);
- shouldBe("window.Event.CLICK", 64);
- shouldBe("window.Event.DBLCLICK", 128);
- shouldBe("window.Event.KEYDOWN", 256);
- shouldBe("window.Event.KEYUP", 512);
- shouldBe("window.Event.KEYPRESS", 1024);
- shouldBe("window.Event.DRAGDROP", 2048);
- shouldBe("window.Event.FOCUS", 4096);
- shouldBe("window.Event.BLUR", 8192);
- shouldBe("window.Event.SELECT", 16384);
- shouldBe("window.Event.CHANGE", 32768);
</del><span class="cx"> }
</span><span class="cx"> </script>
</span><span class="cx"> </head>
</span></span></pre></div>
<a id="trunkLayoutTestsfastxmlhttprequestxmlhttprequestgetexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt (211392 => 211393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt 2017-01-31 00:11:49 UTC (rev 211393)
</span><span class="lines">@@ -24,25 +24,9 @@
</span><span class="cx"> Event object: [object XMLHttpRequestProgressEvent]
</span><span class="cx"> Event properties:
</span><span class="cx"> AT_TARGET : '2'
</span><del>-BLUR : '8192'
</del><span class="cx"> BUBBLING_PHASE : '3'
</span><span class="cx"> CAPTURING_PHASE : '1'
</span><del>-CHANGE : '32768'
-CLICK : '64'
-DBLCLICK : '128'
-DRAGDROP : '2048'
-FOCUS : '4096'
-KEYDOWN : '256'
-KEYPRESS : '1024'
-KEYUP : '512'
-MOUSEDOWN : '1'
-MOUSEDRAG : '32'
-MOUSEMOVE : '16'
-MOUSEOUT : '8'
-MOUSEOVER : '4'
-MOUSEUP : '2'
</del><span class="cx"> NONE : '0'
</span><del>-SELECT : '16384'
</del><span class="cx"> bubbles : 'false'
</span><span class="cx"> cancelBubble : 'false'
</span><span class="cx"> cancelable : 'false'
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsworkersworkerimportScriptsOnErrorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/workers/worker-importScriptsOnError-expected.txt (211392 => 211393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/workers/worker-importScriptsOnError-expected.txt 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/http/tests/workers/worker-importScriptsOnError-expected.txt 2017-01-31 00:11:49 UTC (rev 211393)
</span><span class="lines">@@ -3,25 +3,9 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> AT_TARGET: 2,
</span><del>-BLUR: 8192,
</del><span class="cx"> BUBBLING_PHASE: 3,
</span><span class="cx"> CAPTURING_PHASE: 1,
</span><del>-CHANGE: 32768,
-CLICK: 64,
-DBLCLICK: 128,
-DRAGDROP: 2048,
-FOCUS: 4096,
-KEYDOWN: 256,
-KEYPRESS: 1024,
-KEYUP: 512,
-MOUSEDOWN: 1,
-MOUSEDRAG: 32,
-MOUSEMOVE: 16,
-MOUSEOUT: 8,
-MOUSEOVER: 4,
-MOUSEUP: 2,
</del><span class="cx"> NONE: 0,
</span><del>-SELECT: 16384,
</del><span class="cx"> bubbles: false,
</span><span class="cx"> cancelBubble: false,
</span><span class="cx"> cancelable: true,
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (211392 => 211393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-31 00:11:49 UTC (rev 211393)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-01-30 Chris Dumez <cdumez@apple.com>
+
+ Drop legacy constants on Event interface
+ https://bugs.webkit.org/show_bug.cgi?id=167602
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline W3C test now that more checks are passing.
+
+ * web-platform-tests/dom/historical-expected.txt:
+
</ins><span class="cx"> 2017-01-27 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Import web-platform-tests/user-timing
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomhistoricalexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt (211392 => 211393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt 2017-01-31 00:11:49 UTC (rev 211393)
</span><span class="lines">@@ -54,20 +54,20 @@
</span><span class="cx"> PASS Node member must be nuked: setUserData
</span><span class="cx"> PASS Node member must be nuked: rootNode
</span><span class="cx"> PASS Window member must be nuked: attachEvent
</span><del>-FAIL Event should not have this constant: MOUSEDOWN assert_equals: expected (undefined) undefined but got (number) 1
-FAIL Event should not have this constant: MOUSEUP assert_equals: expected (undefined) undefined but got (number) 2
-FAIL Event should not have this constant: MOUSEOVER assert_equals: expected (undefined) undefined but got (number) 4
-FAIL Event should not have this constant: MOUSEOUT assert_equals: expected (undefined) undefined but got (number) 8
-FAIL Event should not have this constant: MOUSEMOVE assert_equals: expected (undefined) undefined but got (number) 16
-FAIL Event should not have this constant: MOUSEDRAG assert_equals: expected (undefined) undefined but got (number) 32
-FAIL Event should not have this constant: CLICK assert_equals: expected (undefined) undefined but got (number) 64
-FAIL Event should not have this constant: DBLCLICK assert_equals: expected (undefined) undefined but got (number) 128
-FAIL Event should not have this constant: KEYDOWN assert_equals: expected (undefined) undefined but got (number) 256
-FAIL Event should not have this constant: KEYUP assert_equals: expected (undefined) undefined but got (number) 512
-FAIL Event should not have this constant: KEYPRESS assert_equals: expected (undefined) undefined but got (number) 1024
-FAIL Event should not have this constant: DRAGDROP assert_equals: expected (undefined) undefined but got (number) 2048
-FAIL Event should not have this constant: FOCUS assert_equals: expected (undefined) undefined but got (number) 4096
-FAIL Event should not have this constant: BLUR assert_equals: expected (undefined) undefined but got (number) 8192
-FAIL Event should not have this constant: SELECT assert_equals: expected (undefined) undefined but got (number) 16384
-FAIL Event should not have this constant: CHANGE assert_equals: expected (undefined) undefined but got (number) 32768
</del><ins>+PASS Event should not have this constant: MOUSEDOWN
+PASS Event should not have this constant: MOUSEUP
+PASS Event should not have this constant: MOUSEOVER
+PASS Event should not have this constant: MOUSEOUT
+PASS Event should not have this constant: MOUSEMOVE
+PASS Event should not have this constant: MOUSEDRAG
+PASS Event should not have this constant: CLICK
+PASS Event should not have this constant: DBLCLICK
+PASS Event should not have this constant: KEYDOWN
+PASS Event should not have this constant: KEYUP
+PASS Event should not have this constant: KEYPRESS
+PASS Event should not have this constant: DRAGDROP
+PASS Event should not have this constant: FOCUS
+PASS Event should not have this constant: BLUR
+PASS Event should not have this constant: SELECT
+PASS Event should not have this constant: CHANGE
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsinspectormodelremoteobjectgetpropertiesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt (211392 => 211393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2017-01-31 00:11:49 UTC (rev 211393)
</span><span class="lines">@@ -269,22 +269,6 @@
</span><span class="cx"> CAPTURING_PHASE
</span><span class="cx"> AT_TARGET
</span><span class="cx"> BUBBLING_PHASE
</span><del>- MOUSEDOWN
- MOUSEUP
- MOUSEOVER
- MOUSEOUT
- MOUSEMOVE
- MOUSEDRAG
- CLICK
- DBLCLICK
- KEYDOWN
- KEYUP
- KEYPRESS
- DRAGDROP
- FOCUS
- BLUR
- SELECT
- CHANGE
</del><span class="cx"> toString
</span><span class="cx"> toLocaleString
</span><span class="cx"> valueOf
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (211392 => 211393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/Source/WebCore/ChangeLog 2017-01-31 00:11:49 UTC (rev 211393)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2017-01-30 Chris Dumez <cdumez@apple.com>
+
+ Drop legacy constants on Event interface
+ https://bugs.webkit.org/show_bug.cgi?id=167602
+
+ Reviewed by Sam Weinig.
+
+ Drop legacy constants on Event interface:
+ MOUSEDOWN, MOUSEUP, MOUSEOVER, MOUSEOUT, MOUSEMOVE, MOUSEDRAG,
+ CLICK, DBLCLICK, KEYDOWN, KEYUP, KEYPRESS, DRAGDROP, FOCUS,
+ BLUR, SELECT, and CHANGE.
+
+ Those constants are not used for anything, they are not in the
+ specification and Chrome / Firefox do not have them.
+
+ No new tests, rebaselined existing test.
+
+ * dom/Event.idl:
+
</ins><span class="cx"> 2017-01-30 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] position:fixed inside touch-scrollable overflow is mispositioned
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Event.h (211392 => 211393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Event.h 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/Source/WebCore/dom/Event.h 2017-01-31 00:11:49 UTC (rev 211393)
</span><span class="lines">@@ -59,25 +59,6 @@
</span><span class="cx"> BUBBLING_PHASE = 3
</span><span class="cx"> };
</span><span class="cx">
</span><del>- enum EventType {
- MOUSEDOWN = 1,
- MOUSEUP = 2,
- MOUSEOVER = 4,
- MOUSEOUT = 8,
- MOUSEMOVE = 16,
- MOUSEDRAG = 32,
- CLICK = 64,
- DBLCLICK = 128,
- KEYDOWN = 256,
- KEYUP = 512,
- KEYPRESS = 1024,
- DRAGDROP = 2048,
- FOCUS = 4096,
- BLUR = 8192,
- SELECT = 16384,
- CHANGE = 32768
- };
-
</del><span class="cx"> static Ref<Event> create(const AtomicString& type, bool canBubble, bool cancelable)
</span><span class="cx"> {
</span><span class="cx"> return adoptRef(*new Event(type, canBubble, cancelable));
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Event.idl (211392 => 211393)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Event.idl 2017-01-31 00:08:45 UTC (rev 211392)
+++ trunk/Source/WebCore/dom/Event.idl 2017-01-31 00:11:49 UTC (rev 211393)
</span><span class="lines">@@ -35,23 +35,6 @@
</span><span class="cx"> const unsigned short AT_TARGET = 2;
</span><span class="cx"> const unsigned short BUBBLING_PHASE = 3;
</span><span class="cx">
</span><del>- const unsigned short MOUSEDOWN = 1;
- const unsigned short MOUSEUP = 2;
- const unsigned short MOUSEOVER = 4;
- const unsigned short MOUSEOUT = 8;
- const unsigned short MOUSEMOVE = 16;
- const unsigned short MOUSEDRAG = 32;
- const unsigned short CLICK = 64;
- const unsigned short DBLCLICK = 128;
- const unsigned short KEYDOWN = 256;
- const unsigned short KEYUP = 512;
- const unsigned short KEYPRESS = 1024;
- const unsigned short DRAGDROP = 2048;
- const unsigned short FOCUS = 4096;
- const unsigned short BLUR = 8192;
- const unsigned short SELECT = 16384;
- const unsigned short CHANGE = 32768;
-
</del><span class="cx"> readonly attribute DOMString type;
</span><span class="cx"> readonly attribute EventTarget target;
</span><span class="cx"> readonly attribute EventTarget currentTarget;
</span></span></pre>
</div>
</div>
</body>
</html>