<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211331] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211331">211331</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2017-01-28 01:25:59 -0800 (Sat, 28 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
https://bugs.webkit.org/show_bug.cgi?id=167519
Reviewed by Ryosuke Niwa.
Tools:
* QueueStatusServer/templates/statusbubble.html:
To measure the bubbleContainer's width, it must not be wrapping based
on its parent container. So when measuring the width temporarily set
the parent to a very large width so as to not artificially wrap us.
Restore the parent's width after measuring.
Websites/bugs.webkit.org:
While we do post message to determine the size, the fact that we have
constrained the iframe to a size of 450px meant its body is 450px and
the div containing the bubbles wraps at 450px. Its full size (~458px)
is not returned. Although we solve this artifical constraint problem
inside of the bubble containerMetrics measuring, up this default value
from 450 to 460 to reduce UI jitter (the current measurement on my
machine is 458px).
* PrettyPatch/PrettyPatch.rb:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsQueueStatusServertemplatesstatusbubblehtml">trunk/Tools/QueueStatusServer/templates/statusbubble.html</a></li>
<li><a href="#trunkWebsitesbugswebkitorgChangeLog">trunk/Websites/bugs.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesbugswebkitorgPrettyPatchPrettyPatchrb">trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (211330 => 211331)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-01-28 08:19:19 UTC (rev 211330)
+++ trunk/Tools/ChangeLog 2017-01-28 09:25:59 UTC (rev 211331)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-01-28 Joseph Pecoraro <pecoraro@apple.com>
+
+ Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
+ https://bugs.webkit.org/show_bug.cgi?id=167519
+
+ Reviewed by Ryosuke Niwa.
+
+ * QueueStatusServer/templates/statusbubble.html:
+ To measure the bubbleContainer's width, it must not be wrapping based
+ on its parent container. So when measuring the width temporarily set
+ the parent to a very large width so as to not artificially wrap us.
+ Restore the parent's width after measuring.
+
</ins><span class="cx"> 2017-01-27 Andy Estes <aestes@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Add a test for _WKNSFileManagerExtras
</span></span></pre></div>
<a id="trunkToolsQueueStatusServertemplatesstatusbubblehtml"></a>
<div class="modfile"><h4>Modified: trunk/Tools/QueueStatusServer/templates/statusbubble.html (211330 => 211331)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/QueueStatusServer/templates/statusbubble.html 2017-01-28 08:19:19 UTC (rev 211330)
+++ trunk/Tools/QueueStatusServer/templates/statusbubble.html 2017-01-28 09:25:59 UTC (rev 211331)
</span><span class="lines">@@ -54,7 +54,11 @@
</span><span class="cx"> <script>
</span><span class="cx"> window.addEventListener("message", function(e) {
</span><span class="cx"> if (e.data === 'containerMetrics') {
</span><ins>+ var parentContainer = bubbleContainer.parentElement;
+ var originalWidth = parentContainer.style.width;
+ parentContainer.style.width = "1000px";
</ins><span class="cx"> var clientRect = bubbleContainer.getBoundingClientRect();
</span><ins>+ parentContainer.style.width = originalWidth;
</ins><span class="cx"> e.source.postMessage({'width': Math.ceil(clientRect.width), 'height': Math.ceil(clientRect.height)}, e.origin);
</span><span class="cx"> } else
</span><span class="cx"> console.log("Unknown postMessage: " + e.data);
</span></span></pre></div>
<a id="trunkWebsitesbugswebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/bugs.webkit.org/ChangeLog (211330 => 211331)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/bugs.webkit.org/ChangeLog 2017-01-28 08:19:19 UTC (rev 211330)
+++ trunk/Websites/bugs.webkit.org/ChangeLog 2017-01-28 09:25:59 UTC (rev 211331)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2017-01-28 Joseph Pecoraro <pecoraro@apple.com>
+
+ Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
+ https://bugs.webkit.org/show_bug.cgi?id=167519
+
+ Reviewed by Ryosuke Niwa.
+
+ While we do post message to determine the size, the fact that we have
+ constrained the iframe to a size of 450px meant its body is 450px and
+ the div containing the bubbles wraps at 450px. Its full size (~458px)
+ is not returned. Although we solve this artifical constraint problem
+ inside of the bubble containerMetrics measuring, up this default value
+ from 450 to 460 to reduce UI jitter (the current measurement on my
+ machine is 458px).
+
+ * PrettyPatch/PrettyPatch.rb:
+
</ins><span class="cx"> 2017-01-19 Timothy Hatcher <timothy@hatcher.name>
</span><span class="cx">
</span><span class="cx"> Bugzilla email autocomplete does not work on third email field of advanced search page
</span></span></pre></div>
<a id="trunkWebsitesbugswebkitorgPrettyPatchPrettyPatchrb"></a>
<div class="modfile"><h4>Modified: trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb (211330 => 211331)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb 2017-01-28 08:19:19 UTC (rev 211330)
+++ trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb 2017-01-28 09:25:59 UTC (rev 211331)
</span><span class="lines">@@ -490,7 +490,7 @@
</span><span class="cx">
</span><span class="cx"> .statusBubble {
</span><span class="cx"> /* The width/height get set to the bubble contents via postMessage on browsers that support it. */
</span><del>- width: 450px;
</del><ins>+ width: 460px;
</ins><span class="cx"> height: 20px;
</span><span class="cx"> margin: 2px 2px 0 0;
</span><span class="cx"> border: none;
</span></span></pre>
</div>
</div>
</body>
</html>