<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211306] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211306">211306</a></dd>
<dt>Author</dt> <dd>utatane.tea@gmail.com</dd>
<dt>Date</dt> <dd>2017-01-27 15:29:26 -0800 (Fri, 27 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Extend create_hash_table to specify Intrinsic
https://bugs.webkit.org/show_bug.cgi?id=167505
Reviewed by Sam Weinig.
This patch extends create_hash_table to specify Intrinsic.
We can set Intrinsic in the static property table definition
in runtime/XXX.h.
And drop the adhoc code for String.fromCharCode in create_hash_table.
* create_hash_table:
* runtime/StringConstructor.cpp:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorecreate_hash_table">trunk/Source/JavaScriptCore/create_hash_table</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeStringConstructorcpp">trunk/Source/JavaScriptCore/runtime/StringConstructor.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (211305 => 211306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2017-01-27 23:16:17 UTC (rev 211305)
+++ trunk/Source/JavaScriptCore/ChangeLog 2017-01-27 23:29:26 UTC (rev 211306)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-01-27 Yusuke Suzuki <utatane.tea@gmail.com>
+
+ Extend create_hash_table to specify Intrinsic
+ https://bugs.webkit.org/show_bug.cgi?id=167505
+
+ Reviewed by Sam Weinig.
+
+ This patch extends create_hash_table to specify Intrinsic.
+ We can set Intrinsic in the static property table definition
+ in runtime/XXX.h.
+
+ And drop the adhoc code for String.fromCharCode in create_hash_table.
+
+ * create_hash_table:
+ * runtime/StringConstructor.cpp:
+
</ins><span class="cx"> 2017-01-27 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> scanExternalRememberedSet needs to mergeIfNecessary
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorecreate_hash_table"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/create_hash_table (211305 => 211306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/create_hash_table 2017-01-27 23:16:17 UTC (rev 211305)
+++ trunk/Source/JavaScriptCore/create_hash_table 2017-01-27 23:29:26 UTC (rev 211306)
</span><span class="lines">@@ -76,11 +76,12 @@
</span><span class="cx"> $includeBuiltin = 0;
</span><span class="cx">
</span><span class="cx"> $inside = 0;
</span><del>- } elsif (/^(\S+)\s*(\S+)\s*([\w\|]*)\s*(\w*)\s*$/ && $inside) {
</del><ins>+ } elsif (/^(\S+)\s*(\S+)\s*([\w\|]*)\s*(\w*)\s*(\w*)\s*$/ && $inside) {
</ins><span class="cx"> my $key = $1;
</span><span class="cx"> my $val = $2;
</span><span class="cx"> my $att = $3;
</span><span class="cx"> my $param = $4;
</span><ins>+ my $intrinsic = $5;
</ins><span class="cx">
</span><span class="cx"> push(@keys, $key);
</span><span class="cx"> push(@attrs, length($att) > 0 ? $att : "0");
</span><span class="lines">@@ -90,7 +91,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ($att =~ m/Function/) {
</span><del>- push(@values, { "type" => "Function", "function" => $val, "params" => (length($param) ? $param : "") });
</del><ins>+ push(@values, { "type" => "Function", "function" => $val, "params" => (length($param) ? $param : ""), "intrinsic" => (length($intrinsic) ? $intrinsic : "NoIntrinsic") });
</ins><span class="cx"> #printf STDERR "WARNING: Number of arguments missing for $key/$val\n" if (length($param) == 0);
</span><span class="cx"> } elsif ($att =~ m/Accessor/) {
</span><span class="cx"> my $get = $val;
</span><span class="lines">@@ -301,11 +302,13 @@
</span><span class="cx"> my $secondValue = "";
</span><span class="cx"> my $firstCastStr = "";
</span><span class="cx"> my $secondCastStr = "";
</span><ins>+ my $intrinsic = "NoIntrinsic";
</ins><span class="cx">
</span><span class="cx"> if ($values[$i]{"type"} eq "Function") {
</span><span class="cx"> $firstCastStr = "static_cast<NativeFunction>";
</span><span class="cx"> $firstValue = $values[$i]{"function"};
</span><span class="cx"> $secondValue = $values[$i]{"params"};
</span><ins>+ $intrinsic = $values[$i]{"intrinsic"};
</ins><span class="cx"> } elsif ($values[$i]{"type"} eq "Accessor") {
</span><span class="cx"> $firstCastStr = "static_cast<NativeFunction>";
</span><span class="cx"> $secondCastStr = "static_cast<NativeFunction>";
</span><span class="lines">@@ -329,13 +332,6 @@
</span><span class="cx"> $secondValue = "0";
</span><span class="cx"> }
</span><span class="cx">
</span><del>- my $intrinsic = "NoIntrinsic";
- $intrinsic = "FromCharCodeIntrinsic" if ($key eq "fromCharCode");
- if ($name eq "arrayPrototypeTable") {
- $intrinsic = "ArrayPushIntrinsic" if ($key eq "push");
- $intrinsic = "ArrayPopIntrinsic" if ($key eq "pop");
- }
-
</del><span class="cx"> if ($values[$i]{"type"} eq "Function" && $firstValue eq "JSBuiltin") {
</span><span class="cx"> my $tableHead = $name;
</span><span class="cx"> $tableHead =~ s/Table$//;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeStringConstructorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/StringConstructor.cpp (211305 => 211306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/StringConstructor.cpp 2017-01-27 23:16:17 UTC (rev 211305)
+++ trunk/Source/JavaScriptCore/runtime/StringConstructor.cpp 2017-01-27 23:29:26 UTC (rev 211306)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx">
</span><span class="cx"> /* Source for StringConstructor.lut.h
</span><span class="cx"> @begin stringConstructorTable
</span><del>- fromCharCode stringFromCharCode DontEnum|Function 1
</del><ins>+ fromCharCode stringFromCharCode DontEnum|Function 1 FromCharCodeIntrinsic
</ins><span class="cx"> fromCodePoint stringFromCodePoint DontEnum|Function 1
</span><span class="cx"> raw JSBuiltin DontEnum|Function 1
</span><span class="cx"> @end
</span></span></pre>
</div>
</div>
</body>
</html>