<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211152] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211152">211152</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2017-01-25 10:00:49 -0800 (Wed, 25 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Revert <a href="http://trac.webkit.org/projects/webkit/changeset/210882">r210882</a>, removing support for background-repeat-x/y
https://bugs.webkit.org/show_bug.cgi?id=167223
Reviewed by Myles Maxfield.
Fix the layout tests.
fast/backgrounds/background-repeat-x-y.html was mistakenly removed in <a href="http://trac.webkit.org/projects/webkit/changeset/211060">r211060</a> so
remove its expected. Fix the parsing test.
* fast/backgrounds/background-repeat-x-y-expected.html: Removed.
* fast/backgrounds/background-repeat-x-y-parse-expected.txt:
* fast/backgrounds/background-repeat-x-y-parse.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastbackgroundsbackgroundrepeatxyparseexpectedtxt">trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastbackgroundsbackgroundrepeatxyparsehtml">trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse.html</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastbackgroundsbackgroundrepeatxyexpectedhtml">trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-expected.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (211151 => 211152)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-01-25 17:51:13 UTC (rev 211151)
+++ trunk/LayoutTests/ChangeLog 2017-01-25 18:00:49 UTC (rev 211152)
</span><span class="lines">@@ -5,6 +5,22 @@
</span><span class="cx">
</span><span class="cx"> Reviewed by Myles Maxfield.
</span><span class="cx">
</span><ins>+ Fix the layout tests.
+
+ fast/backgrounds/background-repeat-x-y.html was mistakenly removed in r211060 so
+ remove its expected. Fix the parsing test.
+
+ * fast/backgrounds/background-repeat-x-y-expected.html: Removed.
+ * fast/backgrounds/background-repeat-x-y-parse-expected.txt:
+ * fast/backgrounds/background-repeat-x-y-parse.html:
+
+2017-01-25 Simon Fraser <simon.fraser@apple.com>
+
+ Revert r210882, removing support for background-repeat-x/y
+ https://bugs.webkit.org/show_bug.cgi?id=167223
+
+ Reviewed by Myles Maxfield.
+
</ins><span class="cx"> Modify the test to check that background-repeat-x and background-repeat-y are not parsed.
</span><span class="cx">
</span><span class="cx"> * fast/backgrounds/background-repeat-x-y-parse-expected.txt:
</span></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsbackgroundrepeatxyexpectedhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-expected.html (211151 => 211152)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-expected.html 2017-01-25 17:51:13 UTC (rev 211151)
+++ trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-expected.html 2017-01-25 18:00:49 UTC (rev 211152)
</span><span class="lines">@@ -1,27 +0,0 @@
</span><del>-<!DOCTYPE html>
-<html>
-<head>
-<style>
-div {
- display: inline-block;
- width: 150px;
- height: 150px;
- background-image: url('resources/map.jpg');
- background-position: top left;
-}
-</style>
-</head>
-<body>
-<p>This makes sure that background-repeat-x and background-repeat-y are rendered as expected.</p>
-<div style="background-repeat: repeat; border: 1px solid black;"></div>
-<div style="background-repeat: repeat-y; border: 1px solid black;"></div>
-<div style="background-repeat: repeat; border: 1px solid black;"></div>
-<div style="background-repeat: repeat-x; border: 1px solid black;"></div>
-<div style="background-repeat: no-repeat; border: 1px solid black;"></div>
-<div style="background-repeat: no-repeat; border: 1px solid black;"></div>
-<div style="background-repeat: no-repeat;border: 1px solid black;"></div>
-<div style="background-repeat: repeat-x; border: 1px solid black;"></div>
-<div style="background-repeat: repeat-y; border: 1px solid black;"></div>
-<div style="background-repeat: repeat; border: 1px solid black;"></div>
-</body>
-</html>
</del><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsbackgroundrepeatxyparseexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse-expected.txt (211151 => 211152)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse-expected.txt 2017-01-25 17:51:13 UTC (rev 211151)
+++ trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse-expected.txt 2017-01-25 18:00:49 UTC (rev 211152)
</span><span class="lines">@@ -1,14 +1,13 @@
</span><ins>+This test checks that background-repeat-x/y are not parsed
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
</ins><span class="cx"> PASS window.getComputedStyle(document.getElementById('test1')).getPropertyValue('background-repeat') is "repeat"
</span><del>-PASS window.getComputedStyle(document.getElementById('test2')).getPropertyValue('background-repeat') is "repeat-y"
-PASS window.getComputedStyle(document.getElementById('test3')).getPropertyValue('background-repeat') is "repeat"
</del><ins>+PASS window.getComputedStyle(document.getElementById('test2')).getPropertyValue('background-repeat') is "repeat"
+PASS window.getComputedStyle(document.getElementById('test3')).getPropertyValue('background-repeat') is "repeat-y"
</ins><span class="cx"> PASS window.getComputedStyle(document.getElementById('test4')).getPropertyValue('background-repeat') is "repeat-x"
</span><del>-PASS window.getComputedStyle(document.getElementById('test5')).getPropertyValue('background-repeat') is "no-repeat"
-PASS window.getComputedStyle(document.getElementById('test6')).getPropertyValue('background-repeat') is "no-repeat"
-PASS window.getComputedStyle(document.getElementById('test7')).getPropertyValue('background-repeat') is "no-repeat"
-PASS window.getComputedStyle(document.getElementById('test8')).getPropertyValue('background-repeat') is "repeat-x"
-PASS window.getComputedStyle(document.getElementById('test9')).getPropertyValue('background-repeat') is "repeat-y"
-PASS window.getComputedStyle(document.getElementById('test10')).getPropertyValue('background-repeat') is "repeat"
</del><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span><del>-
</del><ins>+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsbackgroundrepeatxyparsehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse.html (211151 => 211152)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse.html 2017-01-25 17:51:13 UTC (rev 211151)
+++ trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse.html 2017-01-25 18:00:49 UTC (rev 211152)
</span><span class="lines">@@ -3,37 +3,28 @@
</span><span class="cx"> <head>
</span><span class="cx"> <style>
</span><span class="cx"> .test {
</span><del>- display: inline-block;
- width: 150px;
- height: 150px;
- background-image: url('resources/map.jpg');
- background-position: top left;
</del><ins>+ display: inline-block;
+ width: 150px;
+ height: 150px;
+ background-image: url('resources/map.jpg');
+ background-position: top left;
+ border: 1px solid black;
</ins><span class="cx"> }
</span><span class="cx"> </style>
</span><span class="cx"> <script src="../../resources/js-test-pre.js"></script>
</span><span class="cx"> </head>
</span><span class="cx"> <body>
</span><del>-<div id="test1" class="test" style="background-repeat-x: repeat; border: 1px solid black;"></div>
-<div id="test2" class="test" style="background-repeat-x: no-repeat; border: 1px solid black;"></div>
-<div id="test3" class="test" style="background-repeat-y: repeat; border: 1px solid black;"></div>
-<div id="test4" class="test" style="background-repeat-y: no-repeat; border: 1px solid black;"></div>
-<div id="test5" class="test" style="background-repeat-x: no-repeat; background-repeat-y: no-repeat; border: 1px solid black;"></div>
-<div id="test6" class="test" style="background-repeat: repeat-y; background-repeat-y: no-repeat; border: 1px solid black;"></div>
-<div id="test7" class="test" style="background-repeat: repeat-x; background-repeat-x: no-repeat; border: 1px solid black;"></div>
-<div id="test8" class="test" style="background-repeat-x: no-repeat; background-repeat: repeat-x; border: 1px solid black;"></div>
-<div id="test9" class="test" style="background-repeat-y: no-repeat; background-repeat: repeat-y; border: 1px solid black;"></div>
-<div id="test10" class="test" style="background-repeat-x: garbage; border: 1px solid black;"></div>
</del><ins>+<div id="test1" class="test" style="background-repeat-y: no-repeat;"></div>
+<div id="test2" class="test" style="background-repeat-x: no-repeat; background-repeat-y: no-repeat;"></div>
+<div id="test3" class="test" style="background-repeat: repeat-y; background-repeat-y: no-repeat;"></div>
+<div id="test4" class="test" style="background-repeat: repeat-x; background-repeat-x: no-repeat;"></div>
</ins><span class="cx"> <script>
</span><ins>+description("This test checks that background-repeat-x/y are not parsed");
+
</ins><span class="cx"> shouldBeEqualToString("window.getComputedStyle(document.getElementById('test1')).getPropertyValue('background-repeat')", "repeat");
</span><del>-shouldBeEqualToString("window.getComputedStyle(document.getElementById('test2')).getPropertyValue('background-repeat')", "repeat-y");
-shouldBeEqualToString("window.getComputedStyle(document.getElementById('test3')).getPropertyValue('background-repeat')", "repeat");
</del><ins>+shouldBeEqualToString("window.getComputedStyle(document.getElementById('test2')).getPropertyValue('background-repeat')", "repeat");
+shouldBeEqualToString("window.getComputedStyle(document.getElementById('test3')).getPropertyValue('background-repeat')", "repeat-y");
</ins><span class="cx"> shouldBeEqualToString("window.getComputedStyle(document.getElementById('test4')).getPropertyValue('background-repeat')", "repeat-x");
</span><del>-shouldBeEqualToString("window.getComputedStyle(document.getElementById('test5')).getPropertyValue('background-repeat')", "no-repeat");
-shouldBeEqualToString("window.getComputedStyle(document.getElementById('test6')).getPropertyValue('background-repeat')", "no-repeat");
-shouldBeEqualToString("window.getComputedStyle(document.getElementById('test7')).getPropertyValue('background-repeat')", "no-repeat");
-shouldBeEqualToString("window.getComputedStyle(document.getElementById('test8')).getPropertyValue('background-repeat')", "repeat-x");
-shouldBeEqualToString("window.getComputedStyle(document.getElementById('test9')).getPropertyValue('background-repeat')", "repeat-y");
-shouldBeEqualToString("window.getComputedStyle(document.getElementById('test10')).getPropertyValue('background-repeat')", "repeat");
</del><span class="cx"> </script>
</span><span class="cx"> <script src="../../resources/js-test-post.js"></script>
</span><span class="cx"> </body>
</span></span></pre>
</div>
</div>
</body>
</html>