<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211123] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211123">211123</a></dd>
<dt>Author</dt> <dd>mcatanzaro@igalia.com</dd>
<dt>Date</dt> <dd>2017-01-24 16:55:10 -0800 (Tue, 24 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>WKR should not confuse Miguel Gomez with Andres Gomez
https://bugs.webkit.org/show_bug.cgi?id=167389
Reviewed by Lucas Forschler.
Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
"mAndres Gomez". Fix this.
* Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
space on each side of the email address, so expect both spaces to be there before
considering the email for replacement.
* Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpytoolcommandsnewcommitbotpy">trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py</a></li>
<li><a href="#trunkToolsScriptswebkitpytoolcommandsnewcommitbot_unittestpy">trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (211122 => 211123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-01-25 00:53:48 UTC (rev 211122)
+++ trunk/Tools/ChangeLog 2017-01-25 00:55:10 UTC (rev 211123)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-01-24 Michael Catanzaro <mcatanzaro@igalia.com>
+
+ WKR should not confuse Miguel Gomez with Andres Gomez
+ https://bugs.webkit.org/show_bug.cgi?id=167389
+
+ Reviewed by Lucas Forschler.
+
+ Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
+ "mAndres Gomez". Fix this.
+
+ * Scripts/webkitpy/tool/commands/newcommitbot.py:
+ (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
+ space on each side of the email address, so expect both spaces to be there before
+ considering the email for replacement.
+ * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
+
</ins><span class="cx"> 2017-01-24 Matt Rajca <mrajca@apple.com>
</span><span class="cx">
</span><span class="cx"> Pass down website autoplay policies to media elements
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpytoolcommandsnewcommitbotpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py (211122 => 211123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py 2017-01-25 00:53:48 UTC (rev 211122)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py 2017-01-25 00:55:10 UTC (rev 211123)
</span><span class="lines">@@ -134,7 +134,7 @@
</span><span class="cx"> commit_log = commit_log.replace(' <' + email + '>', '')
</span><span class="cx"> else:
</span><span class="cx"> for email in contributor.emails:
</span><del>- commit_log = commit_log.replace(email, name_with_nick)
</del><ins>+ commit_log = commit_log.replace(' %s ' % email, ' %s ' % name_with_nick)
</ins><span class="cx">
</span><span class="cx"> lines = commit_log.split('\n')[1:-2] # Ignore lines with ----------.
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpytoolcommandsnewcommitbot_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py (211122 => 211123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py 2017-01-25 00:53:48 UTC (rev 211122)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py 2017-01-25 00:55:10 UTC (rev 211123)
</span><span class="lines">@@ -127,3 +127,25 @@
</span><span class="cx"> ------------------------------------------------------------------------"""),
</span><span class="cx"> "Vsevolod Vlasov (vsevik) rolled out r134927 and r134944 in https://trac.webkit.org/r135487 :"
</span><span class="cx"> " Reverting the reverts after merging.")
</span><ins>+
+ # Miguel <magomez@igalia.com> is not to be confused with Andres <agomez@igalia.com>.
+ def test_email_substring_problem(self):
+ self.assertEqual(NewCommitBot._summarize_commit_log("""------------------------------------------------------------------------
+r211084 | magomez@igalia.com | 2017-01-24 10:25:31 -0600 (Tue, 24 Jan 2017) | 13 lines
+
+[GTK] Do not paint non composited content into the window when using the threaded compositor
+https://bugs.webkit.org/show_bug.cgi?id=167367
+
+Reviewed by Carlos Garcia Campos.
+
+When using the threaded compositor we need to send the non composited content for compositing as well,
+not painting it directly into the window.
+
+No new tests.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::paintsIntoWindow):
+
+------------------------------------------------------------------------"""),
+ "https://trac.webkit.org/r211084 by Miguel Gomez (magomez) [GTK] Do not paint non composited content into the window when using the threaded compositor"
+ " https://webkit.org/b/167367 Reviewed by Carlos Garcia Campos (KaL).")
</ins></span></pre>
</div>
</div>
</body>
</html>