<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211134] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211134">211134</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-01-24 20:25:51 -0800 (Tue, 24 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>WKR does not include my nick when commit-queue lands my patch
https://bugs.webkit.org/show_bug.cgi?id=167388
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-01-24
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot._summarize_commit_log):
* Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
Perform nickname insertion before grabbing "Patch by" details.
This way we can include the nickname with the full name.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpytoolcommandsnewcommitbotpy">trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py</a></li>
<li><a href="#trunkToolsScriptswebkitpytoolcommandsnewcommitbot_unittestpy">trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (211133 => 211134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-01-25 04:23:27 UTC (rev 211133)
+++ trunk/Tools/ChangeLog 2017-01-25 04:25:51 UTC (rev 211134)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2017-01-24 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ WKR does not include my nick when commit-queue lands my patch
+ https://bugs.webkit.org/show_bug.cgi?id=167388
+
+ Reviewed by Ryosuke Niwa.
+
+ * Scripts/webkitpy/tool/commands/newcommitbot.py:
+ (NewCommitBot._summarize_commit_log):
+ * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
+ Perform nickname insertion before grabbing "Patch by" details.
+ This way we can include the nickname with the full name.
+
+2017-01-24 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=167394
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpytoolcommandsnewcommitbotpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py (211133 => 211134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py 2017-01-25 04:23:27 UTC (rev 211133)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py 2017-01-25 04:25:51 UTC (rev 211134)
</span><span class="lines">@@ -113,17 +113,6 @@
</span><span class="cx">
</span><span class="cx"> @classmethod
</span><span class="cx"> def _summarize_commit_log(self, commit_log, committer_list=CommitterList()):
</span><del>- patch_by = self._patch_by_regex.search(commit_log)
- commit_log = self._patch_by_regex.sub('', commit_log, count=1)
-
- rollout = self._rollout_regex.search(commit_log)
- commit_log = self._rollout_regex.sub('', commit_log, count=1)
-
- requested_by = self._requested_by_regex.search(commit_log)
-
- commit_log = self._bugzilla_url_regex.sub(r'https://webkit.org/b/\g<id>', commit_log)
- commit_log = self._trac_url_regex.sub(r'https://trac.webkit.org/r\g<revision>', commit_log)
-
</del><span class="cx"> for contributor in committer_list.contributors():
</span><span class="cx"> if not contributor.irc_nicknames:
</span><span class="cx"> continue
</span><span class="lines">@@ -136,10 +125,22 @@
</span><span class="cx"> for email in contributor.emails:
</span><span class="cx"> commit_log = commit_log.replace(' %s ' % email, ' %s ' % name_with_nick)
</span><span class="cx">
</span><ins>+ patch_by = self._patch_by_regex.search(commit_log)
+ commit_log = self._patch_by_regex.sub('', commit_log, count=1)
+
+ rollout = self._rollout_regex.search(commit_log)
+ commit_log = self._rollout_regex.sub('', commit_log, count=1)
+
+ requested_by = self._requested_by_regex.search(commit_log)
+
+ commit_log = self._bugzilla_url_regex.sub(r'https://webkit.org/b/\g<id>', commit_log)
+ commit_log = self._trac_url_regex.sub(r'https://trac.webkit.org/r\g<revision>', commit_log)
+
</ins><span class="cx"> lines = commit_log.split('\n')[1:-2] # Ignore lines with ----------.
</span><span class="cx">
</span><span class="cx"> firstline = re.match(r'^(?P<revision>r\d+) \| (?P<email>[^\|]+) \| (?P<timestamp>[^|]+) \| [^\n]+', lines[0])
</span><span class="cx"> assert firstline
</span><ins>+
</ins><span class="cx"> author = firstline.group('email')
</span><span class="cx"> if patch_by:
</span><span class="cx"> author = patch_by.group('author')
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpytoolcommandsnewcommitbot_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py (211133 => 211134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py 2017-01-25 04:23:27 UTC (rev 211133)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py 2017-01-25 04:25:51 UTC (rev 211134)
</span><span class="lines">@@ -67,6 +67,22 @@
</span><span class="cx"> "https://trac.webkit.org/r140066 by Simon Fraser (smfr)"
</span><span class="cx"> " Allow PaintInfo to carry all PaintBehavior flags https://webkit.org/b/106980 Reviewed by Beth Dakin (dethbakin).")
</span><span class="cx">
</span><ins>+ self.assertEqual(NewCommitBot._summarize_commit_log("""------------------------------------------------------------------------
+r211085 | commit-queue@webkit.org | 2017-01-24 09:01:44 -0800 (Tue, 24 Jan 2017) | 9 lines
+
+Remove always true openGLMultisamplingEnabled setting
+https://bugs.webkit.org/show_bug.cgi?id=167364
+
+Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-01-24
+Reviewed by Sam Weinig.
+
+* html/canvas/WebGLRenderingContextBase.cpp:
+(WebCore::WebGLRenderingContextBase::create):
+* page/Settings.in:
+------------------------------------------------------------------------"""),
+ "https://trac.webkit.org/r211085 by Joseph Pecoraro (JoePeck)"
+ " Remove always true openGLMultisamplingEnabled setting https://webkit.org/b/167364 Reviewed by Sam Weinig (weinig).")
+
</ins><span class="cx"> def test_summarize_commit_log_rollout(self):
</span><span class="cx"> self.assertEqual(NewCommitBot._summarize_commit_log("""------------------------------------------------------------------------
</span><span class="cx"> r143104 | commit-queue@webkit.org | 2013-02-16 09:09:01 -0800 (Sat, 16 Feb 2013) | 27 lines
</span></span></pre>
</div>
</div>
</body>
</html>