<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211131] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211131">211131</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-01-24 18:59:11 -0800 (Tue, 24 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167311
Patch by Antoine Quint <graouts@apple.com> on 2017-01-24
Reviewed by Dean Jackson.
Source/WebCore:
Ensure we have a chance to start the transition (on the next frame) before registering for an event
tracking its completion.
* Modules/modern-media-controls/controls/tracks-panel.js:
(TracksPanel.prototype.hide):
LayoutTests:
This test should no longer be flaky, so let's no mark it as such anymore.
* platform/mac/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmodernmediacontrolscontrolstrackspaneljs">trunk/Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (211130 => 211131)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-01-25 02:56:40 UTC (rev 211130)
+++ trunk/LayoutTests/ChangeLog 2017-01-25 02:59:11 UTC (rev 211131)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2017-01-24 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><ins>+ LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=167311
+
+ Reviewed by Dean Jackson.
+
+ This test should no longer be flaky, so let's no mark it as such anymore.
+
+ * platform/mac/TestExpectations:
+
+2017-01-24 Antoine Quint <graouts@apple.com>
+
</ins><span class="cx"> Work around a crash when running media/modern-media-controls/pip-support/pip-support-enabled.html
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=167381
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (211130 => 211131)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2017-01-25 02:56:40 UTC (rev 211130)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-01-25 02:59:11 UTC (rev 211131)
</span><span class="lines">@@ -1493,8 +1493,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/167275 media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html [ Pass Failure ]
</span><span class="cx">
</span><del>-webkit.org/b/167311 [ Debug ] media/modern-media-controls/tracks-panel/tracks-panel-hide.html [ Pass Timeout ]
-
</del><span class="cx"> webkit.org/b/167347 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Pass Failure ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/167266 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Pass Failure ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (211130 => 211131)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-25 02:56:40 UTC (rev 211130)
+++ trunk/Source/WebCore/ChangeLog 2017-01-25 02:59:11 UTC (rev 211131)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-01-24 Antoine Quint <graouts@apple.com>
+
+ LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=167311
+
+ Reviewed by Dean Jackson.
+
+ Ensure we have a chance to start the transition (on the next frame) before registering for an event
+ tracking its completion.
+
+ * Modules/modern-media-controls/controls/tracks-panel.js:
+ (TracksPanel.prototype.hide):
+
</ins><span class="cx"> 2017-01-24 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS WK2] Avoid IOSurface readback for snapshot creation
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmodernmediacontrolscontrolstrackspaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.js (211130 => 211131)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.js 2017-01-25 02:56:40 UTC (rev 211130)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.js 2017-01-25 02:59:11 UTC (rev 211131)
</span><span class="lines">@@ -43,7 +43,9 @@
</span><span class="cx"> window.removeEventListener("keydown", this, true);
</span><span class="cx">
</span><span class="cx"> this.element.addEventListener("transitionend", this);
</span><del>- this.element.classList.add("fade-out");
</del><ins>+
+ // Ensure a transition will indeed happen by starting it only on the next frame.
+ window.requestAnimationFrame(() => { this.element.classList.add("fade-out") });
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> get bottomY()
</span></span></pre>
</div>
</div>
</body>
</html>