<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211052] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211052">211052</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2017-01-23 12:58:35 -0800 (Mon, 23 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>When Safari reloads pages with Flash objects after Flash is installed, placeholders don't paint (but do work!)
https://bugs.webkit.org/show_bug.cgi?id=167268
rdar://problem/29857388
Reviewed by Sam Weinig.
Source/WebCore:
* page/Page.cpp:
(WebCore::Page::refreshPlugins):
Call PluginInfoProvider::refresh instead.
(WebCore::Page::clearPluginData):
Add new setter.
* page/Page.h:
Declare new members.
* plugins/PluginInfoProvider.cpp:
(WebCore::PluginInfoProvider::refresh):
Put the logic to clear plug-in data and reload frames here.
* plugins/PluginInfoProvider.h:
Add new members.
Source/WebKit2:
* WebProcess/Plugins/WebPluginInfoProvider.h:
Make refreshPlugins() private.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::refreshPlugins):
Call the newly added PluginInfoProvider::refresh().</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepagePagecpp">trunk/Source/WebCore/page/Page.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePageh">trunk/Source/WebCore/page/Page.h</a></li>
<li><a href="#trunkSourceWebCorepluginsPluginInfoProvidercpp">trunk/Source/WebCore/plugins/PluginInfoProvider.cpp</a></li>
<li><a href="#trunkSourceWebCorepluginsPluginInfoProviderh">trunk/Source/WebCore/plugins/PluginInfoProvider.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsWebPluginInfoProviderh">trunk/Source/WebKit2/WebProcess/Plugins/WebPluginInfoProvider.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebProcesscpp">trunk/Source/WebKit2/WebProcess/WebProcess.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (211051 => 211052)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-23 20:55:09 UTC (rev 211051)
+++ trunk/Source/WebCore/ChangeLog 2017-01-23 20:58:35 UTC (rev 211052)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2017-01-20 Anders Carlsson <andersca@apple.com>
+
+ When Safari reloads pages with Flash objects after Flash is installed, placeholders don't paint (but do work!)
+ https://bugs.webkit.org/show_bug.cgi?id=167268
+ rdar://problem/29857388
+
+ Reviewed by Sam Weinig.
+
+ * page/Page.cpp:
+ (WebCore::Page::refreshPlugins):
+ Call PluginInfoProvider::refresh instead.
+
+ (WebCore::Page::clearPluginData):
+ Add new setter.
+
+ * page/Page.h:
+ Declare new members.
+
+ * plugins/PluginInfoProvider.cpp:
+ (WebCore::PluginInfoProvider::refresh):
+ Put the logic to clear plug-in data and reload frames here.
+
+ * plugins/PluginInfoProvider.h:
+ Add new members.
+
</ins><span class="cx"> 2017-01-23 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r208149): Video details does not apear and missing scrubber in Control Center
</span></span></pre></div>
<a id="trunkSourceWebCorepagePagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.cpp (211051 => 211052)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.cpp 2017-01-23 20:55:09 UTC (rev 211051)
+++ trunk/Source/WebCore/page/Page.cpp 2017-01-23 20:58:35 UTC (rev 211052)
</span><span class="lines">@@ -539,24 +539,11 @@
</span><span class="cx">
</span><span class="cx"> Vector<Ref<Frame>> framesNeedingReload;
</span><span class="cx">
</span><del>- for (auto& page : *allPages) {
</del><ins>+ for (auto& page : *allPages)
</ins><span class="cx"> pluginInfoProviders.add(&page->pluginInfoProvider());
</span><del>- page->m_pluginData = nullptr;
</del><span class="cx">
</span><del>- if (!reload)
- continue;
-
- for (Frame* frame = &page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
- if (frame->loader().subframeLoader().containsPlugins())
- framesNeedingReload.append(*frame);
- }
- }
-
</del><span class="cx"> for (auto& pluginInfoProvider : pluginInfoProviders)
</span><del>- pluginInfoProvider->refreshPlugins();
-
- for (auto& frame : framesNeedingReload)
- frame->loader().reload();
</del><ins>+ pluginInfoProvider->refresh(reload);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PluginData& Page::pluginData()
</span><span class="lines">@@ -566,6 +553,11 @@
</span><span class="cx"> return *m_pluginData;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void Page::clearPluginData()
+{
+ m_pluginData = nullptr;
+}
+
</ins><span class="cx"> bool Page::showAllPlugins() const
</span><span class="cx"> {
</span><span class="cx"> if (m_showAllPlugins)
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.h (211051 => 211052)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.h 2017-01-23 20:55:09 UTC (rev 211051)
+++ trunk/Source/WebCore/page/Page.h 2017-01-23 20:58:35 UTC (rev 211052)
</span><span class="lines">@@ -166,6 +166,7 @@
</span><span class="cx">
</span><span class="cx"> static void refreshPlugins(bool reload);
</span><span class="cx"> WEBCORE_EXPORT PluginData& pluginData();
</span><ins>+ void clearPluginData();
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void setCanStartMedia(bool);
</span><span class="cx"> bool canStartMedia() const { return m_canStartMedia; }
</span></span></pre></div>
<a id="trunkSourceWebCorepluginsPluginInfoProvidercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/PluginInfoProvider.cpp (211051 => 211052)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/PluginInfoProvider.cpp 2017-01-23 20:55:09 UTC (rev 211051)
+++ trunk/Source/WebCore/plugins/PluginInfoProvider.cpp 2017-01-23 20:58:35 UTC (rev 211052)
</span><span class="lines">@@ -26,6 +26,10 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "PluginInfoProvider.h"
</span><span class="cx">
</span><ins>+#include "MainFrame.h"
+#include "Page.h"
+#include "SubframeLoader.h"
+
</ins><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> PluginInfoProvider::~PluginInfoProvider()
</span><span class="lines">@@ -33,6 +37,26 @@
</span><span class="cx"> ASSERT(m_pages.isEmpty());
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void PluginInfoProvider::refresh(bool reloadPages)
+{
+ Vector<Ref<Frame>> framesNeedingReload;
+
+ for (auto& page : m_pages) {
+ page->clearPluginData();
+
+ if (!reloadPages)
+ continue;
+
+ for (Frame* frame = &page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+ if (frame->loader().subframeLoader().containsPlugins())
+ framesNeedingReload.append(*frame);
+ }
+ }
+
+ for (auto& frame : framesNeedingReload)
+ frame->loader().reload();
+}
+
</ins><span class="cx"> void PluginInfoProvider::addPage(Page& page)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(!m_pages.contains(&page));
</span></span></pre></div>
<a id="trunkSourceWebCorepluginsPluginInfoProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/PluginInfoProvider.h (211051 => 211052)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/PluginInfoProvider.h 2017-01-23 20:55:09 UTC (rev 211051)
+++ trunk/Source/WebCore/plugins/PluginInfoProvider.h 2017-01-23 20:58:35 UTC (rev 211052)
</span><span class="lines">@@ -34,16 +34,17 @@
</span><span class="cx"> public:
</span><span class="cx"> virtual ~PluginInfoProvider();
</span><span class="cx">
</span><del>- void refreshPlugins(bool reloadPages);
</del><ins>+ void refresh(bool reloadPages);
</ins><span class="cx">
</span><span class="cx"> void addPage(Page&);
</span><span class="cx"> void removePage(Page&);
</span><span class="cx">
</span><del>- virtual void refreshPlugins() = 0;
</del><span class="cx"> virtual void getPluginInfo(Page&, Vector<PluginInfo>&) = 0;
</span><span class="cx"> virtual void getWebVisiblePluginInfo(Page&, Vector<PluginInfo>&) = 0;
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ virtual void refreshPlugins() = 0;
+
</ins><span class="cx"> HashSet<Page*> m_pages;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (211051 => 211052)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-01-23 20:55:09 UTC (rev 211051)
+++ trunk/Source/WebKit2/ChangeLog 2017-01-23 20:58:35 UTC (rev 211052)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2017-01-20 Anders Carlsson <andersca@apple.com>
+
+ When Safari reloads pages with Flash objects after Flash is installed, placeholders don't paint (but do work!)
+ https://bugs.webkit.org/show_bug.cgi?id=167268
+ rdar://problem/29857388
+
+ Reviewed by Sam Weinig.
+
+ * WebProcess/Plugins/WebPluginInfoProvider.h:
+ Make refreshPlugins() private.
+
+ * WebProcess/WebProcess.cpp:
+ (WebKit::WebProcess::refreshPlugins):
+ Call the newly added PluginInfoProvider::refresh().
+
</ins><span class="cx"> 2017-01-23 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> Use priorities in speculative revalidation
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsWebPluginInfoProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Plugins/WebPluginInfoProvider.h (211051 => 211052)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Plugins/WebPluginInfoProvider.h 2017-01-23 20:55:09 UTC (rev 211051)
+++ trunk/Source/WebKit2/WebProcess/Plugins/WebPluginInfoProvider.h 2017-01-23 20:58:35 UTC (rev 211052)
</span><span class="lines">@@ -42,13 +42,12 @@
</span><span class="cx"> void clearPluginClientPolicies();
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- void refreshPlugins() override;
-
</del><span class="cx"> private:
</span><span class="cx"> WebPluginInfoProvider();
</span><span class="cx">
</span><span class="cx"> void getPluginInfo(WebCore::Page&, Vector<WebCore::PluginInfo>&) override;
</span><span class="cx"> void getWebVisiblePluginInfo(WebCore::Page&, Vector<WebCore::PluginInfo>&) override;
</span><ins>+ void refreshPlugins() override;
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(NETSCAPE_PLUGIN_API)
</span><span class="cx"> void populatePluginCache(const WebCore::Page&);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (211051 => 211052)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2017-01-23 20:55:09 UTC (rev 211051)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2017-01-23 20:58:35 UTC (rev 211052)
</span><span class="lines">@@ -907,7 +907,7 @@
</span><span class="cx"> void WebProcess::refreshPlugins()
</span><span class="cx"> {
</span><span class="cx"> #if ENABLE(NETSCAPE_PLUGIN_API)
</span><del>- WebPluginInfoProvider::singleton().refreshPlugins();
</del><ins>+ WebPluginInfoProvider::singleton().refresh(false);
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>