<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211046] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211046">211046</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-01-23 11:32:37 -0800 (Mon, 23 Jan 2017)</dd>
</dl>

<h3>Log Message</h3>
<pre>[WebRTC] Make VP8 optional in libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=167257

Patch by Youenn Fablet &lt;youennf@gmail.com&gt; on 2017-01-23
Reviewed by Darin Adler.

Source/ThirdParty/libwebrtc:

Reusing strategy used to have VP9 optional for VP8 codec.

* CMakeLists.txt: Updated tocompile and link vp8_noop.cc
* Source/webrtc/media/engine/webrtcvideoengine2.cc:
* Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:
* Source/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:
* Source/webrtc/modules/video_coding/codecs/vp8/vp8_noop.cc: Added.
* Source/webrtc/video/video_encoder.cc:

Tools:

* Scripts/webkitpy/libwebrtc/generate_cmake.py:
(CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceThirdPartylibwebrtcCMakeListstxt">trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt</a></li>
<li><a href="#trunkSourceThirdPartylibwebrtcChangeLog">trunk/Source/ThirdParty/libwebrtc/ChangeLog</a></li>
<li><a href="#trunkSourceThirdPartylibwebrtcSourcewebrtcmediaenginewebrtcvideoengine2cc">trunk/Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/webrtcvideoengine2.cc</a></li>
<li><a href="#trunkSourceThirdPartylibwebrtcSourcewebrtcmodulesvideo_codingcodecsvp8includevp8h">trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h</a></li>
<li><a href="#trunkSourceThirdPartylibwebrtcSourcewebrtcmodulesvideo_codingcodecsvp8vp8_implcc">trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc</a></li>
<li><a href="#trunkSourceThirdPartylibwebrtcSourcewebrtcvideovideo_encodercc">trunk/Source/ThirdParty/libwebrtc/Source/webrtc/video/video_encoder.cc</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpylibwebrtcgenerate_cmakepy">trunk/Tools/Scripts/webkitpy/libwebrtc/generate_cmake.py</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceThirdPartylibwebrtcSourcewebrtcmodulesvideo_codingcodecsvp8vp8_noopcc">trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/vp8_noop.cc</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceThirdPartylibwebrtcCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt (211045 => 211046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt        2017-01-23 19:23:34 UTC (rev 211045)
+++ trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt        2017-01-23 19:32:37 UTC (rev 211046)
</span><span class="lines">@@ -155,6 +155,7 @@
</span><span class="cx">     ${LIBWEBRTC_INPUT_DIR}/webrtc/modules/video_coding/video_coding_impl.cc
</span><span class="cx">     ${LIBWEBRTC_INPUT_DIR}/webrtc/modules/video_coding/video_receiver.cc
</span><span class="cx">     ${LIBWEBRTC_INPUT_DIR}/webrtc/modules/video_coding/video_sender.cc
</span><ins>+    ${LIBWEBRTC_INPUT_DIR}/webrtc/modules/video_coding/codecs/vp8/vp8_noop.cc
</ins><span class="cx">     ${LIBWEBRTC_INPUT_DIR}/webrtc/modules/video_coding/codecs/vp9/vp9_noop.cc)
</span><span class="cx"> add_library(WebrtcModulesVideo_CodingVideo_Coding STATIC ${WebrtcModulesVideo_CodingVideo_Coding_SOURCES})
</span><span class="cx"> target_compile_options(WebrtcModulesVideo_CodingVideo_Coding PRIVATE &quot;-fno-strict-aliasing&quot; &quot;-fstack-protector-strong&quot; &quot;-fcolor-diagnostics&quot; &quot;-arch&quot; &quot;x86_64&quot; &quot;-gdwarf-2&quot; &quot;-mmacosx-version-min=10.9&quot; &quot;-Wall&quot; &quot;-Werror&quot; &quot;-Wextra&quot; &quot;-Wpartial-availability&quot; &quot;-Wno-missing-field-initializers&quot; &quot;-Wno-unused-parameter&quot; &quot;-Wno-c++11-narrowing&quot; &quot;-Wno-covered-switch-default&quot; &quot;-Wno-deprecated-register&quot; &quot;-Wno-unneeded-internal-declaration&quot; &quot;-Wno-inconsistent-missing-override&quot; &quot;-Wno-shift-negative-value&quot; &quot;-O0&quot; &quot;-fvisibility=hidden&quot; &quot;-Wheader-hygiene&quot; &quot;-Wstring-conversion&quot; &quot;-Wno-strict-overflow&quot; &quot;-Wimplicit-fallthrough&quot; &quot;-Wthread-safety&quot; &quot;-Winconsistent-missing-override&quot; &quot;-Wundef&quot; &quot;-std=c99&
 quot; &quot;-fno-threadsafe-statics&quot; &quot;-fvisibility-inlines-hidden&quot; &quot;-Wno-undefined-bool-conversion&quot; &quot;-Wno-tautological-undefined-compare&quot; &quot;-stdlib=libc++&quot; &quot;-fno-rtti&quot; &quot;-fno-exceptions&quot; &quot;-Wnon-virtual-dtor&quot; &quot;-Woverloaded-virtual&quot; &quot;-Wobjc-missing-property-synthesis&quot; &quot;-fobjc-call-cxx-cdtors&quot;)
</span><span class="lines">@@ -4218,6 +4219,7 @@
</span><span class="cx"> CMakeFiles/WebrtcModulesVideo_CodingVideo_Coding.dir/Source/webrtc/modules/video_coding/session_info.cc.o
</span><span class="cx"> CMakeFiles/WebrtcModulesVideo_CodingVideo_Coding.dir/Source/webrtc/modules/video_coding/packet.cc.o
</span><span class="cx"> CMakeFiles/WebrtcModulesVideo_CodingVideo_Coding.dir/Source/webrtc/modules/video_coding/timestamp_map.cc.o
</span><ins>+CMakeFiles/WebrtcModulesVideo_CodingVideo_Coding.dir/Source/webrtc/modules/video_coding/codecs/vp8/vp8_noop.cc.o
</ins><span class="cx"> CMakeFiles/WebrtcModulesVideo_CodingVideo_Coding.dir/Source/webrtc/modules/video_coding/inter_frame_delay.cc.o
</span><span class="cx"> CMakeFiles/WebrtcModulesVideo_CodingVideo_Coding.dir/Source/webrtc/modules/video_coding/h264_sps_pps_tracker.cc.o
</span><span class="cx"> CMakeFiles/WebrtcModulesVideo_CodingVideo_Coding.dir/Source/webrtc/modules/video_coding/frame_buffer2.cc.o
</span></span></pre></div>
<a id="trunkSourceThirdPartylibwebrtcChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (211045 => 211046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/ChangeLog        2017-01-23 19:23:34 UTC (rev 211045)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog        2017-01-23 19:32:37 UTC (rev 211046)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-01-23  Youenn Fablet  &lt;youennf@gmail.com&gt;
+
+        [WebRTC] Make VP8 optional in libwebrtc
+        https://bugs.webkit.org/show_bug.cgi?id=167257
+
+        Reviewed by Darin Adler.
+
+        Reusing strategy used to have VP9 optional for VP8 codec.
+
+        * CMakeLists.txt: Updated tocompile and link vp8_noop.cc
+        * Source/webrtc/media/engine/webrtcvideoengine2.cc:
+        * Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h:
+        * Source/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:
+        * Source/webrtc/modules/video_coding/codecs/vp8/vp8_noop.cc: Added.
+        * Source/webrtc/video/video_encoder.cc:
+
</ins><span class="cx"> 2017-01-20  Youenn Fablet  &lt;youennf@gmail.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [WebRTC] Update build system to make G711 optional in libwebrtc
</span></span></pre></div>
<a id="trunkSourceThirdPartylibwebrtcSourcewebrtcmediaenginewebrtcvideoengine2cc"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/webrtcvideoengine2.cc (211045 => 211046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/webrtcvideoengine2.cc        2017-01-23 19:23:34 UTC (rev 211045)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/webrtcvideoengine2.cc        2017-01-23 19:32:37 UTC (rev 211046)
</span><span class="lines">@@ -115,10 +115,13 @@
</span><span class="cx">       const cricket::VideoCodec&amp; codec) override {
</span><span class="cx">     RTC_DCHECK(factory_ != NULL);
</span><span class="cx">     // If it's a codec type we can simulcast, create a wrapped encoder.
</span><ins>+#ifndef RTC_DISABLE_VP8
+    ASSERT(webrtc::VP8Encoder::IsSupported());
</ins><span class="cx">     if (CodecNamesEq(codec.name.c_str(), kVp8CodecName)) {
</span><span class="cx">       return new webrtc::SimulcastEncoderAdapter(
</span><span class="cx">           new EncoderFactoryAdapter(factory_));
</span><span class="cx">     }
</span><ins>+#endif
</ins><span class="cx">     webrtc::VideoEncoder* encoder = factory_-&gt;CreateVideoEncoder(codec);
</span><span class="cx">     if (encoder) {
</span><span class="cx">       non_simulcast_encoders_.push_back(encoder);
</span><span class="lines">@@ -430,9 +433,11 @@
</span><span class="cx"> 
</span><span class="cx"> std::vector&lt;VideoCodec&gt; DefaultVideoCodecList() {
</span><span class="cx">   std::vector&lt;VideoCodec&gt; codecs;
</span><del>-  AddCodecAndMaybeRtxCodec(
</del><ins>+  if (webrtc::VP8Encoder::IsSupported() &amp;&amp; webrtc::VP8Decoder::IsSupported()) {
+    AddCodecAndMaybeRtxCodec(
</ins><span class="cx">       MakeVideoCodecWithDefaultFeedbackParams(kDefaultVp8PlType, kVp8CodecName),
</span><span class="cx">       &amp;codecs);
</span><ins>+  }
</ins><span class="cx">   if (webrtc::VP9Encoder::IsSupported() &amp;&amp; webrtc::VP9Decoder::IsSupported()) {
</span><span class="cx">     AddCodecAndMaybeRtxCodec(MakeVideoCodecWithDefaultFeedbackParams(
</span><span class="cx">                                  kDefaultVp9PlType, kVp9CodecName),
</span></span></pre></div>
<a id="trunkSourceThirdPartylibwebrtcSourcewebrtcmodulesvideo_codingcodecsvp8includevp8h"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h (211045 => 211046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h        2017-01-23 19:23:34 UTC (rev 211045)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/include/vp8.h        2017-01-23 19:32:37 UTC (rev 211046)
</span><span class="lines">@@ -19,6 +19,7 @@
</span><span class="cx"> 
</span><span class="cx"> class VP8Encoder : public VideoEncoder {
</span><span class="cx">  public:
</span><ins>+  static bool IsSupported();
</ins><span class="cx">   static VP8Encoder* Create();
</span><span class="cx"> 
</span><span class="cx">   virtual ~VP8Encoder() {}
</span><span class="lines">@@ -26,6 +27,7 @@
</span><span class="cx"> 
</span><span class="cx"> class VP8Decoder : public VideoDecoder {
</span><span class="cx">  public:
</span><ins>+  static bool IsSupported();
</ins><span class="cx">   static VP8Decoder* Create();
</span><span class="cx"> 
</span><span class="cx">   virtual ~VP8Decoder() {}
</span></span></pre></div>
<a id="trunkSourceThirdPartylibwebrtcSourcewebrtcmodulesvideo_codingcodecsvp8vp8_implcc"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (211045 => 211046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc        2017-01-23 19:23:34 UTC (rev 211045)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc        2017-01-23 19:32:37 UTC (rev 211046)
</span><span class="lines">@@ -103,10 +103,18 @@
</span><span class="cx"> }
</span><span class="cx"> }  // namespace
</span><span class="cx"> 
</span><ins>+bool VP8Encoder::IsSupported() {
+  return true;
+}
+
</ins><span class="cx"> VP8Encoder* VP8Encoder::Create() {
</span><span class="cx">   return new VP8EncoderImpl();
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+bool VP8Decoder::IsSupported() {
+  return true;
+}
+
</ins><span class="cx"> VP8Decoder* VP8Decoder::Create() {
</span><span class="cx">   return new VP8DecoderImpl();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceThirdPartylibwebrtcSourcewebrtcmodulesvideo_codingcodecsvp8vp8_noopcc"></a>
<div class="addfile"><h4>Added: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/vp8_noop.cc (0 => 211046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/vp8_noop.cc                                (rev 0)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp8/vp8_noop.cc        2017-01-23 19:32:37 UTC (rev 211046)
</span><span class="lines">@@ -0,0 +1,39 @@
</span><ins>+/*
+ *  Copyright (c) 2017 Apple Inc. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ *
+ */
+
+#if !defined(RTC_DISABLE_VP8)
+#error
+#endif  // !defined(RTC_DISABLE_VP8)
+
+#include &quot;webrtc/base/checks.h&quot;
+#include &quot;webrtc/modules/video_coding/codecs/vp8/include/vp8.h&quot;
+
+namespace webrtc {
+
+bool VP8Encoder::IsSupported() {
+  return false;
+}
+
+VP8Encoder* VP8Encoder::Create() {
+  RTC_NOTREACHED();
+  return nullptr;
+}
+
+bool VP8Decoder::IsSupported() {
+  return false;
+}
+
+VP8Decoder* VP8Decoder::Create() {
+  RTC_NOTREACHED();
+  return nullptr;
+}
+
+}  // namespace webrtc
</ins></span></pre></div>
<a id="trunkSourceThirdPartylibwebrtcSourcewebrtcvideovideo_encodercc"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/video/video_encoder.cc (211045 => 211046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/video/video_encoder.cc        2017-01-23 19:23:34 UTC (rev 211045)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/video/video_encoder.cc        2017-01-23 19:32:37 UTC (rev 211046)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx">     case kH264:
</span><span class="cx">       return H264Encoder::IsSupported();
</span><span class="cx">     case kVp8:
</span><del>-      return true;
</del><ins>+      return VP8Encoder::IsSupported();
</ins><span class="cx">     case kVp9:
</span><span class="cx">       return VP9Encoder::IsSupported();
</span><span class="cx">     case kUnsupportedCodec:
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (211045 => 211046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog        2017-01-23 19:23:34 UTC (rev 211045)
+++ trunk/Tools/ChangeLog        2017-01-23 19:32:37 UTC (rev 211046)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2017-01-23  Youenn Fablet  &lt;youennf@gmail.com&gt;
+
+        [WebRTC] Make VP8 optional in libwebrtc
+        https://bugs.webkit.org/show_bug.cgi?id=167257
+
+        Reviewed by Darin Adler.
+
+        * Scripts/webkitpy/libwebrtc/generate_cmake.py:
+        (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
+
</ins><span class="cx"> 2017-01-23  Jer Noble  &lt;jer.noble@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Video details does not apear and missing scrubber in Control Center
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpylibwebrtcgenerate_cmakepy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/libwebrtc/generate_cmake.py (211045 => 211046)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/libwebrtc/generate_cmake.py        2017-01-23 19:23:34 UTC (rev 211045)
+++ trunk/Tools/Scripts/webkitpy/libwebrtc/generate_cmake.py        2017-01-23 19:32:37 UTC (rev 211046)
</span><span class="lines">@@ -281,6 +281,8 @@
</span><span class="cx">         target = self.targets[&quot;//webrtc/modules/video_coding:video_coding&quot;]
</span><span class="cx">         target[&quot;defines&quot;].append(&quot;RTC_DISABLE_VP8&quot;)
</span><span class="cx">         target[&quot;defines&quot;].append(&quot;RTC_DISABLE_VP9&quot;)
</span><ins>+        target[&quot;sources&quot;].append(&quot;//webrtc/modules/video_coding/codecs/vp8/vp8_noop.cc&quot;)
+        target[&quot;source_outputs&quot;][&quot;//webrtc/modules/video_coding/codecs/vp8/vp8_noop.cc&quot;] = [&quot;obj/webrtc/modules/video_coding/webrtc_vp8/vp8_noop.o&quot;]
</ins><span class="cx">         target[&quot;sources&quot;].append(&quot;//webrtc/modules/video_coding/codecs/vp9/vp9_noop.cc&quot;)
</span><span class="cx">         target[&quot;source_outputs&quot;][&quot;//webrtc/modules/video_coding/codecs/vp9/vp9_noop.cc&quot;] = [&quot;obj/webrtc/modules/video_coding/webrtc_vp9/vp9_noop.o&quot;]
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>